)]}'
{"thresh/src/main/java/monasca/thresh/infrastructure/persistence/PersistenceModule.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"801708a8438c3841daae84c18a81ea05e288e5a9","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import javax.inject.Singleton;"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import monasca.common.hibernate.db.AlarmActionDb;"},{"line_number":22,"context_line":"import monasca.common.hibernate.db.AlarmDb;"},{"line_number":23,"context_line":"import monasca.common.hibernate.db.AlarmDefinitionDb;"},{"line_number":24,"context_line":"import monasca.common.hibernate.db.AlarmMetricDb;"}],"source_content_type":"text/x-java","patch_set":3,"id":"fa1b9901_fd1cc614","line":21,"updated":"2015-08-19 14:50:47.000000000","message":"You need to change your import formatter. The auto format rules you picked up are for google and so monasca bottom gets put at the top and the google imports at the bottom. Since this is the monasca project, the monasca imports should be at the bottom and the google ones just put treated like any other import","commit_id":"da67bde6a7487b46a2caafaa70cb9486b1a705ae"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"5d44a182f548d0a211fd38064ac160c5f8c9a7e7","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import javax.inject.Singleton;"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import monasca.common.hibernate.db.AlarmActionDb;"},{"line_number":22,"context_line":"import monasca.common.hibernate.db.AlarmDb;"},{"line_number":23,"context_line":"import monasca.common.hibernate.db.AlarmDefinitionDb;"},{"line_number":24,"context_line":"import monasca.common.hibernate.db.AlarmMetricDb;"}],"source_content_type":"text/x-java","patch_set":3,"id":"fa1b9901_8c6777e8","line":21,"in_reply_to":"fa1b9901_fd1cc614","updated":"2015-08-20 05:58:02.000000000","message":"Done","commit_id":"da67bde6a7487b46a2caafaa70cb9486b1a705ae"}],"thresh/src/main/java/monasca/thresh/infrastructure/persistence/sql/AlarmDefinitionSqlImpl.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"801708a8438c3841daae84c18a81ea05e288e5a9","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"      }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"      return alarmDefinitions;"},{"line_number":105,"context_line":"    } finally {"},{"line_number":106,"context_line":"      if (session !\u003d null) {"},{"line_number":107,"context_line":"        session.close();"}],"source_content_type":"text/x-java","patch_set":3,"id":"fa1b9901_fd692626","line":104,"updated":"2015-08-19 14:50:47.000000000","message":"AlarmDefinitionDAOImpl returns an empty list in this case not a null. An empty list is better than null as the calling code doesn\u0027t have to check for null before using it in a for loop","commit_id":"da67bde6a7487b46a2caafaa70cb9486b1a705ae"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"5d44a182f548d0a211fd38064ac160c5f8c9a7e7","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"      }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"      return alarmDefinitions;"},{"line_number":105,"context_line":"    } finally {"},{"line_number":106,"context_line":"      if (session !\u003d null) {"},{"line_number":107,"context_line":"        session.close();"}],"source_content_type":"text/x-java","patch_set":3,"id":"fa1b9901_0ca287fd","line":104,"in_reply_to":"fa1b9901_fd692626","updated":"2015-08-20 05:58:02.000000000","message":"Done","commit_id":"da67bde6a7487b46a2caafaa70cb9486b1a705ae"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"e80d10050fc73b2d2e5af91063860ccf17c87e1d","unresolved":false,"context_lines":[{"line_number":12,"context_line":" * the License."},{"line_number":13,"context_line":" */"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"package monasca.thresh.infrastructure.persistence.sql;"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import java.util.Collection;"},{"line_number":18,"context_line":"import java.util.Collections;"}],"source_content_type":"text/x-java","patch_set":5,"id":"da20952f_0cba1ae2","line":15,"updated":"2015-08-26 20:44:06.000000000","message":"I think a better name would be \n\n\u0027monasca.thresh.infrastructure.persistence.hibernate\u0027","commit_id":"283fc3ef5c0f333155e09ca038bd738cbc14ac26"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"840daedbd4ff66693935f2dea669bd088858c0db","unresolved":false,"context_lines":[{"line_number":12,"context_line":" * the License."},{"line_number":13,"context_line":" */"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"package monasca.thresh.infrastructure.persistence.sql;"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import java.util.Collection;"},{"line_number":18,"context_line":"import java.util.Collections;"}],"source_content_type":"text/x-java","patch_set":5,"id":"da20952f_52e56335","line":15,"in_reply_to":"da20952f_0cba1ae2","updated":"2015-08-31 09:40:06.000000000","message":"Done","commit_id":"283fc3ef5c0f333155e09ca038bd738cbc14ac26"}],"thresh/src/main/java/monasca/thresh/infrastructure/persistence/sql/AlarmSqlImpl.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"801708a8438c3841daae84c18a81ea05e288e5a9","unresolved":false,"context_lines":[{"line_number":374,"context_line":"  private List\u003cAlarm\u003e createAlarms(final StatelessSession session,"},{"line_number":375,"context_line":"                                   final List\u003cObject[]\u003e alarmList,"},{"line_number":376,"context_line":"                                   final LookupHelper lookupHelper) {"},{"line_number":377,"context_line":"    final List\u003cAlarm\u003e alarms \u003d Lists.newArrayList();"},{"line_number":378,"context_line":"    List\u003cSubAlarm\u003e subAlarms \u003d Lists.newArrayList();"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    String prevAlarmId \u003d null;"}],"source_content_type":"text/x-java","patch_set":3,"id":"fa1b9901_d8deb06c","line":377,"updated":"2015-08-19 14:50:47.000000000","message":"You should use the alarmList.size() in the Constructor since we know how big the List should be","commit_id":"da67bde6a7487b46a2caafaa70cb9486b1a705ae"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"5d44a182f548d0a211fd38064ac160c5f8c9a7e7","unresolved":false,"context_lines":[{"line_number":374,"context_line":"  private List\u003cAlarm\u003e createAlarms(final StatelessSession session,"},{"line_number":375,"context_line":"                                   final List\u003cObject[]\u003e alarmList,"},{"line_number":376,"context_line":"                                   final LookupHelper lookupHelper) {"},{"line_number":377,"context_line":"    final List\u003cAlarm\u003e alarms \u003d Lists.newArrayList();"},{"line_number":378,"context_line":"    List\u003cSubAlarm\u003e subAlarms \u003d Lists.newArrayList();"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    String prevAlarmId \u003d null;"}],"source_content_type":"text/x-java","patch_set":3,"id":"fa1b9901_2cb74b3b","line":377,"in_reply_to":"fa1b9901_d8deb06c","updated":"2015-08-20 05:58:02.000000000","message":"Done","commit_id":"da67bde6a7487b46a2caafaa70cb9486b1a705ae"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"801708a8438c3841daae84c18a81ea05e288e5a9","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                                   final List\u003cObject[]\u003e alarmList,"},{"line_number":376,"context_line":"                                   final LookupHelper lookupHelper) {"},{"line_number":377,"context_line":"    final List\u003cAlarm\u003e alarms \u003d Lists.newArrayList();"},{"line_number":378,"context_line":"    List\u003cSubAlarm\u003e subAlarms \u003d Lists.newArrayList();"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    String prevAlarmId \u003d null;"},{"line_number":381,"context_line":"    Alarm alarm \u003d null;"}],"source_content_type":"text/x-java","patch_set":3,"id":"fa1b9901_98bfd8fa","line":378,"updated":"2015-08-19 14:50:47.000000000","message":"Better to initialize this to null since subAlarms always gets set to a new list in the for loop","commit_id":"da67bde6a7487b46a2caafaa70cb9486b1a705ae"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"5d44a182f548d0a211fd38064ac160c5f8c9a7e7","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                                   final List\u003cObject[]\u003e alarmList,"},{"line_number":376,"context_line":"                                   final LookupHelper lookupHelper) {"},{"line_number":377,"context_line":"    final List\u003cAlarm\u003e alarms \u003d Lists.newArrayList();"},{"line_number":378,"context_line":"    List\u003cSubAlarm\u003e subAlarms \u003d Lists.newArrayList();"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    String prevAlarmId \u003d null;"},{"line_number":381,"context_line":"    Alarm alarm \u003d null;"}],"source_content_type":"text/x-java","patch_set":3,"id":"fa1b9901_6c98e3c0","line":378,"in_reply_to":"fa1b9901_98bfd8fa","updated":"2015-08-20 05:58:02.000000000","message":"Done","commit_id":"da67bde6a7487b46a2caafaa70cb9486b1a705ae"}]}