)]}'
{"thresh/src/test/java/monasca/thresh/domain/model/SubAlarmStatsTest.java":[{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"624532e2123113bff827c653382543776410c124","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    // Must slide 9 times total from the last added value to trigger UNDETERMINED. This is"},{"line_number":117,"context_line":"    // equivalent to the behavior in CloudWatch for an alarm with 3 evaluation periods. 2 more"},{"line_number":118,"context_line":"    // slides to move the value outside of the window and 6 more to exceed the observation"},{"line_number":119,"context_line":"    // threshold."},{"line_number":120,"context_line":"    for (int i \u003d 0; i \u003c 7; i++) {"},{"line_number":121,"context_line":"      assertFalse(subAlarmStats.evaluateAndSlideWindow(initialTime +\u003d 60, 10));"},{"line_number":122,"context_line":"    }"}],"source_content_type":"text/x-java","patch_set":4,"id":"1a26ad4f_5df65d90","line":119,"updated":"2015-10-28 16:26:28.000000000","message":"Can you explain what the observation threshold is for this metric.  Wondering why it cannot be evaluated after 3 minutes in this case.  If 6 slides additional slides is needed, shouldn\u0027t this be 8 times total?","commit_id":"bc93e453b60efd967a3b42d9790fd418b7c0943b"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"143f453d64184a8efb867e1d5637d60eb127fd9b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    // Must slide 9 times total from the last added value to trigger UNDETERMINED. This is"},{"line_number":117,"context_line":"    // equivalent to the behavior in CloudWatch for an alarm with 3 evaluation periods. 2 more"},{"line_number":118,"context_line":"    // slides to move the value outside of the window and 6 more to exceed the observation"},{"line_number":119,"context_line":"    // threshold."},{"line_number":120,"context_line":"    for (int i \u003d 0; i \u003c 7; i++) {"},{"line_number":121,"context_line":"      assertFalse(subAlarmStats.evaluateAndSlideWindow(initialTime +\u003d 60, 10));"},{"line_number":122,"context_line":"    }"}],"source_content_type":"text/x-java","patch_set":4,"id":"1a26ad4f_f503bdb6","line":119,"in_reply_to":"1a26ad4f_5df65d90","updated":"2015-10-28 19:56:24.000000000","message":"It should be 8 not 9. I corrected the other comment but not this one. Will correct this one in the next patch set.\n\nThe reason it is 8 is because the expression is \"avg(hpcs.compute.cpu{id\u003d5}, 60) \u003e 3 times 3\". The alarm doesn\u0027t change to alarm until there have 2 * the number of periods where there are no metrics in any of the periods under evaluation. This works out to Periods * 3 - 1.\n\nThe API doc says:\n\nUNDETERMINED - No metrics for at least one of the subexpressions has been received in (period + 2) times periods (see below for definition of period and periods\n\nHowever this is incorrect. I\u0027ll have to update it.","commit_id":"bc93e453b60efd967a3b42d9790fd418b7c0943b"}]}