)]}'
{"thresh/src/main/java/monasca/thresh/domain/model/Alarm.java":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"081d01d3e13591bfbb200397781722ec4a9ca8b4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Copyright (c) 2014,2016 Hewlett Packard Enterprise Development Company, L.P."},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":" * you may not use this file except in compliance with the License."}],"source_content_type":"text/x-java","patch_set":12,"id":"ba0121b8_010aac89","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":79},"updated":"2016-04-01 11:34:12.000000000","message":"Please add copyright.","commit_id":"0c105c473ef2ec66108b1415602636e469723e57"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"fce57bb9a543f69af4f1b53a3f851c827a26b846","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Copyright (c) 2014,2016 Hewlett Packard Enterprise Development Company, L.P."},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":" * you may not use this file except in compliance with the License."}],"source_content_type":"text/x-java","patch_set":12,"id":"ba0121b8_7661a904","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":79},"in_reply_to":"ba0121b8_010aac89","updated":"2016-04-01 11:51:21.000000000","message":"Done","commit_id":"0c105c473ef2ec66108b1415602636e469723e57"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"081d01d3e13591bfbb200397781722ec4a9ca8b4","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import java.util.ArrayList;"},{"line_number":21,"context_line":"import java.util.Collection;"},{"line_number":22,"context_line":"import java.util.Collections;"},{"line_number":23,"context_line":"import java.util.HashMap;"},{"line_number":24,"context_line":"import java.util.HashSet;"},{"line_number":25,"context_line":"import java.util.List;"}],"source_content_type":"text/x-java","patch_set":12,"id":"ba0121b8_e1e69842","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":29},"updated":"2016-04-01 11:34:12.000000000","message":"The import is never used.","commit_id":"0c105c473ef2ec66108b1415602636e469723e57"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"fce57bb9a543f69af4f1b53a3f851c827a26b846","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import java.util.ArrayList;"},{"line_number":21,"context_line":"import java.util.Collection;"},{"line_number":22,"context_line":"import java.util.Collections;"},{"line_number":23,"context_line":"import java.util.HashMap;"},{"line_number":24,"context_line":"import java.util.HashSet;"},{"line_number":25,"context_line":"import java.util.List;"}],"source_content_type":"text/x-java","patch_set":12,"id":"ba0121b8_96527d33","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":29},"in_reply_to":"ba0121b8_e1e69842","updated":"2016-04-01 11:51:21.000000000","message":"Done","commit_id":"0c105c473ef2ec66108b1415602636e469723e57"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"081d01d3e13591bfbb200397781722ec4a9ca8b4","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    AlarmState initialState \u003d state;"},{"line_number":153,"context_line":"    boolean uninitialized \u003d false;"},{"line_number":154,"context_line":"    int sporadicMetricCounter \u003d 1;"},{"line_number":155,"context_line":"    boolean allSporadic;"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    for (SubAlarm subAlarm : subAlarms.values()) {"}],"source_content_type":"text/x-java","patch_set":12,"id":"ba0121b8_a1b30097","line":154,"range":{"start_line":154,"start_character":4,"end_line":154,"end_character":34},"updated":"2016-04-01 11:34:12.000000000","message":"Why are you initializing the counter with 1?","commit_id":"0c105c473ef2ec66108b1415602636e469723e57"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"fce57bb9a543f69af4f1b53a3f851c827a26b846","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    AlarmState initialState \u003d state;"},{"line_number":153,"context_line":"    boolean uninitialized \u003d false;"},{"line_number":154,"context_line":"    int sporadicMetricCounter \u003d 1;"},{"line_number":155,"context_line":"    boolean allSporadic;"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    for (SubAlarm subAlarm : subAlarms.values()) {"}],"source_content_type":"text/x-java","patch_set":12,"id":"ba0121b8_d636b501","line":154,"range":{"start_line":154,"start_character":4,"end_line":154,"end_character":34},"in_reply_to":"ba0121b8_a1b30097","updated":"2016-04-01 11:51:21.000000000","message":"Why indeed -_-,\nDone.","commit_id":"0c105c473ef2ec66108b1415602636e469723e57"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"081d01d3e13591bfbb200397781722ec4a9ca8b4","unresolved":false,"context_lines":[{"line_number":158,"context_line":"      if (AlarmState.UNDETERMINED.equals(subAlarm.getState())) {"},{"line_number":159,"context_line":"        uninitialized \u003d true;"},{"line_number":160,"context_line":"      }"},{"line_number":161,"context_line":"      if(subAlarm.isSporadicMetric()){"},{"line_number":162,"context_line":"        sporadicMetricCounter +\u003d 1;"},{"line_number":163,"context_line":"      }"},{"line_number":164,"context_line":"      transitionSubAlarms.add(new AlarmTransitionSubAlarm(subAlarm.getExpression(),"}],"source_content_type":"text/x-java","patch_set":12,"id":"ba0121b8_160b0d25","line":161,"updated":"2016-04-01 11:34:12.000000000","message":"Please use whitespaces following GJS throughout the code.","commit_id":"0c105c473ef2ec66108b1415602636e469723e57"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"fce57bb9a543f69af4f1b53a3f851c827a26b846","unresolved":false,"context_lines":[{"line_number":158,"context_line":"      if (AlarmState.UNDETERMINED.equals(subAlarm.getState())) {"},{"line_number":159,"context_line":"        uninitialized \u003d true;"},{"line_number":160,"context_line":"      }"},{"line_number":161,"context_line":"      if(subAlarm.isSporadicMetric()){"},{"line_number":162,"context_line":"        sporadicMetricCounter +\u003d 1;"},{"line_number":163,"context_line":"      }"},{"line_number":164,"context_line":"      transitionSubAlarms.add(new AlarmTransitionSubAlarm(subAlarm.getExpression(),"}],"source_content_type":"text/x-java","patch_set":12,"id":"ba0121b8_9629dd9d","line":161,"in_reply_to":"ba0121b8_160b0d25","updated":"2016-04-01 11:51:21.000000000","message":"Done","commit_id":"0c105c473ef2ec66108b1415602636e469723e57"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"081d01d3e13591bfbb200397781722ec4a9ca8b4","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    }"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    // Handle UNDETERMINED state"},{"line_number":175,"context_line":"    // extra check if all all sporadic, if so...proceed to ok ASAP"},{"line_number":176,"context_line":"    if (uninitialized) {"},{"line_number":177,"context_line":"      if (AlarmState.UNDETERMINED.equals(initialState)) {"},{"line_number":178,"context_line":"        if (allSporadic) {"}],"source_content_type":"text/x-java","patch_set":12,"id":"ba0121b8_366d71cc","line":175,"range":{"start_line":175,"start_character":22,"end_line":175,"end_character":29},"updated":"2016-04-01 11:34:12.000000000","message":"Is it the superlative of all? ;)","commit_id":"0c105c473ef2ec66108b1415602636e469723e57"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"fce57bb9a543f69af4f1b53a3f851c827a26b846","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    }"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    // Handle UNDETERMINED state"},{"line_number":175,"context_line":"    // extra check if all all sporadic, if so...proceed to ok ASAP"},{"line_number":176,"context_line":"    if (uninitialized) {"},{"line_number":177,"context_line":"      if (AlarmState.UNDETERMINED.equals(initialState)) {"},{"line_number":178,"context_line":"        if (allSporadic) {"}],"source_content_type":"text/x-java","patch_set":12,"id":"ba0121b8_f61ad97b","line":175,"range":{"start_line":175,"start_character":22,"end_line":175,"end_character":29},"in_reply_to":"ba0121b8_366d71cc","updated":"2016-04-01 11:51:21.000000000","message":"Done","commit_id":"0c105c473ef2ec66108b1415602636e469723e57"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"081d01d3e13591bfbb200397781722ec4a9ca8b4","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    if (uninitialized) {"},{"line_number":177,"context_line":"      if (AlarmState.UNDETERMINED.equals(initialState)) {"},{"line_number":178,"context_line":"        if (allSporadic) {"},{"line_number":179,"context_line":"          final String rawMsg \u003d buildStateChangeReason(state);"},{"line_number":180,"context_line":"          final String sporadicDetails \u003d String.format(\"All alarms were sporadic for %s\", this.getId());"},{"line_number":181,"context_line":"          state \u003d AlarmState.OK;"},{"line_number":182,"context_line":"          stateChangeReason \u003d String.format(\"%s\\n%s\", rawMsg, sporadicDetails);"},{"line_number":183,"context_line":"          return true;"},{"line_number":184,"context_line":"        }"},{"line_number":185,"context_line":"        return false;"},{"line_number":186,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":12,"id":"ba0121b8_73b37b98","line":183,"range":{"start_line":179,"start_character":10,"end_line":183,"end_character":22},"updated":"2016-04-01 11:34:12.000000000","message":"Please notice that this code will never execute.","commit_id":"0c105c473ef2ec66108b1415602636e469723e57"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"47c810f1afdad542efdf862d688c2f8482e1244d","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    if (uninitialized) {"},{"line_number":177,"context_line":"      if (AlarmState.UNDETERMINED.equals(initialState)) {"},{"line_number":178,"context_line":"        if (allSporadic) {"},{"line_number":179,"context_line":"          final String rawMsg \u003d buildStateChangeReason(state);"},{"line_number":180,"context_line":"          final String sporadicDetails \u003d String.format(\"All alarms were sporadic for %s\", this.getId());"},{"line_number":181,"context_line":"          state \u003d AlarmState.OK;"},{"line_number":182,"context_line":"          stateChangeReason \u003d String.format(\"%s\\n%s\", rawMsg, sporadicDetails);"},{"line_number":183,"context_line":"          return true;"},{"line_number":184,"context_line":"        }"},{"line_number":185,"context_line":"        return false;"},{"line_number":186,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":12,"id":"ba0121b8_6998ae78","line":183,"range":{"start_line":179,"start_character":10,"end_line":183,"end_character":22},"in_reply_to":"ba0121b8_29407606","updated":"2016-04-01 12:06:05.000000000","message":"Got to admit...you might be right :)","commit_id":"0c105c473ef2ec66108b1415602636e469723e57"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"fce57bb9a543f69af4f1b53a3f851c827a26b846","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    if (uninitialized) {"},{"line_number":177,"context_line":"      if (AlarmState.UNDETERMINED.equals(initialState)) {"},{"line_number":178,"context_line":"        if (allSporadic) {"},{"line_number":179,"context_line":"          final String rawMsg \u003d buildStateChangeReason(state);"},{"line_number":180,"context_line":"          final String sporadicDetails \u003d String.format(\"All alarms were sporadic for %s\", this.getId());"},{"line_number":181,"context_line":"          state \u003d AlarmState.OK;"},{"line_number":182,"context_line":"          stateChangeReason \u003d String.format(\"%s\\n%s\", rawMsg, sporadicDetails);"},{"line_number":183,"context_line":"          return true;"},{"line_number":184,"context_line":"        }"},{"line_number":185,"context_line":"        return false;"},{"line_number":186,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":12,"id":"ba0121b8_760fe936","line":183,"range":{"start_line":179,"start_character":10,"end_line":183,"end_character":22},"in_reply_to":"ba0121b8_73b37b98","updated":"2016-04-01 11:51:21.000000000","message":"Hmm...why is that ?\nAm I missing something ? Could you explain ?","commit_id":"0c105c473ef2ec66108b1415602636e469723e57"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"6fac1f11cad63646d96e8fb3977faf8337e18926","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    if (uninitialized) {"},{"line_number":177,"context_line":"      if (AlarmState.UNDETERMINED.equals(initialState)) {"},{"line_number":178,"context_line":"        if (allSporadic) {"},{"line_number":179,"context_line":"          final String rawMsg \u003d buildStateChangeReason(state);"},{"line_number":180,"context_line":"          final String sporadicDetails \u003d String.format(\"All alarms were sporadic for %s\", this.getId());"},{"line_number":181,"context_line":"          state \u003d AlarmState.OK;"},{"line_number":182,"context_line":"          stateChangeReason \u003d String.format(\"%s\\n%s\", rawMsg, sporadicDetails);"},{"line_number":183,"context_line":"          return true;"},{"line_number":184,"context_line":"        }"},{"line_number":185,"context_line":"        return false;"},{"line_number":186,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":12,"id":"ba0121b8_29407606","line":183,"range":{"start_line":179,"start_character":10,"end_line":183,"end_character":22},"in_reply_to":"ba0121b8_760fe936","updated":"2016-04-01 11:58:24.000000000","message":"Because of lines 170-172.","commit_id":"0c105c473ef2ec66108b1415602636e469723e57"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6c125737c581385d25278dff0f22e54aa1918a2c","unresolved":false,"context_lines":[{"line_number":142,"context_line":"   * Evaluates the {@code alarm}, updating the alarm\u0027s state if necessary and returning true if the"},{"line_number":143,"context_line":"   * alarm\u0027s state changed, else false."},{"line_number":144,"context_line":"   *"},{"line_number":145,"context_line":"   * \u003cb\u003eNote:\u003c/b\u003e All alarms need to be sporadic to keep alarm out of {@link AlarmState#UNDETERMINED}"},{"line_number":146,"context_line":"   * state. Otherwise alarm acts as if all alarms are periodic."},{"line_number":147,"context_line":"   *"},{"line_number":148,"context_line":"   */"}],"source_content_type":"text/x-java","patch_set":15,"id":"1a122d0e_adeb3a77","line":145,"range":{"start_line":145,"start_character":22,"end_line":145,"end_character":28},"updated":"2016-04-28 15:16:25.000000000","message":"I believe you mean sub alarms instead of alarms here and in the next line","commit_id":"5defdef627fb9f947ce32236b6216c7c00a667f3"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"62e6ca20be422c9a0986eeee62b86cd809e2aef5","unresolved":false,"context_lines":[{"line_number":142,"context_line":"   * Evaluates the {@code alarm}, updating the alarm\u0027s state if necessary and returning true if the"},{"line_number":143,"context_line":"   * alarm\u0027s state changed, else false."},{"line_number":144,"context_line":"   *"},{"line_number":145,"context_line":"   * \u003cb\u003eNote:\u003c/b\u003e All alarms need to be sporadic to keep alarm out of {@link AlarmState#UNDETERMINED}"},{"line_number":146,"context_line":"   * state. Otherwise alarm acts as if all alarms are periodic."},{"line_number":147,"context_line":"   *"},{"line_number":148,"context_line":"   */"}],"source_content_type":"text/x-java","patch_set":15,"id":"1a122d0e_55f31a73","line":145,"range":{"start_line":145,"start_character":22,"end_line":145,"end_character":28},"in_reply_to":"1a122d0e_adeb3a77","updated":"2016-05-11 08:46:03.000000000","message":"Done","commit_id":"5defdef627fb9f947ce32236b6216c7c00a667f3"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6c125737c581385d25278dff0f22e54aa1918a2c","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    // mark if all sporadic"},{"line_number":169,"context_line":"    allSporadic \u003d sporadicMetricCounter \u003d\u003d subAlarms.size();"},{"line_number":170,"context_line":"    if(allSporadic){"},{"line_number":171,"context_line":"      initialState \u003d AlarmState.OK; // just mark initial state as target"},{"line_number":172,"context_line":"    }"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-java","patch_set":15,"id":"1a122d0e_a82328a6","line":170,"range":{"start_line":170,"start_character":3,"end_line":170,"end_character":20},"updated":"2016-04-28 15:16:25.000000000","message":"fix formatting on this line","commit_id":"5defdef627fb9f947ce32236b6216c7c00a667f3"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"62e6ca20be422c9a0986eeee62b86cd809e2aef5","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    // mark if all sporadic"},{"line_number":169,"context_line":"    allSporadic \u003d sporadicMetricCounter \u003d\u003d subAlarms.size();"},{"line_number":170,"context_line":"    if(allSporadic){"},{"line_number":171,"context_line":"      initialState \u003d AlarmState.OK; // just mark initial state as target"},{"line_number":172,"context_line":"    }"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-java","patch_set":15,"id":"1a122d0e_95e93282","line":170,"range":{"start_line":170,"start_character":3,"end_line":170,"end_character":20},"in_reply_to":"1a122d0e_a82328a6","updated":"2016-05-11 08:46:03.000000000","message":"Done","commit_id":"5defdef627fb9f947ce32236b6216c7c00a667f3"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6c125737c581385d25278dff0f22e54aa1918a2c","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    // mark if all sporadic"},{"line_number":169,"context_line":"    allSporadic \u003d sporadicMetricCounter \u003d\u003d subAlarms.size();"},{"line_number":170,"context_line":"    if(allSporadic){"},{"line_number":171,"context_line":"      initialState \u003d AlarmState.OK; // just mark initial state as target"},{"line_number":172,"context_line":"    }"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    // Handle UNDETERMINED state"}],"source_content_type":"text/x-java","patch_set":15,"id":"1a122d0e_c8c824ab","line":171,"range":{"start_line":171,"start_character":21,"end_line":171,"end_character":34},"updated":"2016-04-28 15:16:25.000000000","message":"Should this instead by initial_state? If this alarm was in the ALARM state because of the last measurements that were received, don\u0027t you want to leave it in that state if no new measurements have been received?","commit_id":"5defdef627fb9f947ce32236b6216c7c00a667f3"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"62e6ca20be422c9a0986eeee62b86cd809e2aef5","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    // mark if all sporadic"},{"line_number":169,"context_line":"    allSporadic \u003d sporadicMetricCounter \u003d\u003d subAlarms.size();"},{"line_number":170,"context_line":"    if(allSporadic){"},{"line_number":171,"context_line":"      initialState \u003d AlarmState.OK; // just mark initial state as target"},{"line_number":172,"context_line":"    }"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    // Handle UNDETERMINED state"}],"source_content_type":"text/x-java","patch_set":15,"id":"1a122d0e_7e3713b0","line":171,"range":{"start_line":171,"start_character":21,"end_line":171,"end_character":34},"in_reply_to":"1a122d0e_c8c824ab","updated":"2016-05-11 08:46:03.000000000","message":"Yes, I guess that makes sense.\n\nThere will be a unit test that will verify if that is happening. I just hope I\u0027ll get the concept right there.","commit_id":"5defdef627fb9f947ce32236b6216c7c00a667f3"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6c125737c581385d25278dff0f22e54aa1918a2c","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"      if (allSporadic) {"},{"line_number":179,"context_line":"        final String rawMsg \u003d buildStateChangeReason(this.state);"},{"line_number":180,"context_line":"        final String sporadicDetails \u003d String.format(\"All alarms were sporadic for %s\", this.getId());"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        state \u003d AlarmState.OK;"},{"line_number":183,"context_line":"        stateChangeReason \u003d String.format(\"%s\\n%s\", rawMsg, sporadicDetails);"}],"source_content_type":"text/x-java","patch_set":15,"id":"1a122d0e_8d659e1f","line":180,"range":{"start_line":180,"start_character":58,"end_line":180,"end_character":64},"updated":"2016-04-28 15:16:25.000000000","message":"probably sub alarms here as well.","commit_id":"5defdef627fb9f947ce32236b6216c7c00a667f3"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"62e6ca20be422c9a0986eeee62b86cd809e2aef5","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"      if (allSporadic) {"},{"line_number":179,"context_line":"        final String rawMsg \u003d buildStateChangeReason(this.state);"},{"line_number":180,"context_line":"        final String sporadicDetails \u003d String.format(\"All alarms were sporadic for %s\", this.getId());"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        state \u003d AlarmState.OK;"},{"line_number":183,"context_line":"        stateChangeReason \u003d String.format(\"%s\\n%s\", rawMsg, sporadicDetails);"}],"source_content_type":"text/x-java","patch_set":15,"id":"1a122d0e_d5ad6a32","line":180,"range":{"start_line":180,"start_character":58,"end_line":180,"end_character":64},"in_reply_to":"1a122d0e_8d659e1f","updated":"2016-05-11 08:46:03.000000000","message":"Done","commit_id":"5defdef627fb9f947ce32236b6216c7c00a667f3"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6c125737c581385d25278dff0f22e54aa1918a2c","unresolved":false,"context_lines":[{"line_number":331,"context_line":"  }"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"  public List\u003cSubAlarm\u003e getSporadicSubAlarms() {"},{"line_number":334,"context_line":"    if(this.subAlarms \u003d\u003d null || this.subAlarms.isEmpty()){"},{"line_number":335,"context_line":"      return Lists.newArrayList();"},{"line_number":336,"context_line":"    }"},{"line_number":337,"context_line":"    return FluentIterable.from(this.getSubAlarms())"}],"source_content_type":"text/x-java","patch_set":15,"id":"1a122d0e_687bd08c","line":334,"range":{"start_line":334,"start_character":0,"end_line":334,"end_character":59},"updated":"2016-04-28 15:16:25.000000000","message":"Formatting","commit_id":"5defdef627fb9f947ce32236b6216c7c00a667f3"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6c125737c581385d25278dff0f22e54aa1918a2c","unresolved":false,"context_lines":[{"line_number":345,"context_line":"  }"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"  public List\u003cSubAlarm\u003e getPeriodicSubAlarms() {"},{"line_number":348,"context_line":"    if(this.subAlarms \u003d\u003d null || this.subAlarms.isEmpty()){"},{"line_number":349,"context_line":"      return Lists.newArrayList();"},{"line_number":350,"context_line":"    }"},{"line_number":351,"context_line":"    return FluentIterable.from(this.getSubAlarms())"}],"source_content_type":"text/x-java","patch_set":15,"id":"1a122d0e_c87ae476","line":348,"range":{"start_line":348,"start_character":0,"end_line":348,"end_character":59},"updated":"2016-04-28 15:16:25.000000000","message":"formatting","commit_id":"5defdef627fb9f947ce32236b6216c7c00a667f3"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"import java.util.Set;"},{"line_number":28,"context_line":"import java.util.UUID;"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"import javax.annotation.Nullable;"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"import com.google.common.base.Predicate;"},{"line_number":33,"context_line":"import com.google.common.collect.FluentIterable;"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_9cb5dfef","line":30,"updated":"2016-05-09 22:35:15.000000000","message":"Please don\u0027t rearrange the imports. It makes the real changes harder to spot.","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"import java.util.Set;"},{"line_number":28,"context_line":"import java.util.UUID;"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"import javax.annotation.Nullable;"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"import com.google.common.base.Predicate;"},{"line_number":33,"context_line":"import com.google.common.collect.FluentIterable;"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_52e6a444","line":30,"in_reply_to":"dab17558_9cb5dfef","updated":"2016-05-10 11:17:04.000000000","message":"Yeah, sorry about that, I guess I need to finally do something about that in IntelliJ.","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":46,"context_line":" *"},{"line_number":47,"context_line":" */"},{"line_number":48,"context_line":"public class Alarm extends AbstractEntity {"},{"line_number":49,"context_line":"  private static final Predicate\u003cSubAlarm\u003e SPORADIC_PREDICATE \u003d new Predicate\u003cSubAlarm\u003e() {"},{"line_number":50,"context_line":"    @Override"},{"line_number":51,"context_line":"    public boolean apply(@Nullable final SubAlarm input) {"},{"line_number":52,"context_line":"      return input !\u003d null \u0026\u0026 input.isSporadicMetric();"},{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":"  };"},{"line_number":55,"context_line":"  private static final Predicate\u003cSubAlarm\u003e PERIODIC_PREDICATE \u003d new Predicate\u003cSubAlarm\u003e() {"},{"line_number":56,"context_line":"    @Override"},{"line_number":57,"context_line":"    public boolean apply(@Nullable final SubAlarm input) {"},{"line_number":58,"context_line":"      return !SPORADIC_PREDICATE.apply(input);"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"  };"},{"line_number":61,"context_line":"  private static final Predicate\u003cSubAlarm\u003e NON_DETERMINISTIC_PREDICATE \u003d new Predicate\u003cSubAlarm\u003e() {"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_59642921","line":58,"range":{"start_line":49,"start_character":0,"end_line":58,"end_character":46},"updated":"2016-05-09 22:35:15.000000000","message":"Remove the Periodic and Sporadic parts","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      return !SPORADIC_PREDICATE.apply(input);"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"  };"},{"line_number":61,"context_line":"  private static final Predicate\u003cSubAlarm\u003e NON_DETERMINISTIC_PREDICATE \u003d new Predicate\u003cSubAlarm\u003e() {"},{"line_number":62,"context_line":"    @Override"},{"line_number":63,"context_line":"    public boolean apply(@Nullable final SubAlarm input) {"},{"line_number":64,"context_line":"      return input !\u003d null \u0026\u0026 !input.isDeterministic();"},{"line_number":65,"context_line":"    }"},{"line_number":66,"context_line":"  };"},{"line_number":67,"context_line":"  private Map\u003cString, SubAlarm\u003e subAlarms;"},{"line_number":68,"context_line":"  private Set\u003cMetricDefinitionAndTenantId\u003e alarmedMetrics \u003d new HashSet\u003c\u003e();"},{"line_number":69,"context_line":"  private AlarmState state;"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_4d90df43","line":66,"range":{"start_line":61,"start_character":0,"end_line":66,"end_character":4},"updated":"2016-05-09 22:35:15.000000000","message":"Personally, I don\u0027t see the code is any simpler using this construct. If anything, it is harder to read. But, I won\u0027t say no :)","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    // extra check if all sporadic, if so...proceed to ok ASAP"},{"line_number":187,"context_line":"    if (uninitialized) {"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"      if (this.isNonDeterministic()) {"},{"line_number":190,"context_line":"        final String rawMsg \u003d this.buildStateChangeReason(this.state);"},{"line_number":191,"context_line":"        final String sporadicDetails \u003d String.format(\"All sub alarms were sporadic for alarm %s\","},{"line_number":192,"context_line":"            this.getId()"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_679d0459","line":189,"range":{"start_line":189,"start_character":15,"end_line":189,"end_character":33},"updated":"2016-05-09 22:35:15.000000000","message":"This is not correct. The point of having deterministic as a property of the Sub Expression is that you could have one or more Sub Expressions that are non-deterministic and one or more that are deterministic. Otherwise, deterministic should just be a property of the Alarm Definition.\n\nI believe the changes in SubAlarmStats are sufficient.","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    // extra check if all sporadic, if so...proceed to ok ASAP"},{"line_number":187,"context_line":"    if (uninitialized) {"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"      if (this.isNonDeterministic()) {"},{"line_number":190,"context_line":"        final String rawMsg \u003d this.buildStateChangeReason(this.state);"},{"line_number":191,"context_line":"        final String sporadicDetails \u003d String.format(\"All sub alarms were sporadic for alarm %s\","},{"line_number":192,"context_line":"            this.getId()"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_72964840","line":189,"range":{"start_line":189,"start_character":15,"end_line":189,"end_character":33},"in_reply_to":"dab17558_679d0459","updated":"2016-05-10 11:17:04.000000000","message":"But it may happen that all sub expressions are non-deterministic\n\nAlso this method returns true only if all sub expressions are non-deterministic. So, I assumed that the case here is similar to the one we had with sporadic metrics. If all metrics were to be sporadic we would immediately transition to ok. Also I wanted to present a detail msg for the notifications that something like that has happened.\n\nAs far as I know this is the place where the reason why state has been changed is computed, so if my assumption is wrong, let me know, I will fix that.","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":413,"context_line":"   *"},{"line_number":414,"context_line":"   * @return true/false"},{"line_number":415,"context_line":"   */"},{"line_number":416,"context_line":"  public boolean isDeterministic() {"},{"line_number":417,"context_line":"    return !this.isNonDeterministic();"},{"line_number":418,"context_line":"  }"},{"line_number":419,"context_line":""}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_1c228f00","line":416,"range":{"start_line":416,"start_character":17,"end_line":416,"end_character":32},"updated":"2016-05-09 22:35:15.000000000","message":"Should only have isDeterminstic() or isNotDeterministic. This is more confusing than just using !isNonDeterministic()","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":413,"context_line":"   *"},{"line_number":414,"context_line":"   * @return true/false"},{"line_number":415,"context_line":"   */"},{"line_number":416,"context_line":"  public boolean isDeterministic() {"},{"line_number":417,"context_line":"    return !this.isNonDeterministic();"},{"line_number":418,"context_line":"  }"},{"line_number":419,"context_line":""}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_12a6dcad","line":416,"range":{"start_line":416,"start_character":17,"end_line":416,"end_character":32},"in_reply_to":"dab17558_1c228f00","updated":"2016-05-10 11:17:04.000000000","message":"Done","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":426,"context_line":"   * @return true/false"},{"line_number":427,"context_line":"   */"},{"line_number":428,"context_line":"  public boolean isNonDeterministic() {"},{"line_number":429,"context_line":"    return !this.subAlarms.isEmpty() \u0026\u0026"},{"line_number":430,"context_line":"        this.getSubAlarms().size() \u003d\u003d this.getNondeterministicSubAlarms().size();"},{"line_number":431,"context_line":"  }"},{"line_number":432,"context_line":"}"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_470600cf","line":429,"range":{"start_line":429,"start_character":0,"end_line":429,"end_character":39},"updated":"2016-05-09 22:35:15.000000000","message":"Wouldn\u0027t this be simpler:\n\nfor (SubAlarm subAlarm : this.subAlarms) {\n   if (subAlarm.isDeterministic()) {\n      return false;\n   }\nreturn true;\n}","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":426,"context_line":"   * @return true/false"},{"line_number":427,"context_line":"   */"},{"line_number":428,"context_line":"  public boolean isNonDeterministic() {"},{"line_number":429,"context_line":"    return !this.subAlarms.isEmpty() \u0026\u0026"},{"line_number":430,"context_line":"        this.getSubAlarms().size() \u003d\u003d this.getNondeterministicSubAlarms().size();"},{"line_number":431,"context_line":"  }"},{"line_number":432,"context_line":"}"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_52fb4447","line":429,"range":{"start_line":429,"start_character":0,"end_line":429,"end_character":39},"in_reply_to":"dab17558_470600cf","updated":"2016-05-10 11:17:04.000000000","message":"Done","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"b9aff1be327a852b04bd6701db49a7d7167fb111","unresolved":false,"context_lines":[{"line_number":148,"context_line":"   * Evaluates the {@code alarm}, updating the alarm\u0027s state if necessary and returning true if the"},{"line_number":149,"context_line":"   * alarm\u0027s state changed, else false."},{"line_number":150,"context_line":"   *"},{"line_number":151,"context_line":"   * \u003cb\u003eNote:\u003c/b\u003e All sub alarms need to be sporadic to keep alarm out of"},{"line_number":152,"context_line":"   * {@link AlarmState#UNDETERMINED} state."},{"line_number":153,"context_line":"   * Otherwise alarm acts as if all sub alarms are periodic."},{"line_number":154,"context_line":"   *"}],"source_content_type":"text/x-java","patch_set":19,"id":"dab17558_3ee487aa","line":151,"range":{"start_line":151,"start_character":44,"end_line":151,"end_character":52},"updated":"2016-05-10 11:29:31.000000000","message":"Yeah, missed that. Will be patched next time.","commit_id":"2335a36dbd58755e0c1ad4ec408abc5dcee78d1a"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"249b59d284e914db8437f7e0c9e9788316eae7c5","unresolved":false,"context_lines":[{"line_number":148,"context_line":"   * Evaluates the {@code alarm}, updating the alarm\u0027s state if necessary and returning true if the"},{"line_number":149,"context_line":"   * alarm\u0027s state changed, else false."},{"line_number":150,"context_line":"   *"},{"line_number":151,"context_line":"   * \u003cb\u003eNote:\u003c/b\u003e All sub alarms need to be sporadic to keep alarm out of"},{"line_number":152,"context_line":"   * {@link AlarmState#UNDETERMINED} state."},{"line_number":153,"context_line":"   * Otherwise alarm acts as if all sub alarms are periodic."},{"line_number":154,"context_line":"   *"}],"source_content_type":"text/x-java","patch_set":19,"id":"dab17558_ae0bf322","line":151,"range":{"start_line":151,"start_character":44,"end_line":151,"end_character":52},"in_reply_to":"dab17558_3ee487aa","updated":"2016-05-11 08:29:00.000000000","message":"Done","commit_id":"2335a36dbd58755e0c1ad4ec408abc5dcee78d1a"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"dd0d3a617b69a65e0ab79424385982a9a760db12","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    // Handle UNDETERMINED state"},{"line_number":179,"context_line":"    if (uninitialized) {"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"      if (!this.isDeterministic()) {"},{"line_number":182,"context_line":"        final String rawMsg \u003d this.buildStateChangeReason(this.state);"},{"line_number":183,"context_line":"        final String detailMsg \u003d String.format("},{"line_number":184,"context_line":"            \"All sub alarms were non deterministic for alarm %s\","}],"source_content_type":"text/x-java","patch_set":20,"id":"dab17558_b8b3214c","line":181,"range":{"start_line":181,"start_character":7,"end_line":181,"end_character":36},"updated":"2016-05-11 15:48:28.000000000","message":"In order to get here, one of the SubAlarms must be in the UNDETERMINED state. Only deterministic SubAlarms go to UNDETERMINED, so this can never be true. This code is not needed.","commit_id":"23344f2588d491d90c0982a9e647a99cd326aea0"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"e7a7ac889b5a5997f9955207223e6f1b132007c1","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    // Handle UNDETERMINED state"},{"line_number":179,"context_line":"    if (uninitialized) {"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"      if (!this.isDeterministic()) {"},{"line_number":182,"context_line":"        final String rawMsg \u003d this.buildStateChangeReason(this.state);"},{"line_number":183,"context_line":"        final String detailMsg \u003d String.format("},{"line_number":184,"context_line":"            \"All sub alarms were non deterministic for alarm %s\","}],"source_content_type":"text/x-java","patch_set":20,"id":"dab17558_9b2b9c81","line":181,"range":{"start_line":181,"start_character":7,"end_line":181,"end_character":36},"in_reply_to":"dab17558_86450e44","updated":"2016-05-12 04:09:28.000000000","message":"Double checked that, and you were correct, this code should be removed.","commit_id":"23344f2588d491d90c0982a9e647a99cd326aea0"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"c75a52dd78b92ddea5baa21b3d8483307d73647d","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    // Handle UNDETERMINED state"},{"line_number":179,"context_line":"    if (uninitialized) {"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"      if (!this.isDeterministic()) {"},{"line_number":182,"context_line":"        final String rawMsg \u003d this.buildStateChangeReason(this.state);"},{"line_number":183,"context_line":"        final String detailMsg \u003d String.format("},{"line_number":184,"context_line":"            \"All sub alarms were non deterministic for alarm %s\","}],"source_content_type":"text/x-java","patch_set":20,"id":"dab17558_86450e44","line":181,"range":{"start_line":181,"start_character":7,"end_line":181,"end_character":36},"in_reply_to":"dab17558_b8b3214c","updated":"2016-05-11 21:35:28.000000000","message":"Giving it a thought...well, I am not a thresh expert, so this\u0027d be a question. Does what you just wrote apply also for initial state, the first time alarm gets created ?","commit_id":"23344f2588d491d90c0982a9e647a99cd326aea0"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"8a451b535e3db8267021c33f655435ed061c9900","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    this.alarmDefinitionId \u003d alarmDefinition.getId();"},{"line_number":76,"context_line":"  }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  public Alarm(AlarmDefinition alarmDefinition, AlarmState state) {"},{"line_number":79,"context_line":"    this(alarmDefinition);"},{"line_number":80,"context_line":"    this.state \u003d state; // override state detected from expression, for test purposes"},{"line_number":81,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":21,"id":"dab17558_cfba500a","line":78,"range":{"start_line":78,"start_character":9,"end_line":78,"end_character":65},"updated":"2016-05-12 20:25:13.000000000","message":"Is this really needed or was it just too hard to replace all of the places where it was called from? Seems to be a bad idea to override the state to UNDETERMINED if it isn\u0027t allowed","commit_id":"e876fc8adc4ec7495c04c1dd26eaf3b3ab8c1939"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"c4ff28ff1a8ca363fab686dcce2491ba6cecfd56","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    this.alarmDefinitionId \u003d alarmDefinition.getId();"},{"line_number":76,"context_line":"  }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  public Alarm(AlarmDefinition alarmDefinition, AlarmState state) {"},{"line_number":79,"context_line":"    this(alarmDefinition);"},{"line_number":80,"context_line":"    this.state \u003d state; // override state detected from expression, for test purposes"},{"line_number":81,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":21,"id":"dab17558_ff686b23","line":78,"range":{"start_line":78,"start_character":9,"end_line":78,"end_character":65},"in_reply_to":"dab17558_cfba500a","updated":"2016-05-13 20:37:59.000000000","message":"There was lots of places to change that, especially in the tests. That\u0027s why I left the comment here. For me it was easier (obviously ;) ) to do just leave this constructor instead of modifying test classes, however I agree with your comment that this may be misleading. \n\nI will refactor the tests to use setter method and remove this constructor.","commit_id":"e876fc8adc4ec7495c04c1dd26eaf3b3ab8c1939"}],"thresh/src/main/java/monasca/thresh/domain/model/SubAlarm.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6c125737c581385d25278dff0f22e54aa1918a2c","unresolved":false,"context_lines":[{"line_number":167,"context_line":"  @Override"},{"line_number":168,"context_line":"  public String toString() {"},{"line_number":169,"context_line":"    return String.format(\"SubAlarm [id\u003d%s, alarmId\u003d%s, alarmSubExpressionId\u003d%s, expression\u003d%s, \" +"},{"line_number":170,"context_line":"        \"state\u003d%s, noState\u003d%s, sporadicMetric\u003d%s, currentValues:[\", id,"},{"line_number":171,"context_line":"        alarmId, alarmSubExpressionId, expression, state, noState, sporadicMetric) + currentValues + \"]]\";"},{"line_number":172,"context_line":"  }"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-java","patch_set":15,"id":"1a122d0e_aa695bfb","line":170,"range":{"start_line":170,"start_character":31,"end_line":170,"end_character":48},"updated":"2016-04-28 15:16:25.000000000","message":"Can you also fix hashcode() and equals to use sporadicMetric correctly? The original code is wrong on that.","commit_id":"5defdef627fb9f947ce32236b6216c7c00a667f3"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"62e6ca20be422c9a0986eeee62b86cd809e2aef5","unresolved":false,"context_lines":[{"line_number":167,"context_line":"  @Override"},{"line_number":168,"context_line":"  public String toString() {"},{"line_number":169,"context_line":"    return String.format(\"SubAlarm [id\u003d%s, alarmId\u003d%s, alarmSubExpressionId\u003d%s, expression\u003d%s, \" +"},{"line_number":170,"context_line":"        \"state\u003d%s, noState\u003d%s, sporadicMetric\u003d%s, currentValues:[\", id,"},{"line_number":171,"context_line":"        alarmId, alarmSubExpressionId, expression, state, noState, sporadicMetric) + currentValues + \"]]\";"},{"line_number":172,"context_line":"  }"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-java","patch_set":15,"id":"1a122d0e_bee36bd7","line":170,"range":{"start_line":170,"start_character":31,"end_line":170,"end_character":48},"in_reply_to":"1a122d0e_aa695bfb","updated":"2016-05-11 08:46:03.000000000","message":"Actually removed sporadic metric field from here.\nIf sub alarm has sporadic metric is determined from metric definition.","commit_id":"5defdef627fb9f947ce32236b6216c7c00a667f3"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import java.util.List;"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import monasca.common.model.alarm.AlarmState;"},{"line_number":26,"context_line":"import monasca.common.model.alarm.AlarmSubExpression;"},{"line_number":27,"context_line":"import monasca.common.model.domain.common.AbstractEntity;"},{"line_number":28,"context_line":"import monasca.common.model.metric.MetricDefinition;"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_67eb44b1","line":26,"updated":"2016-05-09 22:35:15.000000000","message":"Please don\u0027t rearrange the imports. It makes the real changes harder to spot.","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import java.util.List;"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import monasca.common.model.alarm.AlarmState;"},{"line_number":26,"context_line":"import monasca.common.model.alarm.AlarmSubExpression;"},{"line_number":27,"context_line":"import monasca.common.model.domain.common.AbstractEntity;"},{"line_number":28,"context_line":"import monasca.common.model.metric.MetricDefinition;"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_921acc7b","line":26,"in_reply_to":"dab17558_67eb44b1","updated":"2016-05-10 11:17:04.000000000","message":"Done","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":143,"context_line":"  }"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  /**"},{"line_number":146,"context_line":"   * Determines if {@link SubAlarm} is sporadic."},{"line_number":147,"context_line":"   *"},{"line_number":148,"context_line":"   * Infrequency of sub alarm is determined based on underlying"},{"line_number":149,"context_line":"   * metric definition - part of {@link #expression}."}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_194d816c","line":146,"updated":"2016-05-09 22:35:15.000000000","message":"No need for the sporadic changes. I know the original code is wrong, but this code isn\u0027t used so let\u0027s make this change only be deterministic","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":143,"context_line":"  }"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  /**"},{"line_number":146,"context_line":"   * Determines if {@link SubAlarm} is sporadic."},{"line_number":147,"context_line":"   *"},{"line_number":148,"context_line":"   * Infrequency of sub alarm is determined based on underlying"},{"line_number":149,"context_line":"   * metric definition - part of {@link #expression}."}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_d210d45b","line":146,"in_reply_to":"dab17558_194d816c","updated":"2016-05-10 11:17:04.000000000","message":"Done","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    if (this.expression.getPeriods() !\u003d other.getPeriods()) {"},{"line_number":219,"context_line":"      return false;"},{"line_number":220,"context_line":"    }"},{"line_number":221,"context_line":"    if (this.expression.isDeterministic() !\u003d other.isDeterministic()){"},{"line_number":222,"context_line":"      return false;"},{"line_number":223,"context_line":"    }"},{"line_number":224,"context_line":"    // Operator and Threshold can vary"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_592709b6","line":221,"range":{"start_line":221,"start_character":6,"end_line":221,"end_character":70},"updated":"2016-05-09 22:35:15.000000000","message":"Actually, I believe that changes in this field do not require throwing away the current saved measurements.","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    if (this.expression.getPeriods() !\u003d other.getPeriods()) {"},{"line_number":219,"context_line":"      return false;"},{"line_number":220,"context_line":"    }"},{"line_number":221,"context_line":"    if (this.expression.isDeterministic() !\u003d other.isDeterministic()){"},{"line_number":222,"context_line":"      return false;"},{"line_number":223,"context_line":"    }"},{"line_number":224,"context_line":"    // Operator and Threshold can vary"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_755472fe","line":221,"range":{"start_line":221,"start_character":6,"end_line":221,"end_character":70},"in_reply_to":"dab17558_592709b6","updated":"2016-05-10 11:17:04.000000000","message":"Giving it a second thought, I think you\u0027re right. The only difference would be that alarm would be allowed to transition to UNDETERMINED state which does not affect computing.","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"8a451b535e3db8267021c33f655435ed061c9900","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    return result;"},{"line_number":142,"context_line":"  }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  /**"},{"line_number":145,"context_line":"   * Determines if {@link SubAlarm} is deterministic."},{"line_number":146,"context_line":"   *"},{"line_number":147,"context_line":"   * Determinism of a sub alarm is determined based on underlying"},{"line_number":148,"context_line":"   * expression ({@link #expression})."},{"line_number":149,"context_line":"   *"},{"line_number":150,"context_line":"   * Note:"},{"line_number":151,"context_line":"   *  If sub alarm has no expression this method will return"},{"line_number":152,"context_line":"   *  {@value AlarmSubExpression#DEFAULT_DETERMINISTIC}."},{"line_number":153,"context_line":"   *"},{"line_number":154,"context_line":"   * @return true/false"},{"line_number":155,"context_line":"   * @see monasca.common.model.alarm.AlarmSubExpression#isDeterministic()"},{"line_number":156,"context_line":"   */"},{"line_number":157,"context_line":"  public boolean isDeterministic() {"},{"line_number":158,"context_line":"    return this.expression \u003d\u003d null ? AlarmSubExpression.DEFAULT_DETERMINISTIC : this.expression"},{"line_number":159,"context_line":"        .isDeterministic();"},{"line_number":160,"context_line":"  }"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"  public void setState(AlarmState state) {"}],"source_content_type":"text/x-java","patch_set":21,"id":"dab17558_cfd7f0eb","line":159,"range":{"start_line":144,"start_character":0,"end_line":159,"end_character":27},"updated":"2016-05-12 20:25:13.000000000","message":"I wonder if this method is really needed? It can be replaced by getExpression().isDeterminstic(). That way you don\u0027t the weird code handling this.expression \u003d\u003d null. If anybody is really calling this method with a null this.expression we should find out rather than defaulting the answer","commit_id":"e876fc8adc4ec7495c04c1dd26eaf3b3ab8c1939"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3c9dca220d086002df50509009750346d26dce2b","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    return result;"},{"line_number":142,"context_line":"  }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  /**"},{"line_number":145,"context_line":"   * Determines if {@link SubAlarm} is deterministic."},{"line_number":146,"context_line":"   *"},{"line_number":147,"context_line":"   * Determinism of a sub alarm is determined based on underlying"},{"line_number":148,"context_line":"   * expression ({@link #expression})."},{"line_number":149,"context_line":"   *"},{"line_number":150,"context_line":"   * Note:"},{"line_number":151,"context_line":"   *  If sub alarm has no expression this method will return"},{"line_number":152,"context_line":"   *  {@value AlarmSubExpression#DEFAULT_DETERMINISTIC}."},{"line_number":153,"context_line":"   *"},{"line_number":154,"context_line":"   * @return true/false"},{"line_number":155,"context_line":"   * @see monasca.common.model.alarm.AlarmSubExpression#isDeterministic()"},{"line_number":156,"context_line":"   */"},{"line_number":157,"context_line":"  public boolean isDeterministic() {"},{"line_number":158,"context_line":"    return this.expression \u003d\u003d null ? AlarmSubExpression.DEFAULT_DETERMINISTIC : this.expression"},{"line_number":159,"context_line":"        .isDeterministic();"},{"line_number":160,"context_line":"  }"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"  public void setState(AlarmState state) {"}],"source_content_type":"text/x-java","patch_set":21,"id":"dab17558_baea71aa","line":159,"range":{"start_line":144,"start_character":0,"end_line":159,"end_character":27},"in_reply_to":"dab17558_1f78cfc3","updated":"2016-05-13 22:56:17.000000000","message":"Changing it that way is fine with me.","commit_id":"e876fc8adc4ec7495c04c1dd26eaf3b3ab8c1939"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"c4ff28ff1a8ca363fab686dcce2491ba6cecfd56","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    return result;"},{"line_number":142,"context_line":"  }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  /**"},{"line_number":145,"context_line":"   * Determines if {@link SubAlarm} is deterministic."},{"line_number":146,"context_line":"   *"},{"line_number":147,"context_line":"   * Determinism of a sub alarm is determined based on underlying"},{"line_number":148,"context_line":"   * expression ({@link #expression})."},{"line_number":149,"context_line":"   *"},{"line_number":150,"context_line":"   * Note:"},{"line_number":151,"context_line":"   *  If sub alarm has no expression this method will return"},{"line_number":152,"context_line":"   *  {@value AlarmSubExpression#DEFAULT_DETERMINISTIC}."},{"line_number":153,"context_line":"   *"},{"line_number":154,"context_line":"   * @return true/false"},{"line_number":155,"context_line":"   * @see monasca.common.model.alarm.AlarmSubExpression#isDeterministic()"},{"line_number":156,"context_line":"   */"},{"line_number":157,"context_line":"  public boolean isDeterministic() {"},{"line_number":158,"context_line":"    return this.expression \u003d\u003d null ? AlarmSubExpression.DEFAULT_DETERMINISTIC : this.expression"},{"line_number":159,"context_line":"        .isDeterministic();"},{"line_number":160,"context_line":"  }"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"  public void setState(AlarmState state) {"}],"source_content_type":"text/x-java","patch_set":21,"id":"dab17558_1f78cfc3","line":159,"range":{"start_line":144,"start_character":0,"end_line":159,"end_character":27},"in_reply_to":"dab17558_cfd7f0eb","updated":"2016-05-13 20:37:59.000000000","message":"It can, but I like such constructs, they allow to make code shorter in some places and at some point follow encapsulation pattern. \n\nStill, comment about null expression is valid. Case where expression is null is rather impossible, as far as I am aware. So I\u0027ll just leave \n\n  return this.expression.isDeterministic();\n\nif you don\u0027t have any further objections.\n\nCode here does not break anything but potentially allows to access information about expression trait with less typing. Again that\u0027s what I prefer so if you still find this redundant, let me know, I will just remove it. I see no point in arguing over little method.","commit_id":"e876fc8adc4ec7495c04c1dd26eaf3b3ab8c1939"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"125b1f2a1b723f94a5ffa0229c7eee2d6c99dfaf","unresolved":false,"context_lines":[{"line_number":144,"context_line":"  /**"},{"line_number":145,"context_line":"   * Determines if {@link SubAlarm} is deterministic."},{"line_number":146,"context_line":"   *"},{"line_number":147,"context_line":"   * Determinism of a sub alarm is determined based on underlying"},{"line_number":148,"context_line":"   * expression ({@link #expression})."},{"line_number":149,"context_line":"   *"},{"line_number":150,"context_line":"   * @return true/false"}],"source_content_type":"text/x-java","patch_set":23,"id":"bab6814e_cad20bd2","line":147,"range":{"start_line":147,"start_character":5,"end_line":147,"end_character":16},"updated":"2016-05-19 14:36:33.000000000","message":"Determines if a sub-alarm","commit_id":"4230840fd423208ba3ed177c294f132c9d3e7c7a"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"ba7697f6f7f0af26288580b008219c1bba30bb21","unresolved":false,"context_lines":[{"line_number":144,"context_line":"  /**"},{"line_number":145,"context_line":"   * Determines if {@link SubAlarm} is deterministic."},{"line_number":146,"context_line":"   *"},{"line_number":147,"context_line":"   * Determinism of a sub alarm is determined based on underlying"},{"line_number":148,"context_line":"   * expression ({@link #expression})."},{"line_number":149,"context_line":"   *"},{"line_number":150,"context_line":"   * @return true/false"}],"source_content_type":"text/x-java","patch_set":23,"id":"bab6814e_d6c9e95a","line":147,"range":{"start_line":147,"start_character":5,"end_line":147,"end_character":16},"in_reply_to":"bab6814e_cad20bd2","updated":"2016-05-20 08:21:06.000000000","message":"Done","commit_id":"4230840fd423208ba3ed177c294f132c9d3e7c7a"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"125b1f2a1b723f94a5ffa0229c7eee2d6c99dfaf","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  @Override"},{"line_number":170,"context_line":"  public String toString() {"},{"line_number":171,"context_line":"    return String.format(\"SubAlarm [id\u003d%s, alarmId\u003d%s, alarmSubExpressionId\u003d%s, expression\u003d%s, \" +"},{"line_number":172,"context_line":"        \"state\u003d%s, noState\u003d%s, currentValues:[\", id,"},{"line_number":173,"context_line":"        alarmId, alarmSubExpressionId, expression, state, noState) + currentValues + \"]]\";"},{"line_number":174,"context_line":"  }"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-java","patch_set":23,"id":"bab6814e_0de9cde6","line":172,"range":{"start_line":172,"start_character":31,"end_line":172,"end_character":44},"updated":"2016-05-19 14:36:33.000000000","message":"i was just wondering if you wanted to add \"deterministic\" as a field in the string","commit_id":"4230840fd423208ba3ed177c294f132c9d3e7c7a"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"ba7697f6f7f0af26288580b008219c1bba30bb21","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  @Override"},{"line_number":170,"context_line":"  public String toString() {"},{"line_number":171,"context_line":"    return String.format(\"SubAlarm [id\u003d%s, alarmId\u003d%s, alarmSubExpressionId\u003d%s, expression\u003d%s, \" +"},{"line_number":172,"context_line":"        \"state\u003d%s, noState\u003d%s, currentValues:[\", id,"},{"line_number":173,"context_line":"        alarmId, alarmSubExpressionId, expression, state, noState) + currentValues + \"]]\";"},{"line_number":174,"context_line":"  }"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-java","patch_set":23,"id":"bab6814e_337a19f2","line":172,"range":{"start_line":172,"start_character":31,"end_line":172,"end_character":44},"in_reply_to":"bab6814e_0de9cde6","updated":"2016-05-20 08:21:06.000000000","message":"It\u0027s part of the expression, so I think that\u0027s not needed.","commit_id":"4230840fd423208ba3ed177c294f132c9d3e7c7a"}],"thresh/src/main/java/monasca/thresh/domain/model/SubAlarmStats.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6c125737c581385d25278dff0f22e54aa1918a2c","unresolved":false,"context_lines":[{"line_number":124,"context_line":"   * @param alarmDelay How long to give metrics a chance to arrive"},{"line_number":125,"context_line":"   */"},{"line_number":126,"context_line":"  boolean evaluate(final long now, long alarmDelay) {"},{"line_number":127,"context_line":"    AlarmState newState;"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    final boolean shouldEvaluate \u003d this.stats.shouldEvaluate(now, alarmDelay);"},{"line_number":130,"context_line":"    final boolean sporadicEvaluate \u003d this.immediateSporadicEvaluate();"}],"source_content_type":"text/x-java","patch_set":15,"id":"1a122d0e_aa379bfd","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":24},"updated":"2016-04-28 15:16:25.000000000","message":"Leave the final on","commit_id":"5defdef627fb9f947ce32236b6216c7c00a667f3"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"62e6ca20be422c9a0986eeee62b86cd809e2aef5","unresolved":false,"context_lines":[{"line_number":124,"context_line":"   * @param alarmDelay How long to give metrics a chance to arrive"},{"line_number":125,"context_line":"   */"},{"line_number":126,"context_line":"  boolean evaluate(final long now, long alarmDelay) {"},{"line_number":127,"context_line":"    AlarmState newState;"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    final boolean shouldEvaluate \u003d this.stats.shouldEvaluate(now, alarmDelay);"},{"line_number":130,"context_line":"    final boolean sporadicEvaluate \u003d this.immediateSporadicEvaluate();"}],"source_content_type":"text/x-java","patch_set":15,"id":"1a122d0e_fe3fa322","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":24},"in_reply_to":"1a122d0e_aa379bfd","updated":"2016-05-11 08:46:03.000000000","message":"Done","commit_id":"5defdef627fb9f947ce32236b6216c7c00a667f3"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6c125737c581385d25278dff0f22e54aa1918a2c","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    AlarmState newState;"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    final boolean shouldEvaluate \u003d this.stats.shouldEvaluate(now, alarmDelay);"},{"line_number":130,"context_line":"    final boolean sporadicEvaluate \u003d this.immediateSporadicEvaluate();"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    if (this.immediateAlarmEvaluate()) {"},{"line_number":133,"context_line":"      logger.trace(\"{} is candidate for immediate evaluation from state {}\","}],"source_content_type":"text/x-java","patch_set":15,"id":"1a122d0e_8d4759bb","line":130,"range":{"start_line":130,"start_character":18,"end_line":130,"end_character":34},"updated":"2016-04-28 15:16:25.000000000","message":"The below code might be easier to understand if you renamed sporadicEvaluate to something like sporadicAndUndetermined.","commit_id":"5defdef627fb9f947ce32236b6216c7c00a667f3"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6c125737c581385d25278dff0f22e54aa1918a2c","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    } else {"},{"line_number":139,"context_line":"      if (!(shouldEvaluate || sporadicEvaluate)) {"},{"line_number":140,"context_line":"        return false;"},{"line_number":141,"context_line":"      } else if (sporadicEvaluate) {"},{"line_number":142,"context_line":"        newState \u003d AlarmState.OK;"},{"line_number":143,"context_line":"      } else {"},{"line_number":144,"context_line":"        newState \u003d determineAlarmStateUsingView();"}],"source_content_type":"text/x-java","patch_set":15,"id":"1a122d0e_ad0a1588","line":141,"updated":"2016-04-28 15:16:25.000000000","message":"This is wrong. Even if the SubAlarm is sporadic and UNDETERMINED, it can transition immediately to ALARM. However, determineAlarmStateUsingView() needs to be called to do that. I think the changes to have determineAlarmStateUsingView() return OK for sporadic sub alarms gives you the right answer without changing this method at all.","commit_id":"5defdef627fb9f947ce32236b6216c7c00a667f3"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"31352ef09e87931a40556989afe195184e83367c","unresolved":false,"context_lines":[{"line_number":136,"context_line":"      );"},{"line_number":137,"context_line":"      newState \u003d AlarmState.ALARM;"},{"line_number":138,"context_line":"    } else {"},{"line_number":139,"context_line":"      if (!(shouldEvaluate || sporadicEvaluate)) {"},{"line_number":140,"context_line":"        return false;"},{"line_number":141,"context_line":"      } else if (sporadicEvaluate) {"},{"line_number":142,"context_line":"        newState \u003d AlarmState.OK;"}],"source_content_type":"text/x-java","patch_set":16,"id":"dab17558_939ff75e","line":139,"range":{"start_line":139,"start_character":12,"end_line":139,"end_character":26},"updated":"2016-05-06 03:21:50.000000000","message":"If we don\u0027t allow the \"sporadic\" alarms to be created in the undetermined state, then I think this would become:\n\nif (!shouldEvaluate) {\n    return false;\n}","commit_id":"c367ef1f4d2d53be9ed296c249cc52c932634529"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"26af6db66857b4ac0a5894654b9a2a25c43f37bf","unresolved":false,"context_lines":[{"line_number":136,"context_line":"      );"},{"line_number":137,"context_line":"      newState \u003d AlarmState.ALARM;"},{"line_number":138,"context_line":"    } else {"},{"line_number":139,"context_line":"      if (!(shouldEvaluate || sporadicEvaluate)) {"},{"line_number":140,"context_line":"        return false;"},{"line_number":141,"context_line":"      } else if (sporadicEvaluate) {"},{"line_number":142,"context_line":"        newState \u003d AlarmState.OK;"}],"source_content_type":"text/x-java","patch_set":16,"id":"dab17558_a420eff8","line":139,"range":{"start_line":139,"start_character":12,"end_line":139,"end_character":26},"in_reply_to":"dab17558_939ff75e","updated":"2016-05-06 06:05:14.000000000","message":"It will get back to this in next patch set.\nBasically I modified SubAlarm to determine initial state set in model based on alarm\u0027s expression. \n\nUsing latest modification in gramma for expression it is possible to tell if one is sporadic or not therefore determine initial state for SubAlarm\n\n sporadic\u003dtrue \u003e AlarmState.OK\n sporadic\u003dfalse \u003e AlarmState.UNDETERMINED","commit_id":"c367ef1f4d2d53be9ed296c249cc52c932634529"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"31352ef09e87931a40556989afe195184e83367c","unresolved":false,"context_lines":[{"line_number":139,"context_line":"      if (!(shouldEvaluate || sporadicEvaluate)) {"},{"line_number":140,"context_line":"        return false;"},{"line_number":141,"context_line":"      } else if (sporadicEvaluate) {"},{"line_number":142,"context_line":"        newState \u003d AlarmState.OK;"},{"line_number":143,"context_line":"      } else {"},{"line_number":144,"context_line":"        newState \u003d determineAlarmStateUsingView();"},{"line_number":145,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":16,"id":"dab17558_b3bafbbe","line":142,"range":{"start_line":142,"start_character":8,"end_line":142,"end_character":16},"updated":"2016-05-06 03:21:50.000000000","message":"See comment above, but my understanding of this block is it is the case where the alarm is currently in the UNDETERMINED state, but that really shouldn\u0027t be possible (because it is sporadic). Therefore, let\u0027s set it to OK.\n\nIt might be better when initializing the alarm to put it in the OK state, rather that the UNDETERMINED state, if the UNDETERMINED state shouldn\u0027t be allowed.\n\nThen this if block is removed.","commit_id":"c367ef1f4d2d53be9ed296c249cc52c932634529"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"26af6db66857b4ac0a5894654b9a2a25c43f37bf","unresolved":false,"context_lines":[{"line_number":139,"context_line":"      if (!(shouldEvaluate || sporadicEvaluate)) {"},{"line_number":140,"context_line":"        return false;"},{"line_number":141,"context_line":"      } else if (sporadicEvaluate) {"},{"line_number":142,"context_line":"        newState \u003d AlarmState.OK;"},{"line_number":143,"context_line":"      } else {"},{"line_number":144,"context_line":"        newState \u003d determineAlarmStateUsingView();"},{"line_number":145,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":16,"id":"dab17558_c47d33e9","line":142,"range":{"start_line":142,"start_character":8,"end_line":142,"end_character":16},"in_reply_to":"dab17558_b3bafbbe","updated":"2016-05-06 06:05:14.000000000","message":"Check above.","commit_id":"c367ef1f4d2d53be9ed296c249cc52c932634529"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"31352ef09e87931a40556989afe195184e83367c","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    emptyWindowObservations++;"},{"line_number":187,"context_line":"    if ((emptyWindowObservations \u003e\u003d emptyWindowObservationThreshold)"},{"line_number":188,"context_line":"        \u0026\u0026 shouldSendStateChange(AlarmState.UNDETERMINED)) {"},{"line_number":189,"context_line":"      if (!subAlarm.isSporadicMetric()) {"},{"line_number":190,"context_line":"        return AlarmState.UNDETERMINED;"},{"line_number":191,"context_line":"      } else {"},{"line_number":192,"context_line":"        return AlarmState.OK;"}],"source_content_type":"text/x-java","patch_set":16,"id":"dab17558_73bb730f","line":189,"range":{"start_line":189,"start_character":9,"end_line":189,"end_character":11},"updated":"2016-05-06 03:21:50.000000000","message":"So, this case would be if no_undetermined then return OK, else return UNDETERMINED\n\nwhich is basically what you have. Just recording my random notes. I think the code is fine, just would prefer no_undetermined, rather than isSporadic.","commit_id":"c367ef1f4d2d53be9ed296c249cc52c932634529"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"31352ef09e87931a40556989afe195184e83367c","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"  /**"},{"line_number":201,"context_line":"   * Will return true if {@link SubAlarm} is sporadic and current state is set to"},{"line_number":202,"context_line":"   * {@link AlarmState#UNDETERMINED}."},{"line_number":203,"context_line":"   *"},{"line_number":204,"context_line":"   * @return true/false"},{"line_number":205,"context_line":"   */"}],"source_content_type":"text/x-java","patch_set":16,"id":"dab17558_407778d4","line":202,"range":{"start_line":202,"start_character":23,"end_line":202,"end_character":35},"updated":"2016-05-06 03:21:50.000000000","message":"Hmmm, not the most knowledgable about this code, but I don\u0027t think that we should allow alarms for which there is no undetermined state to be created or ever enter the UNDETERMINED state. I could misunderstand how this code works, so my comments might not be valid, but I think I\u0027m right.\n\nPerhaps we should modify the alarm creation bolt to reflect that, but it just seems a little odd to allow the alarm to be created in the undetermined state if we are explicitly trying to prevent that from occurring.","commit_id":"c367ef1f4d2d53be9ed296c249cc52c932634529"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"package monasca.thresh.domain.model;"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import org.slf4j.Logger;"},{"line_number":22,"context_line":"import org.slf4j.LoggerFactory;"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import monasca.common.model.alarm.AlarmState;"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_e7ee14b3","line":21,"updated":"2016-05-09 22:35:15.000000000","message":"Please don\u0027t rearrange the imports. It makes the real changes harder to spot.","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"package monasca.thresh.domain.model;"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import org.slf4j.Logger;"},{"line_number":22,"context_line":"import org.slf4j.LoggerFactory;"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import monasca.common.model.alarm.AlarmState;"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_b5cd3ab9","line":21,"in_reply_to":"dab17558_e7ee14b3","updated":"2016-05-10 11:17:04.000000000","message":"Done","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"125b1f2a1b723f94a5ffa0229c7eee2d6c99dfaf","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    if (emptyWindowThresholdExceeded \u0026\u0026 this.shouldSendStateChange(AlarmState.UNDETERMINED)) {"},{"line_number":185,"context_line":"      final boolean isDeterministic \u003d this.subAlarm.isDeterministic();"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"      final AlarmState state \u003d isDeterministic ? AlarmState.UNDETERMINED : AlarmState.OK;"},{"line_number":188,"context_line":"      final AlarmState subAlarmState \u003d this.subAlarm.getState();"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"      logger.debug("}],"source_content_type":"text/x-java","patch_set":23,"id":"bab6814e_983859a2","line":187,"range":{"start_line":187,"start_character":30,"end_line":187,"end_character":31},"updated":"2016-05-19 14:36:33.000000000","message":"Should this be reversed? If the alarm is deterministic, shouldn\u0027t the state be OK?","commit_id":"4230840fd423208ba3ed177c294f132c9d3e7c7a"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"ba7697f6f7f0af26288580b008219c1bba30bb21","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    if (emptyWindowThresholdExceeded \u0026\u0026 this.shouldSendStateChange(AlarmState.UNDETERMINED)) {"},{"line_number":185,"context_line":"      final boolean isDeterministic \u003d this.subAlarm.isDeterministic();"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"      final AlarmState state \u003d isDeterministic ? AlarmState.UNDETERMINED : AlarmState.OK;"},{"line_number":188,"context_line":"      final AlarmState subAlarmState \u003d this.subAlarm.getState();"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"      logger.debug("}],"source_content_type":"text/x-java","patch_set":23,"id":"bab6814e_f6418daa","line":187,"range":{"start_line":187,"start_character":30,"end_line":187,"end_character":31},"in_reply_to":"bab6814e_983859a2","updated":"2016-05-20 08:21:06.000000000","message":"Done","commit_id":"4230840fd423208ba3ed177c294f132c9d3e7c7a"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"e79189ef951bfc153c31288edb6a83e378efa0c6","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        this.emptyWindowObservationThreshold;"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    if (emptyWindowThresholdExceeded \u0026\u0026 this.shouldSendStateChange(AlarmState.UNDETERMINED)) {"},{"line_number":185,"context_line":"      final boolean isDeterministic \u003d this.subAlarm.isDeterministic();"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"      final AlarmState state \u003d isDeterministic ? AlarmState.OK : AlarmState.UNDETERMINED;"},{"line_number":188,"context_line":"      final AlarmState subAlarmState \u003d this.subAlarm.getState();"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"      logger.debug("}],"source_content_type":"text/x-java","patch_set":27,"id":"9abb7d3a_7bb761f5","line":187,"range":{"start_line":185,"start_character":0,"end_line":187,"end_character":89},"updated":"2016-06-07 03:48:17.000000000","message":"This should be a method on SubAlarm and reuse SubAlarm.initialStateFromExpression instead of writing it again.","commit_id":"52d200817f8abff702bcde36ce56b109ffb83c28"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"0fb793db6f098852459b69164232df4ad46bd51a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        this.emptyWindowObservationThreshold;"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    if (emptyWindowThresholdExceeded \u0026\u0026 this.shouldSendStateChange(AlarmState.UNDETERMINED)) {"},{"line_number":185,"context_line":"      final boolean isDeterministic \u003d this.subAlarm.isDeterministic();"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"      final AlarmState state \u003d isDeterministic ? AlarmState.OK : AlarmState.UNDETERMINED;"},{"line_number":188,"context_line":"      final AlarmState subAlarmState \u003d this.subAlarm.getState();"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"      logger.debug("}],"source_content_type":"text/x-java","patch_set":27,"id":"7aa08908_f44c0944","line":187,"range":{"start_line":185,"start_character":0,"end_line":187,"end_character":89},"in_reply_to":"9abb7d3a_7bb761f5","updated":"2016-06-07 09:53:26.000000000","message":"Done.\n\nIn tests I am leaving the ternary operator, that seems to be better idea for me.","commit_id":"52d200817f8abff702bcde36ce56b109ffb83c28"}],"thresh/src/main/java/monasca/thresh/infrastructure/persistence/AlarmDAOImpl.java":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"f99c4685235231cd80c303bf1d78b36c250bcbb1","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                row, \"expression\")));"},{"line_number":114,"context_line":"        final SubAlarm subAlarm \u003d"},{"line_number":115,"context_line":"            new SubAlarm(getString(row, \"sub_alarm_id\"), alarmId, subExpression);"},{"line_number":116,"context_line":"        subAlarm.setSporadicMetric(Objects.equals(this.getString(row, \"sa_sporadic\"), \"1\"));"},{"line_number":117,"context_line":"        subAlarms.add(subAlarm);"},{"line_number":118,"context_line":"        prevAlarmId \u003d alarmId;"},{"line_number":119,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":11,"id":"ba0121b8_e81b8371","line":116,"range":{"start_line":116,"start_character":35,"end_line":116,"end_character":42},"updated":"2016-03-30 15:00:32.000000000","message":"I am not sure if that is how it supposed to look like in MySQL...","commit_id":"6cc710fde9e6b692de2cd79cae66a5b0fb3d692d"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"ba45e4a7e5e415d5623a5824f1eb93cab1b8d242","unresolved":false,"context_lines":[{"line_number":254,"context_line":"      for (final SubAlarm subAlarm : alarm.getSubAlarms()) {"},{"line_number":255,"context_line":"        h.insert("},{"line_number":256,"context_line":"            \"insert into sub_alarm (id, alarm_id, sub_expression_id, expression, \" +"},{"line_number":257,"context_line":"                \"sporadic, created_at, updated_at) values (?, ?, ?, ?, NOW(), NOW())\","},{"line_number":258,"context_line":"            subAlarm.getId(),"},{"line_number":259,"context_line":"            subAlarm.getAlarmId(),"},{"line_number":260,"context_line":"            subAlarm.getAlarmSubExpressionId(),"}],"source_content_type":"text/x-java","patch_set":12,"id":"ba0121b8_0018ead1","line":257,"range":{"start_line":257,"start_character":59,"end_line":257,"end_character":69},"updated":"2016-04-01 09:40:16.000000000","message":"parameter for \u0027sporadic\u0027 is missing","commit_id":"0c105c473ef2ec66108b1415602636e469723e57"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"4f025a74e72cff8169c241eb53b4da8008c21931","unresolved":false,"context_lines":[{"line_number":254,"context_line":"      for (final SubAlarm subAlarm : alarm.getSubAlarms()) {"},{"line_number":255,"context_line":"        h.insert("},{"line_number":256,"context_line":"            \"insert into sub_alarm (id, alarm_id, sub_expression_id, expression, \" +"},{"line_number":257,"context_line":"                \"sporadic, created_at, updated_at) values (?, ?, ?, ?, NOW(), NOW())\","},{"line_number":258,"context_line":"            subAlarm.getId(),"},{"line_number":259,"context_line":"            subAlarm.getAlarmId(),"},{"line_number":260,"context_line":"            subAlarm.getAlarmSubExpressionId(),"}],"source_content_type":"text/x-java","patch_set":12,"id":"ba0121b8_33c903ad","line":257,"range":{"start_line":257,"start_character":59,"end_line":257,"end_character":69},"in_reply_to":"ba0121b8_0018ead1","updated":"2016-04-01 11:03:25.000000000","message":"Done","commit_id":"0c105c473ef2ec66108b1415602636e469723e57"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6c125737c581385d25278dff0f22e54aa1918a2c","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                row, \"expression\")));"},{"line_number":114,"context_line":"        final SubAlarm subAlarm \u003d"},{"line_number":115,"context_line":"            new SubAlarm(getString(row, \"sub_alarm_id\"), alarmId, subExpression);"},{"line_number":116,"context_line":"        subAlarm.setSporadicMetric(Objects.equals(this.getString(row, \"sa_sporadic\"), \"1\"));"},{"line_number":117,"context_line":"        subAlarms.add(subAlarm);"},{"line_number":118,"context_line":"        prevAlarmId \u003d alarmId;"},{"line_number":119,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":15,"id":"1a122d0e_6d1bddca","line":116,"range":{"start_line":116,"start_character":35,"end_line":116,"end_character":89},"updated":"2016-04-28 15:16:25.000000000","message":"How is this different than \"1\".equals(this.getString(row, \"sa_sporadic\")) ?","commit_id":"5defdef627fb9f947ce32236b6216c7c00a667f3"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"import monasca.thresh.domain.model.SubExpression;"},{"line_number":28,"context_line":"import monasca.thresh.domain.service.AlarmDAO;"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"import com.google.common.collect.Lists;"},{"line_number":31,"context_line":"import org.apache.commons.codec.binary.Hex;"},{"line_number":32,"context_line":"import org.apache.commons.codec.digest.DigestUtils;"},{"line_number":33,"context_line":"import org.apache.commons.exec.ExecuteException;"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_79ce4db5","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":39},"updated":"2016-05-09 22:35:15.000000000","message":"We don\u0027t need any of these changes for the deterministic feature so just revert this file","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"import monasca.thresh.domain.model.SubExpression;"},{"line_number":28,"context_line":"import monasca.thresh.domain.service.AlarmDAO;"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"import com.google.common.collect.Lists;"},{"line_number":31,"context_line":"import org.apache.commons.codec.binary.Hex;"},{"line_number":32,"context_line":"import org.apache.commons.codec.digest.DigestUtils;"},{"line_number":33,"context_line":"import org.apache.commons.exec.ExecuteException;"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_35edcaef","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":39},"in_reply_to":"dab17558_79ce4db5","updated":"2016-05-10 11:17:04.000000000","message":"Done","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"}],"thresh/src/main/java/monasca/thresh/infrastructure/persistence/AlarmDefinitionDAOImpl.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      // Need to convert the results appropriately based on type."},{"line_number":90,"context_line":"      Integer period \u003d Conversions.variantToInteger(row.get(\"period\"));"},{"line_number":91,"context_line":"      Integer periods \u003d Conversions.variantToInteger(row.get(\"periods\"));"},{"line_number":92,"context_line":"      Boolean deterministic \u003d \"1\".equalsIgnoreCase(row.get(\"is_deterministic\").toString());"},{"line_number":93,"context_line":"      Map\u003cString, String\u003e dimensions \u003d new HashMap\u003c\u003e();"},{"line_number":94,"context_line":"      while (addedDimension(dimensions, id, rows, index)) {"},{"line_number":95,"context_line":"        index++;"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_67486488","line":92,"range":{"start_line":92,"start_character":30,"end_line":92,"end_character":90},"updated":"2016-05-09 22:35:15.000000000","message":"How about row.get(\u0027is_deterministic\u0027) \u003e 0? Easier to understand, unless you have a found a problem with something like that","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"5f403d9919c6e7bcf1961a0f1b624c01af0fc055","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      // Need to convert the results appropriately based on type."},{"line_number":90,"context_line":"      Integer period \u003d Conversions.variantToInteger(row.get(\"period\"));"},{"line_number":91,"context_line":"      Integer periods \u003d Conversions.variantToInteger(row.get(\"periods\"));"},{"line_number":92,"context_line":"      Boolean deterministic \u003d \"1\".equalsIgnoreCase(row.get(\"is_deterministic\").toString());"},{"line_number":93,"context_line":"      Map\u003cString, String\u003e dimensions \u003d new HashMap\u003c\u003e();"},{"line_number":94,"context_line":"      while (addedDimension(dimensions, id, rows, index)) {"},{"line_number":95,"context_line":"        index++;"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_9ee013fc","line":92,"range":{"start_line":92,"start_character":30,"end_line":92,"end_character":90},"in_reply_to":"dab17558_67486488","updated":"2016-05-10 11:24:19.000000000","message":"I haven\u0027t checked that.\nI will need to get back to it.","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"14d3456a1817bbf8cbff23e87892a69eccfa6112","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      // Need to convert the results appropriately based on type."},{"line_number":90,"context_line":"      Integer period \u003d Conversions.variantToInteger(row.get(\"period\"));"},{"line_number":91,"context_line":"      Integer periods \u003d Conversions.variantToInteger(row.get(\"periods\"));"},{"line_number":92,"context_line":"      Boolean deterministic \u003d \"1\".equals(row.get(\"is_deterministic\").toString());"},{"line_number":93,"context_line":"      Map\u003cString, String\u003e dimensions \u003d new HashMap\u003c\u003e();"},{"line_number":94,"context_line":"      while (addedDimension(dimensions, id, rows, index)) {"},{"line_number":95,"context_line":"        index++;"}],"source_content_type":"text/x-java","patch_set":20,"id":"dab17558_c2844b0c","line":92,"range":{"start_line":92,"start_character":32,"end_line":92,"end_character":80},"updated":"2016-05-11 08:44:56.000000000","message":"I am not sure if that\u0027s because unit test for this is using H2, but underlying type of \u0027is_deterministic\u0027 value is Byte. So applying comparison operator won\u0027t work.","commit_id":"23344f2588d491d90c0982a9e647a99cd326aea0"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"dd0d3a617b69a65e0ab79424385982a9a760db12","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      // Need to convert the results appropriately based on type."},{"line_number":90,"context_line":"      Integer period \u003d Conversions.variantToInteger(row.get(\"period\"));"},{"line_number":91,"context_line":"      Integer periods \u003d Conversions.variantToInteger(row.get(\"periods\"));"},{"line_number":92,"context_line":"      Boolean deterministic \u003d \"1\".equals(row.get(\"is_deterministic\").toString());"},{"line_number":93,"context_line":"      Map\u003cString, String\u003e dimensions \u003d new HashMap\u003c\u003e();"},{"line_number":94,"context_line":"      while (addedDimension(dimensions, id, rows, index)) {"},{"line_number":95,"context_line":"        index++;"}],"source_content_type":"text/x-java","patch_set":20,"id":"dab17558_585795c9","line":92,"range":{"start_line":92,"start_character":32,"end_line":92,"end_character":80},"in_reply_to":"dab17558_c2844b0c","updated":"2016-05-11 15:48:28.000000000","message":"ok","commit_id":"23344f2588d491d90c0982a9e647a99cd326aea0"}],"thresh/src/main/java/monasca/thresh/infrastructure/persistence/hibernate/AlarmSqlImpl.java":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"31352ef09e87931a40556989afe195184e83367c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  private static final int SUB_ALARM_ID \u003d 3;"},{"line_number":76,"context_line":"  private static final int ALARM_EXPRESSION \u003d 4;"},{"line_number":77,"context_line":"  private static final int SUB_EXPRESSION_ID \u003d 5;"},{"line_number":78,"context_line":"  private static final int SUB_ALARM_IS_SPORADIC \u003d 7;"},{"line_number":79,"context_line":"  private static final int TENANT_ID \u003d 6;"},{"line_number":80,"context_line":"  private static final int MAX_COLUMN_LENGTH \u003d 255;"},{"line_number":81,"context_line":"  private final SessionFactory sessionFactory;"}],"source_content_type":"text/x-java","patch_set":16,"id":"1a122d0e_063cc32d","line":78,"range":{"start_line":78,"start_character":17,"end_line":78,"end_character":22},"updated":"2016-05-06 03:21:50.000000000","message":"Shouldn\u0027t SUB_ALARM_IS_SPORADIC come after TENANT_ID?","commit_id":"c367ef1f4d2d53be9ed296c249cc52c932634529"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"26af6db66857b4ac0a5894654b9a2a25c43f37bf","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  private static final int SUB_ALARM_ID \u003d 3;"},{"line_number":76,"context_line":"  private static final int ALARM_EXPRESSION \u003d 4;"},{"line_number":77,"context_line":"  private static final int SUB_EXPRESSION_ID \u003d 5;"},{"line_number":78,"context_line":"  private static final int SUB_ALARM_IS_SPORADIC \u003d 7;"},{"line_number":79,"context_line":"  private static final int TENANT_ID \u003d 6;"},{"line_number":80,"context_line":"  private static final int MAX_COLUMN_LENGTH \u003d 255;"},{"line_number":81,"context_line":"  private final SessionFactory sessionFactory;"}],"source_content_type":"text/x-java","patch_set":16,"id":"dab17558_84efabaf","line":78,"range":{"start_line":78,"start_character":17,"end_line":78,"end_character":22},"in_reply_to":"1a122d0e_063cc32d","updated":"2016-05-06 06:05:14.000000000","message":"That field should be actually removed from here.","commit_id":"c367ef1f4d2d53be9ed296c249cc52c932634529"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":359,"context_line":"      List\u003cMetricDefinition\u003e valueList \u003d Lists.newArrayListWithExpectedSize(metrics.size());"},{"line_number":360,"context_line":"      for (String keyMetricName : metrics.keySet()) {"},{"line_number":361,"context_line":"        MetricDefinition md \u003d new MetricDefinition(keyMetricName, metrics.get(keyMetricName));"},{"line_number":362,"context_line":"        md.setSporadic(isSporadic);"},{"line_number":363,"context_line":"        valueList.add(md);"},{"line_number":364,"context_line":"      }"},{"line_number":365,"context_line":"      metricDefinitionList.put(keyDimensionSetId, valueList);"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_95b8f6c9","line":362,"range":{"start_line":362,"start_character":11,"end_line":362,"end_character":22},"updated":"2016-05-10 11:17:04.000000000","message":"In the name or removing sporadic - those lines got thrown away as well.","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":385,"context_line":"                                   final LookupHelper lookupHelper) {"},{"line_number":386,"context_line":"    final List\u003cAlarm\u003e alarms \u003d Lists.newArrayListWithCapacity(alarmList.size());"},{"line_number":387,"context_line":"    // exit fast if there is no data in alarm list"},{"line_number":388,"context_line":"    if(alarmList.isEmpty()){"},{"line_number":389,"context_line":"      return alarms;"},{"line_number":390,"context_line":"    }"},{"line_number":391,"context_line":""}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_795c8ded","line":388,"range":{"start_line":388,"start_character":4,"end_line":388,"end_character":7},"updated":"2016-05-09 22:35:15.000000000","message":"There should be a space after the if and before the {","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":385,"context_line":"                                   final LookupHelper lookupHelper) {"},{"line_number":386,"context_line":"    final List\u003cAlarm\u003e alarms \u003d Lists.newArrayListWithCapacity(alarmList.size());"},{"line_number":387,"context_line":"    // exit fast if there is no data in alarm list"},{"line_number":388,"context_line":"    if(alarmList.isEmpty()){"},{"line_number":389,"context_line":"      return alarms;"},{"line_number":390,"context_line":"    }"},{"line_number":391,"context_line":""}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_55acce8b","line":388,"range":{"start_line":388,"start_character":4,"end_line":388,"end_character":7},"in_reply_to":"dab17558_795c8ded","updated":"2016-05-10 11:17:04.000000000","message":"Done","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"}],"thresh/src/main/java/monasca/thresh/infrastructure/thresholding/AlarmCreationBolt.java":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"9556f093fe9116659ac1a90b4fae10eb6ad2328f","unresolved":false,"context_lines":[{"line_number":334,"context_line":"      if (metricFitsInAlarmSubExpr(subAlarm.getExpression(),"},{"line_number":335,"context_line":"          metricDefinitionAndTenantId.metricDefinition)) {"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        subAlarm.setSporadicMetric(metric.isSparse());"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        final TenantIdAndMetricName timn \u003d new TenantIdAndMetricName(metricDefinitionAndTenantId);"},{"line_number":340,"context_line":"        final Values values \u003d new Values("}],"source_content_type":"text/x-java","patch_set":11,"id":"ba0121b8_689db309","line":337,"range":{"start_line":337,"start_character":17,"end_line":337,"end_character":34},"updated":"2016-03-30 15:32:33.000000000","message":"Perhaps this should be also called in checkSporadic\n\n  checkSporadic(existingAlarm, metric)\n\nlogic seems to be the same IMHO.","commit_id":"6cc710fde9e6b692de2cd79cae66a5b0fb3d692d"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":317,"context_line":"    if (!md.name.equals(check.name)) {"},{"line_number":318,"context_line":"      return false;"},{"line_number":319,"context_line":"    }"},{"line_number":320,"context_line":"    if (md.isSporadic() !\u003d check.isSporadic()) {"},{"line_number":321,"context_line":"      return false;"},{"line_number":322,"context_line":"    }"},{"line_number":323,"context_line":"    if ((md.dimensions !\u003d null) \u0026\u0026 !md.dimensions.isEmpty()) {"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_f9687d89","line":320,"range":{"start_line":320,"start_character":4,"end_line":320,"end_character":48},"updated":"2016-05-09 22:35:15.000000000","message":"Remove this code","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":317,"context_line":"    if (!md.name.equals(check.name)) {"},{"line_number":318,"context_line":"      return false;"},{"line_number":319,"context_line":"    }"},{"line_number":320,"context_line":"    if (md.isSporadic() !\u003d check.isSporadic()) {"},{"line_number":321,"context_line":"      return false;"},{"line_number":322,"context_line":"    }"},{"line_number":323,"context_line":"    if ((md.dimensions !\u003d null) \u0026\u0026 !md.dimensions.isEmpty()) {"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_b5ea5aaa","line":320,"range":{"start_line":320,"start_character":4,"end_line":320,"end_character":48},"in_reply_to":"dab17558_f9687d89","updated":"2016-05-10 11:17:04.000000000","message":"Done","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            alarmDefinition, metricDefinitionAndTenantId);"},{"line_number":363,"context_line":"    final List\u003cAlarm\u003e result \u003d new LinkedList\u003c\u003e();"},{"line_number":364,"context_line":"    if (waitingAlarms.isEmpty()) {"},{"line_number":365,"context_line":"      final Alarm newAlarm \u003d new Alarm(alarmDefinition, AlarmState.UNDETERMINED);"},{"line_number":366,"context_line":"      newAlarm.addAlarmedMetric(metricDefinitionAndTenantId);"},{"line_number":367,"context_line":"      reuseExistingMetric(newAlarm, alarmDefinition, existingAlarms);"},{"line_number":368,"context_line":"      if (alarmIsComplete(newAlarm)) {"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_87b74885","line":365,"range":{"start_line":365,"start_character":56,"end_line":365,"end_character":79},"updated":"2016-05-09 22:35:15.000000000","message":"This state should be determined by the Sub Expressions. OK should be set if all sub expressions are non-deterministic, UNDETERMINED otherwise","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            alarmDefinition, metricDefinitionAndTenantId);"},{"line_number":363,"context_line":"    final List\u003cAlarm\u003e result \u003d new LinkedList\u003c\u003e();"},{"line_number":364,"context_line":"    if (waitingAlarms.isEmpty()) {"},{"line_number":365,"context_line":"      final Alarm newAlarm \u003d new Alarm(alarmDefinition, AlarmState.UNDETERMINED);"},{"line_number":366,"context_line":"      newAlarm.addAlarmedMetric(metricDefinitionAndTenantId);"},{"line_number":367,"context_line":"      reuseExistingMetric(newAlarm, alarmDefinition, existingAlarms);"},{"line_number":368,"context_line":"      if (alarmIsComplete(newAlarm)) {"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_d81e335e","line":365,"range":{"start_line":365,"start_character":56,"end_line":365,"end_character":79},"in_reply_to":"dab17558_87b74885","updated":"2016-05-10 11:17:04.000000000","message":"That\u0027s been changed directly in Alarm class.\nI removed state as argument and allow alarm to decide which state to set based on provided alarm definition.","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"dd0d3a617b69a65e0ab79424385982a9a760db12","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            alarmDefinition, metricDefinitionAndTenantId);"},{"line_number":360,"context_line":"    final List\u003cAlarm\u003e result \u003d new LinkedList\u003c\u003e();"},{"line_number":361,"context_line":"    if (waitingAlarms.isEmpty()) {"},{"line_number":362,"context_line":"      final Alarm newAlarm \u003d new Alarm(alarmDefinition);"},{"line_number":363,"context_line":"      newAlarm.addAlarmedMetric(metricDefinitionAndTenantId);"},{"line_number":364,"context_line":"      reuseExistingMetric(newAlarm, alarmDefinition, existingAlarms);"},{"line_number":365,"context_line":"      if (alarmIsComplete(newAlarm)) {"}],"source_content_type":"text/x-java","patch_set":20,"id":"dab17558_d59230f5","line":362,"updated":"2016-05-11 15:48:28.000000000","message":"Remove the import for AlarmState, it is no longer required","commit_id":"23344f2588d491d90c0982a9e647a99cd326aea0"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"a083a2cb74cb9576c9c1b4ab364e58354465800b","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            alarmDefinition, metricDefinitionAndTenantId);"},{"line_number":360,"context_line":"    final List\u003cAlarm\u003e result \u003d new LinkedList\u003c\u003e();"},{"line_number":361,"context_line":"    if (waitingAlarms.isEmpty()) {"},{"line_number":362,"context_line":"      final Alarm newAlarm \u003d new Alarm(alarmDefinition);"},{"line_number":363,"context_line":"      newAlarm.addAlarmedMetric(metricDefinitionAndTenantId);"},{"line_number":364,"context_line":"      reuseExistingMetric(newAlarm, alarmDefinition, existingAlarms);"},{"line_number":365,"context_line":"      if (alarmIsComplete(newAlarm)) {"}],"source_content_type":"text/x-java","patch_set":20,"id":"dab17558_3b4ef03a","line":362,"in_reply_to":"dab17558_d59230f5","updated":"2016-05-12 04:27:03.000000000","message":"Done","commit_id":"23344f2588d491d90c0982a9e647a99cd326aea0"}],"thresh/src/main/java/monasca/thresh/infrastructure/thresholding/MetricAggregationBolt.java":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"528ea48ea6d8185f661525a30f85af38d2ac931b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Copyright (c) 2014 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":" * you may not use this file except in compliance with the License."}],"source_content_type":"text/x-java","patch_set":6,"id":"fa0719c6_16e2add5","line":2,"range":{"start_line":2,"start_character":3,"end_line":2,"end_character":13},"updated":"2016-03-21 16:17:36.000000000","message":"Please add copyright","commit_id":"418b5a3989a4a08f318930f65c4c25f4ba88ac8c"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"8fcaa4fafd18a1d280702421040ceb23fb63280e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Copyright (c) 2014 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":" * you may not use this file except in compliance with the License."}],"source_content_type":"text/x-java","patch_set":6,"id":"fa0719c6_8c0c853c","line":2,"range":{"start_line":2,"start_character":3,"end_line":2,"end_character":13},"in_reply_to":"fa0719c6_16e2add5","updated":"2016-03-23 12:16:39.000000000","message":"Done","commit_id":"418b5a3989a4a08f318930f65c4c25f4ba88ac8c"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"528ea48ea6d8185f661525a30f85af38d2ac931b","unresolved":false,"context_lines":[{"line_number":230,"context_line":"          metricName,"},{"line_number":231,"context_line":"          alarmDelay"},{"line_number":232,"context_line":"      );"},{"line_number":233,"context_line":"    } else {"},{"line_number":234,"context_line":"      alarmDelay \u003d config.alarmDelay;"},{"line_number":235,"context_line":"      logger.trace("},{"line_number":236,"context_line":"          \"{} metric is neither periodic nor sparse, using default alarm delay {}\","}],"source_content_type":"text/x-java","patch_set":6,"id":"fa0719c6_d6ee75eb","line":233,"range":{"start_line":233,"start_character":6,"end_line":233,"end_character":10},"updated":"2016-03-21 16:17:36.000000000","message":"Shouldn\u0027t you check if the metric is sparse first?","commit_id":"418b5a3989a4a08f318930f65c4c25f4ba88ac8c"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"50305b9096005435331b5dfb498b1931bf9de021","unresolved":false,"context_lines":[{"line_number":230,"context_line":"          metricName,"},{"line_number":231,"context_line":"          alarmDelay"},{"line_number":232,"context_line":"      );"},{"line_number":233,"context_line":"    } else {"},{"line_number":234,"context_line":"      alarmDelay \u003d config.alarmDelay;"},{"line_number":235,"context_line":"      logger.trace("},{"line_number":236,"context_line":"          \"{} metric is neither periodic nor sparse, using default alarm delay {}\","}],"source_content_type":"text/x-java","patch_set":6,"id":"fa0719c6_51cb76a5","line":233,"range":{"start_line":233,"start_character":6,"end_line":233,"end_character":10},"in_reply_to":"fa0719c6_d6ee75eb","updated":"2016-03-22 06:30:59.000000000","message":"Do you mean something like:\n\n MetricPeriod.isPeriodic(period) \u0026\u0026 !MetricPeriod.isSparse(period)","commit_id":"418b5a3989a4a08f318930f65c4c25f4ba88ac8c"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    final SubAlarm newSubAlarm \u003d"},{"line_number":236,"context_line":"        new SubAlarm(original.getId(), original.getAlarmId(), new SubExpression("},{"line_number":237,"context_line":"            original.getAlarmSubExpressionId(), original.getExpression()), original.getState());"},{"line_number":238,"context_line":"    newSubAlarm.setNoState(original.isNoState());"},{"line_number":239,"context_line":"    newSubAlarm.setCurrentValues(original.getCurrentValues());"},{"line_number":240,"context_line":"    return newSubAlarm;"},{"line_number":241,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_592d4945","line":238,"updated":"2016-05-09 22:35:15.000000000","message":"Don\u0027t need this change","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    final SubAlarm newSubAlarm \u003d"},{"line_number":236,"context_line":"        new SubAlarm(original.getId(), original.getAlarmId(), new SubExpression("},{"line_number":237,"context_line":"            original.getAlarmSubExpressionId(), original.getExpression()), original.getState());"},{"line_number":238,"context_line":"    newSubAlarm.setNoState(original.isNoState());"},{"line_number":239,"context_line":"    newSubAlarm.setCurrentValues(original.getCurrentValues());"},{"line_number":240,"context_line":"    return newSubAlarm;"},{"line_number":241,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_38edbfef","line":238,"in_reply_to":"dab17558_592d4945","updated":"2016-05-10 11:17:04.000000000","message":"I can revert it, but since this property is not actually used (and I\u0027ve removed that from SubAlarm), maybe let\u0027s just keep it as it is right now? What do you think?","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"}],"thresh/src/test/java/monasca/thresh/domain/model/AlarmTest.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    assertTrue(expression.evaluate(subExpressionValues));"},{"line_number":184,"context_line":"  }"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"  public void testShouldInitiallyProceedToOKIfAllSubAlarmsAreNonDeterministic(){"},{"line_number":187,"context_line":"    final String expression1 \u003d \"count(log.error{path\u003d/var/log/test.log}, deterministic\u003dfalse, 1) \u003e 10\";"},{"line_number":188,"context_line":"    final String expression2 \u003d \"count(log.warning{path\u003d/var/log/test.log}, deterministic\u003dfalse, 1) \u003e 5\";"},{"line_number":189,"context_line":"    final String expression \u003d String.format(\"%s or %s\", expression1, expression2);"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_b9e39504","line":186,"range":{"start_line":186,"start_character":78,"end_line":186,"end_character":80},"updated":"2016-05-09 22:35:15.000000000","message":"Should be a space before {. You might need to adjust your IDE\u0027s settings","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    assertTrue(expression.evaluate(subExpressionValues));"},{"line_number":184,"context_line":"  }"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"  public void testShouldInitiallyProceedToOKIfAllSubAlarmsAreNonDeterministic(){"},{"line_number":187,"context_line":"    final String expression1 \u003d \"count(log.error{path\u003d/var/log/test.log}, deterministic\u003dfalse, 1) \u003e 10\";"},{"line_number":188,"context_line":"    final String expression2 \u003d \"count(log.warning{path\u003d/var/log/test.log}, deterministic\u003dfalse, 1) \u003e 5\";"},{"line_number":189,"context_line":"    final String expression \u003d String.format(\"%s or %s\", expression1, expression2);"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_f25d1848","line":186,"range":{"start_line":186,"start_character":78,"end_line":186,"end_character":80},"in_reply_to":"dab17558_b9e39504","updated":"2016-05-10 11:17:04.000000000","message":"The reason that happens is that, I am having troubles adjusting import rules (as you saw, sometimes imports are reorganized unintentionally).","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"dd0d3a617b69a65e0ab79424385982a9a760db12","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    final Alarm alarm \u003d this.createAlarm(expr);"},{"line_number":193,"context_line":"    final Iterator\u003cSubAlarm\u003e iter \u003d alarm.getSubAlarms().iterator();"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    iter.next().setState(AlarmState.UNDETERMINED);"},{"line_number":196,"context_line":"    iter.next().setState(AlarmState.UNDETERMINED);"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    assertTrue(alarm.evaluate(expr));"},{"line_number":199,"context_line":"    assertFalse(alarm.isDeterministic());"}],"source_content_type":"text/x-java","patch_set":20,"id":"dab17558_d8c38536","line":196,"range":{"start_line":195,"start_character":0,"end_line":196,"end_character":50},"updated":"2016-05-11 15:48:28.000000000","message":"These should be OK, not UNDETERMINED. Non deterministic SubAlarms should only ever be OK or ALARM","commit_id":"23344f2588d491d90c0982a9e647a99cd326aea0"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"a083a2cb74cb9576c9c1b4ab364e58354465800b","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    final Alarm alarm \u003d this.createAlarm(expr);"},{"line_number":193,"context_line":"    final Iterator\u003cSubAlarm\u003e iter \u003d alarm.getSubAlarms().iterator();"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    iter.next().setState(AlarmState.UNDETERMINED);"},{"line_number":196,"context_line":"    iter.next().setState(AlarmState.UNDETERMINED);"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    assertTrue(alarm.evaluate(expr));"},{"line_number":199,"context_line":"    assertFalse(alarm.isDeterministic());"}],"source_content_type":"text/x-java","patch_set":20,"id":"dab17558_db588433","line":196,"range":{"start_line":195,"start_character":0,"end_line":196,"end_character":50},"in_reply_to":"dab17558_d8c38536","updated":"2016-05-12 04:27:03.000000000","message":"Done","commit_id":"23344f2588d491d90c0982a9e647a99cd326aea0"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"dd0d3a617b69a65e0ab79424385982a9a760db12","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    final Alarm alarm \u003d this.createAlarm(expr);"},{"line_number":215,"context_line":"    final Iterator\u003cSubAlarm\u003e iter \u003d alarm.getSubAlarms().iterator();"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    iter.next().setState(AlarmState.UNDETERMINED);"},{"line_number":218,"context_line":"    iter.next().setState(AlarmState.UNDETERMINED);"},{"line_number":219,"context_line":"    iter.next().setState(AlarmState.UNDETERMINED);"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    assertFalse(alarm.evaluate(expr));"}],"source_content_type":"text/x-java","patch_set":20,"id":"dab17558_389bb167","line":218,"range":{"start_line":217,"start_character":0,"end_line":218,"end_character":50},"updated":"2016-05-11 15:48:28.000000000","message":"See above","commit_id":"23344f2588d491d90c0982a9e647a99cd326aea0"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"a083a2cb74cb9576c9c1b4ab364e58354465800b","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    final Alarm alarm \u003d this.createAlarm(expr);"},{"line_number":215,"context_line":"    final Iterator\u003cSubAlarm\u003e iter \u003d alarm.getSubAlarms().iterator();"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    iter.next().setState(AlarmState.UNDETERMINED);"},{"line_number":218,"context_line":"    iter.next().setState(AlarmState.UNDETERMINED);"},{"line_number":219,"context_line":"    iter.next().setState(AlarmState.UNDETERMINED);"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    assertFalse(alarm.evaluate(expr));"}],"source_content_type":"text/x-java","patch_set":20,"id":"dab17558_3b443048","line":218,"range":{"start_line":217,"start_character":0,"end_line":218,"end_character":50},"in_reply_to":"dab17558_389bb167","updated":"2016-05-12 04:27:03.000000000","message":"Done","commit_id":"23344f2588d491d90c0982a9e647a99cd326aea0"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"dd0d3a617b69a65e0ab79424385982a9a760db12","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    alarm.setState(AlarmState.OK);"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    SubAlarm subAlarm1 \u003d iter.next();"},{"line_number":251,"context_line":"    subAlarm1.setState(AlarmState.UNDETERMINED);"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    assertTrue(alarm.evaluate(expr));"},{"line_number":254,"context_line":"    assertFalse(alarm.isDeterministic());"}],"source_content_type":"text/x-java","patch_set":20,"id":"dab17558_b8a7a1a5","line":251,"range":{"start_line":251,"start_character":0,"end_line":251,"end_character":48},"updated":"2016-05-11 15:48:28.000000000","message":"See above","commit_id":"23344f2588d491d90c0982a9e647a99cd326aea0"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"a083a2cb74cb9576c9c1b4ab364e58354465800b","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    alarm.setState(AlarmState.OK);"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    SubAlarm subAlarm1 \u003d iter.next();"},{"line_number":251,"context_line":"    subAlarm1.setState(AlarmState.UNDETERMINED);"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    assertTrue(alarm.evaluate(expr));"},{"line_number":254,"context_line":"    assertFalse(alarm.isDeterministic());"}],"source_content_type":"text/x-java","patch_set":20,"id":"dab17558_bb7660a1","line":251,"range":{"start_line":251,"start_character":0,"end_line":251,"end_character":48},"in_reply_to":"dab17558_b8a7a1a5","updated":"2016-05-12 04:27:03.000000000","message":"Done","commit_id":"23344f2588d491d90c0982a9e647a99cd326aea0"}],"thresh/src/test/java/monasca/thresh/domain/model/SubAlarmStatsTest.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":299,"context_line":"      if ((t1 % 60) \u003d\u003d 2) {"},{"line_number":300,"context_line":"        stats.evaluateAndSlideWindow(t1, 1);"},{"line_number":301,"context_line":"        if (i \u003c\u003d subExpr.getAlarmSubExpression().getPeriod()) {"},{"line_number":302,"context_line":"          // Haven\u0027t waited long enough to evaluate, but this is sporadic, so it should be in ok"},{"line_number":303,"context_line":"          assertEquals(stats.getSubAlarm().getState(), AlarmState.OK);"},{"line_number":304,"context_line":"        } else {"},{"line_number":305,"context_line":"          assertEquals(stats.getSubAlarm().getState(), AlarmState.ALARM);"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_19caa16d","line":302,"range":{"start_line":302,"start_character":65,"end_line":302,"end_character":73},"updated":"2016-05-09 22:35:15.000000000","message":"deterministic","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":299,"context_line":"      if ((t1 % 60) \u003d\u003d 2) {"},{"line_number":300,"context_line":"        stats.evaluateAndSlideWindow(t1, 1);"},{"line_number":301,"context_line":"        if (i \u003c\u003d subExpr.getAlarmSubExpression().getPeriod()) {"},{"line_number":302,"context_line":"          // Haven\u0027t waited long enough to evaluate, but this is sporadic, so it should be in ok"},{"line_number":303,"context_line":"          assertEquals(stats.getSubAlarm().getState(), AlarmState.OK);"},{"line_number":304,"context_line":"        } else {"},{"line_number":305,"context_line":"          assertEquals(stats.getSubAlarm().getState(), AlarmState.ALARM);"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_389bff73","line":302,"range":{"start_line":302,"start_character":65,"end_line":302,"end_character":73},"in_reply_to":"dab17558_19caa16d","updated":"2016-05-10 11:17:04.000000000","message":"Done","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"}],"thresh/src/test/java/monasca/thresh/infrastructure/persistence/AlarmDAOImplTest.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"dd0d3a617b69a65e0ab79424385982a9a760db12","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  @BeforeClass"},{"line_number":73,"context_line":"  protected void setupClass() throws Exception {"},{"line_number":74,"context_line":"    // See class comment"},{"line_number":75,"context_line":"    db \u003d new DBI(\"jdbc:mysql://localhost/mon\", \"monapi\", \"password\");"},{"line_number":76,"context_line":"    handle \u003d db.open();"},{"line_number":77,"context_line":"    dao \u003d new AlarmDAOImpl(db);"},{"line_number":78,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":20,"id":"dab17558_58b5d57b","line":75,"range":{"start_line":75,"start_character":31,"end_line":75,"end_character":40},"updated":"2016-05-11 15:48:28.000000000","message":"This assumes you are running this test directly on your devstack. Personally, I run this test on my workstation and access the database on my devstack.","commit_id":"23344f2588d491d90c0982a9e647a99cd326aea0"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"a083a2cb74cb9576c9c1b4ab364e58354465800b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  @BeforeClass"},{"line_number":73,"context_line":"  protected void setupClass() throws Exception {"},{"line_number":74,"context_line":"    // See class comment"},{"line_number":75,"context_line":"    db \u003d new DBI(\"jdbc:mysql://localhost/mon\", \"monapi\", \"password\");"},{"line_number":76,"context_line":"    handle \u003d db.open();"},{"line_number":77,"context_line":"    dao \u003d new AlarmDAOImpl(db);"},{"line_number":78,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":20,"id":"dab17558_fb5628cc","line":75,"range":{"start_line":75,"start_character":31,"end_line":75,"end_character":40},"in_reply_to":"dab17558_58b5d57b","updated":"2016-05-12 04:27:03.000000000","message":"Done","commit_id":"23344f2588d491d90c0982a9e647a99cd326aea0"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"c75a52dd78b92ddea5baa21b3d8483307d73647d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  @BeforeClass"},{"line_number":73,"context_line":"  protected void setupClass() throws Exception {"},{"line_number":74,"context_line":"    // See class comment"},{"line_number":75,"context_line":"    db \u003d new DBI(\"jdbc:mysql://localhost/mon\", \"monapi\", \"password\");"},{"line_number":76,"context_line":"    handle \u003d db.open();"},{"line_number":77,"context_line":"    dao \u003d new AlarmDAOImpl(db);"},{"line_number":78,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":20,"id":"dab17558_e965cb1d","line":75,"range":{"start_line":75,"start_character":31,"end_line":75,"end_character":40},"in_reply_to":"dab17558_58b5d57b","updated":"2016-05-11 21:35:28.000000000","message":"My mysql database is not on devstack :). I will revert that.","commit_id":"23344f2588d491d90c0982a9e647a99cd326aea0"}],"thresh/src/test/java/monasca/thresh/infrastructure/persistence/AlarmDefinitionDAOImplTest.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    final AlarmExpression expression7 \u003d new AlarmExpression(\"max(cpu,deterministic\u003dyes) \u003e 90\");"},{"line_number":120,"context_line":"    final AlarmDefinition alarmDefinition7 \u003d"},{"line_number":121,"context_line":"        new AlarmDefinition(TENANT_ID, ALARM_NAME, ALARM_DESCR, expression5, \"LOW\","},{"line_number":122,"context_line":"            false, Arrays.asList(\"hostname\", \"dev\"));"},{"line_number":123,"context_line":"    insertAndCheck(alarmDefinition7);"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_42bb8ee5","line":121,"range":{"start_line":121,"start_character":64,"end_line":121,"end_character":75},"updated":"2016-05-09 22:35:15.000000000","message":"Should this be expression7?","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    final AlarmExpression expression7 \u003d new AlarmExpression(\"max(cpu,deterministic\u003dyes) \u003e 90\");"},{"line_number":120,"context_line":"    final AlarmDefinition alarmDefinition7 \u003d"},{"line_number":121,"context_line":"        new AlarmDefinition(TENANT_ID, ALARM_NAME, ALARM_DESCR, expression5, \"LOW\","},{"line_number":122,"context_line":"            false, Arrays.asList(\"hostname\", \"dev\"));"},{"line_number":123,"context_line":"    insertAndCheck(alarmDefinition7);"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_38a93f7c","line":121,"range":{"start_line":121,"start_character":64,"end_line":121,"end_character":75},"in_reply_to":"dab17558_42bb8ee5","updated":"2016-05-10 11:17:04.000000000","message":"Done","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    final AlarmExpression expression8 \u003d new AlarmExpression(\"max(cpu,deterministic\u003dtrue) \u003e 90\");"},{"line_number":126,"context_line":"    final AlarmDefinition alarmDefinition8 \u003d"},{"line_number":127,"context_line":"        new AlarmDefinition(TENANT_ID, ALARM_NAME, ALARM_DESCR, expression6, \"LOW\","},{"line_number":128,"context_line":"            false, Arrays.asList(\"hostname\", \"dev\"));"},{"line_number":129,"context_line":"    insertAndCheck(alarmDefinition8);"},{"line_number":130,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_82b576ef","line":127,"range":{"start_line":127,"start_character":64,"end_line":127,"end_character":75},"updated":"2016-05-09 22:35:15.000000000","message":"Should this be expression8?","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    final AlarmExpression expression8 \u003d new AlarmExpression(\"max(cpu,deterministic\u003dtrue) \u003e 90\");"},{"line_number":126,"context_line":"    final AlarmDefinition alarmDefinition8 \u003d"},{"line_number":127,"context_line":"        new AlarmDefinition(TENANT_ID, ALARM_NAME, ALARM_DESCR, expression6, \"LOW\","},{"line_number":128,"context_line":"            false, Arrays.asList(\"hostname\", \"dev\"));"},{"line_number":129,"context_line":"    insertAndCheck(alarmDefinition8);"},{"line_number":130,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_98b82bca","line":127,"range":{"start_line":127,"start_character":64,"end_line":127,"end_character":75},"in_reply_to":"dab17558_82b576ef","updated":"2016-05-10 11:17:04.000000000","message":"Done","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"}],"thresh/src/test/java/monasca/thresh/infrastructure/thresholding/AlarmCreationBoltTest.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"import static org.testng.Assert.assertTrue;"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"import java.util.ArrayList;"},{"line_number":34,"context_line":"import java.util.Arrays;"},{"line_number":35,"context_line":"import java.util.HashMap;"},{"line_number":36,"context_line":"import java.util.Iterator;"},{"line_number":37,"context_line":"import java.util.LinkedList;"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_d9f93982","line":34,"updated":"2016-05-09 22:35:15.000000000","message":"Please don\u0027t rearrange the imports. It makes the real changes harder to spot.","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"import static org.testng.Assert.assertTrue;"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"import java.util.ArrayList;"},{"line_number":34,"context_line":"import java.util.Arrays;"},{"line_number":35,"context_line":"import java.util.HashMap;"},{"line_number":36,"context_line":"import java.util.Iterator;"},{"line_number":37,"context_line":"import java.util.LinkedList;"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_23e3d034","line":34,"in_reply_to":"dab17558_d9f93982","updated":"2016-05-10 11:17:04.000000000","message":"Done","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        new MetricDefinitionAndTenantId(build(\"cpu\"), TENANT_ID + \"2\");"},{"line_number":173,"context_line":"    assertFalse(bolt.validMetricDefinition(alarmDefinition, badCpuWrongTenant));"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    // check sporadic"},{"line_number":176,"context_line":"    final AlarmDefinition nonDeterministicDef \u003d"},{"line_number":177,"context_line":"        createAlarmDefinition(\"count(log.error{},deterministic\u003dno) \u003e 2\", \"hostname\");"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_79392d41","line":175,"range":{"start_line":175,"start_character":13,"end_line":175,"end_character":21},"updated":"2016-05-09 22:35:15.000000000","message":"Change all sporadic to determinstic","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        \"max(cpu{service\u003d2}%s) \u003e 90\", (deterministic ? \",deterministic\u003dtrue\" : \"\")"},{"line_number":536,"context_line":"    );"},{"line_number":537,"context_line":"    final AlarmDefinition alarmDefinition \u003d createAlarmDefinition(expression, matchBy);"},{"line_number":538,"context_line":"    createAlarms(alarmDefinition, matchBy);"},{"line_number":539,"context_line":"    return alarmDefinition;"},{"line_number":540,"context_line":"  }"},{"line_number":541,"context_line":""}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_2d9f5bb5","line":538,"range":{"start_line":538,"start_character":4,"end_line":538,"end_character":42},"updated":"2016-05-09 22:35:15.000000000","message":"Check initial alarm state based on deterministic","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    assertEquals(this.createdAlarms.size(), 1);"},{"line_number":621,"context_line":"    // Make sure it did not get added to the existing alarm"},{"line_number":622,"context_line":"    verifyCreatedAlarm(this.createdAlarms.get(0), alarmDefinition, collector, cpuMtid, loadAvgMtid);"},{"line_number":623,"context_line":"  }"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"  private AlarmDefinition createAlarmDefinition(final String expression, final String... matchBy) {"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_8d580734","line":622,"range":{"start_line":622,"start_character":0,"end_line":622,"end_character":100},"updated":"2016-05-09 22:35:15.000000000","message":"Verify the Alarm State based on deterministic","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    assertEquals(this.createdAlarms.size(), 1);"},{"line_number":621,"context_line":"    // Make sure it did not get added to the existing alarm"},{"line_number":622,"context_line":"    verifyCreatedAlarm(this.createdAlarms.get(0), alarmDefinition, collector, cpuMtid, loadAvgMtid);"},{"line_number":623,"context_line":"  }"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"  private AlarmDefinition createAlarmDefinition(final String expression, final String... matchBy) {"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_8339dca6","line":622,"range":{"start_line":622,"start_character":0,"end_line":622,"end_character":100},"in_reply_to":"dab17558_8d580734","updated":"2016-05-10 11:17:04.000000000","message":"Done","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"}],"thresh/src/test/java/monasca/thresh/infrastructure/thresholding/MetricAggregationBoltTest.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"import static org.testng.Assert.assertNull;"},{"line_number":30,"context_line":"import static org.testng.Assert.assertTrue;"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"import java.util.ArrayList;"},{"line_number":33,"context_line":"import java.util.Arrays;"},{"line_number":34,"context_line":"import java.util.List;"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_591389b8","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":27},"updated":"2016-05-09 22:35:15.000000000","message":"Please don\u0027t rearrange the imports. It makes the real changes harder to spot.","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    assertEquals(subAlarm1.getState(), AlarmState.OK);"},{"line_number":178,"context_line":"    assertEquals(subAlarm2.getState(), AlarmState.UNDETERMINED);"},{"line_number":179,"context_line":"    assertEquals(subAlarm3.getState(), AlarmState.UNDETERMINED);"},{"line_number":180,"context_line":"    assertEquals(subAlarm4.getState(), AlarmState.OK); // sporadic"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    verify(collector, times(1)).emit(new Values(subAlarm1.getAlarmId(), subAlarm1));"},{"line_number":183,"context_line":"    // Have to reset the mock so it can tell the difference when subAlarm2 and subAlarm3 are emitted"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_6d804347","line":180,"range":{"start_line":180,"start_character":58,"end_line":180,"end_character":66},"updated":"2016-05-09 22:35:15.000000000","message":"No more sporadic","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    assertEquals(subAlarm1.getState(), AlarmState.OK);"},{"line_number":178,"context_line":"    assertEquals(subAlarm2.getState(), AlarmState.UNDETERMINED);"},{"line_number":179,"context_line":"    assertEquals(subAlarm3.getState(), AlarmState.UNDETERMINED);"},{"line_number":180,"context_line":"    assertEquals(subAlarm4.getState(), AlarmState.OK); // sporadic"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    verify(collector, times(1)).emit(new Values(subAlarm1.getAlarmId(), subAlarm1));"},{"line_number":183,"context_line":"    // Have to reset the mock so it can tell the difference when subAlarm2 and subAlarm3 are emitted"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_83071cc9","line":180,"range":{"start_line":180,"start_character":58,"end_line":180,"end_character":66},"in_reply_to":"dab17558_6d804347","updated":"2016-05-10 11:17:04.000000000","message":"Done","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":410,"context_line":"    assertEquals(subAlarm4.getState(), AlarmState.OK);"},{"line_number":411,"context_line":"    verify(collector, times(1)).emit(new Values(subAlarm4.getAlarmId(), subAlarm4));"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    // Have to reset the mock so it can tell the difference when subAlarm2 is emitted again."},{"line_number":414,"context_line":"    reset(collector);"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    bolt.setCurrentTime(t1 +\u003d 60000);"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_0d0537bb","line":413,"range":{"start_line":413,"start_character":65,"end_line":413,"end_character":74},"updated":"2016-05-09 22:35:15.000000000","message":"subalarm4","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":449,"context_line":"    verify(collector, times(1)).emit(new Values(subAlarm2.getAlarmId(), subAlarm2));"},{"line_number":450,"context_line":"  }"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"  public void shouldSendOKOnStartupForNonDeterministic() {"},{"line_number":453,"context_line":"    long t1 \u003d 14000;"},{"line_number":454,"context_line":"    bolt.setCurrentTime(t1);"},{"line_number":455,"context_line":"    sendSubAlarmCreated(metricDef4, subAlarm4);"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    final MkTupleParam tupleParam \u003d new MkTupleParam();"},{"line_number":458,"context_line":"    tupleParam.setStream(MetricAggregationBolt.METRIC_AGGREGATION_CONTROL_STREAM);"},{"line_number":459,"context_line":"    final Tuple lagTuple \u003d"},{"line_number":460,"context_line":"        Testing.testTuple(Arrays.asList(MetricAggregationBolt.METRICS_BEHIND), tupleParam);"},{"line_number":461,"context_line":"    bolt.execute(lagTuple);"},{"line_number":462,"context_line":"    verify(collector, times(1)).ack(lagTuple);"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    t1 +\u003d 60000;"},{"line_number":465,"context_line":"    bolt.setCurrentTime(t1);"},{"line_number":466,"context_line":"    sendTickTuple();"},{"line_number":467,"context_line":"    verify(collector, never()).emit(new Values(subAlarm4.getAlarmId(), subAlarm4));"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    t1 +\u003d 60000;"},{"line_number":470,"context_line":"    bolt.setCurrentTime(t1);"},{"line_number":471,"context_line":"    sendTickTuple();"},{"line_number":472,"context_line":"    verify(collector, never()).emit(new Values(subAlarm4.getAlarmId(), subAlarm4));"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"    t1 +\u003d 60000;"},{"line_number":475,"context_line":"    bolt.setCurrentTime(t1);"},{"line_number":476,"context_line":"    sendTickTuple();"},{"line_number":477,"context_line":"    assertEquals(subAlarm4.getState(), AlarmState.OK);"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    verify(collector, times(1)).emit(new Values(subAlarm4.getAlarmId(), subAlarm4));"},{"line_number":480,"context_line":"  }"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"  private Tuple createTickTuple() {"},{"line_number":483,"context_line":"    final MkTupleParam tupleParam \u003d new MkTupleParam();"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_2da59bb4","line":480,"range":{"start_line":452,"start_character":0,"end_line":480,"end_character":3},"updated":"2016-05-09 22:35:15.000000000","message":"This is pretty much the test above with a different subAlarm and expected state. It would be better to refactor so you reuse common code.","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":449,"context_line":"    verify(collector, times(1)).emit(new Values(subAlarm2.getAlarmId(), subAlarm2));"},{"line_number":450,"context_line":"  }"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"  public void shouldSendOKOnStartupForNonDeterministic() {"},{"line_number":453,"context_line":"    long t1 \u003d 14000;"},{"line_number":454,"context_line":"    bolt.setCurrentTime(t1);"},{"line_number":455,"context_line":"    sendSubAlarmCreated(metricDef4, subAlarm4);"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    final MkTupleParam tupleParam \u003d new MkTupleParam();"},{"line_number":458,"context_line":"    tupleParam.setStream(MetricAggregationBolt.METRIC_AGGREGATION_CONTROL_STREAM);"},{"line_number":459,"context_line":"    final Tuple lagTuple \u003d"},{"line_number":460,"context_line":"        Testing.testTuple(Arrays.asList(MetricAggregationBolt.METRICS_BEHIND), tupleParam);"},{"line_number":461,"context_line":"    bolt.execute(lagTuple);"},{"line_number":462,"context_line":"    verify(collector, times(1)).ack(lagTuple);"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    t1 +\u003d 60000;"},{"line_number":465,"context_line":"    bolt.setCurrentTime(t1);"},{"line_number":466,"context_line":"    sendTickTuple();"},{"line_number":467,"context_line":"    verify(collector, never()).emit(new Values(subAlarm4.getAlarmId(), subAlarm4));"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    t1 +\u003d 60000;"},{"line_number":470,"context_line":"    bolt.setCurrentTime(t1);"},{"line_number":471,"context_line":"    sendTickTuple();"},{"line_number":472,"context_line":"    verify(collector, never()).emit(new Values(subAlarm4.getAlarmId(), subAlarm4));"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"    t1 +\u003d 60000;"},{"line_number":475,"context_line":"    bolt.setCurrentTime(t1);"},{"line_number":476,"context_line":"    sendTickTuple();"},{"line_number":477,"context_line":"    assertEquals(subAlarm4.getState(), AlarmState.OK);"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    verify(collector, times(1)).emit(new Values(subAlarm4.getAlarmId(), subAlarm4));"},{"line_number":480,"context_line":"  }"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"  private Tuple createTickTuple() {"},{"line_number":483,"context_line":"    final MkTupleParam tupleParam \u003d new MkTupleParam();"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_83971ceb","line":480,"range":{"start_line":452,"start_character":0,"end_line":480,"end_character":3},"in_reply_to":"dab17558_2da59bb4","updated":"2016-05-10 11:17:04.000000000","message":"I will try to refactor that a bit with the next patch set.","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"}],"thresh/src/test/java/monasca/thresh/infrastructure/thresholding/MetricFilteringBoltTest.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    final Map\u003cString, String\u003e extraDimensions \u003d new HashMap\u003c\u003e(metricDefinition.dimensions);"},{"line_number":295,"context_line":"    extraDimensions.put(\"group\", \"group_a\");"},{"line_number":296,"context_line":"    final MetricDefinition inexactMetricDef \u003d"},{"line_number":297,"context_line":"        new MetricDefinition(metricDefinition.name, extraDimensions, metricDefinition.isSporadic());"},{"line_number":298,"context_line":"    return inexactMetricDef;"},{"line_number":299,"context_line":"  }"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_597a69f2","line":297,"range":{"start_line":297,"start_character":69,"end_line":297,"end_character":99},"updated":"2016-05-09 22:35:15.000000000","message":"Remove this change","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"37b9d59efb565331224cd793226625e038529a7f","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    return tuple;"},{"line_number":496,"context_line":"  }"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"  public void testAllInitialNonDeterministic() {"},{"line_number":499,"context_line":"    MetricFilteringBolt.clearMetricDefinitions();"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    final String expression1 \u003d"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_59bd4967","line":498,"range":{"start_line":498,"start_character":14,"end_line":498,"end_character":44},"updated":"2016-05-09 22:35:15.000000000","message":"What value does this test add? Where ate things checked differently for non-deterministic alarms?","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d3c66041f62083a97bcdc52015a03085f65bbf7f","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    return tuple;"},{"line_number":496,"context_line":"  }"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"  public void testAllInitialNonDeterministic() {"},{"line_number":499,"context_line":"    MetricFilteringBolt.clearMetricDefinitions();"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    final String expression1 \u003d"}],"source_content_type":"text/x-java","patch_set":18,"id":"dab17558_834c3c9f","line":498,"range":{"start_line":498,"start_character":14,"end_line":498,"end_character":44},"in_reply_to":"dab17558_59bd4967","updated":"2016-05-10 11:17:04.000000000","message":"Right now, I don\u0027t think there\u0027s any, so I will just remove it.","commit_id":"b5052670e32599ccc9c0bc9ccad9e9da0d6a8c67"}]}
