)]}'
{"thresh/src/main/java/monasca/thresh/infrastructure/persistence/AlarmDefinitionDAOImpl.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"395b74f343565e631c0a6b19973e8c4bcdbcd032","unresolved":false,"context_lines":[{"line_number":183,"context_line":"  }"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"  @Override"},{"line_number":186,"context_line":"  public void deleteByDefinitionId(String alarmDefinitionId) {"},{"line_number":187,"context_line":"    try (Handle h \u003d db.open()) {"},{"line_number":188,"context_line":"      h.execute(\"delete from alarm_definition where id \u003d :id\", alarmDefinitionId);"},{"line_number":189,"context_line":"    }"}],"source_content_type":"text/x-java","patch_set":1,"id":"da36d5c6_23c3818a","line":186,"range":{"start_line":186,"start_character":14,"end_line":186,"end_character":34},"updated":"2017-02-24 14:56:05.000000000","message":"Add an unit test for this to AlarmDefinitionDAOImplTest.java","commit_id":"4b4411188e9a0feca88bbdff52490e12de2590ec"}],"thresh/src/main/java/monasca/thresh/infrastructure/persistence/hibernate/AlarmDefinitionSqlImpl.java":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"186a9d1737f7c2994b37ee77e2218f69a0e2c5f2","unresolved":false,"context_lines":[{"line_number":252,"context_line":"   *"},{"line_number":253,"context_line":"   * @param tx {@link Transaction} object"},{"line_number":254,"context_line":"   */"},{"line_number":255,"context_line":"  private void rollbackIfNotNull(final Transaction tx) {"},{"line_number":256,"context_line":"    if (tx !\u003d null) {"},{"line_number":257,"context_line":"      try {"},{"line_number":258,"context_line":"        tx.rollback();"}],"source_content_type":"text/x-java","patch_set":1,"id":"da36d5c6_7ba447b9","line":255,"updated":"2017-02-24 11:36:00.000000000","message":"Not really sure, but looks like something that might be added to every method here. Was long time ago when I was working on those bits of code.","commit_id":"4b4411188e9a0feca88bbdff52490e12de2590ec"}],"thresh/src/main/java/monasca/thresh/infrastructure/thresholding/AlarmCreationBolt.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"395b74f343565e631c0a6b19973e8c4bcdbcd032","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    alarmCache.remove(alarmDefinitionId);"},{"line_number":211,"context_line":"    alarmDefinitionCache.remove(alarmDefinitionId);"},{"line_number":212,"context_line":"    alarmDAO.deleteByDefinitionId(alarmDefinitionId);"},{"line_number":213,"context_line":"    if(!keepAlarmDefs) {"},{"line_number":214,"context_line":"      alarmDefDAO.deleteByDefinitionId(alarmDefinitionId);"},{"line_number":215,"context_line":"    }"},{"line_number":216,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":1,"id":"da36d5c6_a37a1186","line":213,"range":{"start_line":213,"start_character":4,"end_line":213,"end_character":23},"updated":"2017-02-24 14:56:05.000000000","message":"Need space after the if.","commit_id":"4b4411188e9a0feca88bbdff52490e12de2590ec"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"395b74f343565e631c0a6b19973e8c4bcdbcd032","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    alarmCache.remove(alarmDefinitionId);"},{"line_number":211,"context_line":"    alarmDefinitionCache.remove(alarmDefinitionId);"},{"line_number":212,"context_line":"    alarmDAO.deleteByDefinitionId(alarmDefinitionId);"},{"line_number":213,"context_line":"    if(!keepAlarmDefs) {"},{"line_number":214,"context_line":"      alarmDefDAO.deleteByDefinitionId(alarmDefinitionId);"},{"line_number":215,"context_line":"    }"},{"line_number":216,"context_line":"  }"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"  protected void handleNewMetricDefinition("}],"source_content_type":"text/x-java","patch_set":1,"id":"da36d5c6_c35705c8","line":215,"range":{"start_line":213,"start_character":0,"end_line":215,"end_character":5},"updated":"2017-02-24 14:56:05.000000000","message":"Add check for this in the unit test for AlarmCreationBolt","commit_id":"4b4411188e9a0feca88bbdff52490e12de2590ec"}]}