)]}'
{"monitoring/alarms/tests.py":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"60702bba3d143511a6223c6ec42f9ca1b55b0e92","unresolved":false,"context_lines":[{"line_number":18,"context_line":"            \u0027spec_set\u0027: [\u0027alarm_list_by_dimension\u0027],"},{"line_number":19,"context_line":"            \u0027alarm_list_by_dimension.return_value\u0027: [],"},{"line_number":20,"context_line":"        }) as mock:"},{"line_number":21,"context_line":"            res \u003d self.client.get(ALARMS_URL_BY_SERVICE)"},{"line_number":22,"context_line":"            self.assertEqual(mock.alarm_list_by_dimension.call_count, 2)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        self.assertTemplateUsed("}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_f3e4b3ac","line":21,"updated":"2015-07-15 16:09:19.000000000","message":"We should probably change the name of this constant here as well.","commit_id":"0f7ab2bd662a73d4b884ba051019df03c13e7716"}],"monitoring/api/monitor.py":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"f28682f212ea94df4aa5d0f588bc0d39e0853f12","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    return result[\u0027elements\u0027] if type(result) is dict else result"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def alarm_list_by_service(request, dimensions, offset\u003d0, limit\u003d10000,"},{"line_number":69,"context_line":"                          marker\u003dNone, paginate\u003dFalse):"},{"line_number":70,"context_line":"    service_dim \u003d {}"},{"line_number":71,"context_line":"    metric \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_e3ce532d","line":68,"updated":"2015-07-14 23:17:37.000000000","message":"The name of the function should more closely match what it\u0027s doing now.  Maybe alarm_list_by_dimension?","commit_id":"93e955c23379485e38eda9be64b62eebf8a0d2bb"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"f1e4c0d96211b8103d2bed884add5170614db872","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    return result[\u0027elements\u0027] if type(result) is dict else result"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def alarm_list_by_service(request, dimensions, offset\u003d0, limit\u003d10000,"},{"line_number":69,"context_line":"                          marker\u003dNone, paginate\u003dFalse):"},{"line_number":70,"context_line":"    service_dim \u003d {}"},{"line_number":71,"context_line":"    metric \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_231c3bc0","line":68,"updated":"2015-07-14 22:47:41.000000000","message":"can we rename this to alarm_list_by_dimensions?","commit_id":"93e955c23379485e38eda9be64b62eebf8a0d2bb"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"f28682f212ea94df4aa5d0f588bc0d39e0853f12","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    dimensions \u003d dimensions.split(\",\")"},{"line_number":74,"context_line":"    for item in dimensions:"},{"line_number":75,"context_line":"        name \u003d item.split(\"\u003d\")[0]"},{"line_number":76,"context_line":"        value \u003d item.split(\"\u003d\")[1]"},{"line_number":77,"context_line":"        if name \u003d\u003d \u0027metric\u0027:"},{"line_number":78,"context_line":"            metric \u003d value"},{"line_number":79,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_fe74a636","line":76,"updated":"2015-07-14 23:17:37.000000000","message":"We should do this on one line with \"name, value \u003d item.split(\"\u003d\")\".  This avoids having to split the string twice.","commit_id":"93e955c23379485e38eda9be64b62eebf8a0d2bb"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"f1e4c0d96211b8103d2bed884add5170614db872","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    dimensions \u003d dimensions.split(\",\")"},{"line_number":74,"context_line":"    for item in dimensions:"},{"line_number":75,"context_line":"        name \u003d item.split(\"\u003d\")[0]"},{"line_number":76,"context_line":"        value \u003d item.split(\"\u003d\")[1]"},{"line_number":77,"context_line":"        if name \u003d\u003d \u0027metric\u0027:"},{"line_number":78,"context_line":"            metric \u003d value"},{"line_number":79,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_c3622f3e","line":76,"updated":"2015-07-14 22:47:41.000000000","message":"this should be on one line \"name, value \u003d item.split(\u0027\u003d\u0027)","commit_id":"93e955c23379485e38eda9be64b62eebf8a0d2bb"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"f28682f212ea94df4aa5d0f588bc0d39e0853f12","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if name \u003d\u003d \u0027metric\u0027:"},{"line_number":78,"context_line":"            metric \u003d value"},{"line_number":79,"context_line":"        else:"},{"line_number":80,"context_line":"            service_dim[name] \u003d value"},{"line_number":81,"context_line":"    if metric:"},{"line_number":82,"context_line":"        result \u003d monascaclient(request).alarms.list(offset\u003doffset, limit\u003dlimit,"},{"line_number":83,"context_line":"                                                metric_dimensions\u003dservice_dim,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_03e497a9","line":80,"updated":"2015-07-14 23:17:37.000000000","message":"This should probably be called something other than service_dim.","commit_id":"93e955c23379485e38eda9be64b62eebf8a0d2bb"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"f28682f212ea94df4aa5d0f588bc0d39e0853f12","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"def alarm_list_by_metric(request, metric, offset\u003d0, limit\u003d10000):"},{"line_number":92,"context_line":"    result \u003d monascaclient(request).alarms.list(offset\u003doffset, limit\u003dlimit, metric_name\u003dmetric)"},{"line_number":93,"context_line":"    return result[\u0027elements\u0027] if type(result) is dict else result"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_fe7586f9","line":92,"updated":"2015-07-14 23:17:37.000000000","message":"This function doesn\u0027t appear to be referenced anymore.","commit_id":"93e955c23379485e38eda9be64b62eebf8a0d2bb"}]}