)]}'
{"monitoring/overview/views.py":[{"author":{"_account_id":16557,"name":"Sam Kirsch","email":"samkirsch@gmail.com","username":"SamKirsch10"},"change_message_id":"84dbf80762399cdb04340d0f28baeabef0ffaaf4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"index_by_severity \u003d {d[\u0027severity\u0027]: i for i, d in enumerate(priorities)}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def get_dashboard_links(request):"},{"line_number":73,"context_line":"    flat_keys \u003d {\u0027fileName\u0027,\u0027title\u0027}"},{"line_number":74,"context_line":"    try:"},{"line_number":75,"context_line":"        default_links \u003d DEFAULT_LINKS"},{"line_number":76,"context_line":"        for project_link in DASHBOARDS:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_384a8bad","line":73,"updated":"2015-07-30 20:25:17.000000000","message":"is this intended to be a list or a dictionary?","commit_id":"05492c099b98be89b300cfa4d6ea4e30ac7077ba"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"fb04254b96d8e881fdf03e18079c617ea8fadcb5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"index_by_severity \u003d {d[\u0027severity\u0027]: i for i, d in enumerate(priorities)}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def get_dashboard_links(request):"},{"line_number":73,"context_line":"    flat_keys \u003d {\u0027fileName\u0027,\u0027title\u0027}"},{"line_number":74,"context_line":"    try:"},{"line_number":75,"context_line":"        default_links \u003d DEFAULT_LINKS"},{"line_number":76,"context_line":"        for project_link in DASHBOARDS:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_d8333912","line":73,"in_reply_to":"3a50d1a3_384a8bad","updated":"2015-07-31 17:04:25.000000000","message":"Yes, agree this should either be a dictionary or a list, but this is a weird thing that I haven\u0027t seen before.","commit_id":"05492c099b98be89b300cfa4d6ea4e30ac7077ba"},{"author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"change_message_id":"d8dfd1b69a648587af48a99c9824f55f71f52b91","unresolved":false,"context_lines":[{"line_number":70,"context_line":"index_by_severity \u003d {d[\u0027severity\u0027]: i for i, d in enumerate(priorities)}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def get_dashboard_links(request):"},{"line_number":73,"context_line":"    flat_keys \u003d {\u0027fileName\u0027,\u0027title\u0027}"},{"line_number":74,"context_line":"    try:"},{"line_number":75,"context_line":"        default_links \u003d DEFAULT_LINKS"},{"line_number":76,"context_line":"        for project_link in DASHBOARDS:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_96038bb8","line":73,"in_reply_to":"3a50d1a3_384a8bad","updated":"2015-08-03 22:13:28.000000000","message":"it\u0027s a list of dictionaries, optionally can be a nested list -- see the examples in local_settings.py.  trying to support legacy behavior and not break anyone.","commit_id":"05492c099b98be89b300cfa4d6ea4e30ac7077ba"},{"author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"change_message_id":"d8dfd1b69a648587af48a99c9824f55f71f52b91","unresolved":false,"context_lines":[{"line_number":70,"context_line":"index_by_severity \u003d {d[\u0027severity\u0027]: i for i, d in enumerate(priorities)}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def get_dashboard_links(request):"},{"line_number":73,"context_line":"    flat_keys \u003d {\u0027fileName\u0027,\u0027title\u0027}"},{"line_number":74,"context_line":"    try:"},{"line_number":75,"context_line":"        default_links \u003d DEFAULT_LINKS"},{"line_number":76,"context_line":"        for project_link in DASHBOARDS:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_76311fa2","line":73,"in_reply_to":"3a50d1a3_d8333912","updated":"2015-08-03 22:13:28.000000000","message":"see if my comment in the next PS helps clarify, eric wanted to use one variable instead of two -- so it can appear in either form and the code will handle it.","commit_id":"05492c099b98be89b300cfa4d6ea4e30ac7077ba"},{"author":{"_account_id":16557,"name":"Sam Kirsch","email":"samkirsch@gmail.com","username":"SamKirsch10"},"change_message_id":"84dbf80762399cdb04340d0f28baeabef0ffaaf4","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                # in case we exhaust the list without a project"},{"line_number":95,"context_line":"                # match"},{"line_number":96,"context_line":"                #"},{"line_number":97,"context_line":"                default_links \u003d value"},{"line_number":98,"context_line":"        return default_links"},{"line_number":99,"context_line":"    except Exception:"},{"line_number":100,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_38e12b9b","line":97,"updated":"2015-07-30 20:25:17.000000000","message":"we should probably use if elif else statements","commit_id":"05492c099b98be89b300cfa4d6ea4e30ac7077ba"},{"author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"change_message_id":"d8dfd1b69a648587af48a99c9824f55f71f52b91","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                # in case we exhaust the list without a project"},{"line_number":95,"context_line":"                # match"},{"line_number":96,"context_line":"                #"},{"line_number":97,"context_line":"                default_links \u003d value"},{"line_number":98,"context_line":"        return default_links"},{"line_number":99,"context_line":"    except Exception:"},{"line_number":100,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_16269b68","line":97,"in_reply_to":"3a50d1a3_38e12b9b","updated":"2015-08-03 22:13:28.000000000","message":"done in the next PS","commit_id":"05492c099b98be89b300cfa4d6ea4e30ac7077ba"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"fb04254b96d8e881fdf03e18079c617ea8fadcb5","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                # in case we exhaust the list without a project"},{"line_number":95,"context_line":"                # match"},{"line_number":96,"context_line":"                #"},{"line_number":97,"context_line":"                default_links \u003d value"},{"line_number":98,"context_line":"        return default_links"},{"line_number":99,"context_line":"    except Exception:"},{"line_number":100,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_3b3a57ce","line":97,"in_reply_to":"3a50d1a3_38e12b9b","updated":"2015-07-31 17:04:25.000000000","message":"probably, but this code is not quite understandable to me.\n\nAt this point you set default_links \u003d value, but then when you start the loop again, it could be overwritten, or something else returned.\n\nHow about writing this as\n\nlinks \u003d DEFAULT_LINKS\n\nfor ...\n   if ...\n       links \u003d \n   elif ...\n      links \u003d \n   elif\n       links \u003d\n\nreturn links","commit_id":"05492c099b98be89b300cfa4d6ea4e30ac7077ba"},{"author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"change_message_id":"d8dfd1b69a648587af48a99c9824f55f71f52b91","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                # in case we exhaust the list without a project"},{"line_number":95,"context_line":"                # match"},{"line_number":96,"context_line":"                #"},{"line_number":97,"context_line":"                default_links \u003d value"},{"line_number":98,"context_line":"        return default_links"},{"line_number":99,"context_line":"    except Exception:"},{"line_number":100,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_76d83f54","line":97,"in_reply_to":"3a50d1a3_3b3a57ce","updated":"2015-08-03 22:13:28.000000000","message":"i need to return early if we get a match, or we\u0027ll override the match as we iterate through the loop.  see the next PS with if/elif and see if that is ok...","commit_id":"05492c099b98be89b300cfa4d6ea4e30ac7077ba"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"fb04254b96d8e881fdf03e18079c617ea8fadcb5","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                #"},{"line_number":97,"context_line":"                default_links \u003d value"},{"line_number":98,"context_line":"        return default_links"},{"line_number":99,"context_line":"    except Exception:"},{"line_number":100,"context_line":"        pass"},{"line_number":101,"context_line":"    #"},{"line_number":102,"context_line":"    # Safety here -- should have got a match somewhere above,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_1b2f5b89","line":99,"updated":"2015-07-31 17:04:25.000000000","message":"Do you wan\u0027t to log here?","commit_id":"05492c099b98be89b300cfa4d6ea4e30ac7077ba"},{"author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"change_message_id":"d8dfd1b69a648587af48a99c9824f55f71f52b91","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                #"},{"line_number":97,"context_line":"                default_links \u003d value"},{"line_number":98,"context_line":"        return default_links"},{"line_number":99,"context_line":"    except Exception:"},{"line_number":100,"context_line":"        pass"},{"line_number":101,"context_line":"    #"},{"line_number":102,"context_line":"    # Safety here -- should have got a match somewhere above,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_16dd3b42","line":99,"in_reply_to":"3a50d1a3_1b2f5b89","updated":"2015-08-03 22:13:28.000000000","message":"great idea, in the next PS","commit_id":"05492c099b98be89b300cfa4d6ea4e30ac7077ba"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"e101b405a660582e273766c796b2adf7356debf3","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                # match"},{"line_number":110,"context_line":"                #"},{"line_number":111,"context_line":"                return value"},{"line_number":112,"context_line":"        return links"},{"line_number":113,"context_line":"    except Exception:"},{"line_number":114,"context_line":"        LOG.warn(\"Failed to parse dashboard links, returning defaults.\")"},{"line_number":115,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_496dbdca","line":112,"updated":"2015-08-06 15:44:59.000000000","message":"you can just return DEFAULT_LINKS here since you do not do anything with the variable links in the loop","commit_id":"fd49b584fdc58e213832a75ac3e35e25a966eb0f"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"e101b405a660582e273766c796b2adf7356debf3","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                return value"},{"line_number":112,"context_line":"        return links"},{"line_number":113,"context_line":"    except Exception:"},{"line_number":114,"context_line":"        LOG.warn(\"Failed to parse dashboard links, returning defaults.\")"},{"line_number":115,"context_line":"        pass"},{"line_number":116,"context_line":"    #"},{"line_number":117,"context_line":"    # Extra safety here -- should have got a match somewhere above,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_697e796b","line":114,"updated":"2015-08-06 15:44:59.000000000","message":"maybe this should be \"Failed to parse dashboard links by project, returning defaults.\"","commit_id":"fd49b584fdc58e213832a75ac3e35e25a966eb0f"}]}