)]}'
{"monitoring/overview/views.py":[{"author":{"_account_id":15799,"name":"Ben Motz","email":"ben.launchpad@ouat.co.uk","username":"bmotz"},"change_message_id":"a54d286d1a2cc53c194eb3389942c76a99256b1f","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        else:"},{"line_number":311,"context_line":"            status \u003d response.getcode()"},{"line_number":312,"context_line":"            return http.HttpResponse("},{"line_number":313,"context_line":"                proxy_stream_generator(response),"},{"line_number":314,"context_line":"                status\u003dstatus,"},{"line_number":315,"context_line":"                content_type\u003dresponse.headers[\u0027content-type\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_57b77184","line":312,"updated":"2015-09-07 09:29:15.000000000","message":"I think this should probably be using StreamingHttpResponse? \n\nhttps://docs.djangoproject.com/en/1.8/ref/request-response/#django.http.StreamingHttpResponse","commit_id":"2abb46c62a576d546294515b06d6bf73611d966a"}],"monitoring/utils/config.py":[{"author":{"_account_id":15799,"name":"Ben Motz","email":"ben.launchpad@ouat.co.uk","username":"bmotz"},"change_message_id":"a54d286d1a2cc53c194eb3389942c76a99256b1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"da20952f_9c30ce57","updated":"2015-09-07 09:29:15.000000000","message":"File should have a licence notice","commit_id":"2abb46c62a576d546294515b06d6bf73611d966a"},{"author":{"_account_id":15799,"name":"Ben Motz","email":"ben.launchpad@ouat.co.uk","username":"bmotz"},"change_message_id":"a54d286d1a2cc53c194eb3389942c76a99256b1f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"from django.conf import settings  # noqa"},{"line_number":4,"context_line":"from monitoring.config import local_settings"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_b2493b62","line":1,"updated":"2015-09-07 09:29:15.000000000","message":"The OpenStack style guide says files shouldn\u0027t include vim configuration (H106)","commit_id":"2abb46c62a576d546294515b06d6bf73611d966a"},{"author":{"_account_id":15799,"name":"Ben Motz","email":"ben.launchpad@ouat.co.uk","username":"bmotz"},"change_message_id":"a54d286d1a2cc53c194eb3389942c76a99256b1f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"from django.conf import settings  # noqa"},{"line_number":4,"context_line":"from monitoring.config import local_settings"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"def get_config(name, default):"},{"line_number":7,"context_line":"    value \u003d getattr(settings, name, None)"},{"line_number":8,"context_line":"    if value is not None:"},{"line_number":9,"context_line":"        return value"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_770715ca","line":6,"updated":"2015-09-07 09:29:15.000000000","message":"So if a setting is defined globally, it takes precedence over the local setting, unless the global value is explicitly set to None, in which case the value from the local setting is used instead.\n\nFurther to that, effectively \"VARIABLE \u003d None\" will result in different behaviour if it\u0027s in the global settings to if it\u0027s in local_settings.\n\nI think this may be a bit surprising to users, especially as it will only apply to variables that are retrieved with this method, and not to all settings.\n\nThe use of this method in various places through the source will result in a change to the existing behaviour, which could break existing installations.","commit_id":"2abb46c62a576d546294515b06d6bf73611d966a"},{"author":{"_account_id":16172,"name":"Maciej Maciaszek","email":"maciej.maciaszek@ts.fujitsu.com","username":"macio"},"change_message_id":"f0dde80ff839b0611be0f0b9558de73b9493cb87","unresolved":false,"context_lines":[{"line_number":3,"context_line":"from django.conf import settings  # noqa"},{"line_number":4,"context_line":"from monitoring.config import local_settings"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"def get_config(name, default):"},{"line_number":7,"context_line":"    value \u003d getattr(settings, name, None)"},{"line_number":8,"context_line":"    if value is not None:"},{"line_number":9,"context_line":"        return value"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_dade2a10","line":6,"in_reply_to":"da20952f_770715ca","updated":"2015-09-08 06:38:51.000000000","message":"You must know that local_settings are not imported anywhere. And such file is a good place to control application (ansible templates). Another option is to:\n\nimport local_settings as settings\n\n# and use settings.CONSTANT\n\nand in local_settings:\n\nfrom django.conf import settings\n\nCONSTANT \u003d getattr(settings, \u0027CONSTANT\u0027, \u0027default\u0027)","commit_id":"2abb46c62a576d546294515b06d6bf73611d966a"},{"author":{"_account_id":15799,"name":"Ben Motz","email":"ben.launchpad@ouat.co.uk","username":"bmotz"},"change_message_id":"01e7ee9bb4b5551986d03fb2e028f163ea66f8d2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from monitoring.config import local_settings"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def get_config(name, default):"},{"line_number":27,"context_line":"    if hasattr(settings, name):"},{"line_number":28,"context_line":"        return getattr(settings, name)"},{"line_number":29,"context_line":"    return getattr(local_settings, name, default)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_79fda73a","line":26,"updated":"2015-09-08 09:21:46.000000000","message":"It looks like this method is no longer used anywhere in the patch, so it should probably be removed","commit_id":"39f2dbddea3b3c5a9547f0c0693b3fc80035d668"}],"test-requirements.txt":[{"author":{"_account_id":16170,"name":"Michal Zielonka","email":"michal.zielonka@ts.fujitsu.com","username":"michal.zielonka"},"change_message_id":"adddb05cb47147564d1230f5e98350382f325435","unresolved":false,"context_lines":[{"line_number":5,"context_line":"cffi\u003d\u003d1.2.1"},{"line_number":6,"context_line":"oslo.i18n\u003d\u003d1.7.0"},{"line_number":7,"context_line":"oslo.utils\u003d\u003d1.9.0"},{"line_number":8,"context_line":"oslo.serialization\u003d\u003d1.6.0"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"coverage\u003e\u003d3.6"},{"line_number":11,"context_line":"django-nose"}],"source_content_type":"text/plain","patch_set":1,"id":"da20952f_bc5352e1","line":8,"updated":"2015-09-07 08:38:43.000000000","message":"downgrade?","commit_id":"2abb46c62a576d546294515b06d6bf73611d966a"},{"author":{"_account_id":16172,"name":"Maciej Maciaszek","email":"maciej.maciaszek@ts.fujitsu.com","username":"macio"},"change_message_id":"2707ca9f942ab7277c2bcb656970e784bf951337","unresolved":false,"context_lines":[{"line_number":5,"context_line":"cffi\u003d\u003d1.2.1"},{"line_number":6,"context_line":"oslo.i18n\u003d\u003d1.7.0"},{"line_number":7,"context_line":"oslo.utils\u003d\u003d1.9.0"},{"line_number":8,"context_line":"oslo.serialization\u003d\u003d1.6.0"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"coverage\u003e\u003d3.6"},{"line_number":11,"context_line":"django-nose"}],"source_content_type":"text/plain","patch_set":1,"id":"da20952f_3cae6281","line":8,"in_reply_to":"da20952f_bc5352e1","updated":"2015-09-07 08:46:37.000000000","message":"yes! existing imports (i.e. in ceilometer client) use\n`from oslo.serialization import jsonutils`\nNotation with dot is abandoned in oslo.serialization 1.7.\n\nIn 1.6 you can still use both:\n`from oslo.serialization import jsonutils`\nand\n`from oslo_serialization import jsonutils`","commit_id":"2abb46c62a576d546294515b06d6bf73611d966a"}]}
