)]}'
{"monitoring/overview/views.py":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"9453de05bc967267fbc7da7324307b5f2833f12d","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        if \u0027dimensions\u0027 in req_kwargs:"},{"line_number":204,"context_line":"            dimensions_str \u003d req_kwargs[\u0027dimensions\u0027][0]"},{"line_number":205,"context_line":"            print(dimensions_str)"},{"line_number":206,"context_line":"            print(type(dimensions_str))"},{"line_number":207,"context_line":"            dimensions_str_array \u003d dimensions_str.split(\u0027,\u0027)"},{"line_number":208,"context_line":"            for dimension in dimensions_str_array:"},{"line_number":209,"context_line":"                dimension_name_value \u003d dimension.split(\u0027:\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_b3ffc433","line":206,"updated":"2015-10-05 22:53:02.000000000","message":"these print statements seem unneeded.  at the least these should be moved to python logging framework so we can choose whether or not this goes to the console.","commit_id":"ef26b3598f91b35354cb4ef347050d3d041d8aa5"},{"author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"change_message_id":"41710c4e7a28604ec748bafa386d51ff1bacd912","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        if \u0027dimensions\u0027 in req_kwargs:"},{"line_number":204,"context_line":"            dimensions_str \u003d req_kwargs[\u0027dimensions\u0027][0]"},{"line_number":205,"context_line":"            print(dimensions_str)"},{"line_number":206,"context_line":"            print(type(dimensions_str))"},{"line_number":207,"context_line":"            dimensions_str_array \u003d dimensions_str.split(\u0027,\u0027)"},{"line_number":208,"context_line":"            for dimension in dimensions_str_array:"},{"line_number":209,"context_line":"                dimension_name_value \u003d dimension.split(\u0027:\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_2e3a6637","line":206,"in_reply_to":"7a2fa921_b3ffc433","updated":"2015-10-06 01:14:10.000000000","message":"good idea, not sure where these come from but are not needed, will fix","commit_id":"ef26b3598f91b35354cb4ef347050d3d041d8aa5"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"9453de05bc967267fbc7da7324307b5f2833f12d","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        # scope the reqeust to the region they are scoped to in"},{"line_number":220,"context_line":"        # horizon."},{"line_number":221,"context_line":"        #"},{"line_number":222,"context_line":"        if not scoped_to_region:"},{"line_number":223,"context_line":"            new_dimension_dict[\u0027region\u0027] \u003d self.request.user.services_region"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        req_kwargs[\u0027dimensions\u0027] \u003d new_dimension_dict"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_5358b056","line":222,"updated":"2015-10-05 22:53:02.000000000","message":"instead of this extra local variable, you might want to consider doing:\n\nif \u0027region\u0027 not in new_dimension_dict:\n\nThis might perform slightly better, though this is a nitpick","commit_id":"ef26b3598f91b35354cb4ef347050d3d041d8aa5"},{"author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"change_message_id":"41710c4e7a28604ec748bafa386d51ff1bacd912","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        # scope the reqeust to the region they are scoped to in"},{"line_number":220,"context_line":"        # horizon."},{"line_number":221,"context_line":"        #"},{"line_number":222,"context_line":"        if not scoped_to_region:"},{"line_number":223,"context_line":"            new_dimension_dict[\u0027region\u0027] \u003d self.request.user.services_region"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        req_kwargs[\u0027dimensions\u0027] \u003d new_dimension_dict"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_4e1242b6","line":222,"in_reply_to":"7a2fa921_5358b056","updated":"2015-10-06 01:14:10.000000000","message":"good idea","commit_id":"ef26b3598f91b35354cb4ef347050d3d041d8aa5"}]}