)]}'
{"monitoring/config/local_settings.py":[{"author":{"_account_id":15799,"name":"Ben Motz","email":"ben.launchpad@ouat.co.uk","username":"bmotz"},"change_message_id":"d2e0d0f7e80c9d146c28c0076915bfe3b9821848","unresolved":false,"context_lines":[{"line_number":2,"context_line":"from django.utils.translation import ugettext_lazy as _"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Service group names (global across all projects):"},{"line_number":5,"context_line":"MONITORING_SERVICES_GROUPS \u003d ["},{"line_number":6,"context_line":"    {\u0027name\u0027: _(\u0027OpenStack Services\u0027), \u0027groupBy\u0027: \u0027service\u0027},"},{"line_number":7,"context_line":"    {\u0027name\u0027: _(\u0027Servers\u0027), \u0027groupBy\u0027: \u0027hostname\u0027}"},{"line_number":8,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_4708ee28","line":5,"updated":"2015-11-13 12:57:02.000000000","message":"Could the additional configuration key have potential for confusion?\n\n(i.e. if the site settings does provide MONITORING_SERVICES then there\u0027ll be a local_settings.MONITORING_SERVICES and local_setings.MONITORING_SERVICES_GROUPS with different content)","commit_id":"4fa598009cca21ae6fa0d33bfb84577d6aef16b0"},{"author":{"_account_id":11155,"name":"Ryan Bak","email":"ryan.bak@twcable.com","username":"ryanmbak"},"change_message_id":"70243824f494df70f023d87276d4e499a42b12cc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"from django.utils.translation import ugettext_lazy as _"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Service group names (global across all projects):"},{"line_number":5,"context_line":"MONITORING_SERVICES_GROUPS \u003d ["},{"line_number":6,"context_line":"    {\u0027name\u0027: _(\u0027OpenStack Services\u0027), \u0027groupBy\u0027: \u0027service\u0027},"},{"line_number":7,"context_line":"    {\u0027name\u0027: _(\u0027Servers\u0027), \u0027groupBy\u0027: \u0027hostname\u0027}"},{"line_number":8,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_0700a133","line":5,"in_reply_to":"da85f559_4708ee28","updated":"2015-11-16 23:44:53.000000000","message":"This could certainly be a bit confusing, but I didn\u0027t see a way around it.  The grafana links had seperate names for the list (GRAFANA_LINKS) and attribute (DASHBOARDS) to begin with, but the variable names were the same in this case and needed to be split out.  I\u0027m open to any suggests though.","commit_id":"4fa598009cca21ae6fa0d33bfb84577d6aef16b0"},{"author":{"_account_id":15799,"name":"Ben Motz","email":"ben.launchpad@ouat.co.uk","username":"bmotz"},"change_message_id":"d2e0d0f7e80c9d146c28c0076915bfe3b9821848","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#    {\u0027*\u0027: ["},{"line_number":28,"context_line":"#         {\u0027name\u0027: _(\u0027Services\u0027), \u0027groupBy\u0027: \u0027service\u0027},"},{"line_number":29,"context_line":"#         {\u0027name\u0027: _(\u0027Instances\u0027), \u0027groupBy\u0027: \u0027hostname\u0027}]},"},{"line_number":30,"context_line":"# ]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"MONITORING_SERVICE_TYPE \u003d getattr("},{"line_number":33,"context_line":"    settings, \u0027MONITORING_SERVICE_TYPE\u0027, \u0027monitoring\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_dce1159c","line":30,"updated":"2015-11-13 12:57:02.000000000","message":"I\u0027d usually expect a comment documenting a configuration setting to be next to the setting in the file. That aside, maybe change to using the new format by default?","commit_id":"4fa598009cca21ae6fa0d33bfb84577d6aef16b0"},{"author":{"_account_id":11155,"name":"Ryan Bak","email":"ryan.bak@twcable.com","username":"ryanmbak"},"change_message_id":"70243824f494df70f023d87276d4e499a42b12cc","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#    {\u0027*\u0027: ["},{"line_number":28,"context_line":"#         {\u0027name\u0027: _(\u0027Services\u0027), \u0027groupBy\u0027: \u0027service\u0027},"},{"line_number":29,"context_line":"#         {\u0027name\u0027: _(\u0027Instances\u0027), \u0027groupBy\u0027: \u0027hostname\u0027}]},"},{"line_number":30,"context_line":"# ]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"MONITORING_SERVICE_TYPE \u003d getattr("},{"line_number":33,"context_line":"    settings, \u0027MONITORING_SERVICE_TYPE\u0027, \u0027monitoring\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_87657146","line":30,"in_reply_to":"da85f559_dce1159c","updated":"2015-11-16 23:44:53.000000000","message":"I was just the same format we used to make the grafana links configurable.  I can move this up, but I didn\u0027t want to break anyone by switching over to the new format by default.","commit_id":"4fa598009cca21ae6fa0d33bfb84577d6aef16b0"}]}