)]}'
{"monitoring/alarmdefs/forms.py":[{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"8d90c7987d15a0756831c8337a16019dbf895241","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                                    \u0027undetermined\u0027: item[\u0027undetermined\u0027]}"},{"line_number":85,"context_line":"        data \u003d []"},{"line_number":86,"context_line":"        for id, label, type, address in chain(self.choices, choices):"},{"line_number":87,"context_line":"            if id in selected.keys():"},{"line_number":88,"context_line":"                actions \u003d selected[id]"},{"line_number":89,"context_line":"                data.append((id, label, type, address, actions[\u0027alarm\u0027],"},{"line_number":90,"context_line":"                             actions[\u0027ok\u0027], actions[\u0027undetermined\u0027], True))"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_87475176","line":87,"range":{"start_line":87,"start_character":30,"end_line":87,"end_character":34},"updated":"2016-05-13 23:27:22.000000000","message":"Just because of python3 compatibility, I\u0027d suggest that you use \u0027if id in selected:\u0027 instead of \u0027if id in selected.keys():\u0027\n\nReference: https://wiki.openstack.org/wiki/Python3#Common_patterns","commit_id":"82a7a1e71ee66c30109128cea408a566ed3f83c4"},{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"8041e36b1995ad0381c59f43d5ef35fcf0ce56b8","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                                    \u0027undetermined\u0027: item[\u0027undetermined\u0027]}"},{"line_number":85,"context_line":"        data \u003d []"},{"line_number":86,"context_line":"        for id, label, type, address in chain(self.choices, choices):"},{"line_number":87,"context_line":"            if id in selected.keys():"},{"line_number":88,"context_line":"                actions \u003d selected[id]"},{"line_number":89,"context_line":"                data.append((id, label, type, address, actions[\u0027alarm\u0027],"},{"line_number":90,"context_line":"                             actions[\u0027ok\u0027], actions[\u0027undetermined\u0027], True))"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_d3e2bb00","line":87,"range":{"start_line":87,"start_character":30,"end_line":87,"end_character":34},"in_reply_to":"dab17558_87475176","updated":"2016-05-14 03:26:03.000000000","message":"Done","commit_id":"82a7a1e71ee66c30109128cea408a566ed3f83c4"}],"monitoring/alarmdefs/templates/alarmdefs/expression_field.html":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"67cbf61639ee47c84824d147d723af2f374de32d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% load i18n %}"},{"line_number":2,"context_line":"\u003cdiv ng-controller\u003d\"alarmEditController\" ng-init\u003d\"init(\u0027{{ service }}\u0027)\"\u003e"},{"line_number":3,"context_line":"    \u003cinput type\u003d\"hidden\" name\u003d\"{{ name }}\" id\u003d\"dimension\"/\u003e"},{"line_number":4,"context_line":"    \u003cinput type\u003d\"hidden\" name\u003d\"match_by\" id\u003d\"match\"/\u003e"},{"line_number":5,"context_line":"    \u003cdiv style\u003d\"margin-bottom:5px;\"\u003e"},{"line_number":6,"context_line":"        \u003cselect id\u003d\"function\" class\u003d\"form-control\""},{"line_number":7,"context_line":"                ng-model\u003d\"currentFunction\" ng-options\u003d\"f[0] as f[1] for f in {{func}}\" ng-change\u003d\"saveExpression()\"\u003e\u003c/select\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"dab17558_330379ba","side":"PARENT","line":4,"range":{"start_line":4,"start_character":24,"end_line":4,"end_character":25},"updated":"2016-05-13 06:46:59.000000000","message":"Was it unused ? Why did you remove it ?","commit_id":"c1003ac0c710f2ff44419ea4356e2fe2e94e3c2d"},{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"a8a366c25483fa88cf62f629cab6b0e16e2a4d7e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% load i18n %}"},{"line_number":2,"context_line":"\u003cdiv ng-controller\u003d\"alarmEditController\" ng-init\u003d\"init(\u0027{{ service }}\u0027)\"\u003e"},{"line_number":3,"context_line":"    \u003cinput type\u003d\"hidden\" name\u003d\"{{ name }}\" id\u003d\"dimension\"/\u003e"},{"line_number":4,"context_line":"    \u003cinput type\u003d\"hidden\" name\u003d\"match_by\" id\u003d\"match\"/\u003e"},{"line_number":5,"context_line":"    \u003cdiv style\u003d\"margin-bottom:5px;\"\u003e"},{"line_number":6,"context_line":"        \u003cselect id\u003d\"function\" class\u003d\"form-control\""},{"line_number":7,"context_line":"                ng-model\u003d\"currentFunction\" ng-options\u003d\"f[0] as f[1] for f in {{func}}\" ng-change\u003d\"saveExpression()\"\u003e\u003c/select\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"dab17558_09ef22b1","side":"PARENT","line":4,"range":{"start_line":4,"start_character":24,"end_line":4,"end_character":25},"in_reply_to":"dab17558_330379ba","updated":"2016-05-13 07:41:48.000000000","message":"Yes it is.\nI found that POST data has two match_by items.\nSo I remove one which is unused.","commit_id":"c1003ac0c710f2ff44419ea4356e2fe2e94e3c2d"}]}