)]}'
{"monitoring/static/monitoring/js/controllers.js":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"031452825bf438fa35745fa573f3004963f57068","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            return deferred.promise;"},{"line_number":177,"context_line":"        };"},{"line_number":178,"context_line":"        $scope.possibleDimKeys \u003d function(query) {"},{"line_number":179,"context_line":"            var deferred \u003d $q.defer();"},{"line_number":180,"context_line":"            var dim \u003d {}"},{"line_number":181,"context_line":"            var dimList \u003d []"},{"line_number":182,"context_line":"            angular.forEach($scope.matchingMetrics, function(value, name) {"}],"source_content_type":"text/javascript","patch_set":1,"id":"7aa08908_e06471e6","line":179,"range":{"start_line":179,"start_character":30,"end_line":179,"end_character":35},"updated":"2016-06-10 07:05:21.000000000","message":"I am not sure if horizon contains angular version that allows that by maybe it does. See if it possible to do\n\n return $q(function(resolve,reject) {\n })","commit_id":"000919b39bc70aaaf4306f2d8c7663bf788587fa"},{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"1ec2ee50ae6d3e77cd292a78e1164d00cf22c711","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            return deferred.promise;"},{"line_number":177,"context_line":"        };"},{"line_number":178,"context_line":"        $scope.possibleDimKeys \u003d function(query) {"},{"line_number":179,"context_line":"            var deferred \u003d $q.defer();"},{"line_number":180,"context_line":"            var dim \u003d {}"},{"line_number":181,"context_line":"            var dimList \u003d []"},{"line_number":182,"context_line":"            angular.forEach($scope.matchingMetrics, function(value, name) {"}],"source_content_type":"text/javascript","patch_set":1,"id":"7aa08908_b5810292","line":179,"range":{"start_line":179,"start_character":30,"end_line":179,"end_character":35},"in_reply_to":"7aa08908_5acc4d61","updated":"2016-06-10 10:49:00.000000000","message":"Oops, I found words which is \"resembles ES6 style\" in AngularJS.\nSo as you mentioned, it is able to write like \"return $q(function(resolve, reject) {})\".","commit_id":"000919b39bc70aaaf4306f2d8c7663bf788587fa"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"c08683b0ce6f9a8162add8ea549bae4b106dd390","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            return deferred.promise;"},{"line_number":177,"context_line":"        };"},{"line_number":178,"context_line":"        $scope.possibleDimKeys \u003d function(query) {"},{"line_number":179,"context_line":"            var deferred \u003d $q.defer();"},{"line_number":180,"context_line":"            var dim \u003d {}"},{"line_number":181,"context_line":"            var dimList \u003d []"},{"line_number":182,"context_line":"            angular.forEach($scope.matchingMetrics, function(value, name) {"}],"source_content_type":"text/javascript","patch_set":1,"id":"7aa08908_5acc4d61","line":179,"range":{"start_line":179,"start_character":30,"end_line":179,"end_character":35},"in_reply_to":"7aa08908_da2e7d41","updated":"2016-06-10 10:21:38.000000000","message":"Heh, it is ES5 still, notice no arrow expression ;-).\nIn ES6 that would be\n\n return $q((resolve,reject) \u003d\u003e {})\n\nhower in ES5 that is\n\n return $q(function(resolve, reject) {})\n\ntry it, I think that will work and it also clearly states that possibleDimKeys is happening in the background processing.","commit_id":"000919b39bc70aaaf4306f2d8c7663bf788587fa"},{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"8e6b0e36f1bc7b32a35d438158afe0295d61fb85","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            return deferred.promise;"},{"line_number":177,"context_line":"        };"},{"line_number":178,"context_line":"        $scope.possibleDimKeys \u003d function(query) {"},{"line_number":179,"context_line":"            var deferred \u003d $q.defer();"},{"line_number":180,"context_line":"            var dim \u003d {}"},{"line_number":181,"context_line":"            var dimList \u003d []"},{"line_number":182,"context_line":"            angular.forEach($scope.matchingMetrics, function(value, name) {"}],"source_content_type":"text/javascript","patch_set":1,"id":"7aa08908_da2e7d41","line":179,"range":{"start_line":179,"start_character":30,"end_line":179,"end_character":35},"in_reply_to":"7aa08908_e06471e6","updated":"2016-06-10 10:16:01.000000000","message":"Yes it does.\nI tested ES6 style that you mentioned above, and it works.\nBut I don\u0027t know applying ES6 style is correct.\nSo I leave code as it is.","commit_id":"000919b39bc70aaaf4306f2d8c7663bf788587fa"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"031452825bf438fa35745fa573f3004963f57068","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                    }"},{"line_number":187,"context_line":"                }"},{"line_number":188,"context_line":"            });"},{"line_number":189,"context_line":"            angular.forEach(dim, function(value, name) {"},{"line_number":190,"context_line":"                dimList.push(value)"},{"line_number":191,"context_line":"            });"},{"line_number":192,"context_line":"            deferred.resolve(dimList);"}],"source_content_type":"text/javascript","patch_set":1,"id":"7aa08908_e0abd1d4","line":189,"range":{"start_line":189,"start_character":20,"end_line":189,"end_character":27},"updated":"2016-06-10 07:05:21.000000000","message":"Wouldn\u0027t be possible to use single loop here ?","commit_id":"000919b39bc70aaaf4306f2d8c7663bf788587fa"},{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"8e6b0e36f1bc7b32a35d438158afe0295d61fb85","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                    }"},{"line_number":187,"context_line":"                }"},{"line_number":188,"context_line":"            });"},{"line_number":189,"context_line":"            angular.forEach(dim, function(value, name) {"},{"line_number":190,"context_line":"                dimList.push(value)"},{"line_number":191,"context_line":"            });"},{"line_number":192,"context_line":"            deferred.resolve(dimList);"}],"source_content_type":"text/javascript","patch_set":1,"id":"7aa08908_e93619b3","line":189,"range":{"start_line":189,"start_character":20,"end_line":189,"end_character":27},"in_reply_to":"7aa08908_e0abd1d4","updated":"2016-06-10 10:16:01.000000000","message":"Done","commit_id":"000919b39bc70aaaf4306f2d8c7663bf788587fa"}]}