)]}'
{"monitoring/overview/templates/overview/index.html":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"fd5db75e8b7a0a8aa731a6f474d7c8be060dea50","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      \u003c/a\u003e"},{"line_number":16,"context_line":"      {% for dashboard in dashboards %}"},{"line_number":17,"context_line":"      \u003ca target\u003d{{ dashboard.title }} href\u003d\"{{grafana_url}}/dashboard/db/{{ dashboard.path }}\" class\u003d\"btn btn-default btn-sm\"\u003e"},{"line_number":18,"context_line":"              \u003cspan class\u003d\"glyphicon glyphicon-dashboard\"\u003e\u003c/span\u003e"},{"line_number":19,"context_line":"              {% trans dashboard.title %}"},{"line_number":20,"context_line":"          \u003c/a\u003e"},{"line_number":21,"context_line":"      {% endfor %}"}],"source_content_type":"text/html","patch_set":1,"id":"1aa78d24_a0d1bbfd","line":18,"updated":"2016-07-09 16:12:25.000000000","message":"I think these button should also be changed.","commit_id":"6e76764d1ebffd112a162f10a4f2d048e92e9322"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"b227360f44d8aa1eac01a10b582ca84bb89db248","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      \u003c/a\u003e"},{"line_number":16,"context_line":"      {% for dashboard in dashboards %}"},{"line_number":17,"context_line":"      \u003ca target\u003d{{ dashboard.title }} href\u003d\"{{grafana_url}}/dashboard/db/{{ dashboard.path }}\" class\u003d\"btn btn-default btn-sm\"\u003e"},{"line_number":18,"context_line":"              \u003cspan class\u003d\"glyphicon glyphicon-dashboard\"\u003e\u003c/span\u003e"},{"line_number":19,"context_line":"              {% trans dashboard.title %}"},{"line_number":20,"context_line":"          \u003c/a\u003e"},{"line_number":21,"context_line":"      {% endfor %}"}],"source_content_type":"text/html","patch_set":2,"id":"1aa78d24_148516ce","line":18,"updated":"2016-07-12 10:21:27.000000000","message":"So we don\u0027t change that ?\nCurrently we are still using those buttons, so it\u0027d be great if you updated icons also here.","commit_id":"03f842ebe05bbfd3a4dcb912af2409330cec4727"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"ae38ccd1ddb5efc122b4fc658e35024ec010a194","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      \u003c/a\u003e"},{"line_number":16,"context_line":"      {% for dashboard in dashboards %}"},{"line_number":17,"context_line":"      \u003ca target\u003d{{ dashboard.title }} href\u003d\"{{grafana_url}}/dashboard/db/{{ dashboard.path }}\" class\u003d\"btn btn-default btn-sm\"\u003e"},{"line_number":18,"context_line":"              \u003cspan class\u003d\"glyphicon glyphicon-dashboard\"\u003e\u003c/span\u003e"},{"line_number":19,"context_line":"              {% trans dashboard.title %}"},{"line_number":20,"context_line":"          \u003c/a\u003e"},{"line_number":21,"context_line":"      {% endfor %}"}],"source_content_type":"text/html","patch_set":2,"id":"1aa78d24_2007d01e","line":18,"in_reply_to":"1aa78d24_148516ce","updated":"2016-07-13 19:49:39.000000000","message":"Done","commit_id":"03f842ebe05bbfd3a4dcb912af2409330cec4727"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"47d7df4210724c8b1cc77056d9d1234e804aaaf1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"      {% endif %}"},{"line_number":30,"context_line":"      {% if can_access_logs and enable_kibana_button %}"},{"line_number":31,"context_line":"      \u003ca target\u003d\"dashboard\" href\u003d\"{% url \u0027horizon:monitoring:overview:kibana_proxy\u0027 url\u003d\u0027/\u0027 %}\" class\u003d\"btn btn-default\"\u003e"},{"line_number":32,"context_line":"              \u003cspan class\u003d\"fa fa-bar-charts\"\u003e\u003c/span\u003e"},{"line_number":33,"context_line":"              Log Management"},{"line_number":34,"context_line":"      \u003c/a\u003e"},{"line_number":35,"context_line":"      {% endif %}"}],"source_content_type":"text/html","patch_set":4,"id":"1aa78d24_032ba295","line":32,"updated":"2016-07-14 10:09:24.000000000","message":"fa-bar-chart :), drop /s/ in the end.","commit_id":"5b7b9dd4313b4894029b33d7ce2f45b1d1c77e46"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"e24278665bc01dfd769290e9c2f0cf7d8c3fd4b3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"      {% endif %}"},{"line_number":30,"context_line":"      {% if can_access_logs and enable_kibana_button %}"},{"line_number":31,"context_line":"      \u003ca target\u003d\"dashboard\" href\u003d\"{% url \u0027horizon:monitoring:overview:kibana_proxy\u0027 url\u003d\u0027/\u0027 %}\" class\u003d\"btn btn-default\"\u003e"},{"line_number":32,"context_line":"              \u003cspan class\u003d\"fa fa-bar-charts\"\u003e\u003c/span\u003e"},{"line_number":33,"context_line":"              Log Management"},{"line_number":34,"context_line":"      \u003c/a\u003e"},{"line_number":35,"context_line":"      {% endif %}"}],"source_content_type":"text/html","patch_set":4,"id":"fad55976_405be754","line":32,"in_reply_to":"1aa78d24_032ba295","updated":"2016-07-15 18:44:48.000000000","message":"Done","commit_id":"5b7b9dd4313b4894029b33d7ce2f45b1d1c77e46"}],"monitoring/overview/templates/overview/monitor.html":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"47d7df4210724c8b1cc77056d9d1234e804aaaf1","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            \u003cdiv ng-repeat\u003d\"service in group.services\" style\u003d\"display:inline-block; margin-bottom:4px; margin-right:4px;\"\u003e"},{"line_number":61,"context_line":"                \u003ca href\u003d\"{% url \u0027horizon:monitoring:alarms:index\u0027 %}alarm/{$ service.name $}\"\u003e"},{"line_number":62,"context_line":"                 \u003cdiv class\u003d\"btn {$ service.class $}\"\u003e"},{"line_number":63,"context_line":"                    \u003cdiv class\u003d\"fa {$ service.icon $}\"\u003e \u003c/div\u003e"},{"line_number":64,"context_line":"                    {$ service.display $}"},{"line_number":65,"context_line":"                 \u003c/div\u003e"},{"line_number":66,"context_line":"                 \u003c/a\u003e"}],"source_content_type":"text/html","patch_set":4,"id":"1aa78d24_fe5d4916","line":63,"updated":"2016-07-14 10:09:24.000000000","message":"This variable you are trying to template here\n\n service.icon\n\neither service is set, but icon property is falsy. Generated HTML looks like this:\n\n  \u003ca href\u003d\"/dashboard/monitoring/alarms/alarm/hostname\u003ddevstack\"\u003e\n    \u003cdiv class\u003d\"btn btn-info\"\u003e\n      \u003cdiv class\u003d\"fa \"\u003e \u003c/div\u003e\n        devstack\n    \u003c/div\u003e\n  \u003c/a\u003e\n\nAs you can see, div at 2nd level has only \u0027fa\u0027 class.","commit_id":"5b7b9dd4313b4894029b33d7ce2f45b1d1c77e46"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"8c4f50e4edbf7ddfd9bd55b6675226a0405c5eb2","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            \u003cdiv ng-repeat\u003d\"service in group.services\" style\u003d\"display:inline-block; margin-bottom:4px; margin-right:4px;\"\u003e"},{"line_number":61,"context_line":"                \u003ca href\u003d\"{% url \u0027horizon:monitoring:alarms:index\u0027 %}alarm/{$ service.name $}\"\u003e"},{"line_number":62,"context_line":"                 \u003cdiv class\u003d\"btn {$ service.class $}\"\u003e"},{"line_number":63,"context_line":"                    \u003cdiv class\u003d\"fa {$ service.icon $}\"\u003e \u003c/div\u003e"},{"line_number":64,"context_line":"                    {$ service.display $}"},{"line_number":65,"context_line":"                 \u003c/div\u003e"},{"line_number":66,"context_line":"                 \u003c/a\u003e"}],"source_content_type":"text/html","patch_set":4,"id":"1aa78d24_1e577527","line":63,"in_reply_to":"1aa78d24_fe5d4916","updated":"2016-07-14 10:29:52.000000000","message":"Don\u0027t mind that comment, please.","commit_id":"5b7b9dd4313b4894029b33d7ce2f45b1d1c77e46"}],"monitoring/overview/views.py":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"2141d4da533cc174055794911ff2e1522542c9b0","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def get_icon(status):"},{"line_number":43,"context_line":"    status_fa_icon_map \u003d {\u0027btn-success\u0027: \"fa-check\","},{"line_number":44,"context_line":"                          \u0027btn-info\u0027: \"fa-exclamation\","},{"line_number":45,"context_line":"                          \u0027btn-danger\u0027: \"fa-exclamation-triangle\","},{"line_number":46,"context_line":"                          \u0027btn-warning\u0027:\"fa-exclamation-circle\","}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_977527fc","line":43,"updated":"2016-07-13 20:23:18.000000000","message":"Is it really necessary to create this object each time this method is called ?","commit_id":"8da19bcda986b62b0ff9daba1f42587207486bb2"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"8c4f50e4edbf7ddfd9bd55b6675226a0405c5eb2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"priorities \u003d ["},{"line_number":54,"context_line":"    {\u0027status\u0027: \u0027btn-success\u0027, \u0027severity\u0027: \u0027OK\u0027},"},{"line_number":55,"context_line":"    {\u0027status\u0027: \u0027btn-default\u0027, \u0027severity\u0027: \u0027UNDETERMINED\u0027},"},{"line_number":56,"context_line":"    {\u0027status\u0027: \u0027btn-info\u0027, \u0027severity\u0027: \u0027LOW\u0027},"},{"line_number":57,"context_line":"    {\u0027status\u0027: \u0027btn-warning\u0027, \u0027severity\u0027: \u0027MEDIUM\u0027},"},{"line_number":58,"context_line":"    {\u0027status\u0027: \u0027btn-warning\u0027, \u0027severity\u0027: \u0027HIGH\u0027},"},{"line_number":59,"context_line":"    {\u0027status\u0027: \u0027btn-danger\u0027, \u0027severity\u0027: \u0027CRITICAL\u0027},"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_1e80158b","line":56,"updated":"2016-07-14 10:29:52.000000000","message":"I think I would rather see warning class here (btn-warning), seems more appropriate, suggesting that something is happening but it not that bad. Blue color does not visually suggest so.","commit_id":"5b7b9dd4313b4894029b33d7ce2f45b1d1c77e46"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"e24278665bc01dfd769290e9c2f0cf7d8c3fd4b3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"priorities \u003d ["},{"line_number":54,"context_line":"    {\u0027status\u0027: \u0027btn-success\u0027, \u0027severity\u0027: \u0027OK\u0027},"},{"line_number":55,"context_line":"    {\u0027status\u0027: \u0027btn-default\u0027, \u0027severity\u0027: \u0027UNDETERMINED\u0027},"},{"line_number":56,"context_line":"    {\u0027status\u0027: \u0027btn-info\u0027, \u0027severity\u0027: \u0027LOW\u0027},"},{"line_number":57,"context_line":"    {\u0027status\u0027: \u0027btn-warning\u0027, \u0027severity\u0027: \u0027MEDIUM\u0027},"},{"line_number":58,"context_line":"    {\u0027status\u0027: \u0027btn-warning\u0027, \u0027severity\u0027: \u0027HIGH\u0027},"},{"line_number":59,"context_line":"    {\u0027status\u0027: \u0027btn-danger\u0027, \u0027severity\u0027: \u0027CRITICAL\u0027},"}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_0049ef8b","line":56,"in_reply_to":"1aa78d24_1e80158b","updated":"2016-07-15 18:44:48.000000000","message":"Done","commit_id":"5b7b9dd4313b4894029b33d7ce2f45b1d1c77e46"}]}