)]}'
{"monitoring/notifications/forms.py":[{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"ef787e8c2ed90a4b091b05e798a53f67dde1faae","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def _init_fields(self, readOnly\u003dFalse, create\u003dFalse):"},{"line_number":36,"context_line":"        required \u003d True"},{"line_number":37,"context_line":"        textWidget \u003d None"},{"line_number":38,"context_line":"        integerWidget \u003d None"},{"line_number":39,"context_line":"        selectWidget \u003d None"},{"line_number":40,"context_line":"        readOnlyTextInput \u003d READONLY_TEXTINPUT"},{"line_number":41,"context_line":"        readOnlySelectInput \u003d forms.Select(attrs\u003d{\u0027disabled\u0027: \u0027disabled\u0027})"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_2a3589f6","line":38,"range":{"start_line":38,"start_character":24,"end_line":38,"end_character":28},"updated":"2016-07-19 21:32:49.000000000","message":"I think that forms.NumberInput() is more kindness than None. Or getting rid of \"integerWidget \u003d None\" is more simple because IntegerField has NumberInput widget by default.","commit_id":"1d3170b9d9c5521ff199dd7f2f48e9e19055c6c6"},{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"ef787e8c2ed90a4b091b05e798a53f67dde1faae","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                                 max_length\u003d\"512\","},{"line_number":63,"context_line":"                                                 widget\u003dtextWidget,"},{"line_number":64,"context_line":"                                                 help_text\u003d_(\"The email/url address to notify.\"))"},{"line_number":65,"context_line":"        self.fields[\u0027period\u0027] \u003d forms.IntegerField(label\u003d_(\"Period\"),"},{"line_number":66,"context_line":"                                                   initial\u003d0,"},{"line_number":67,"context_line":"                                                   required\u003drequired,"},{"line_number":68,"context_line":"                                                   widget\u003dintegerWidget,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_d5145245","line":65,"range":{"start_line":65,"start_character":32,"end_line":65,"end_character":50},"updated":"2016-07-19 21:32:49.000000000","message":"Adding min_value\u003d0 argument is useful to prevent keying minus value.","commit_id":"1d3170b9d9c5521ff199dd7f2f48e9e19055c6c6"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"b8bee670843e6bfc21f74c5dbd19dfe2a382beb8","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    def clean_period(self):"},{"line_number":92,"context_line":"        \u0027\u0027\u0027Check to make sure period is zero unless type is WEBHOOK."},{"line_number":93,"context_line":"        \u0027\u0027\u0027"},{"line_number":94,"context_line":"        data \u003d super(forms.Form, self).clean()"},{"line_number":95,"context_line":"        if data[\u0027type\u0027] !\u003d constants.NotificationType.WEBHOOK and data[\u0027period\u0027] !\u003d 0:"},{"line_number":96,"context_line":"            raise forms.ValidationError(\"Period must be zero except for type webhook.\")"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_d042b60f","line":94,"updated":"2016-07-19 14:52:43.000000000","message":"don\u0027t call clean from within another clean.\n\nhttps://docs.djangoproject.com/en/1.9/ref/forms/validation/#cleaning-a-specific-field-attribute\n\nuse cleaned_data","commit_id":"1d3170b9d9c5521ff199dd7f2f48e9e19055c6c6"}]}
