)]}'
{"monitoring/alarms/tables.py":[{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"1c84598278469a313ed3127f7deee6a60913bd3c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    severity \u003d data[\u0027alarm_definition\u0027][\u0027severity\u0027]"},{"line_number":64,"context_line":"    state \u003d data[\u0027state\u0027]"},{"line_number":65,"context_line":"    if state \u003d\u003d \u0027ALARM\u0027:"},{"line_number":66,"context_line":"        return severity"},{"line_number":67,"context_line":"    else:"},{"line_number":68,"context_line":"        return state"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_f1ea400e","line":66,"range":{"start_line":66,"start_character":15,"end_line":66,"end_character":23},"updated":"2016-08-30 02:00:35.000000000","message":"Why don\u0027t you add .upper() to severity instead of doing in alarms/views and overview/views.\n\nThese 2 files call this show_severity method.","commit_id":"c0e60c9e8f465f3719fa4dcf6ccce839a4e68697"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"56f0445d0e5666fb9929fbadf32c83c972c34e14","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    severity \u003d data[\u0027alarm_definition\u0027][\u0027severity\u0027]"},{"line_number":64,"context_line":"    state \u003d data[\u0027state\u0027]"},{"line_number":65,"context_line":"    if state \u003d\u003d \u0027ALARM\u0027:"},{"line_number":66,"context_line":"        return severity"},{"line_number":67,"context_line":"    else:"},{"line_number":68,"context_line":"        return state"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_bbc87d56","line":66,"range":{"start_line":66,"start_character":15,"end_line":66,"end_character":23},"in_reply_to":"fa7ab95a_f1ea400e","updated":"2016-08-30 11:26:25.000000000","message":"+1","commit_id":"c0e60c9e8f465f3719fa4dcf6ccce839a4e68697"},{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"74bf17cacdd18a52b4232f3638a5978cf688e2a5","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    if state \u003d\u003d \u0027ALARM\u0027:"},{"line_number":66,"context_line":"        return severity.upper()"},{"line_number":67,"context_line":"    else:"},{"line_number":68,"context_line":"        return state"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def show_alarm_id(data):"},{"line_number":71,"context_line":"    return data[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_e510705c","line":68,"range":{"start_line":68,"start_character":15,"end_line":68,"end_character":20},"updated":"2016-08-30 23:50:38.000000000","message":"Is state always upper case?","commit_id":"e2d333610f5165ef7a7f8b830ada2d8fa05b9c93"},{"author":{"_account_id":11155,"name":"Ryan Bak","email":"ryan.bak@twcable.com","username":"ryanmbak"},"change_message_id":"2f876ae07072f3acc0beefa17c304a74f2e30747","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    if state \u003d\u003d \u0027ALARM\u0027:"},{"line_number":66,"context_line":"        return severity.upper()"},{"line_number":67,"context_line":"    else:"},{"line_number":68,"context_line":"        return state"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def show_alarm_id(data):"},{"line_number":71,"context_line":"    return data[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_aa1fe807","line":68,"range":{"start_line":68,"start_character":15,"end_line":68,"end_character":20},"in_reply_to":"fa7ab95a_2f304a07","updated":"2016-08-31 14:39:03.000000000","message":"On second thought, it doesn\u0027t hurt to ensure this.  I\u0027ve updated the patch.","commit_id":"e2d333610f5165ef7a7f8b830ada2d8fa05b9c93"},{"author":{"_account_id":11155,"name":"Ryan Bak","email":"ryan.bak@twcable.com","username":"ryanmbak"},"change_message_id":"06f8efb53b6664b33f446f39f4fe54db75c2b1e2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    if state \u003d\u003d \u0027ALARM\u0027:"},{"line_number":66,"context_line":"        return severity.upper()"},{"line_number":67,"context_line":"    else:"},{"line_number":68,"context_line":"        return state"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def show_alarm_id(data):"},{"line_number":71,"context_line":"    return data[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_c6a4200a","line":68,"range":{"start_line":68,"start_character":15,"end_line":68,"end_character":20},"in_reply_to":"fa7ab95a_609c1c6a","updated":"2016-08-31 16:15:42.000000000","message":"I added upper here for consistency, but I\u0027m confident it isn\u0027t necessary for the ALARM state as that is not user defined.","commit_id":"e2d333610f5165ef7a7f8b830ada2d8fa05b9c93"},{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"b1a2acd1ad827b4506b62ef586e7797696ebd634","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    if state \u003d\u003d \u0027ALARM\u0027:"},{"line_number":66,"context_line":"        return severity.upper()"},{"line_number":67,"context_line":"    else:"},{"line_number":68,"context_line":"        return state"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def show_alarm_id(data):"},{"line_number":71,"context_line":"    return data[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_609c1c6a","line":68,"range":{"start_line":68,"start_character":15,"end_line":68,"end_character":20},"in_reply_to":"fa7ab95a_aa1fe807","updated":"2016-08-31 16:04:25.000000000","message":"If you add upper(), I think before line 65 is better.\nBecause If state is lower case, \u0027if instruction\u0027 will be always false.","commit_id":"e2d333610f5165ef7a7f8b830ada2d8fa05b9c93"},{"author":{"_account_id":11155,"name":"Ryan Bak","email":"ryan.bak@twcable.com","username":"ryanmbak"},"change_message_id":"0087b6106a043df91c2649257c53de3da3356782","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    if state \u003d\u003d \u0027ALARM\u0027:"},{"line_number":66,"context_line":"        return severity.upper()"},{"line_number":67,"context_line":"    else:"},{"line_number":68,"context_line":"        return state"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def show_alarm_id(data):"},{"line_number":71,"context_line":"    return data[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_2f304a07","line":68,"range":{"start_line":68,"start_character":15,"end_line":68,"end_character":20},"in_reply_to":"fa7ab95a_e510705c","updated":"2016-08-31 14:35:46.000000000","message":"I believe so.  The issue here is that when defining an alarm you can give a severity in any case.","commit_id":"e2d333610f5165ef7a7f8b830ada2d8fa05b9c93"}],"monitoring/overview/views.py":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"4cea74702c58fe6c1128b9b9ca5bde03d5b8e794","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    status_index \u003d 0"},{"line_number":178,"context_line":"    for a in alarms:"},{"line_number":179,"context_line":"        severity \u003d alarm_tables.show_severity(a)"},{"line_number":180,"context_line":"        severity_index \u003d index_by_severity[severity.lower()]"},{"line_number":181,"context_line":"        status_index \u003d max(status_index, severity_index)"},{"line_number":182,"context_line":"    return priorities[status_index][\u0027status\u0027]"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_e31e046f","line":180,"updated":"2016-08-29 19:36:00.000000000","message":"might want to place a default here - \n\nindex_by_severity.get(severity.lower(),UNDETERMINED)\n\nnot required, but maybe a good idea?","commit_id":"2b7e429e183a817f4fa7b0ae5a64ca68be445703"}]}