)]}'
{"monitoring/api/tests.py":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"934db7dfa50c521dcbd0d81102c95efda66d1335","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"df7087c5_35b49ef1","updated":"2018-03-16 13:12:40.000000000","message":"I think we should move these tests to monitoring.test package. The tests.py modules in `overview`, `alarms`, `alarmdefs`, and `notifications` are meant for individual panels and follow the general schema for Horizon plugins. `api` package does not represent any panel.","commit_id":"263f78752ea23f0aba78fc8dc7e0b550c32862fc"},{"author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"change_message_id":"5d8a9c56b9d63872ce3a6301a4fd9698b953742a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"df7087c5_1c0c1993","in_reply_to":"df7087c5_35b49ef1","updated":"2018-03-16 21:10:26.000000000","message":"ok","commit_id":"263f78752ea23f0aba78fc8dc7e0b550c32862fc"},{"author":{"_account_id":26733,"name":"Amir Mofakhar","email":"amir@mofakhar.info","username":"amofakhar"},"change_message_id":"b9fb4bb154a66bf3a66fc5a9e7279d2dcd73c3aa","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @override_settings(OPENSTACK_SSL_NO_VERIFY\u003dFalse)"},{"line_number":34,"context_line":"    @override_settings(OPENSTACK_SSL_CACERT\u003d\u0027/etc/ssl/certs/some.crt\u0027)"},{"line_number":35,"context_line":"    def test_ssl_verify_with_cert(self):"},{"line_number":36,"context_line":"        insecure \u003d getattr(d_settings, \u0027OPENSTACK_SSL_NO_VERIFY\u0027, False)"},{"line_number":37,"context_line":"        cert \u003d getattr(d_settings, \u0027OPENSTACK_SSL_CACERT\u0027, None)"},{"line_number":38,"context_line":"        to_verify \u003d _get_to_verify(insecure, cert)"}],"source_content_type":"text/x-python","patch_set":11,"id":"df7087c5_9fb04ddf","line":35,"updated":"2018-03-15 10:04:27.000000000","message":"I think it makes more sense to have some tests for client.monascaclient method instead. They will also cover the _get_to_verify method.","commit_id":"263f78752ea23f0aba78fc8dc7e0b550c32862fc"},{"author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"change_message_id":"5d8a9c56b9d63872ce3a6301a4fd9698b953742a","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @override_settings(OPENSTACK_SSL_NO_VERIFY\u003dFalse)"},{"line_number":34,"context_line":"    @override_settings(OPENSTACK_SSL_CACERT\u003d\u0027/etc/ssl/certs/some.crt\u0027)"},{"line_number":35,"context_line":"    def test_ssl_verify_with_cert(self):"},{"line_number":36,"context_line":"        insecure \u003d getattr(d_settings, \u0027OPENSTACK_SSL_NO_VERIFY\u0027, False)"},{"line_number":37,"context_line":"        cert \u003d getattr(d_settings, \u0027OPENSTACK_SSL_CACERT\u0027, None)"},{"line_number":38,"context_line":"        to_verify \u003d _get_to_verify(insecure, cert)"}],"source_content_type":"text/x-python","patch_set":11,"id":"df7087c5_3c11ddad","line":35,"in_reply_to":"df7087c5_9fb04ddf","updated":"2018-03-16 21:10:26.000000000","message":"will add one","commit_id":"263f78752ea23f0aba78fc8dc7e0b550c32862fc"}],"monitoring/test/client_tests.py":[{"author":{"_account_id":26733,"name":"Amir Mofakhar","email":"amir@mofakhar.info","username":"amofakhar"},"change_message_id":"4c31749df2a4556474eb23f3e52b4af11d1ed4c1","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            with patch(\u0027openstack_dashboard.api.base.url_for\u0027,"},{"line_number":78,"context_line":"                       side_effect\u003d_mock_url_for):"},{"line_number":79,"context_line":"                monclient \u003d monascaclient(mock_request)"},{"line_number":80,"context_line":"        self.assertIsNotNone(monclient)"}],"source_content_type":"text/x-python","patch_set":14,"id":"df7087c5_3e2d31a8","line":80,"updated":"2018-03-19 15:39:03.000000000","message":"1. This test does not make sense because if monascaclient returns anything it will be passed and also if it returns a client object with incorrect properties it will pass again.\n\n2. There is no need to mock _get_auth_params_from_request. if you don\u0027t do that , this method will be tested automatically and no need for test_no_ssl_verify and test_ssl_verify_with_cert. both of them should be covered in test_client.","commit_id":"7e93f302ba8349a2a918b7a42e5f5de5b00b98bb"},{"author":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"change_message_id":"c17c56ed5e7abde1b2a1860d3a2f88d0efe12852","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2018 OP5 AB"},{"line_number":2,"context_line":"# (c) Copyright 2017-2018 SUSE LLC"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":15,"id":"df7087c5_5e555c4f","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":21},"updated":"2018-03-20 20:20:12.000000000","message":"New file, so doesn\u0027t need the 2017. ;)","commit_id":"b42a9b5293ef629bf48b19350a926faa8ca76a61"},{"author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"change_message_id":"2e210ad3fb27b1b184da2300deb9064275f6dda0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2018 OP5 AB"},{"line_number":2,"context_line":"# (c) Copyright 2017-2018 SUSE LLC"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":15,"id":"df7087c5_34452944","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":21},"in_reply_to":"df7087c5_5e555c4f","updated":"2018-03-20 21:24:35.000000000","message":"ic. will fix. Thanks.","commit_id":"b42a9b5293ef629bf48b19350a926faa8ca76a61"},{"author":{"_account_id":26733,"name":"Amir Mofakhar","email":"amir@mofakhar.info","username":"amofakhar"},"change_message_id":"a53dba02825f3786a6e5ac9b36ef12a190b3e35e","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            auth_params,"},{"line_number":87,"context_line":"            (923, \u002722\u0027, 789, 55, \u0027monitoring_url\u0027, \u0027identity_url\u0027))"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @patch(\u0027monascaclient.client._session\u0027)"},{"line_number":90,"context_line":"    def test_client_no_verify(self, mock_session):"},{"line_number":91,"context_line":"        ("},{"line_number":92,"context_line":"            version,"}],"source_content_type":"text/x-python","patch_set":16,"id":"df7087c5_9d4a07aa","line":89,"updated":"2018-03-21 13:46:27.000000000","message":"good tests below ones but unfortunately they are not testing monasca-ui.monitoring.api.client.monclient !\n\nthese two tests are testing monascaclient (python-monascaclient) which is a seperate library and there is no need to test it here in monasca-ui.\n(look at your patches)\n\nyou can see it just by changing line #106 in api.client.py to : verify\u003d\u0027HELLO\u0027 and see that all tests are passed yet! which should not be!","commit_id":"5f73287d49e6e39ee5d0d0d373c9415d6be30322"},{"author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"change_message_id":"d8c5833cde164bedc87388c41fe9d55b74f87744","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            auth_params,"},{"line_number":87,"context_line":"            (923, \u002722\u0027, 789, 55, \u0027monitoring_url\u0027, \u0027identity_url\u0027))"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @patch(\u0027monascaclient.client._session\u0027)"},{"line_number":90,"context_line":"    def test_client_no_verify(self, mock_session):"},{"line_number":91,"context_line":"        ("},{"line_number":92,"context_line":"            version,"}],"source_content_type":"text/x-python","patch_set":16,"id":"df7087c5_f1d31ed4","line":89,"in_reply_to":"df7087c5_9d4a07aa","updated":"2018-03-22 00:41:32.000000000","message":"I will add one api.client.monascaclient test.\nI will keep the following tests...since the actual call into _session of keystone is what we really care. I just want to make sure the variations of the verify will reflect in the params passed into _session.","commit_id":"5f73287d49e6e39ee5d0d0d373c9415d6be30322"}]}