)]}'
{"monitoring/alarms/tables.py":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"48c0f5250a6e88b7f10084701a9402ee677deeba","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def show_metric_name(data):"},{"line_number":70,"context_line":"    if len(data[\u0027metrics\u0027]) \u003e 1:"},{"line_number":71,"context_line":"        names \u003d {}"},{"line_number":72,"context_line":"        for metric in data[\u0027metrics\u0027]:"},{"line_number":73,"context_line":"            names[metric[\u0027name\u0027]] \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_3a15b249","line":70,"range":{"start_line":70,"start_character":4,"end_line":70,"end_character":32},"updated":"2018-04-12 07:54:26.000000000","message":"You don\u0027t really need this conditional.","commit_id":"f84891ec428ec3bd46c617abba4565aefcc7a1bb"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"48c0f5250a6e88b7f10084701a9402ee677deeba","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def show_metric_name(data):"},{"line_number":70,"context_line":"    if len(data[\u0027metrics\u0027]) \u003e 1:"},{"line_number":71,"context_line":"        names \u003d {}"},{"line_number":72,"context_line":"        for metric in data[\u0027metrics\u0027]:"},{"line_number":73,"context_line":"            names[metric[\u0027name\u0027]] \u003d \u0027\u0027"},{"line_number":74,"context_line":"        return \u0027, \u0027.join([\u0027%s\u0027 % (n) for n in names])"},{"line_number":75,"context_line":"    else:"},{"line_number":76,"context_line":"        return data[\u0027metrics\u0027][0][\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_da24b6c8","line":73,"range":{"start_line":71,"start_character":8,"end_line":73,"end_character":38},"updated":"2018-04-12 07:54:26.000000000","message":"nicer:\n\n  names \u003d set(metric[\u0027name\u0027] for metric in data[\u0027metrics\u0027])","commit_id":"f84891ec428ec3bd46c617abba4565aefcc7a1bb"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"48c0f5250a6e88b7f10084701a9402ee677deeba","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        names \u003d {}"},{"line_number":72,"context_line":"        for metric in data[\u0027metrics\u0027]:"},{"line_number":73,"context_line":"            names[metric[\u0027name\u0027]] \u003d \u0027\u0027"},{"line_number":74,"context_line":"        return \u0027, \u0027.join([\u0027%s\u0027 % (n) for n in names])"},{"line_number":75,"context_line":"    else:"},{"line_number":76,"context_line":"        return data[\u0027metrics\u0027][0][\u0027name\u0027]"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_75049b15","line":74,"range":{"start_line":74,"start_character":15,"end_line":74,"end_character":53},"updated":"2018-04-12 07:54:26.000000000","message":"Could be replaced with:\n\n  \u0027, \u0027.join(names)","commit_id":"f84891ec428ec3bd46c617abba4565aefcc7a1bb"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"10f1a7f02bffb07293d75c2c254d8706d17185e4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    return data[\u0027id\u0027]"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def show_metric_name(data):"},{"line_number":70,"context_line":"    names \u003d set(metric[\u0027name\u0027] for metric in data[\u0027metrics\u0027])"},{"line_number":71,"context_line":"    return \u0027, \u0027.join(names)"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_080ba58d","line":69,"range":{"start_line":69,"start_character":4,"end_line":69,"end_character":20},"updated":"2018-04-13 09:47:15.000000000","message":"nit: we should rename this to plural and update the column name as well.","commit_id":"47939f7997fcf7a89ce847af9174b0f768ad1314"}],"test-requirements.txt":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"10f1a7f02bffb07293d75c2c254d8706d17185e4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":8,"context_line":"django-nose\u003e\u003d1.4.4 # BSD"},{"line_number":9,"context_line":"mock\u003e\u003d2.0.0 # BSD"},{"line_number":10,"context_line":"mox3\u003e\u003d0.25.0 # Apache-2.0"},{"line_number":11,"context_line":"funcsigs\u003e\u003d1.0.0;python_version\u003d\u003d\u00272.7\u0027 or python_version\u003d\u003d\u00272.6\u0027 # Apache-2.0"},{"line_number":12,"context_line":"nodeenv\u003e\u003d0.9.4 # BSD"},{"line_number":13,"context_line":"nose\u003e\u003d1.3.7 # LGPL"}],"source_content_type":"text/plain","patch_set":2,"id":"bf659307_e8b991cb","line":10,"updated":"2018-04-13 09:47:15.000000000","message":"Please don\u0027t add dependency on mox. We want to get rid of it in OpenStack and we actually don\u0027t need it here. I know tox fails locally complaining about missing mox, but that\u0027s because older Horizon version gets installed. Zuul installs Horizon from current master and it should just pass fine in OpenStack CI without mox.","commit_id":"47939f7997fcf7a89ce847af9174b0f768ad1314"}]}
