)]}'
{"monitoring/overview/templates/overview/index.html":[{"author":{"_account_id":28062,"name":"Martin Chacon Piza","email":"martin@chaconpiza.com","username":"martinchacon"},"change_message_id":"03538c278a57f03ac91dc8b3ba87399b358ff956","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      \u003c/a\u003e"},{"line_number":44,"context_line":"      {% endfor %}"},{"line_number":45,"context_line":"      {% endif %}"},{"line_number":46,"context_line":"      {% if enable_log_management_button or enable_event_management_button and can_access_kibana  %}"},{"line_number":47,"context_line":"      \u003ca target\u003d\"dashboard\" href\u003d\"{% url \u0027horizon:monitoring:overview:kibana_proxy\u0027 url\u003d\u0027/\u0027 %}\" class\u003d\"btn btn-default\"\u003e"},{"line_number":48,"context_line":"          \u003cspan class\u003d\"fa fa-bar-chart\"\u003e\u003c/span\u003e"},{"line_number":49,"context_line":"                {% if enable_log_management_button %}"}],"source_content_type":"text/html","patch_set":4,"id":"3f79a3b5_cf4d7e3d","line":46,"range":{"start_line":46,"start_character":6,"end_line":46,"end_character":100},"updated":"2018-10-17 14:41:59.000000000","message":"The Logical operator \u0027and\u0027 has higher precedence than \u0027or\u0027.\n\nThis sentence leads into a bug when the log_management_button is enable but user doesn\u0027t has permission to access Kibana.\n\nThis issue can not be solved by adding parenthesis, because it is a Django template [1]\n\nAlthough is possible to fix it in one logical sentence:\n\n(a or b) and c\nnot ( not ((a or b) and c) )\nnot ( not (a or b) or not c )\nnot ( not a and not b or not c )\n\nIn this case:\n\n{% if not enable_log_management_button and not enable_event_management_button or not can_access_kibana %}\n{% else %}\n\u003cPrint the button\u003e\n{% endif %}\n\n... or just use nested ifs.\n\n[1] https://docs.djangoproject.com/en/dev/ref/templates/builtins/?from\u003dolddocs#complex-expressions","commit_id":"b44f766f8d718bdab78a9668d66b9d25436b720a"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"9e01a121209ffb7f59d45c738461591d635dce5c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      \u003c/a\u003e"},{"line_number":44,"context_line":"      {% endfor %}"},{"line_number":45,"context_line":"      {% endif %}"},{"line_number":46,"context_line":"      {% if enable_log_management_button or enable_event_management_button and can_access_kibana  %}"},{"line_number":47,"context_line":"      \u003ca target\u003d\"dashboard\" href\u003d\"{% url \u0027horizon:monitoring:overview:kibana_proxy\u0027 url\u003d\u0027/\u0027 %}\" class\u003d\"btn btn-default\"\u003e"},{"line_number":48,"context_line":"          \u003cspan class\u003d\"fa fa-bar-chart\"\u003e\u003c/span\u003e"},{"line_number":49,"context_line":"                {% if enable_log_management_button %}"}],"source_content_type":"text/html","patch_set":4,"id":"3f79a3b5_9befb3f9","line":46,"range":{"start_line":46,"start_character":6,"end_line":46,"end_character":100},"in_reply_to":"3f79a3b5_cf4d7e3d","updated":"2018-10-18 13:02:54.000000000","message":"Done","commit_id":"b44f766f8d718bdab78a9668d66b9d25436b720a"}]}
