)]}'
{"id":"openstack%2Fmonasca-ui~666941","triplet_id":"openstack%2Fmonasca-ui~master~I617a0c609450bf015ddf6e98fd672723a2660071","project":"openstack/monasca-ui","branch":"master","topic":"hidegraph","hashtags":[],"change_id":"I617a0c609450bf015ddf6e98fd672723a2660071","subject":"Hide Graph Metric action of alarm when Grafana is not available","status":"MERGED","created":"2019-06-22 02:18:02.000000000","updated":"2019-09-23 17:31:11.000000000","submitted":"2019-09-18 08:45:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":11,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"666941-1568796325793-4b597bb9","meta_rev_id":"fc96263e59234b0a0134ae750799f2ceb34a1460","_number":666941,"virtual_id_number":666941,"owner":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":30177,"name":"Ethan Apodaca","email":"eapodaca@suse.com","username":"eapodaca"},{"value":0,"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},{"value":0,"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":6825,"name":"Gary W. Smith","email":"garysmith123@gmail.com","username":"gary-w-smith"},{"value":0,"_account_id":12156,"name":"Jeremy Moffitt","email":"jmoffitt@suse.com","username":"jmoffitt"},{"value":0,"_account_id":10684,"name":"Mohan Seri","email":"mohan.seri@hp.com","username":"serim"},{"value":2,"date":"2019-09-18 08:45:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},{"value":0,"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"all":[{"value":0,"_account_id":30177,"name":"Ethan Apodaca","email":"eapodaca@suse.com","username":"eapodaca"},{"value":0,"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},{"value":0,"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":6825,"name":"Gary W. Smith","email":"garysmith123@gmail.com","username":"gary-w-smith"},{"value":0,"_account_id":12156,"name":"Jeremy Moffitt","email":"jmoffitt@suse.com","username":"jmoffitt"},{"value":0,"_account_id":10684,"name":"Mohan Seri","email":"mohan.seri@hp.com","username":"serim"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-09-16 08:39:26.000000000","_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},{"value":0,"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"all":[{"value":0,"_account_id":30177,"name":"Ethan Apodaca","email":"eapodaca@suse.com","username":"eapodaca"},{"value":0,"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},{"value":0,"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":6825,"name":"Gary W. Smith","email":"garysmith123@gmail.com","username":"gary-w-smith"},{"value":0,"_account_id":12156,"name":"Jeremy Moffitt","email":"jmoffitt@suse.com","username":"jmoffitt"},{"value":0,"_account_id":10684,"name":"Mohan Seri","email":"mohan.seri@hp.com","username":"serim"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-09-18 08:33:43.000000000","_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},{"value":0,"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":6825,"name":"Gary W. Smith","email":"garysmith123@gmail.com","username":"gary-w-smith"},{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},{"_account_id":10684,"name":"Mohan Seri","email":"mohan.seri@hp.com","username":"serim"},{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},{"_account_id":12156,"name":"Jeremy Moffitt","email":"jmoffitt@suse.com","username":"jmoffitt"},{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30177,"name":"Ethan Apodaca","email":"eapodaca@suse.com","username":"eapodaca"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-22 02:20:06.000000000","updated_by":{"_account_id":12156,"name":"Jeremy Moffitt","email":"jmoffitt@suse.com","username":"jmoffitt"},"reviewer":{"_account_id":12156,"name":"Jeremy Moffitt","email":"jmoffitt@suse.com","username":"jmoffitt"},"state":"REVIEWER"},{"updated":"2019-06-22 02:20:16.000000000","updated_by":{"_account_id":10684,"name":"Mohan Seri","email":"mohan.seri@hp.com","username":"serim"},"reviewer":{"_account_id":10684,"name":"Mohan Seri","email":"mohan.seri@hp.com","username":"serim"},"state":"REVIEWER"},{"updated":"2019-06-22 02:20:53.000000000","updated_by":{"_account_id":6825,"name":"Gary W. Smith","email":"garysmith123@gmail.com","username":"gary-w-smith"},"reviewer":{"_account_id":6825,"name":"Gary W. Smith","email":"garysmith123@gmail.com","username":"gary-w-smith"},"state":"REVIEWER"},{"updated":"2019-06-22 02:21:03.000000000","updated_by":{"_account_id":30177,"name":"Ethan Apodaca","email":"eapodaca@suse.com","username":"eapodaca"},"reviewer":{"_account_id":30177,"name":"Ethan Apodaca","email":"eapodaca@suse.com","username":"eapodaca"},"state":"REVIEWER"},{"updated":"2019-06-24 18:47:54.000000000","updated_by":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"reviewer":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"state":"REVIEWER"},{"updated":"2019-06-24 20:16:25.000000000","updated_by":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"reviewer":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"state":"REVIEWER"},{"updated":"2019-09-13 12:23:34.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2019-09-18 08:33:43.000000000","updated_by":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"reviewer":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"state":"REVIEWER"},{"updated":"2019-09-18 08:45:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8e5589988f68e18ef7676991b655dc3dde8231d8","author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"date":"2019-06-22 02:18:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d374bd5640ef9d9461dac145abdffde54291433a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-22 02:38:04.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/41/666941/1/check/openstack-tox-cover/c1a6d34/cover/ : SUCCESS in 6m 04s\n- openstack-tox-lower-constraints http://logs.openstack.org/41/666941/1/check/openstack-tox-lower-constraints/6d7d4dd/ : SUCCESS in 6m 06s\n- openstack-tox-pep8 http://logs.openstack.org/41/666941/1/check/openstack-tox-pep8/564af15/ : FAILURE in 6m 07s\n- openstack-tox-py27 http://logs.openstack.org/41/666941/1/check/openstack-tox-py27/39c6e66/ : SUCCESS in 5m 21s\n- openstack-tox-py36 http://logs.openstack.org/41/666941/1/check/openstack-tox-py36/7850149/ : SUCCESS in 5m 30s","accounts_in_message":[],"_revision_number":1},{"id":"89a2fac70543892f6913eba97ef405b839f531cc","author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"date":"2019-06-24 18:47:11.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"83aeb435b391e5c61df196292c77d97d35db306d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-24 18:58:31.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/41/666941/2/check/openstack-tox-cover/3d17163/cover/ : SUCCESS in 5m 45s\n- openstack-tox-lower-constraints http://logs.openstack.org/41/666941/2/check/openstack-tox-lower-constraints/0fca0d2/ : SUCCESS in 4m 56s\n- openstack-tox-pep8 http://logs.openstack.org/41/666941/2/check/openstack-tox-pep8/e1583f2/ : SUCCESS in 4m 34s\n- openstack-tox-py27 http://logs.openstack.org/41/666941/2/check/openstack-tox-py27/3ebbeb5/ : SUCCESS in 4m 13s\n- openstack-tox-py36 http://logs.openstack.org/41/666941/2/check/openstack-tox-py36/514e4c2/ : SUCCESS in 4m 26s","accounts_in_message":[],"_revision_number":2},{"id":"bff5079b0cc741c6d3df962e4416078fa370ca03","author":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"date":"2019-06-24 20:16:25.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)\n\nLooks good, just a minor nit.","accounts_in_message":[],"_revision_number":2},{"id":"f3575a09d8b4f1bc1d291689eec3f25ccb4504e9","author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"date":"2019-06-24 20:24:51.000000000","message":"Patch Set 2:\n\n(1 comment)\n\n@Joseph, good catch, thanks!","accounts_in_message":[],"_revision_number":2},{"id":"9014dc846a1f04a39548a785c9b415348b71e4a5","author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"date":"2019-06-24 20:25:48.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ed872638980a5aef74e76872bcd9e18906faf518","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-24 20:47:24.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/41/666941/3/check/openstack-tox-cover/976c2af/cover/ : SUCCESS in 5m 28s\n- openstack-tox-lower-constraints http://logs.openstack.org/41/666941/3/check/openstack-tox-lower-constraints/db2bb21/ : SUCCESS in 4m 49s\n- openstack-tox-pep8 http://logs.openstack.org/41/666941/3/check/openstack-tox-pep8/4fe1412/ : SUCCESS in 4m 05s\n- openstack-tox-py27 http://logs.openstack.org/41/666941/3/check/openstack-tox-py27/fb77287/ : SUCCESS in 4m 37s\n- openstack-tox-py36 http://logs.openstack.org/41/666941/3/check/openstack-tox-py36/89da35e/ : SUCCESS in 4m 21s","accounts_in_message":[],"_revision_number":3},{"id":"514aa29d132604f0f7ba9f79035dcd9c5b81f40f","author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"date":"2019-06-25 14:05:07.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"a58053df45f3752ad853ca6dc4c9f93da3d2a28b","author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"date":"2019-06-25 23:40:00.000000000","message":"Patch Set 3:\n\n(1 comment)\n\n@Witold thanks for the review, please see my question in-line.","accounts_in_message":[],"_revision_number":3},{"id":"37d8654063e3185d17f2ca6781ec266081f5dd3e","author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"date":"2019-06-26 09:37:02.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"666cda7587ff8baf7e6c14415487c5e4ce7492ea","author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"date":"2019-07-09 16:32:43.000000000","message":"Patch Set 3:\n\n\u003e (1 comment)\n\n@Witold,  GRAFANA_URL was considered at first, but in alarms/tables.py there is a fallback in get_link_url for older version of grafana integration when GRAFANA_URL is not set. I guess we don\u0027t need to care about Grafana older version anymore? Please advice. Thanks!","accounts_in_message":[],"_revision_number":3},{"id":"5fba47659cda431153bf40aec80746469d7fc43f","author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"date":"2019-07-10 09:19:42.000000000","message":"Patch Set 3:\n\n\u003e @Witold,  GRAFANA_URL was considered at first, but in\n \u003e alarms/tables.py there is a fallback in get_link_url for older\n \u003e version of grafana integration when GRAFANA_URL is not set. I guess\n \u003e we don\u0027t need to care about Grafana older version anymore? Please\n \u003e advice. Thanks!\n\nI think it\u0027s safe to assume that Grafana 4 is the oldest supported version. From my understanding it requires `GRAFANA_URL` set.","accounts_in_message":[],"_revision_number":3},{"id":"838d9c166df359c067826598ac48a53f838a99b6","author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"date":"2019-07-10 22:29:17.000000000","message":"Patch Set 3:\n\n\u003e \u003e @Witold,  GRAFANA_URL was considered at first, but in\n \u003e \u003e alarms/tables.py there is a fallback in get_link_url for older\n \u003e \u003e version of grafana integration when GRAFANA_URL is not set. I\n \u003e guess\n \u003e \u003e we don\u0027t need to care about Grafana older version anymore? Please\n \u003e \u003e advice. Thanks!\n \u003e \n \u003e I think it\u0027s safe to assume that Grafana 4 is the oldest supported\n \u003e version. From my understanding it requires `GRAFANA_URL` set.\n\nThat sounds good to me. I will try GRAFANA_URL. Thanks!","accounts_in_message":[],"_revision_number":3},{"id":"695ed7635d011cb926e15c3dabaee89dfa68fe40","author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"date":"2019-08-02 18:16:16.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"05129069c97d0f57791f266ce9c49120af0196f3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-02 18:26:54.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://logs.opendev.org/41/666941/4/check/openstack-tox-cover/aa908e3/cover/ : SUCCESS in 5m 50s\n- openstack-tox-lower-constraints https://logs.opendev.org/41/666941/4/check/openstack-tox-lower-constraints/1fb7914/ : SUCCESS in 5m 34s\n- openstack-tox-pep8 https://logs.opendev.org/41/666941/4/check/openstack-tox-pep8/f28ce49/ : SUCCESS in 4m 50s\n- openstack-tox-py27 https://logs.opendev.org/41/666941/4/check/openstack-tox-py27/e09256d/ : SUCCESS in 5m 07s\n- openstack-tox-py36 https://logs.opendev.org/41/666941/4/check/openstack-tox-py36/f02e041/ : SUCCESS in 4m 49s\n- openstack-tox-py37 https://logs.opendev.org/41/666941/4/check/openstack-tox-py37/c2ea71d/ : SUCCESS in 5m 30s","accounts_in_message":[],"_revision_number":4},{"id":"7e32280ec3926dceec9e407575d5eed0ae5057be","author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"date":"2019-08-05 10:44:13.000000000","message":"Patch Set 4: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"dd10c5d0f0ddf1219b3b70b031f581be94e6665b","author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"date":"2019-08-15 23:20:53.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"5ab7f693e5e2c94741c429dfe78f084a554795ee","author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"date":"2019-08-16 00:16:04.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"1467b05853f80625ffc9a70bb3cb323dfbae6a5c","author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"date":"2019-08-16 01:15:32.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"81bc987827db992830d28a8b70fb3de6a2e9c8c0","author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"date":"2019-08-16 22:56:27.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"d6d2e6a5c47eab68e987846b2bdb63268771bf40","author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"date":"2019-08-16 23:05:09.000000000","message":"Patch Set 5:\n\nI updated to handle the cases when GRAFANA_URL set in monasca ui local_settings or horizon(django) local_settings","accounts_in_message":[],"_revision_number":5},{"id":"cc7a10c3b10a9323c9cbbdb55db51651c6bc28f8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 23:07:02.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/39b2dcd7b25542a29b7dc2101d714ba8 : SUCCESS in 8m 11s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ed08fd64053542859beb7b6d0fa34060 : SUCCESS in 5m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f582f64c76bd4513981aeae6fb4a11d9 : SUCCESS in 4m 12s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/8b550e53ed6c4067b0e7abe2ae69b8be : SUCCESS in 5m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fdcd9f6774ea48d0922eae5dda8c8492 : SUCCESS in 4m 46s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/0ad7c19f39034bf9bd9f93ca4d92d656 : SUCCESS in 5m 19s","accounts_in_message":[],"_revision_number":5},{"id":"f1b034e00efb0bcc9586109a9cef82d37a7a7029","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2019-09-13 12:23:34.000000000","message":"Patch Set 5: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"4fc1386817d306bff28e15f7e082ff6618185671","author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"date":"2019-09-13 16:54:41.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"0905c476fcbb9164de90798c74655cf9f08b88cd","author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"date":"2019-09-13 18:35:55.000000000","message":"Patch Set 5:\n\n@Ivan and @Witold I was puzzled why it didn\u0027t work for Witold but I don\u0027t have devstack integrated with monitoring and grafana.... I only have QA real cloud to try.  Thanks for the review, I will update.","accounts_in_message":[],"_revision_number":5},{"id":"f7576e0e4a1cf571a30aa18eae196b2ee606fa98","author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"date":"2019-09-13 18:48:13.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"39d376a27ee16d596d643d571046fbf648b08abe","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-13 19:01:19.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8bf9b76f872b48da97c9583a92395c9a : SUCCESS in 7m 21s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4c4365172d0344239d64905e2dc7fb70 : SUCCESS in 5m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/abf155559c624345a980633cc2905dc6 : SUCCESS in 3m 34s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/1ff572bd0228408da96b2a5aada00ba4 : SUCCESS in 4m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ec105560939c407a8d1d2540ce92433c : SUCCESS in 4m 05s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/f9008b90a7c7424d8ecbc9a23175c7a8 : SUCCESS in 6m 00s","accounts_in_message":[],"_revision_number":6},{"id":"775a32c6874a19cc3c50c508fbc9486638af79fa","author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"date":"2019-09-16 08:39:26.000000000","message":"Patch Set 6: Code-Review+2","accounts_in_message":[],"_revision_number":6},{"id":"33a8dd44337829dc9faa9a65ba609b3d0dddf2c5","author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"date":"2019-09-16 13:38:12.000000000","message":"Patch Set 6:\n\nHave posted follow-up fixes in https://review.opendev.org/682321 and https://review.opendev.org/682325","accounts_in_message":[],"_revision_number":6},{"id":"b794a289762168419ed77ada019ff7091f4c0788","author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"date":"2019-09-18 08:33:43.000000000","message":"Patch Set 6: Workflow+1","accounts_in_message":[],"_revision_number":6},{"id":"b6c8da7f4a7d880645362046d6ed80a5e1d661c9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 08:33:54.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":6},{"id":"3022642d34f43e0484978e8feac22e082f881e27","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 08:45:25.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f3302a715bdd47caacb6d44ad301c53d : SUCCESS in 5m 20s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0aa371c9d04d4cd8baa5ed1ee8064144 : SUCCESS in 4m 23s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/275f9fba7ac84575a928cfb6a3b8cc41 : SUCCESS in 5m 01s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3fea9c9ba3eb4b47bea00f7e16399036 : SUCCESS in 4m 56s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/f388f5d8091c4321a80ca25f595ad223 : SUCCESS in 4m 10s","accounts_in_message":[],"_revision_number":6},{"id":"1ee0adc36705600409bb2670214d98b6ee853e4d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 08:45:25.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":6},{"id":"b530afbe8c86536591aca7b04427e0d34184dcb6","author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"date":"2019-09-18 21:11:10.000000000","message":"Patch Set 6: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit 9ba0b0dced015618eaf9493bbaf52501645aa0ea","accounts_in_message":[],"_revision_number":6},{"id":"0a9e2dfc25a9ebffd3265f24f1dafc6bd1226dc9","author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"date":"2019-09-23 17:31:11.000000000","message":"Patch Set 6: Cherry Picked\n\nThis patchset was cherry picked to branch stable/rocky as commit 8187d760c0f4f161bb5581398e13a52fff023f26","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"43f285394fc9a4ff54df038f748c1b488e607b90","revisions":{"ab74e844b518b0af818af9f80bdf17bc3704eea3":{"kind":"REWORK","_number":1,"created":"2019-06-22 02:18:02.000000000","uploader":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"ref":"refs/changes/41/666941/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/monasca-ui","ref":"refs/changes/41/666941/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/1"}}},"commit":{"parents":[{"commit":"6d1ac152a6ce00ae71e21147b49a1f3ab2a75210","subject":"Update hacking version to latest","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/6d1ac152a6ce00ae71e21147b49a1f3ab2a75210"}]}],"author":{"name":"Gloria Gu","email":"gfgu@suse.com","date":"2019-06-22 01:26:46.000000000","tz":-420},"committer":{"name":"Gloria Gu","email":"gfgu@suse.com","date":"2019-06-22 02:12:24.000000000","tz":-420},"subject":"Hide Graph Metric action of alarm when Grafana is not available","message":"Hide Graph Metric action of alarm when Grafana is not available\n\nWhen Grafana integration is not available, click the action button of\nGraph Metric will go to a non-existing Grafana page.\n\nAdded logic to hide the Graph Metric button when Grafana integration\nis not avaialable. Also added unit tests for the changes.\n\nStory: 2005906\nTask: 34165\n\nChange-Id: I617a0c609450bf015ddf6e98fd672723a2660071\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/ab74e844b518b0af818af9f80bdf17bc3704eea3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/ab74e844b518b0af818af9f80bdf17bc3704eea3"}]},"branch":"refs/heads/master"},"5644c525f7a5a028a10c01be1f9e8bc13b2e78ae":{"kind":"REWORK","_number":2,"created":"2019-06-24 18:47:11.000000000","uploader":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"ref":"refs/changes/41/666941/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/monasca-ui","ref":"refs/changes/41/666941/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/2"}}},"commit":{"parents":[{"commit":"6d1ac152a6ce00ae71e21147b49a1f3ab2a75210","subject":"Update hacking version to latest","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/6d1ac152a6ce00ae71e21147b49a1f3ab2a75210"}]}],"author":{"name":"Gloria Gu","email":"gfgu@suse.com","date":"2019-06-22 01:26:46.000000000","tz":-420},"committer":{"name":"Gloria Gu","email":"gfgu@suse.com","date":"2019-06-24 18:46:56.000000000","tz":-420},"subject":"Hide Graph Metric action of alarm when Grafana is not available","message":"Hide Graph Metric action of alarm when Grafana is not available\n\nWhen Grafana integration is not available, click the action button of\nGraph Metric will go to a non-existing Grafana page.\n\nAdded logic to hide the Graph Metric button when Grafana integration\nis not avaialable. Also added unit tests for the changes.\n\nStory: 2005906\nTask: 34165\n\nChange-Id: I617a0c609450bf015ddf6e98fd672723a2660071\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/5644c525f7a5a028a10c01be1f9e8bc13b2e78ae"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/5644c525f7a5a028a10c01be1f9e8bc13b2e78ae"}]},"branch":"refs/heads/master"},"c52911385bf4b143f9bc36294e460d5deba6e4a6":{"kind":"REWORK","_number":3,"created":"2019-06-24 20:25:48.000000000","uploader":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"ref":"refs/changes/41/666941/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/monasca-ui","ref":"refs/changes/41/666941/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/3"}}},"commit":{"parents":[{"commit":"6d1ac152a6ce00ae71e21147b49a1f3ab2a75210","subject":"Update hacking version to latest","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/6d1ac152a6ce00ae71e21147b49a1f3ab2a75210"}]}],"author":{"name":"Gloria Gu","email":"gfgu@suse.com","date":"2019-06-22 01:26:46.000000000","tz":-420},"committer":{"name":"Gloria Gu","email":"gfgu@suse.com","date":"2019-06-24 20:25:17.000000000","tz":-420},"subject":"Hide Graph Metric action of alarm when Grafana is not available","message":"Hide Graph Metric action of alarm when Grafana is not available\n\nWhen Grafana integration is not available, click the action button of\nGraph Metric will go to a non-existing Grafana page.\n\nAdded logic to hide the Graph Metric button when Grafana integration\nis not avaialable. Also added unit tests for the changes.\n\nStory: 2005906\nTask: 34165\n\nChange-Id: I617a0c609450bf015ddf6e98fd672723a2660071\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/c52911385bf4b143f9bc36294e460d5deba6e4a6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/c52911385bf4b143f9bc36294e460d5deba6e4a6"}]},"branch":"refs/heads/master"},"4aff16addcd72611abb05c411f8fa8d0bce32233":{"kind":"REWORK","_number":4,"created":"2019-08-02 18:16:16.000000000","uploader":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"ref":"refs/changes/41/666941/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/monasca-ui","ref":"refs/changes/41/666941/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/4"}}},"commit":{"parents":[{"commit":"6d1ac152a6ce00ae71e21147b49a1f3ab2a75210","subject":"Update hacking version to latest","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/6d1ac152a6ce00ae71e21147b49a1f3ab2a75210"}]}],"author":{"name":"Gloria Gu","email":"gfgu@suse.com","date":"2019-06-22 01:26:46.000000000","tz":-420},"committer":{"name":"Gloria Gu","email":"gfgu@suse.com","date":"2019-08-02 18:15:50.000000000","tz":-420},"subject":"Hide Graph Metric action of alarm when Grafana is not available","message":"Hide Graph Metric action of alarm when Grafana is not available\n\nWhen Grafana integration is not available, click the action button of\nGraph Metric will go to a non-existing Grafana page.\n\nAdded logic to hide the Graph Metric button when Grafana integration\nis not avaialable. Also added unit tests for the changes.\n\nStory: 2005906\nTask: 34165\n\nChange-Id: I617a0c609450bf015ddf6e98fd672723a2660071\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/4aff16addcd72611abb05c411f8fa8d0bce32233"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/4aff16addcd72611abb05c411f8fa8d0bce32233"}]},"branch":"refs/heads/master"},"347b394f32b5d9fbb9213e058ea78e47a7f58e40":{"kind":"REWORK","_number":5,"created":"2019-08-16 22:56:27.000000000","uploader":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"ref":"refs/changes/41/666941/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/monasca-ui","ref":"refs/changes/41/666941/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/5"}}},"commit":{"parents":[{"commit":"6d1ac152a6ce00ae71e21147b49a1f3ab2a75210","subject":"Update hacking version to latest","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/6d1ac152a6ce00ae71e21147b49a1f3ab2a75210"}]}],"author":{"name":"Gloria Gu","email":"gfgu@suse.com","date":"2019-06-22 01:26:46.000000000","tz":-420},"committer":{"name":"Gloria Gu","email":"gfgu@suse.com","date":"2019-08-16 22:56:01.000000000","tz":-420},"subject":"Hide Graph Metric action of alarm when Grafana is not available","message":"Hide Graph Metric action of alarm when Grafana is not available\n\nWhen Grafana integration is not available, click the action button of\nGraph Metric will go to a non-existing Grafana page.\n\nAdded logic to hide the Graph Metric button when Grafana integration\nis not avaialable. Also added unit tests for the changes.\n\nStory: 2005906\nTask: 34165\n\nChange-Id: I617a0c609450bf015ddf6e98fd672723a2660071\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/347b394f32b5d9fbb9213e058ea78e47a7f58e40"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/347b394f32b5d9fbb9213e058ea78e47a7f58e40"}]},"branch":"refs/heads/master"},"43f285394fc9a4ff54df038f748c1b488e607b90":{"kind":"REWORK","_number":6,"created":"2019-09-13 18:48:13.000000000","uploader":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"ref":"refs/changes/41/666941/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/monasca-ui","ref":"refs/changes/41/666941/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/monasca-ui refs/changes/41/666941/6"}}},"commit":{"parents":[{"commit":"6d1ac152a6ce00ae71e21147b49a1f3ab2a75210","subject":"Update hacking version to latest","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/6d1ac152a6ce00ae71e21147b49a1f3ab2a75210"}]}],"author":{"name":"Gloria Gu","email":"gfgu@suse.com","date":"2019-06-22 01:26:46.000000000","tz":-420},"committer":{"name":"Gloria Gu","email":"gfgu@suse.com","date":"2019-09-13 18:47:44.000000000","tz":-420},"subject":"Hide Graph Metric action of alarm when Grafana is not available","message":"Hide Graph Metric action of alarm when Grafana is not available\n\nWhen Grafana integration is not available, click the action button of\nGraph Metric will go to a non-existing Grafana page.\n\nAdded logic to hide the Graph Metric button when Grafana integration\nis not avaialable. Also added unit tests for the changes.\n\nStory: 2005906\nTask: 34165\n\nChange-Id: I617a0c609450bf015ddf6e98fd672723a2660071\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/43f285394fc9a4ff54df038f748c1b488e607b90"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/43f285394fc9a4ff54df038f748c1b488e607b90"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}