)]}'
{"id":"openstack%2Fmonasca-ui~682321","triplet_id":"openstack%2Fmonasca-ui~master~I5cd66954ffb1169f3149cd6f705593efe3a15b13","project":"openstack/monasca-ui","branch":"master","topic":"django_settings","hashtags":[],"change_id":"I5cd66954ffb1169f3149cd6f705593efe3a15b13","subject":"Use django.conf.settings instead of local_settings","status":"MERGED","created":"2019-09-16 09:35:07.000000000","updated":"2019-09-30 12:58:35.000000000","submitted":"2019-09-30 12:58:35.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"682321-1569848315615-33733760","meta_rev_id":"86e685d62844b4536c1670254c6a8b762a4bac74","_number":682321,"virtual_id_number":682321,"owner":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},{"value":0,"_account_id":14123,"name":"Stefano Canepa","email":"sc@linux.it","username":"sc"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-09-30 12:58:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14123,"name":"Stefano Canepa","email":"sc@linux.it","username":"sc"},"recommended":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"all":[{"value":1,"date":"2019-09-18 15:35:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":1,"date":"2019-09-17 18:56:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},{"value":2,"date":"2019-09-30 12:07:55.000000000","_account_id":14123,"name":"Stefano Canepa","email":"sc@linux.it","username":"sc"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-09-30 12:48:24.000000000","_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"all":[{"value":0,"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},{"value":0,"_account_id":14123,"name":"Stefano Canepa","email":"sc@linux.it","username":"sc"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-09-30 12:48:24.000000000","_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},{"_account_id":14123,"name":"Stefano Canepa","email":"sc@linux.it","username":"sc"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-16 12:24:01.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2019-09-17 18:56:56.000000000","updated_by":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"reviewer":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"state":"REVIEWER"},{"updated":"2019-09-18 15:35:13.000000000","updated_by":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"reviewer":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"state":"REVIEWER"},{"updated":"2019-09-30 12:07:55.000000000","updated_by":{"_account_id":14123,"name":"Stefano Canepa","email":"sc@linux.it","username":"sc"},"reviewer":{"_account_id":14123,"name":"Stefano Canepa","email":"sc@linux.it","username":"sc"},"state":"REVIEWER"},{"updated":"2019-09-30 12:48:24.000000000","updated_by":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"reviewer":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"state":"REVIEWER"},{"updated":"2019-09-30 12:58:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e30a546a9e299d2a6abdd70a04ef49c0b521c4dd","author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"date":"2019-09-16 09:35:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"672f539c7e00a18e34422a721d5ade87daaa5b67","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-16 09:46:45.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ec2e48232a384b8cbe893bcf2033e5e5 : FAILURE in 7m 29s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/159e3571b30f41488e82006040d887ad : FAILURE in 5m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1195bb95a8154ef1bcb237d32fd36c12 : SUCCESS in 3m 38s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/433d9cc0955e4be8a4605f8310b4b4c6 : FAILURE in 4m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/181297786d6d4aa7b528c23348cc6c9b : FAILURE in 4m 37s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/917879fb7c1441be96328a2630648d31 : FAILURE in 4m 48s","accounts_in_message":[],"_revision_number":1},{"id":"e6dadfa7d31f18a0f68505e3b72992d64f6b60fe","author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"date":"2019-09-16 13:20:19.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"03ce21cc1d61c79b63ae4c3d007d9404675b23fa","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-16 13:34:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fccd239f24ae4c8c9aff19ed2525e588 : SUCCESS in 7m 07s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/bc7f789b102f4160bfdb072537057fa7 : SUCCESS in 5m 52s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0d76f15ba1df44ed8a5e2a2c650a68d5 : SUCCESS in 4m 52s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a2d2aa6c89354193be7b2003b031e86a : SUCCESS in 4m 35s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/14ad2f81b8484fcf97c6fd6c05ef83ae : SUCCESS in 5m 46s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/19d50756b8e1412e896bf7146ad27b83 : SUCCESS in 5m 38s","accounts_in_message":[],"_revision_number":2},{"id":"32a8ded09943b1405ef3b109e3d00617fc084983","author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"date":"2019-09-17 18:56:56.000000000","message":"Patch Set 2: Code-Review+1\n\nTried it, it works fine. LGTM","accounts_in_message":[],"_revision_number":2},{"id":"6400cc7323485b63ea85643e04db50917902a7e5","author":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"date":"2019-09-18 15:35:13.000000000","message":"Patch Set 2: Code-Review+1\n\nLooks good to me (though I haven\u0027t tested it myself)","accounts_in_message":[],"_revision_number":2},{"id":"0ace7a53232c3e723f7a7b8fceea459abdab9f63","author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"date":"2019-09-30 09:38:35.000000000","message":"Topic set to django_settings","accounts_in_message":[],"_revision_number":2},{"id":"fb52e668ead2aab1962b37e385b36423fb90c628","author":{"_account_id":14123,"name":"Stefano Canepa","email":"sc@linux.it","username":"sc"},"date":"2019-09-30 12:07:55.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"56e4481b482e58c72e9e27b0721db5592799cfd5","author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"date":"2019-09-30 12:48:24.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"e7df66a95dcc33b4fc54192ca19e6a624e92aee8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-30 12:48:35.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"2b946b6676ad61d0775b52e7c59e201295c06eeb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-30 12:58:35.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"86e685d62844b4536c1670254c6a8b762a4bac74","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-30 12:58:35.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4a5c5d1ea7804268b78018ea7f6ca3fc : SUCCESS in 5m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/41f9ffb4d9724a81b173a78f61d80a7d : SUCCESS in 4m 30s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/f8427ee1ba2a49a5b9ca05f00299c1d2 : SUCCESS in 4m 17s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7fb6a43f9c42427b954e000c7a0a1dd0 : SUCCESS in 4m 10s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/aa8e71c9a4e9427aab5de627462e0714 : SUCCESS in 4m 45s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"855a1f2fc5943e4c742ea69b2adebf402f0808f4","revisions":{"b97204c6180e0c2171940829cc2f72a2a59c6b29":{"kind":"REWORK","_number":1,"created":"2019-09-16 09:35:07.000000000","uploader":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"ref":"refs/changes/21/682321/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/monasca-ui","ref":"refs/changes/21/682321/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/21/682321/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/21/682321/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/21/682321/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/monasca-ui refs/changes/21/682321/1"}}},"commit":{"parents":[{"commit":"f0231ab00f7e352fa8a9637a3e3a887f0d6ce374","subject":"Add Python 3 Train unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/f0231ab00f7e352fa8a9637a3e3a887f0d6ce374"}]}],"author":{"name":"Witek Bedyk","email":"witold.bedyk@suse.com","date":"2019-09-16 09:20:45.000000000","tz":120},"committer":{"name":"Witek Bedyk","email":"witold.bedyk@suse.com","date":"2019-09-16 09:34:32.000000000","tz":120},"subject":"Use django.conf.settings instead of local_settings","message":"Use django.conf.settings instead of local_settings\n\nThe default and preferred way of modifying the settings of Horizon\nplugin is to add a configuration file to\nopenstack_dashboard/local/local_settings.d/ directory [1]. For that to\nwork we should use the settings from django.conf.settings and not from\nmonitoring.config.local_settings.\n\n[1] https://docs.openstack.org/horizon/latest/configuration/settings.html\n\nStory: 2006556\nTask: 36644\n\nChange-Id: I5cd66954ffb1169f3149cd6f705593efe3a15b13\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/b97204c6180e0c2171940829cc2f72a2a59c6b29"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/b97204c6180e0c2171940829cc2f72a2a59c6b29"}]},"branch":"refs/heads/master"},"855a1f2fc5943e4c742ea69b2adebf402f0808f4":{"kind":"REWORK","_number":2,"created":"2019-09-16 13:20:19.000000000","uploader":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"ref":"refs/changes/21/682321/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/monasca-ui","ref":"refs/changes/21/682321/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/21/682321/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/21/682321/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/monasca-ui refs/changes/21/682321/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/monasca-ui refs/changes/21/682321/2"}}},"commit":{"parents":[{"commit":"f0231ab00f7e352fa8a9637a3e3a887f0d6ce374","subject":"Add Python 3 Train unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/f0231ab00f7e352fa8a9637a3e3a887f0d6ce374"}]}],"author":{"name":"Witek Bedyk","email":"witold.bedyk@suse.com","date":"2019-09-16 09:20:45.000000000","tz":120},"committer":{"name":"Witek Bedyk","email":"witold.bedyk@suse.com","date":"2019-09-16 13:19:32.000000000","tz":120},"subject":"Use django.conf.settings instead of local_settings","message":"Use django.conf.settings instead of local_settings\n\nThe default and preferred way of modifying the settings of Horizon\nplugin is to add a configuration file to\nopenstack_dashboard/local/local_settings.d/ directory [1]. For that to\nwork we should use the settings from django.conf.settings and not from\nmonitoring.config.local_settings.\n\n[1] https://docs.openstack.org/horizon/latest/configuration/settings.html\n\nStory: 2006556\nTask: 36644\n\nChange-Id: I5cd66954ffb1169f3149cd6f705593efe3a15b13\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/855a1f2fc5943e4c742ea69b2adebf402f0808f4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-ui/commit/855a1f2fc5943e4c742ea69b2adebf402f0808f4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}