)]}'
{"monitoring/alarmdefs/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c9407fd275d2141defa51f619e24d1592d1b2288","unresolved":false,"context_lines":[{"line_number":268,"context_line":"            messages.success(request,"},{"line_number":269,"context_line":"                             _(\u0027Alarm definition has been updated.\u0027))"},{"line_number":270,"context_line":"        except Exception:"},{"line_number":271,"context_line":"            exceptions.handle(request)"},{"line_number":272,"context_line":"            return False"},{"line_number":273,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_97ef8e1b","line":271,"updated":"2020-09-12 01:33:15.000000000","message":"It would be nice to have a proper message.","commit_id":"d75b2f223f2271074dc2bfb2ae438929111ca534"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"d2ad7e094222a28d40fbd998817f43fc97379a8d","unresolved":false,"context_lines":[{"line_number":268,"context_line":"            messages.success(request,"},{"line_number":269,"context_line":"                             _(\u0027Alarm definition has been updated.\u0027))"},{"line_number":270,"context_line":"        except Exception:"},{"line_number":271,"context_line":"            exceptions.handle(request)"},{"line_number":272,"context_line":"            return False"},{"line_number":273,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_4bff0a65","line":271,"in_reply_to":"9f560f44_97ef8e1b","updated":"2020-09-14 05:14:55.000000000","message":"Done.","commit_id":"d75b2f223f2271074dc2bfb2ae438929111ca534"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a42e3c7a7eeb20303a5a988023971c8d5f2a00e0","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                             _(\u0027Alarm definition has been updated.\u0027))"},{"line_number":270,"context_line":"        except Exception:"},{"line_number":271,"context_line":"            exceptions.handle(request,"},{"line_number":272,"context_line":"                              _(\u0027Unable to retrieve alarm definition.\u0027))"},{"line_number":273,"context_line":"            return False"},{"line_number":274,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_684598b4","line":272,"range":{"start_line":272,"start_character":43,"end_line":272,"end_character":51},"updated":"2020-09-15 09:34:56.000000000","message":"retrieve? update? This is part of EditAlarmForm.","commit_id":"fb7fa4c5fbcd61ce2aef6f4ab2c5225781c81413"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"6ce4763a14ae844a04c210cd696a4bc053b83f10","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                             _(\u0027Alarm definition has been updated.\u0027))"},{"line_number":270,"context_line":"        except Exception:"},{"line_number":271,"context_line":"            exceptions.handle(request,"},{"line_number":272,"context_line":"                              _(\u0027Unable to retrieve alarm definition.\u0027))"},{"line_number":273,"context_line":"            return False"},{"line_number":274,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_41c85d55","line":272,"range":{"start_line":272,"start_character":43,"end_line":272,"end_character":51},"in_reply_to":"9f560f44_684598b4","updated":"2020-09-16 08:20:11.000000000","message":"done.","commit_id":"fb7fa4c5fbcd61ce2aef6f4ab2c5225781c81413"}],"monitoring/alarmdefs/workflows.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c9407fd275d2141defa51f619e24d1592d1b2288","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                undetermined_actions\u003dcontext[\u0027undetermined_actions\u0027],"},{"line_number":223,"context_line":"            )"},{"line_number":224,"context_line":"        except Exception:"},{"line_number":225,"context_line":"            exceptions.handle(request, escalate\u003dTrue)"},{"line_number":226,"context_line":"            return False"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_d7dc6675","line":225,"updated":"2020-09-12 01:33:15.000000000","message":"It is better to provide a proper message.","commit_id":"d75b2f223f2271074dc2bfb2ae438929111ca534"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"d2ad7e094222a28d40fbd998817f43fc97379a8d","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                undetermined_actions\u003dcontext[\u0027undetermined_actions\u0027],"},{"line_number":223,"context_line":"            )"},{"line_number":224,"context_line":"        except Exception:"},{"line_number":225,"context_line":"            exceptions.handle(request, escalate\u003dTrue)"},{"line_number":226,"context_line":"            return False"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_cbeafa9d","line":225,"in_reply_to":"9f560f44_d7dc6675","updated":"2020-09-14 05:14:55.000000000","message":"Done.","commit_id":"d75b2f223f2271074dc2bfb2ae438929111ca534"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a42e3c7a7eeb20303a5a988023971c8d5f2a00e0","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            )"},{"line_number":224,"context_line":"        except Exception:"},{"line_number":225,"context_line":"            exceptions.handle(request,"},{"line_number":226,"context_line":"                              _(\u0027Unable to retrieve alarm definition.\u0027),"},{"line_number":227,"context_line":"                              escalate\u003dTrue)"},{"line_number":228,"context_line":"            return False"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_484254ad","line":226,"range":{"start_line":226,"start_character":43,"end_line":226,"end_character":51},"updated":"2020-09-15 09:34:56.000000000","message":"retrieve? not \"create\"?","commit_id":"fb7fa4c5fbcd61ce2aef6f4ab2c5225781c81413"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"6ce4763a14ae844a04c210cd696a4bc053b83f10","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            )"},{"line_number":224,"context_line":"        except Exception:"},{"line_number":225,"context_line":"            exceptions.handle(request,"},{"line_number":226,"context_line":"                              _(\u0027Unable to retrieve alarm definition.\u0027),"},{"line_number":227,"context_line":"                              escalate\u003dTrue)"},{"line_number":228,"context_line":"            return False"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_01af857d","line":226,"range":{"start_line":226,"start_character":43,"end_line":226,"end_character":51},"in_reply_to":"9f560f44_484254ad","updated":"2020-09-16 08:20:11.000000000","message":"done.","commit_id":"fb7fa4c5fbcd61ce2aef6f4ab2c5225781c81413"}],"monitoring/alarms/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a42e3c7a7eeb20303a5a988023971c8d5f2a00e0","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        alarms \u003d api.monitor.alarm_list(request)"},{"line_number":96,"context_line":"    except Exception as e:"},{"line_number":97,"context_line":"        messages.error(request,"},{"line_number":98,"context_line":"                       _(\u0027Unable to list alarms: %s\u0027) % str(e))"},{"line_number":99,"context_line":"        alarms \u003d []"},{"line_number":100,"context_line":"    alarms_by_service \u003d {}"},{"line_number":101,"context_line":"    for a in alarms:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_c884a4d6","line":98,"updated":"2020-09-15 09:34:56.000000000","message":"Why not exceptions.handle() without redirect?","commit_id":"fb7fa4c5fbcd61ce2aef6f4ab2c5225781c81413"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b33659b1e880f0e560d5dd2b14630383a55157d1","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        alarms \u003d api.monitor.alarm_list(request)"},{"line_number":96,"context_line":"    except Exception as e:"},{"line_number":97,"context_line":"        messages.error(request,"},{"line_number":98,"context_line":"                       _(\u0027Unable to list alarms: %s\u0027) % str(e))"},{"line_number":99,"context_line":"        alarms \u003d []"},{"line_number":100,"context_line":"    alarms_by_service \u003d {}"},{"line_number":101,"context_line":"    for a in alarms:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_bfec9229","line":98,"in_reply_to":"9f560f44_81a9d57d","updated":"2020-09-22 05:02:36.000000000","message":"The goal of the blueprint is not to improve exceptions.handle only. The goal is to provide error details to user in a smarter and unified way.\n\nThis messages.error() concatenates an exception message directly. This is what you improved in exceptions.handle() https://review.opendev.org/#/c/708069/.\n\nWhile I believe this is a part of the blueprint goal, but I am okay if you just cover exceptions.handle().","commit_id":"fb7fa4c5fbcd61ce2aef6f4ab2c5225781c81413"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"6ce4763a14ae844a04c210cd696a4bc053b83f10","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        alarms \u003d api.monitor.alarm_list(request)"},{"line_number":96,"context_line":"    except Exception as e:"},{"line_number":97,"context_line":"        messages.error(request,"},{"line_number":98,"context_line":"                       _(\u0027Unable to list alarms: %s\u0027) % str(e))"},{"line_number":99,"context_line":"        alarms \u003d []"},{"line_number":100,"context_line":"    alarms_by_service \u003d {}"},{"line_number":101,"context_line":"    for a in alarms:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_81a9d57d","line":98,"in_reply_to":"9f560f44_c884a4d6","updated":"2020-09-16 08:20:11.000000000","message":"Sorry, what you mean. My change https://review.opendev.org/#/c/708069/ only covers exceptions.handle() function not messages.error.","commit_id":"fb7fa4c5fbcd61ce2aef6f4ab2c5225781c81413"}],"monitoring/notifications/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c9407fd275d2141defa51f619e24d1592d1b2288","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                               \u0027successfully.\u0027))"},{"line_number":121,"context_line":"        except Exception:"},{"line_number":122,"context_line":"            exceptions.handle(request,"},{"line_number":123,"context_line":"                              _(\u0027Unable to create the notification \u0027"},{"line_number":124,"context_line":"                                \u0027method.\u0027))"},{"line_number":125,"context_line":"            return False"},{"line_number":126,"context_line":"        return True"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b7d7324f","line":124,"range":{"start_line":123,"start_character":30,"end_line":124,"end_character":43},"updated":"2020-09-12 01:33:15.000000000","message":"It can be a single line.","commit_id":"d75b2f223f2271074dc2bfb2ae438929111ca534"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"d2ad7e094222a28d40fbd998817f43fc97379a8d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                               \u0027successfully.\u0027))"},{"line_number":121,"context_line":"        except Exception:"},{"line_number":122,"context_line":"            exceptions.handle(request,"},{"line_number":123,"context_line":"                              _(\u0027Unable to create the notification \u0027"},{"line_number":124,"context_line":"                                \u0027method.\u0027))"},{"line_number":125,"context_line":"            return False"},{"line_number":126,"context_line":"        return True"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_2b2bb6ea","line":124,"range":{"start_line":123,"start_character":30,"end_line":124,"end_character":43},"in_reply_to":"9f560f44_b7d7324f","updated":"2020-09-14 05:14:55.000000000","message":"Done.","commit_id":"d75b2f223f2271074dc2bfb2ae438929111ca534"}],"monitoring/overview/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c9407fd275d2141defa51f619e24d1592d1b2288","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        alarms \u003d api.monitor.alarm_list(request)"},{"line_number":191,"context_line":"    except Exception:"},{"line_number":192,"context_line":"        messages.error(request,"},{"line_number":193,"context_line":"                       _(\u0027Unable to list alarms: %s\u0027))"},{"line_number":194,"context_line":"        alarms \u003d []"},{"line_number":195,"context_line":"    alarms_by_service \u003d {}"},{"line_number":196,"context_line":"    for a in alarms:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_97c82ea8","line":193,"range":{"start_line":193,"start_character":47,"end_line":193,"end_character":51},"updated":"2020-09-12 01:33:15.000000000","message":"Remove it.","commit_id":"d75b2f223f2271074dc2bfb2ae438929111ca534"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"d2ad7e094222a28d40fbd998817f43fc97379a8d","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        alarms \u003d api.monitor.alarm_list(request)"},{"line_number":191,"context_line":"    except Exception:"},{"line_number":192,"context_line":"        messages.error(request,"},{"line_number":193,"context_line":"                       _(\u0027Unable to list alarms: %s\u0027))"},{"line_number":194,"context_line":"        alarms \u003d []"},{"line_number":195,"context_line":"    alarms_by_service \u003d {}"},{"line_number":196,"context_line":"    for a in alarms:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_6b312e59","line":193,"range":{"start_line":193,"start_character":47,"end_line":193,"end_character":51},"in_reply_to":"9f560f44_97c82ea8","updated":"2020-09-14 05:14:55.000000000","message":"It is message.error not exception.handle function so I have changed this file to master as no changes are required here.","commit_id":"d75b2f223f2271074dc2bfb2ae438929111ca534"}]}