)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"19f3e7b05bff87061464d4ce1af09e90eb18e870","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the linter is a blacklisted dependency, so we don\u0027t want to"},{"line_number":10,"context_line":"pull it in for unit tests, as that causes any setup.py driven"},{"line_number":11,"context_line":"build/install process to require flake8, which is not actually needed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also update to the newer flake8 2.6.x which is needed by current"},{"line_number":14,"context_line":"hacking (which causes no fallout so should be fine)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_c5ba64df","line":11,"updated":"2018-10-03 17:57:01.000000000","message":"I don\u0027t understand this. setup.py doesn\u0027t use test-requirements for install, does it? I was able to build an sdist and install mox3 using setup.py in a venv without flake8.","commit_id":"9e27c33eea7f1e38bc10bc8a790a133f2b5d3296"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"758bb209f4c2e7916952475fc20557630c6947cb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the linter is a blacklisted dependency, so we don\u0027t want to"},{"line_number":10,"context_line":"pull it in for unit tests, as that causes any setup.py driven"},{"line_number":11,"context_line":"build/install process to require flake8, which is not actually needed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also update to the newer flake8 2.6.x which is needed by current"},{"line_number":14,"context_line":"hacking (which causes no fallout so should be fine)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_6f5dfa13","line":11,"in_reply_to":"3f79a3b5_c5ba64df","updated":"2019-08-13 15:34:11.000000000","message":"I\u0027m not talking about that, sorry, I should have worded this differently. \n\nif you do tox -e py37 without this change then you get flake8 installed and that is not needed for running unit tests (I noticed it because the old flake8 version that is required here is not compatible with python 3.7).","commit_id":"9e27c33eea7f1e38bc10bc8a790a133f2b5d3296"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"19f3e7b05bff87061464d4ce1af09e90eb18e870","unresolved":false,"context_lines":[{"line_number":10,"context_line":"pull it in for unit tests, as that causes any setup.py driven"},{"line_number":11,"context_line":"build/install process to require flake8, which is not actually needed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also update to the newer flake8 2.6.x which is needed by current"},{"line_number":14,"context_line":"hacking (which causes no fallout so should be fine)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I54f99e7e29c7b3727db98bdaf8bc168da3890a1d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_654fd0bd","line":13,"updated":"2018-10-03 17:57:01.000000000","message":"This project doesn\u0027t even appear to use hacking. I\u0027m not opposed to updating flake8, but I don\u0027t think we need to do it for hacking.","commit_id":"9e27c33eea7f1e38bc10bc8a790a133f2b5d3296"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"758bb209f4c2e7916952475fc20557630c6947cb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"pull it in for unit tests, as that causes any setup.py driven"},{"line_number":11,"context_line":"build/install process to require flake8, which is not actually needed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also update to the newer flake8 2.6.x which is needed by current"},{"line_number":14,"context_line":"hacking (which causes no fallout so should be fine)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I54f99e7e29c7b3727db98bdaf8bc168da3890a1d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_efa6ca0f","line":13,"in_reply_to":"3f79a3b5_654fd0bd","updated":"2019-08-13 15:34:11.000000000","message":"which is the version needed by current hacking. I\u0027ll be happy to pick newer flake8 versions but they have fallout on this project..","commit_id":"9e27c33eea7f1e38bc10bc8a790a133f2b5d3296"}],"tox.ini":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e191cf0acb21ab41d2b1ef862bee25cec1862177","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[testenv:pep8]"},{"line_number":18,"context_line":"basepython \u003d python3"},{"line_number":19,"context_line":"deps \u003d {[testenv]deps}"},{"line_number":20,"context_line":"    flake8\u003c2.7.0,\u003e\u003d2.6.0"},{"line_number":21,"context_line":"commands \u003d flake8"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f79a3b5_8d77c78e","line":19,"range":{"start_line":19,"start_character":6,"end_line":19,"end_character":22},"updated":"2018-10-15 15:40:34.000000000","message":"If we\u0027re going to do this, we might as well go all in. These aren\u0027t needed for flake8","commit_id":"9e27c33eea7f1e38bc10bc8a790a133f2b5d3296"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"758bb209f4c2e7916952475fc20557630c6947cb","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[testenv:pep8]"},{"line_number":18,"context_line":"basepython \u003d python3"},{"line_number":19,"context_line":"deps \u003d {[testenv]deps}"},{"line_number":20,"context_line":"    flake8\u003c2.7.0,\u003e\u003d2.6.0"},{"line_number":21,"context_line":"commands \u003d flake8"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"7faddb67_0f27a6b8","line":19,"range":{"start_line":19,"start_character":6,"end_line":19,"end_character":22},"in_reply_to":"3f79a3b5_8d77c78e","updated":"2019-08-13 15:34:11.000000000","message":"sure, done","commit_id":"9e27c33eea7f1e38bc10bc8a790a133f2b5d3296"}]}