)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"ca18aafd4b911a90c7850b924222d950a317bfa9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Danek Duvall \u003cdanek.duvall@oracle.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-18 20:10:32 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add OraclePDB installation instructions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I86320d1b90a692b4b458bd2ac8b40423d66a439c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_463e40db","line":7,"updated":"2015-05-28 11:02:03.000000000","message":"It would be nice, if you would expand on what\u0027s inside the commit, what .template/.sh files do and generally what this app consists of.","commit_id":"eb172bd1163b705088204d5b654379aab852e091"}],"OraclePDBConnector/package/Classes/OraclePDB.murano":[{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"79a581b81dfa8f5afa496bf31d0708f00be69591","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Namespaces:"},{"line_number":16,"context_line":"  \u003d: com.oracle.db.muranoPdb"},{"line_number":17,"context_line":"  std: io.murano"},{"line_number":18,"context_line":"  res: io.murano.resources"},{"line_number":19,"context_line":"  sys: io.murano.system"},{"line_number":20,"context_line":"  ext: io.murano.extensions"},{"line_number":21,"context_line":"  apps: io.murano.apps"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a016987_f0d6d7ef","line":18,"updated":"2015-05-20 09:38:50.000000000","message":"res namespace is not used in this class","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"79a581b81dfa8f5afa496bf31d0708f00be69591","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  res: io.murano.resources"},{"line_number":19,"context_line":"  sys: io.murano.system"},{"line_number":20,"context_line":"  ext: io.murano.extensions"},{"line_number":21,"context_line":"  apps: io.murano.apps"},{"line_number":22,"context_line":"Name: OraclePDB"},{"line_number":23,"context_line":"Extends: \u0027io.murano.databases.SqlDatabase\u0027"},{"line_number":24,"context_line":"Properties:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a016987_f04497b7","line":21,"updated":"2015-05-20 09:38:50.000000000","message":"same for apps, please remove","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":13149,"name":"Dmytro Dovbii","email":"dmanddov@gmail.com","username":"Ddovbii"},"change_message_id":"2a0e82559c1ee4494ee8a45856903177f95f241c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Properties:"},{"line_number":25,"context_line":"  name:"},{"line_number":26,"context_line":"      Contract: $.string().notNull()"},{"line_number":27,"context_line":"  host:"},{"line_number":28,"context_line":"      Contract: $.string()"},{"line_number":29,"context_line":"      Usage: Out"},{"line_number":30,"context_line":"  username:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a016987_75b9e0ca","line":27,"updated":"2015-05-28 13:36:10.000000000","message":"\u0027host\u0027 is not initialized in workflow. Is it needed?","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":13149,"name":"Dmytro Dovbii","email":"dmanddov@gmail.com","username":"Ddovbii"},"change_message_id":"2a0e82559c1ee4494ee8a45856903177f95f241c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  host:"},{"line_number":28,"context_line":"      Contract: $.string()"},{"line_number":29,"context_line":"      Usage: Out"},{"line_number":30,"context_line":"  username:"},{"line_number":31,"context_line":"      Contract: $.string()"},{"line_number":32,"context_line":"      Usage: InOut"},{"line_number":33,"context_line":"  database:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a016987_9560dc36","line":30,"updated":"2015-05-28 13:36:10.000000000","message":"Why do you use \u0027InOut\u0027 usage for \u0027username\u0027, \u0027database\u0027, \u0027password\u0027, \u0027createDB\u0027? As I can see, these properties is not modified during workflow.","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":13149,"name":"Dmytro Dovbii","email":"dmanddov@gmail.com","username":"Ddovbii"},"change_message_id":"2a0e82559c1ee4494ee8a45856903177f95f241c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      Usage: In"},{"line_number":43,"context_line":"  agent:"},{"line_number":44,"context_line":"      Contract: $.class(ext:StaticAgent)"},{"line_number":45,"context_line":"      Usage: InOut"},{"line_number":46,"context_line":"  listener:"},{"line_number":47,"context_line":"      Contract: $.string()"},{"line_number":48,"context_line":"      Default: \u00271.1.1.1\u0027"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a016987_07271f13","line":45,"updated":"2015-05-28 13:36:10.000000000","message":"Maybe \u0027Out\u0027 ?","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":13149,"name":"Dmytro Dovbii","email":"dmanddov@gmail.com","username":"Ddovbii"},"change_message_id":"2a0e82559c1ee4494ee8a45856903177f95f241c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      Contract: $.string()"},{"line_number":48,"context_line":"      Default: \u00271.1.1.1\u0027"},{"line_number":49,"context_line":"      Usage: InOut"},{"line_number":50,"context_line":"  pdbport:"},{"line_number":51,"context_line":"      Contract: $.string()"},{"line_number":52,"context_line":"      Default: \u00271521\u0027"},{"line_number":53,"context_line":"      Usage: InOut"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a016987_350fe889","line":50,"updated":"2015-05-28 13:36:10.000000000","message":"\u0027pdbport\u0027 is not used","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"79a581b81dfa8f5afa496bf31d0708f00be69591","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Methods:"},{"line_number":61,"context_line":"  initialize:"},{"line_number":62,"context_line":"    Body:"},{"line_number":63,"context_line":"      - $.environment: $.find(std:Environment).require()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  deploy:"},{"line_number":66,"context_line":"    Body:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a016987_101f33b8","line":63,"updated":"2015-05-20 09:38:50.000000000","message":"environment is a private variable, the convention is to write it in that way:\n\n$._environment\n\nBut it\u0027s not en error, so you\u0027ll decide fix it or not","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"79a581b81dfa8f5afa496bf31d0708f00be69591","unresolved":false,"context_lines":[{"line_number":72,"context_line":"          - $.environment.reporter.report($this, \u0027Listener {0}\u0027.format($.listener))"},{"line_number":73,"context_line":"          - If: $.createDB"},{"line_number":74,"context_line":"            Then:"},{"line_number":75,"context_line":"              - $.createDatabase(database \u003d\u003e $.database)"},{"line_number":76,"context_line":"              - $.createUser(username \u003d\u003e $.username, password \u003d\u003e $.password, database \u003d\u003e $.database)"},{"line_number":77,"context_line":"              - $connection_string: $.getConnectionString(username \u003d\u003e $.username, password \u003d\u003e $.password) "},{"line_number":78,"context_line":"              - $.environment.reporter.report($this, \u0027Connection String {0}\u0027.format($connection_string))"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a016987_9a434142","line":75,"updated":"2015-05-20 09:38:50.000000000","message":"database is an optional value, regarding to Property, but required in argument for createDatabase. I suppose you get an error, it database is not provided","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"79a581b81dfa8f5afa496bf31d0708f00be69591","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            Then:"},{"line_number":75,"context_line":"              - $.createDatabase(database \u003d\u003e $.database)"},{"line_number":76,"context_line":"              - $.createUser(username \u003d\u003e $.username, password \u003d\u003e $.password, database \u003d\u003e $.database)"},{"line_number":77,"context_line":"              - $connection_string: $.getConnectionString(username \u003d\u003e $.username, password \u003d\u003e $.password) "},{"line_number":78,"context_line":"              - $.environment.reporter.report($this, \u0027Connection String {0}\u0027.format($connection_string))"},{"line_number":79,"context_line":"          - $.setAttr(deployed, true)"},{"line_number":80,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a016987_90ae837f","line":77,"updated":"2015-05-20 09:38:50.000000000","message":"it\u0027s better to remove trailing space","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":13617,"name":"Danek Duvall","email":"danek.duvall@oracle.com","username":"dhduvall"},"change_message_id":"a575af83c8f83f78b9b41fd3676ccfbc0c2dcee2","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            Then:"},{"line_number":75,"context_line":"              - $.createDatabase(database \u003d\u003e $.database)"},{"line_number":76,"context_line":"              - $.createUser(username \u003d\u003e $.username, password \u003d\u003e $.password, database \u003d\u003e $.database)"},{"line_number":77,"context_line":"              - $connection_string: $.getConnectionString(username \u003d\u003e $.username, password \u003d\u003e $.password) "},{"line_number":78,"context_line":"              - $.environment.reporter.report($this, \u0027Connection String {0}\u0027.format($connection_string))"},{"line_number":79,"context_line":"          - $.setAttr(deployed, true)"},{"line_number":80,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1af86dd1_cc09a3df","line":77,"in_reply_to":"7a016987_90ae837f","updated":"2015-06-11 23:05:13.000000000","message":"Done","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":13149,"name":"Dmytro Dovbii","email":"dmanddov@gmail.com","username":"Ddovbii"},"change_message_id":"2a0e82559c1ee4494ee8a45856903177f95f241c","unresolved":false,"context_lines":[{"line_number":124,"context_line":"              password \u003d\u003e $password"},{"line_number":125,"context_line":"             ))"},{"line_number":126,"context_line":"        - $queue: $.environment.agentListener.queueName()"},{"line_number":127,"context_line":"        - $.agent: new(ext:StaticAgent, env \u003d\u003e $.environment,"},{"line_number":128,"context_line":"              input_queue \u003d\u003e $.agent_queue,"},{"line_number":129,"context_line":"              response_queue \u003d\u003e $queue )"},{"line_number":130,"context_line":"        - $.agent.prepare()"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a016987_0a42863e","line":127,"updated":"2015-05-28 13:36:10.000000000","message":"why do you create new instance of Agent in each method? Could you create it once in initialize() method and use it everywhere ? At least, this block of code can be transferred in new method.","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":13149,"name":"Dmytro Dovbii","email":"dmanddov@gmail.com","username":"Ddovbii"},"change_message_id":"2a0e82559c1ee4494ee8a45856903177f95f241c","unresolved":false,"context_lines":[{"line_number":157,"context_line":"          Contract: $.string().notNull()"},{"line_number":158,"context_line":"    Body:"},{"line_number":159,"context_line":"        - $.environment.reporter.report($this, \u0027Generating a connection string for the PDB\u0027)"},{"line_number":160,"context_line":"        - Return: format(\u0027{0}/{1}@//{2}/{3}\u0027,$.username, $.password, $.listener, $.database)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"  checkAvailability:"},{"line_number":163,"context_line":"      Body:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a016987_6a61faa7","line":160,"updated":"2015-05-28 13:36:10.000000000","message":"You build string with properties of class but not with arguments of method here.","commit_id":"eb172bd1163b705088204d5b654379aab852e091"}],"OraclePDBConnector/package/License.txt":[{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"79a581b81dfa8f5afa496bf31d0708f00be69591","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Oracle and/or its affiliates. All rights reserved.\r"},{"line_number":2,"context_line":"#\r"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");\r"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License.\r"}],"source_content_type":"text/plain","patch_set":1,"id":"7a016987_b0f5ff57","line":1,"updated":"2015-05-20 09:38:50.000000000","message":"Please, remove \\r everywhere","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":13617,"name":"Danek Duvall","email":"danek.duvall@oracle.com","username":"dhduvall"},"change_message_id":"a575af83c8f83f78b9b41fd3676ccfbc0c2dcee2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Oracle and/or its affiliates. All rights reserved.\r"},{"line_number":2,"context_line":"#\r"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");\r"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License.\r"}],"source_content_type":"text/plain","patch_set":1,"id":"1af86dd1_4c6ff392","line":1,"in_reply_to":"7a016987_b0f5ff57","updated":"2015-06-11 23:05:13.000000000","message":"Done","commit_id":"eb172bd1163b705088204d5b654379aab852e091"}],"OraclePDBConnector/package/Resources/scripts/ora_env.sh":[{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"ca18aafd4b911a90c7850b924222d950a317bfa9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2015 Oracle and/or its affiliates. All rights reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a016987_497f7366","line":1,"updated":"2015-05-28 11:02:03.000000000","message":"It wwould be nice if we would be consistent in having #!/path/to/interpreter\n\nin all .sh files","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":13617,"name":"Danek Duvall","email":"danek.duvall@oracle.com","username":"dhduvall"},"change_message_id":"a575af83c8f83f78b9b41fd3676ccfbc0c2dcee2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2015 Oracle and/or its affiliates. All rights reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1af86dd1_6c206f4a","line":1,"in_reply_to":"7a016987_497f7366","updated":"2015-06-11 23:05:13.000000000","message":"Done","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"ca18aafd4b911a90c7850b924222d950a317bfa9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"export PATH\u003d$ORACLE_HOME/perl/bin:$PATH"},{"line_number":20,"context_line":"export PATH\u003d$ORACLE_HOME/bin:$PATH"},{"line_number":21,"context_line":"# Find site_perl"},{"line_number":22,"context_line":"site_perl\u003d(`ls -r $ORACLE_HOME/perl/lib/site_perl`)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"if [[ `/usr/bin/arch` \u003d\u003d \u0027sun4\u0027 ]]"},{"line_number":25,"context_line":"then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a016987_a99b87c8","line":22,"updated":"2015-05-28 11:02:03.000000000","message":"I\u0027m not strongly against ``, but prefer to use $() the new bash syntax instead. Feel free to ignore this comment.","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":13617,"name":"Danek Duvall","email":"danek.duvall@oracle.com","username":"dhduvall"},"change_message_id":"a575af83c8f83f78b9b41fd3676ccfbc0c2dcee2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"export PATH\u003d$ORACLE_HOME/perl/bin:$PATH"},{"line_number":20,"context_line":"export PATH\u003d$ORACLE_HOME/bin:$PATH"},{"line_number":21,"context_line":"# Find site_perl"},{"line_number":22,"context_line":"site_perl\u003d(`ls -r $ORACLE_HOME/perl/lib/site_perl`)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"if [[ `/usr/bin/arch` \u003d\u003d \u0027sun4\u0027 ]]"},{"line_number":25,"context_line":"then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1af86dd1_2c1a7718","line":22,"in_reply_to":"7a016987_a99b87c8","updated":"2015-06-11 23:05:13.000000000","message":"Done","commit_id":"eb172bd1163b705088204d5b654379aab852e091"}],"OraclePDBConnector/package/Resources/scripts/pdb_create.sh":[{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"ca18aafd4b911a90c7850b924222d950a317bfa9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# Export env variables"},{"line_number":18,"context_line":". ./ora_env.sh"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"PID\u003d`echo $$`"},{"line_number":21,"context_line":"sql_file\u003d\"$ORACLE_USER_HOME/pdb_create_$PID.sql\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Create pluggable database"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a016987_a9e9471c","line":20,"updated":"2015-05-28 11:02:03.000000000","message":"you can use \n\n  PID\u003d$$\n\ninstead. No echo or subcommand needed.","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":13617,"name":"Danek Duvall","email":"danek.duvall@oracle.com","username":"dhduvall"},"change_message_id":"a575af83c8f83f78b9b41fd3676ccfbc0c2dcee2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# Export env variables"},{"line_number":18,"context_line":". ./ora_env.sh"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"PID\u003d`echo $$`"},{"line_number":21,"context_line":"sql_file\u003d\"$ORACLE_USER_HOME/pdb_create_$PID.sql\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Create pluggable database"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1af86dd1_0cee9bec","line":20,"in_reply_to":"7a016987_a9e9471c","updated":"2015-06-11 23:05:13.000000000","message":"Done","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"ca18aafd4b911a90c7850b924222d950a317bfa9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"EXIT;"},{"line_number":32,"context_line":"EOF"},{"line_number":33,"context_line":"chown oracle:oracle $sql_file"},{"line_number":34,"context_line":"# Execute the sql statements "},{"line_number":35,"context_line":"su - oracle -c \". ~/ora_env.sh \u0026\u0026 sqlplus /nolog @$sql_file $1\""},{"line_number":36,"context_line":"# remove the sql_file"},{"line_number":37,"context_line":"rm -f $sql_file"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a016987_86f1d86c","line":34,"updated":"2015-05-28 11:02:03.000000000","message":"trailing whitespace","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":13617,"name":"Danek Duvall","email":"danek.duvall@oracle.com","username":"dhduvall"},"change_message_id":"a575af83c8f83f78b9b41fd3676ccfbc0c2dcee2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"EXIT;"},{"line_number":32,"context_line":"EOF"},{"line_number":33,"context_line":"chown oracle:oracle $sql_file"},{"line_number":34,"context_line":"# Execute the sql statements "},{"line_number":35,"context_line":"su - oracle -c \". ~/ora_env.sh \u0026\u0026 sqlplus /nolog @$sql_file $1\""},{"line_number":36,"context_line":"# remove the sql_file"},{"line_number":37,"context_line":"rm -f $sql_file"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1af86dd1_ecb9ffed","line":34,"in_reply_to":"7a016987_86f1d86c","updated":"2015-06-11 23:05:13.000000000","message":"Done","commit_id":"eb172bd1163b705088204d5b654379aab852e091"}],"OraclePDBConnector/package/Resources/scripts/pdb_create_user.sh":[{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"ca18aafd4b911a90c7850b924222d950a317bfa9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":". ./ora_env.sh"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"PID\u003d`echo $$`"},{"line_number":20,"context_line":"sql_file\u003d\"$ORACLE_USER_HOME/pdb_create_user_$PID.sql\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# get the address to attach to"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a016987_a92ca74a","line":19,"updated":"2015-05-28 11:02:03.000000000","message":"You can use \n\n  PID\u003d$$","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":13617,"name":"Danek Duvall","email":"danek.duvall@oracle.com","username":"dhduvall"},"change_message_id":"a575af83c8f83f78b9b41fd3676ccfbc0c2dcee2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":". ./ora_env.sh"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"PID\u003d`echo $$`"},{"line_number":20,"context_line":"sql_file\u003d\"$ORACLE_USER_HOME/pdb_create_user_$PID.sql\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# get the address to attach to"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1af86dd1_6cce2f85","line":19,"in_reply_to":"7a016987_a92ca74a","updated":"2015-06-11 23:05:13.000000000","message":"Done","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"ca18aafd4b911a90c7850b924222d950a317bfa9","unresolved":false,"context_lines":[{"line_number":29,"context_line":"fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# create user"},{"line_number":32,"context_line":"# grant all privileges "},{"line_number":33,"context_line":"# TODO: privileges to be set based on what the ADMIN user is requesting "},{"line_number":34,"context_line":"# from the client."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a016987_a6c73411","line":32,"updated":"2015-05-28 11:02:03.000000000","message":"We generally do not like trailing whitespaces, pls remove them.","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":13617,"name":"Danek Duvall","email":"danek.duvall@oracle.com","username":"dhduvall"},"change_message_id":"a575af83c8f83f78b9b41fd3676ccfbc0c2dcee2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# create user"},{"line_number":32,"context_line":"# grant all privileges "},{"line_number":33,"context_line":"# TODO: privileges to be set based on what the ADMIN user is requesting "},{"line_number":34,"context_line":"# from the client."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1af86dd1_4ccb7373","line":32,"in_reply_to":"7a016987_a6c73411","updated":"2015-06-11 23:05:13.000000000","message":"Done","commit_id":"eb172bd1163b705088204d5b654379aab852e091"}],"OraclePDBConnector/package/UI/ui.yaml":[{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"ca18aafd4b911a90c7850b924222d950a317bfa9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"          hidden: true"},{"line_number":20,"context_line":"          initial: \u0027Oracle-PDB\u0027"},{"line_number":21,"context_line":"          description: \u003e-"},{"line_number":22,"context_line":"            All Files in this package are copyright 2015 Oracle and/or its "},{"line_number":23,"context_line":"            affiliates. All rights reserved."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"            Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a016987_c6f7d057","line":22,"updated":"2015-05-28 11:02:03.000000000","message":"trailing whitespace","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":13617,"name":"Danek Duvall","email":"danek.duvall@oracle.com","username":"dhduvall"},"change_message_id":"a575af83c8f83f78b9b41fd3676ccfbc0c2dcee2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"          hidden: true"},{"line_number":20,"context_line":"          initial: \u0027Oracle-PDB\u0027"},{"line_number":21,"context_line":"          description: \u003e-"},{"line_number":22,"context_line":"            All Files in this package are copyright 2015 Oracle and/or its "},{"line_number":23,"context_line":"            affiliates. All rights reserved."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"            Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1af86dd1_acaae783","line":22,"in_reply_to":"7a016987_c6f7d057","updated":"2015-06-11 23:05:13.000000000","message":"Done","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"79a581b81dfa8f5afa496bf31d0708f00be69591","unresolved":false,"context_lines":[{"line_number":39,"context_line":"          type: flavor"},{"line_number":40,"context_line":"          label: Requirements"},{"line_number":41,"context_line":"          required: false"},{"line_number":42,"context_line":"          hidden: true"},{"line_number":43,"context_line":"          requirements:"},{"line_number":44,"context_line":"            min_disk: 40"},{"line_number":45,"context_line":"            min_memory_mb: 4096"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a016987_305eaf44","line":42,"updated":"2015-05-20 09:38:50.000000000","message":"You don\u0027t pass flavor anywhere. why do you need this field?\n requirements are applied only to create a list of valid flavors from which user should pick one. but this field is hidden, so this value of this field will be always empty","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"79a581b81dfa8f5afa496bf31d0708f00be69591","unresolved":false,"context_lines":[{"line_number":85,"context_line":"          label: Create Database on Deploy"},{"line_number":86,"context_line":"          description: \u003e-"},{"line_number":87,"context_line":"            Enable checkbox to create a database during an environment deployment"},{"line_number":88,"context_line":"        "}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a016987_9a6a21b2","line":88,"updated":"2015-05-20 09:38:50.000000000","message":"Please, remove spaces","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":13617,"name":"Danek Duvall","email":"danek.duvall@oracle.com","username":"dhduvall"},"change_message_id":"a575af83c8f83f78b9b41fd3676ccfbc0c2dcee2","unresolved":false,"context_lines":[{"line_number":85,"context_line":"          label: Create Database on Deploy"},{"line_number":86,"context_line":"          description: \u003e-"},{"line_number":87,"context_line":"            Enable checkbox to create a database during an environment deployment"},{"line_number":88,"context_line":"        "}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1af86dd1_cca523b6","line":88,"in_reply_to":"7a016987_9a6a21b2","updated":"2015-06-11 23:05:13.000000000","message":"Done","commit_id":"eb172bd1163b705088204d5b654379aab852e091"}],"OraclePDBConnector/package/manifest.yaml":[{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"03584b229d93928bd62c419d8bbd403ba491502c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Classes:"},{"line_number":27,"context_line":" com.oracle.db.muranoPdb.OraclePDB: OraclePDB.murano"},{"line_number":28,"context_line":"Require:"},{"line_number":29,"context_line":"    io.murano.databases.SqlDatabase:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a2ca52d_1e3bd69d","line":29,"updated":"2015-10-15 00:55:48.000000000","message":"should probably be \u0027io.murano.databases\u0027","commit_id":"eb172bd1163b705088204d5b654379aab852e091"}],"OraclePDBConnector/readme.md":[{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"79a581b81dfa8f5afa496bf31d0708f00be69591","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a016987_10acd38a","updated":"2015-05-20 09:38:50.000000000","message":"It\u0027s better to use .rst format for readme, like it\u0027s done everywhere else","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":13617,"name":"Danek Duvall","email":"danek.duvall@oracle.com","username":"dhduvall"},"change_message_id":"6029b628bd85037fb1867f61031d4a684f8e29ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a016987_82018008","in_reply_to":"7a016987_10acd38a","updated":"2015-05-21 06:20:32.000000000","message":"There is one other markdown file in the repo. Should I file a bug to get that converted?","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"4b9b0c1a1afbebd86e1bbd1b8931c97091034c6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a016987_d345ed42","in_reply_to":"7a016987_82018008","updated":"2015-05-22 13:25:19.000000000","message":"We will say \"thank you\" if you would do that :)","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":13617,"name":"Danek Duvall","email":"danek.duvall@oracle.com","username":"dhduvall"},"change_message_id":"a575af83c8f83f78b9b41fd3676ccfbc0c2dcee2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1af86dd1_2cadd788","in_reply_to":"7a016987_d345ed42","updated":"2015-06-11 23:05:13.000000000","message":"I replied offline, but figured I should respond here, too. I understand the desire for a consistent documentation format, but when I tried to convert the markdown to rst, I was unable to get the formatting to come out correctly, and I believe that it is a fundamental limitation of the rst language.\n\nCompare the rst version:\n\n    https://github.com/dhduvall/murano-apps.rst/blob/master/OraclePDBConnector/readme.rst\n\nwith the markdown version:\n\n    https://github.com/dhduvall/murano-apps/blob/master/OraclePDBConnector/readme.md\n\nIn particular, I\u0027ve been completely unable to nest source code blocks\ninside of lists.  I keep getting these blockquote-styled paragraphs after\nthe first source code block, and that\u0027s both wrong and ugly.  Plus, if you\nlook at the generated html, it shows the lists being interrupted and\nrestarted, rather than having the source code block simply nest inside.\n\nSo I\u0027d really very much rather stick with markdown.","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"79a581b81dfa8f5afa496bf31d0708f00be69591","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Oracle PDB Connector is a Murano application that provides OpenStack cloud"},{"line_number":6,"context_line":"users with means for self-service provisioning of Oracle Database 12c and"},{"line_number":7,"context_line":"Oracle Multitenant Pluggable DataBases (PDBs). "},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is an unsupported technology preview release not intended for use in"},{"line_number":10,"context_line":"production environments.  It is supported on the Juno and Kilo OpenStack"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"7a016987_9097a339","line":7,"updated":"2015-05-20 09:38:50.000000000","message":"Please, remove trailing spaces everywhere","commit_id":"eb172bd1163b705088204d5b654379aab852e091"},{"author":{"_account_id":13617,"name":"Danek Duvall","email":"danek.duvall@oracle.com","username":"dhduvall"},"change_message_id":"a575af83c8f83f78b9b41fd3676ccfbc0c2dcee2","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Oracle PDB Connector is a Murano application that provides OpenStack cloud"},{"line_number":6,"context_line":"users with means for self-service provisioning of Oracle Database 12c and"},{"line_number":7,"context_line":"Oracle Multitenant Pluggable DataBases (PDBs). "},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is an unsupported technology preview release not intended for use in"},{"line_number":10,"context_line":"production environments.  It is supported on the Juno and Kilo OpenStack"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"1af86dd1_ecb57fd0","line":7,"in_reply_to":"7a016987_9097a339","updated":"2015-06-11 23:05:13.000000000","message":"Done","commit_id":"eb172bd1163b705088204d5b654379aab852e091"}]}