)]}'
{"muranodashboard/packages/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d27b5251feb71484b54f2d8e7ba3e84b958d970e","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                if error:"},{"line_number":417,"context_line":"                    reason \u003d error.get(\u0027message\u0027)"},{"line_number":418,"context_line":"            except ValueError:"},{"line_number":419,"context_line":"                # Let horizon operate with original exception"},{"line_number":420,"context_line":"                raise"},{"line_number":421,"context_line":"        msg \u003d _(\u0027Uploading package failed. {0}\u0027).format(reason)"},{"line_number":422,"context_line":"        LOG.exception(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_9da41eba","line":419,"range":{"start_line":419,"start_character":16,"end_line":419,"end_character":61},"updated":"2020-02-07 08:52:03.000000000","message":"This looks unnecessary now. It is now apparent as \"raise\" means this.","commit_id":"01b79a97ba9ca71ae7c8c21c8d4bd2f1c3429994"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3b5bd6d218f9dc41968fb81d88c5952b2eb7ce56","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                if error:"},{"line_number":417,"context_line":"                    reason \u003d error.get(\u0027message\u0027)"},{"line_number":418,"context_line":"            except ValueError:"},{"line_number":419,"context_line":"                raise"},{"line_number":420,"context_line":"        msg \u003d _(\u0027Uploading package failed. {0}\u0027).format(reason)"},{"line_number":421,"context_line":"        LOG.exception(msg)"},{"line_number":422,"context_line":"        exceptions.handle("}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_27711be0","line":419,"updated":"2020-02-11 23:03:48.000000000","message":"Why did you change the logic? The original code raises original_e passed in the argument, but the new code raises a ValueError from json.loads.","commit_id":"a85d874748b760a357ca93ee4cf05f0c8b04d98b"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"dc97b8cd4dee5bf46fe355b82f97c782e951d387","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                if error:"},{"line_number":417,"context_line":"                    reason \u003d error.get(\u0027message\u0027)"},{"line_number":418,"context_line":"            except ValueError:"},{"line_number":419,"context_line":"                raise"},{"line_number":420,"context_line":"        msg \u003d _(\u0027Uploading package failed. {0}\u0027).format(reason)"},{"line_number":421,"context_line":"        LOG.exception(msg)"},{"line_number":422,"context_line":"        exceptions.handle("}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_4a577e28","line":419,"in_reply_to":"3fa7e38b_27711be0","updated":"2020-02-12 00:25:38.000000000","message":"ok. I will fix it in a new patch.","commit_id":"a85d874748b760a357ca93ee4cf05f0c8b04d98b"}],"muranodashboard/tests/unit/packages/test_views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d27b5251feb71484b54f2d8e7ba3e84b958d970e","unresolved":false,"context_lines":[{"line_number":485,"context_line":"        mock_json.loads.side_effect \u003d ValueError(\u0027test_error_message\u0027)"},{"line_number":486,"context_line":"        original_e \u003d ValueError(\u0027original_error_message\u0027)"},{"line_number":487,"context_line":"        setattr(original_e, \u0027details\u0027, \u0027error_details\u0027)"},{"line_number":488,"context_line":"        self.assertRaisesRegex(ValueError, \u0027original_error_message\u0027)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    @mock.patch.object(views, \u0027glance\u0027)"},{"line_number":491,"context_line":"    @mock.patch.object(views, \u0027messages\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_9d7dfe1f","line":488,"updated":"2020-02-07 08:52:03.000000000","message":"This looks odd. assertRaisesRegex should be used as a function or a contextmanager.","commit_id":"01b79a97ba9ca71ae7c8c21c8d4bd2f1c3429994"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a810f2ab5405ccb3572afec20d0ae2e8e79b81fb","unresolved":false,"context_lines":[{"line_number":485,"context_line":"        mock_json.loads.side_effect \u003d ValueError(\u0027test_error_message\u0027)"},{"line_number":486,"context_line":"        original_e \u003d ValueError(\u0027original_error_message\u0027)"},{"line_number":487,"context_line":"        setattr(original_e, \u0027details\u0027, \u0027error_details\u0027)"},{"line_number":488,"context_line":"        self.assertRaisesRegex(ValueError, \u0027original_error_message\u0027)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    @mock.patch.object(views, \u0027glance\u0027)"},{"line_number":491,"context_line":"    @mock.patch.object(views, \u0027messages\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_dd88561b","line":488,"in_reply_to":"3fa7e38b_9d7dfe1f","updated":"2020-02-07 08:53:27.000000000","message":"What I would like to mean is that nothing is tested here.\nYou dropped self.import_pkg_wizard._handle_exception().","commit_id":"01b79a97ba9ca71ae7c8c21c8d4bd2f1c3429994"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8719a2358a920169c4b2c1ee05ab94a71c21ad98","unresolved":false,"context_lines":[{"line_number":485,"context_line":"        mock_json.loads.side_effect \u003d ValueError(\u0027test_error_message\u0027)"},{"line_number":486,"context_line":"        original_e \u003d ValueError(\u0027original_error_message\u0027)"},{"line_number":487,"context_line":"        setattr(original_e, \u0027details\u0027, \u0027error_details\u0027)"},{"line_number":488,"context_line":"        with self.assertRaisesRegex(ValueError, \u0027test_error_message\u0027):"},{"line_number":489,"context_line":"            self.import_pkg_wizard._handle_exception(original_e)"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    @mock.patch.object(views, \u0027glance\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_673cf3e9","line":488,"updated":"2020-02-11 23:05:40.000000000","message":"It is super surprising. six removal should not change the test logic. This shows the change in views.py is not correct.","commit_id":"a85d874748b760a357ca93ee4cf05f0c8b04d98b"}]}