)]}'
{"murano/api/v1/environments.py":[{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"69f1e2ca0457bb20ee7bfe56fc1d8edfd1cfee5e","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                LOG.error(msg)"},{"line_number":144,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":145,"context_line":"        else:"},{"line_number":146,"context_line":"            msg \u003d _(\u0027Environment Template must contain at least one \u0027"},{"line_number":147,"context_line":"                    \u0027non-white space symbol\u0027)"},{"line_number":148,"context_line":"            LOG.error(msg)"},{"line_number":149,"context_line":"            raise exc.HTTPClientError(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_8964e9e5","line":146,"updated":"2015-10-23 16:14:45.000000000","message":"Template -\u003e name","commit_id":"e7ef91fee165a4e0b258e5de5c1a05d792fb16e1"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"52b9c01eed93c91d17d7a7b6b80030974922518b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        LOG.debug(\u0027Environments:Create \u003cBody {body}\u003e\u0027.format(body\u003dbody))"},{"line_number":64,"context_line":"        policy.check(\u0027create_environment\u0027, request.context)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if not body.get(\u0027name\u0027):"},{"line_number":67,"context_line":"            msg \u003d _(\u0027Please, specify a name of the environment to create\u0027)"},{"line_number":68,"context_line":"            LOG.exception(msg)"},{"line_number":69,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a26ad4f_9e156a4a","line":66,"updated":"2015-11-02 10:47:35.000000000","message":"you should also check, that name here is not empty","commit_id":"fb651397c22a97c166abb1026baa65504e76a457"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"52b9c01eed93c91d17d7a7b6b80030974922518b","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                LOG.exception(msg)"},{"line_number":84,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            msg \u003d _(\u0027Environment name must contain only alphanumeric or \"_-.\" \u0027"},{"line_number":87,"context_line":"                    \u0027characters, must start with alpha\u0027)"},{"line_number":88,"context_line":"            LOG.exception(msg)"},{"line_number":89,"context_line":"            raise exc.HTTPClientError(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a26ad4f_c101c706","line":86,"updated":"2015-11-02 10:47:35.000000000","message":"the error message here is wrong.\n\nand anyway the check should occur on 66th line","commit_id":"fb651397c22a97c166abb1026baa65504e76a457"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"97b0c15f2d133864c3297a5b7dda999a5f77e79d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        LOG.debug(\u0027Environments:Create \u003cBody {body}\u003e\u0027.format(body\u003dbody))"},{"line_number":64,"context_line":"        policy.check(\u0027create_environment\u0027, request.context)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if (not body.get(\u0027name\u0027)) or (not name.strip()):"},{"line_number":67,"context_line":"            msg \u003d _(\u0027Please, specify a name of the environment to create\u0027)"},{"line_number":68,"context_line":"            LOG.exception(msg)"},{"line_number":69,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a26ad4f_f4b7df37","line":66,"updated":"2015-11-02 11:18:30.000000000","message":"you can put that a bit simply:\n\nif (not (\u0027name\u0027 in body and body[\u0027name\u0027].strip())):\n\nwell anyway name is not defined here \u003d) it\u0027s only assigned on line 72","commit_id":"01e57fe3efb120c3272078675189993509baff17"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"85585ca2d0a12c331aabec40f52c282d99394d81","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        LOG.debug(\u0027Environments:Create \u003cBody {body}\u003e\u0027.format(body\u003dbody))"},{"line_number":64,"context_line":"        policy.check(\u0027create_environment\u0027, request.context)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if (not body.get(\u0027name\u0027)) or (not name.strip()):"},{"line_number":67,"context_line":"            msg \u003d _(\u0027Please, specify a name of the environment to create\u0027)"},{"line_number":68,"context_line":"            LOG.exception(msg)"},{"line_number":69,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a26ad4f_b4bc07dd","line":66,"in_reply_to":"1a26ad4f_f4b7df37","updated":"2015-11-02 11:24:46.000000000","message":"sure, my bad. I was in hurry.","commit_id":"01e57fe3efb120c3272078675189993509baff17"}],"murano/tests/functional/api/v1/test_env_templates.py":[{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"69f1e2ca0457bb20ee7bfe56fc1d8edfd1cfee5e","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        \"\"\"Check the deletion of an wrong environment template request.\"\"\""},{"line_number":148,"context_line":"        self.assertRaises(exceptions.BadRequest,"},{"line_number":149,"context_line":"                          self.client.create_env_template,"},{"line_number":150,"context_line":"                          \u0027  \u0027)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    @tag(\u0027all\u0027, \u0027coverage\u0027)"},{"line_number":153,"context_line":"    @attr(type\u003d\u0027negative\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_09d45945","line":150,"updated":"2015-10-23 16:14:45.000000000","message":"did you check env name with ascii characters? \n\ndoes deployment with $ finished correctly?\n\nI suggest to add a couple of more checks to this test","commit_id":"e7ef91fee165a4e0b258e5de5c1a05d792fb16e1"}]}