)]}'
{"murano/packages/package_base.py":[{"author":{"_account_id":13962,"name":"Victor Ryzhenkin","email":"vryzhenkin@mirantis.com","username":"vryzhenkin"},"change_message_id":"181ab5d880eb385e37670959062a7e8a53b5d21f","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            myimage \u003d Image.open(full_path)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"            if myimage.format not in allowed_ftype:"},{"line_number":134,"context_line":"                msg \u003d _(\u0027{0}: Unsupported Format. Only png, jpeg and gif\u0027"},{"line_number":135,"context_line":"                        \u0027formats are allowed\u0027).format(what_image)"},{"line_number":136,"context_line":"                raise exceptions.PackageLoadError(msg)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_7b2698cf","line":134,"updated":"2015-10-29 23:59:12.000000000","message":"The same question as below about allowed_ftype. What do you think, can we use this variable I\u0027m msg?","commit_id":"e4d6501344f9ebc00e5b64b250a9d48c401ede52"},{"author":{"_account_id":13962,"name":"Victor Ryzhenkin","email":"vryzhenkin@mirantis.com","username":"vryzhenkin"},"change_message_id":"181ab5d880eb385e37670959062a7e8a53b5d21f","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"            if width \u003e max_width or height \u003e max_height:"},{"line_number":141,"context_line":"                msg \u003d _(\u0027{0}: Uploaded image is too large: {1}x{2}. Max\u0027"},{"line_number":142,"context_line":"                        \u0027allowed 70x70\u0027).format(what_image, width, height)"},{"line_number":143,"context_line":"                raise exceptions.PackageLoadError(msg)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"            stream \u003d open(full_path, \u0027r\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_db47ac75","line":142,"updated":"2015-10-29 23:59:12.000000000","message":"Maybe we can use max_width and max_height instead of hardcoded max allowed values?","commit_id":"e4d6501344f9ebc00e5b64b250a9d48c401ede52"},{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"c2c697a733e2d84be1448049df7a5dfe4dd1b5d6","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            if width \u003e max_width or height \u003e max_height:"},{"line_number":141,"context_line":"                msg \u003d _(\u0027{0}: Uploaded image is too large: {1}x{2}. Max\u0027"},{"line_number":142,"context_line":"                        \u0027allowed 70x70\u0027).format(what_image, width, height)"},{"line_number":143,"context_line":"                raise exceptions.PackageLoadError(msg)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"            stream \u003d open(full_path, \u0027r\u0027)"},{"line_number":146,"context_line":"            return stream.read()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_0de4fc38","line":143,"updated":"2015-10-30 09:28:44.000000000","message":"I think we can add only notification about 70x70 size, \nmaximum allowed size should be 5 Mb. And yes, let\u0027s make that constant value as Victor said","commit_id":"e4d6501344f9ebc00e5b64b250a9d48c401ede52"},{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"1cf926a3e665bf39606bc6de0ee36a5cf7d9d576","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            if width \u003e max_width or height \u003e max_height:"},{"line_number":141,"context_line":"                msg \u003d _(\u0027{0}: Uploaded image is too large: {1}x{2}. Max\u0027"},{"line_number":142,"context_line":"                        \u0027allowed 70x70\u0027).format(what_image, width, height)"},{"line_number":143,"context_line":"                raise exceptions.PackageLoadError(msg)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"            stream \u003d open(full_path, \u0027r\u0027)"},{"line_number":146,"context_line":"            return stream.read()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_8dceccb2","line":143,"in_reply_to":"1a26ad4f_0de4fc38","updated":"2015-10-30 09:29:13.000000000","message":"Otherwise it will be impossible to upload existing apps","commit_id":"e4d6501344f9ebc00e5b64b250a9d48c401ede52"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"bf58e7a551b796f69188e2f63afe13d4c080f103","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            return"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        allowed_ftype \u003d (\u0027png\u0027, \u0027jpeg\u0027, \u0027gif\u0027)"},{"line_number":129,"context_line":"        allowed_size \u003d 5e+6"},{"line_number":130,"context_line":"        max_width \u003d 70"},{"line_number":131,"context_line":"        max_height \u003d 70"},{"line_number":132,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_9b6f982a","line":129,"updated":"2015-11-03 06:38:30.000000000","message":"let\u0027s make it 5mb (5 * 1024 * 1024), not 5 * 1000 * 1000","commit_id":"68e685b1548ae4e48ef4049b1796250db0c4075b"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"bf58e7a551b796f69188e2f63afe13d4c080f103","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"                raise exceptions.PackageLoadError(msg)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"            if os.stat(full_path).st_size \u003e allowed_size:"},{"line_number":141,"context_line":"                msg \u003d _(\u0027{0}: Uploaded image is too large. Max allowed\u0027"},{"line_number":142,"context_line":"                        \u0027 {1}x{2}\u0027).format(what_image, max_width, max_height)"},{"line_number":143,"context_line":"                raise exceptions.PackageLoadError(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_1b62a83e","line":140,"updated":"2015-11-03 06:38:30.000000000","message":"you\u0027re comparing size, but the error message says something about max height/width. looks inconsistent.","commit_id":"68e685b1548ae4e48ef4049b1796250db0c4075b"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"bf58e7a551b796f69188e2f63afe13d4c080f103","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                        \u0027 {1}x{2}\u0027).format(what_image, max_width, max_height)"},{"line_number":143,"context_line":"                raise exceptions.PackageLoadError(msg)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"            stream \u003d open(full_path, \u0027r\u0027)"},{"line_number":146,"context_line":"            return stream.read()"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_dbce702c","line":145,"updated":"2015-11-03 06:38:30.000000000","message":"I believe with syntax is a bit more preferred here, let\u0027s leave it that way.","commit_id":"68e685b1548ae4e48ef4049b1796250db0c4075b"}]}
