)]}'
{"murano/dsl/yaql_functions.py":[{"author":{"_account_id":7226,"name":"Stan Lagun","email":"stan.lagun@gmail.com","username":"istalker2"},"change_message_id":"06756edc3a4026605807907ed31dc58bbadab037","unresolved":false,"context_lines":[{"line_number":246,"context_line":"@specs.parameter(\u0027serialize_type\u0027, bool)"},{"line_number":247,"context_line":"def dump(obj, serialize_type\u003dTrue):"},{"line_number":248,"context_line":"    executor \u003d helpers.get_executor()"},{"line_number":249,"context_line":"    return serializer.serialize(obj, executor, serialize_type)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"def register(context, runtime_version):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_24319d0c","line":249,"updated":"2016-07-27 22:41:40.000000000","message":"Seems that instead of serializing obj you should be serializing obj.real_this. Otherwise dump($obj.cast(Parent)) will dump only the portion of the class that belongs to the Parent class and up. On the one side it might be useful, but it a) is not consistent with the rest of MuranoPL. b) You may end up with serialized model for the base abstract interface that cannot be instantiated back. Maybe we should consider to have this behavior controlled by the optional property.\nAlso, could you please write a test for this cast() use case?","commit_id":"d11a15e568d4379980fc4a3d0933ed0f8cd05e58"},{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"d7e802b863cf62a4a1bd38e1f403f48c62a0373f","unresolved":false,"context_lines":[{"line_number":246,"context_line":"@specs.parameter(\u0027serialize_type\u0027, bool)"},{"line_number":247,"context_line":"def dump(obj, serialize_type\u003dTrue):"},{"line_number":248,"context_line":"    executor \u003d helpers.get_executor()"},{"line_number":249,"context_line":"    return serializer.serialize(obj, executor, serialize_type)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"def register(context, runtime_version):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_1c4017a5","line":249,"in_reply_to":"bacf61ea_24319d0c","updated":"2016-07-28 10:53:28.000000000","message":"Done both of these.","commit_id":"d11a15e568d4379980fc4a3d0933ed0f8cd05e58"}],"murano/engine/system/yaql_functions.py":[{"author":{"_account_id":7226,"name":"Stan Lagun","email":"stan.lagun@gmail.com","username":"istalker2"},"change_message_id":"06756edc3a4026605807907ed31dc58bbadab037","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"def uuid_():"},{"line_number":208,"context_line":"    return uuid.uuid4().hex"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"@helpers.memoize"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_44177151","line":208,"updated":"2016-07-27 22:41:40.000000000","message":"Can you please use helpers.generate_id() for consistency? (Also though I do agree that this is a good idea to have such function your commit doesn\u0027t need it anymore)","commit_id":"d11a15e568d4379980fc4a3d0933ed0f8cd05e58"},{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"d7e802b863cf62a4a1bd38e1f403f48c62a0373f","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"def uuid_():"},{"line_number":208,"context_line":"    return uuid.uuid4().hex"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"@helpers.memoize"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_f5e71b3e","line":208,"in_reply_to":"bacf61ea_44177151","updated":"2016-07-28 10:53:28.000000000","message":"I agree, let\u0027s remove it from here. We may add one In a separate commit","commit_id":"d11a15e568d4379980fc4a3d0933ed0f8cd05e58"}]}