)]}'
{"meta/io.murano/Classes/resources/CinderVolume.yaml":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e5b7d8026bde077980a42269554c319d5f8537ac","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    Contract: $.class(CinderVolumeBackup)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  attachments:"},{"line_number":55,"context_line":"    Contract: []"},{"line_number":56,"context_line":"    Usage: Out"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Methods:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bff0334d_9e09d596","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":16},"updated":"2017-04-06 19:14:50.000000000","message":"Why don\u0027t you provide a more rigorous Contract? The Contract: [], as you probably know, allows for a wildcard list. Why not use something like (for example):\n\n  applications:\n    Contract: [$.class(Application).owned().notNull()]\n\nin io.murano/Classes/Environment.yaml.","commit_id":"5c9c29c2344e21d9323bec26f76ed6927f41916b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"cbeb4da6157590b8bad14bea82134dad273812e7","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    Contract: $.class(CinderVolumeBackup)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  attachments:"},{"line_number":55,"context_line":"    Contract: []"},{"line_number":56,"context_line":"    Usage: Out"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Methods:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bff0334d_35f5e6ed","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":16},"in_reply_to":"bff0334d_6c7ccf82","updated":"2017-04-10 17:48:40.000000000","message":"I wasn\u0027t aware that it was a dictionary. It\u0027s not clear by checking [0] but is apparent in [1] (after Ctrl+F \u0027attachments\u0027).\n\n[0] https://developer.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dshow-a-volume-s-details-detail\n[1] https://docs.openstack.org/user-guide/common/cli-manage-volumes.html\n\nI\u0027m OK with leaving it as a looser contract based on your reasoning.","commit_id":"5c9c29c2344e21d9323bec26f76ed6927f41916b"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"69a0c14ab772e20f2cd87ae81577ff9f3a0756b6","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    Contract: $.class(CinderVolumeBackup)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  attachments:"},{"line_number":55,"context_line":"    Contract: []"},{"line_number":56,"context_line":"    Usage: Out"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Methods:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bff0334d_6c7ccf82","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":16},"in_reply_to":"bff0334d_9e09d596","updated":"2017-04-10 16:16:06.000000000","message":"Correct me if Im wrong, but it seems to do this we would need to create a wrapper class, something like CinderVolumeAttachment, with a property for each value of the attachments dict. This feels like a waste of effort, one of the benefits of json is that you can deserialise objects without having to write these wrappers for every input. If Cinder happen to add or remove any one piece of info about an attachment in the future, our code will instantly break. Do we want such a firm contract here?","commit_id":"5c9c29c2344e21d9323bec26f76ed6927f41916b"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"3f7039c0253966817fba8638bac2e8fdbfa4c4e1","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            value: $.getRef()"},{"line_number":102,"context_line":"          format(\u0027vol-{0}-attachments\u0027, id($)):"},{"line_number":103,"context_line":"            value:"},{"line_number":104,"context_line":"              get_attr: [$.getResourceName(), attachments_list]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  deploy:"},{"line_number":107,"context_line":"    Body:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ff52f3f_64a2299d","line":104,"range":{"start_line":104,"start_character":46,"end_line":104,"end_character":62},"updated":"2017-04-13 16:19:02.000000000","message":"why is it attahcements_list and not attachements?","commit_id":"107fc981be079d4af4da35ff131b133deecaa574"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"bbff868cb2b59de924f45226cefb6a61f4fe211c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            value: $.getRef()"},{"line_number":102,"context_line":"          format(\u0027vol-{0}-attachments\u0027, id($)):"},{"line_number":103,"context_line":"            value:"},{"line_number":104,"context_line":"              get_attr: [$.getResourceName(), attachments_list]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  deploy:"},{"line_number":107,"context_line":"    Body:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7ffa3b31_2e56fe5d","line":104,"range":{"start_line":104,"start_character":46,"end_line":104,"end_character":62},"in_reply_to":"9ff52f3f_64a2299d","updated":"2017-04-18 14:00:56.000000000","message":"Hi just noticed your comment - \u0027attachments\u0027 in Heat is in an incorrect format so I submitted a change to deprecate it.[0] \u0027attachments_list\u0027 is the replacement attribute.\n\n[0] https://review.openstack.org/#/c/452718/","commit_id":"107fc981be079d4af4da35ff131b133deecaa574"}],"murano_tempest_tests/tests/scenario/application_catalog/base.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a1a3456584e43ad1cef1f6012982ff9e970bffd9","unresolved":false,"context_lines":[{"line_number":348,"context_line":"    def get_volume_attachments(self, environment_id):"},{"line_number":349,"context_line":"        stack \u003d self.get_stack_id(environment_id)"},{"line_number":350,"context_line":"        stack_outputs \u003d self.orchestration_client.\\"},{"line_number":351,"context_line":"            show_stack(stack)[\u0027stack\u0027][\u0027outputs\u0027]"},{"line_number":352,"context_line":"        for output in stack_outputs:"},{"line_number":353,"context_line":"            if (output[\u0027output_key\u0027].startswith(\u0027vol-\u0027) and"},{"line_number":354,"context_line":"                    output[\u0027output_key\u0027].endswith(\u0027-attachments\u0027)):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_5f177d46","line":351,"range":{"start_line":351,"start_character":12,"end_line":351,"end_character":22},"updated":"2017-04-04 18:01:18.000000000","message":"Interesting, looks like \u0027resolve_outputs\u0027 is True by default.","commit_id":"c170343dd3355efb1c450609fb9edb3371923fc4"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"91f9aa3a06bb63fec5f2f6149f525ade571a982d","unresolved":false,"context_lines":[{"line_number":348,"context_line":"    def get_volume_attachments(self, environment_id):"},{"line_number":349,"context_line":"        stack \u003d self.get_stack_id(environment_id)"},{"line_number":350,"context_line":"        stack_outputs \u003d self.orchestration_client.\\"},{"line_number":351,"context_line":"            show_stack(stack)[\u0027stack\u0027][\u0027outputs\u0027]"},{"line_number":352,"context_line":"        for output in stack_outputs:"},{"line_number":353,"context_line":"            if (output[\u0027output_key\u0027].startswith(\u0027vol-\u0027) and"},{"line_number":354,"context_line":"                    output[\u0027output_key\u0027].endswith(\u0027-attachments\u0027)):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_3b54aefd","line":351,"range":{"start_line":351,"start_character":12,"end_line":351,"end_character":22},"in_reply_to":"dfeb2761_5f177d46","updated":"2017-04-05 11:54:37.000000000","message":"I wasn\u0027t aware of this argument but looking at python-heatclient, yes this appears to be the case (http://git.openstack.org/cgit/openstack/python-heatclient/commit/?id\u003dec59701df0981889df50ca8f491e0cae78669913)","commit_id":"c170343dd3355efb1c450609fb9edb3371923fc4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a1a3456584e43ad1cef1f6012982ff9e970bffd9","unresolved":false,"context_lines":[{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def check_volume_attachments(self, environment_id):"},{"line_number":358,"context_line":"        volume_attachments \u003d self.get_volume_attachments(environment_id)"},{"line_number":359,"context_line":"        self.assertTrue(type(volume_attachments) \u003d\u003d list)"},{"line_number":360,"context_line":"        self.assertTrue(len(volume_attachments) \u003e 0)"},{"line_number":361,"context_line":"        instance_id \u003d self.get_instance_id(\u0027testMurano\u0027)"},{"line_number":362,"context_line":"        for attachment in volume_attachments:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_7fd922f1","line":359,"range":{"start_line":359,"start_character":8,"end_line":359,"end_character":57},"updated":"2017-04-04 18:01:18.000000000","message":"self.assertIsInstance(volume_attachments, list)","commit_id":"c170343dd3355efb1c450609fb9edb3371923fc4"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"91f9aa3a06bb63fec5f2f6149f525ade571a982d","unresolved":false,"context_lines":[{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def check_volume_attachments(self, environment_id):"},{"line_number":358,"context_line":"        volume_attachments \u003d self.get_volume_attachments(environment_id)"},{"line_number":359,"context_line":"        self.assertTrue(type(volume_attachments) \u003d\u003d list)"},{"line_number":360,"context_line":"        self.assertTrue(len(volume_attachments) \u003e 0)"},{"line_number":361,"context_line":"        instance_id \u003d self.get_instance_id(\u0027testMurano\u0027)"},{"line_number":362,"context_line":"        for attachment in volume_attachments:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_1b59ea33","line":359,"range":{"start_line":359,"start_character":8,"end_line":359,"end_character":57},"in_reply_to":"dfeb2761_7fd922f1","updated":"2017-04-05 11:54:37.000000000","message":"Done","commit_id":"c170343dd3355efb1c450609fb9edb3371923fc4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a1a3456584e43ad1cef1f6012982ff9e970bffd9","unresolved":false,"context_lines":[{"line_number":357,"context_line":"    def check_volume_attachments(self, environment_id):"},{"line_number":358,"context_line":"        volume_attachments \u003d self.get_volume_attachments(environment_id)"},{"line_number":359,"context_line":"        self.assertTrue(type(volume_attachments) \u003d\u003d list)"},{"line_number":360,"context_line":"        self.assertTrue(len(volume_attachments) \u003e 0)"},{"line_number":361,"context_line":"        instance_id \u003d self.get_instance_id(\u0027testMurano\u0027)"},{"line_number":362,"context_line":"        for attachment in volume_attachments:"},{"line_number":363,"context_line":"            self.assertEqual(attachment.get(\u0027server_id\u0027), instance_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_dfe70eac","line":360,"range":{"start_line":360,"start_character":8,"end_line":360,"end_character":52},"updated":"2017-04-04 18:01:18.000000000","message":"self.assertGreater(len(volume_attachments), 0) -- I believe assertGreater should be available.","commit_id":"c170343dd3355efb1c450609fb9edb3371923fc4"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"91f9aa3a06bb63fec5f2f6149f525ade571a982d","unresolved":false,"context_lines":[{"line_number":357,"context_line":"    def check_volume_attachments(self, environment_id):"},{"line_number":358,"context_line":"        volume_attachments \u003d self.get_volume_attachments(environment_id)"},{"line_number":359,"context_line":"        self.assertTrue(type(volume_attachments) \u003d\u003d list)"},{"line_number":360,"context_line":"        self.assertTrue(len(volume_attachments) \u003e 0)"},{"line_number":361,"context_line":"        instance_id \u003d self.get_instance_id(\u0027testMurano\u0027)"},{"line_number":362,"context_line":"        for attachment in volume_attachments:"},{"line_number":363,"context_line":"            self.assertEqual(attachment.get(\u0027server_id\u0027), instance_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_db3ee2b6","line":360,"range":{"start_line":360,"start_character":8,"end_line":360,"end_character":52},"in_reply_to":"dfeb2761_dfe70eac","updated":"2017-04-05 11:54:37.000000000","message":"Done","commit_id":"c170343dd3355efb1c450609fb9edb3371923fc4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e5b7d8026bde077980a42269554c319d5f8537ac","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        instance_id \u003d self.get_instance_id(\u0027testMurano\u0027)"},{"line_number":362,"context_line":"        for attachment in volume_attachments:"},{"line_number":363,"context_line":"            self.assertEqual(attachment.get(\u0027server_id\u0027), instance_id)"},{"line_number":364,"context_line":"            self.assertTrue(attachment.get(\u0027device\u0027).startswith(\u0027/dev/\u0027))"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def check_volume_attached(self, name, volume_id):"},{"line_number":367,"context_line":"        instance_id \u003d self.get_instance_id(name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_9e6315b2","line":364,"range":{"start_line":364,"start_character":64,"end_line":364,"end_character":71},"updated":"2017-04-06 19:14:50.000000000","message":"I was somewhat concerned whether this is always the case. However: \"Note that as of the 12.0.0 Liberty release, the Nova libvirt driver no longer honors a user-supplied device name. This is the same behavior as if the device name parameter is not supplied on the request.\"\n\nI\u0027m assuming that the libvirt  driver always prefixes device names with \u0027/dev/\u0027 automatically?","commit_id":"5c9c29c2344e21d9323bec26f76ed6927f41916b"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"69a0c14ab772e20f2cd87ae81577ff9f3a0756b6","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        instance_id \u003d self.get_instance_id(\u0027testMurano\u0027)"},{"line_number":362,"context_line":"        for attachment in volume_attachments:"},{"line_number":363,"context_line":"            self.assertEqual(attachment.get(\u0027server_id\u0027), instance_id)"},{"line_number":364,"context_line":"            self.assertTrue(attachment.get(\u0027device\u0027).startswith(\u0027/dev/\u0027))"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def check_volume_attached(self, name, volume_id):"},{"line_number":367,"context_line":"        instance_id \u003d self.get_instance_id(name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_acb9b715","line":364,"range":{"start_line":364,"start_character":64,"end_line":364,"end_character":71},"in_reply_to":"bff0334d_9e6315b2","updated":"2017-04-10 16:16:06.000000000","message":"While we can\u0027t guarantee the name it will be attached as, it seems in the majority of unixes it will be mounted under the /dev/ filesystem [0]. That said if we want to be ultra sure this is cross compatible I can lower the check to something like not null. What do you think?\n\n[0] https://en.wikipedia.org/wiki/Device_file#Implementations","commit_id":"5c9c29c2344e21d9323bec26f76ed6927f41916b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"cbeb4da6157590b8bad14bea82134dad273812e7","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        instance_id \u003d self.get_instance_id(\u0027testMurano\u0027)"},{"line_number":362,"context_line":"        for attachment in volume_attachments:"},{"line_number":363,"context_line":"            self.assertEqual(attachment.get(\u0027server_id\u0027), instance_id)"},{"line_number":364,"context_line":"            self.assertTrue(attachment.get(\u0027device\u0027).startswith(\u0027/dev/\u0027))"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def check_volume_attached(self, name, volume_id):"},{"line_number":367,"context_line":"        instance_id \u003d self.get_instance_id(name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_b2490cb8","line":364,"range":{"start_line":364,"start_character":64,"end_line":364,"end_character":71},"in_reply_to":"bff0334d_acb9b715","updated":"2017-04-10 17:48:40.000000000","message":"Thanks for providing that link. \u0027/dev/\u0027 should be fine.","commit_id":"5c9c29c2344e21d9323bec26f76ed6927f41916b"}]}
