)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"448f997cbc674e580c901645f455782243c34d94","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     0c47f3ec (bagpipe-bgp translate_api_internal fix)"},{"line_number":2,"context_line":"Author:     Thomas Morin \u003cthomas.morin@orange.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2017-07-11 15:47:58 +0200"},{"line_number":4,"context_line":"Commit:     Thomas Morin \u003ctmmorin.orange@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-10 12:22:12 +0000"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9f436f4f_45aed798","line":2,"updated":"2017-08-10 15:55:47.000000000","message":"Isn\u0027t this a bit dangerous that contributor\u003d\u003dapprover past FF? I\u0027d be very wary if I were you.","commit_id":"e7c0ab5e02ab1311b5e82918b21b86bf3f9a0a4b"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"5d36b52e60e368e99aefed8ce607429bd7950c1b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     0c47f3ec (bagpipe-bgp translate_api_internal fix)"},{"line_number":2,"context_line":"Author:     Thomas Morin \u003cthomas.morin@orange.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2017-07-11 15:47:58 +0200"},{"line_number":4,"context_line":"Commit:     Thomas Morin \u003ctmmorin.orange@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-10 12:22:12 +0000"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9f436f4f_e5214bfd","line":2,"in_reply_to":"9f436f4f_45aed798","updated":"2017-08-10 16:10:00.000000000","message":"Yes, but it\u0027s hard to do otherwise with one core in the project.","commit_id":"e7c0ab5e02ab1311b5e82918b21b86bf3f9a0a4b"}],"devstack/gate_hook.sh":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b46f60861cfb74f9a24d2846f4a916e525d50e87","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # https://github.com/openvswitch/ovs/commit/741f47cf35df2bfc7811b2cff75c9bb8d05fd26f"},{"line_number":74,"context_line":"        OVS_BRANCH\u003d\"v2.6.1\""},{"line_number":75,"context_line":"        compile_ovs_kernel_module"},{"line_number":76,"context_line":"        # OVS \u003e\u003d 2.8 is another option, because this is when support for"},{"line_number":77,"context_line":"        # non-TEB MPLS/GRE has been added, but we don\u0027t want to enable it"},{"line_number":78,"context_line":"        # until our fullstack environment is fully ready to use it"},{"line_number":79,"context_line":"        #"}],"source_content_type":"text/x-sh","patch_set":10,"id":"9f436f4f_6570bba6","line":76,"updated":"2017-08-10 15:54:38.000000000","message":"this seems to contradict the commit message as it\u0027s been commented out!?","commit_id":"e7c0ab5e02ab1311b5e82918b21b86bf3f9a0a4b"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"5d36b52e60e368e99aefed8ce607429bd7950c1b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # https://github.com/openvswitch/ovs/commit/741f47cf35df2bfc7811b2cff75c9bb8d05fd26f"},{"line_number":74,"context_line":"        OVS_BRANCH\u003d\"v2.6.1\""},{"line_number":75,"context_line":"        compile_ovs_kernel_module"},{"line_number":76,"context_line":"        # OVS \u003e\u003d 2.8 is another option, because this is when support for"},{"line_number":77,"context_line":"        # non-TEB MPLS/GRE has been added, but we don\u0027t want to enable it"},{"line_number":78,"context_line":"        # until our fullstack environment is fully ready to use it"},{"line_number":79,"context_line":"        #"}],"source_content_type":"text/x-sh","patch_set":10,"id":"9f436f4f_a506a385","line":76,"in_reply_to":"9f436f4f_6570bba6","updated":"2017-08-10 16:10:00.000000000","message":"It\u0027s commented out, because when not, although OVS-2.8 compiles fine on xenial, there are some errors in the MPLS dataplane that result in failing tests that were previously working.\n\nI could as well remove the lines below, I suspect they will only be useful later.","commit_id":"e7c0ab5e02ab1311b5e82918b21b86bf3f9a0a4b"}],"networking_bagpipe/bagpipe_bgp/vpn/ipvpn/mpls_ovs_dataplane.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b46f60861cfb74f9a24d2846f4a916e525d50e87","unresolved":false,"context_lines":[{"line_number":922,"context_line":"                   help\u003d\"OVS interface name for MPLS/GRE encap\"),"},{"line_number":923,"context_line":"        cfg.ListOpt(\"gre_tunnel_options\", default\u003d[],"},{"line_number":924,"context_line":"                    item_type\u003dtypes.String(),"},{"line_number":925,"context_line":"                    help\u003d(\"Options passed to OVS for GRE tunnel port creation \""},{"line_number":926,"context_line":"                          \"(e.g. \u0027packet_type\u003dlegacy_l3\u0027) that will be added \""},{"line_number":927,"context_line":"                          \"as OVS tunnel interface options \""},{"line_number":928,"context_line":"                          \"(e.g. \u0027options:packet_type\u003dlegacy_l3\u0027)\")),"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f436f4f_05e20f02","line":925,"updated":"2017-08-10 15:54:38.000000000","message":"these must be comma separated now.","commit_id":"e7c0ab5e02ab1311b5e82918b21b86bf3f9a0a4b"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"5d36b52e60e368e99aefed8ce607429bd7950c1b","unresolved":false,"context_lines":[{"line_number":922,"context_line":"                   help\u003d\"OVS interface name for MPLS/GRE encap\"),"},{"line_number":923,"context_line":"        cfg.ListOpt(\"gre_tunnel_options\", default\u003d[],"},{"line_number":924,"context_line":"                    item_type\u003dtypes.String(),"},{"line_number":925,"context_line":"                    help\u003d(\"Options passed to OVS for GRE tunnel port creation \""},{"line_number":926,"context_line":"                          \"(e.g. \u0027packet_type\u003dlegacy_l3\u0027) that will be added \""},{"line_number":927,"context_line":"                          \"as OVS tunnel interface options \""},{"line_number":928,"context_line":"                          \"(e.g. \u0027options:packet_type\u003dlegacy_l3\u0027)\")),"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f436f4f_c5a64754","line":925,"in_reply_to":"9f436f4f_05e20f02","updated":"2017-08-10 16:10:00.000000000","message":"Yes, indeed.\n\nI updated the help string.\n\n(Note that there was no known purpose for this until now than to test earlier version of OVS patches to support MPLS-over-GRE.)","commit_id":"e7c0ab5e02ab1311b5e82918b21b86bf3f9a0a4b"}]}