)]}'
{"id":"openstack%2Fnetworking-bagpipe~537660","triplet_id":"openstack%2Fnetworking-bagpipe~stable%2Fpike~I474834340751d05ae33b6eb8404511e23f110598","project":"openstack/networking-bagpipe","branch":"stable/pike","topic":"bug/1745145-stable/pike","hashtags":[],"change_id":"I474834340751d05ae33b6eb8404511e23f110598","subject":"bagpipe-bgp: ensure instance id uniqueness","status":"MERGED","created":"2018-01-24 21:26:04.000000000","updated":"2018-03-15 21:33:20.000000000","submitted":"2018-03-15 21:33:20.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"537660-1521149600922-94ae77fa","meta_rev_id":"d71beb7b0de0db3023d1310d26d8072edff0b9b1","_number":537660,"virtual_id_number":537660,"owner":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2018-02-05 09:24:51.000000000","_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},{"value":0,"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},{"value":0,"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":2,"date":"2018-03-15 21:33:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"all":[{"value":0,"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},{"value":2,"date":"2018-03-15 20:19:58.000000000","_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},{"value":2,"date":"2018-02-05 16:20:47.000000000","_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"all":[{"value":0,"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},{"value":1,"date":"2018-03-15 20:19:58.000000000","_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},{"value":0,"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},{"value":0,"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},{"value":0,"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-02-05 16:20:47.000000000","updated_by":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"reviewer":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"state":"REVIEWER"},{"updated":"2018-03-15 20:19:58.000000000","updated_by":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"reviewer":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"state":"REVIEWER"},{"updated":"2018-03-15 21:33:20.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9daaafe2a2291207df084815e09043114c63c379","author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"date":"2018-01-24 21:26:04.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"08d41137ab006735873342d121bd9eebfe6ca9b8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-25 00:03:23.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/60/537660/1/check/openstack-tox-pep8/e2456f3/ : SUCCESS in 6m 35s\n- openstack-tox-py27 http://logs.openstack.org/60/537660/1/check/openstack-tox-py27/e402280/ : SUCCESS in 8m 32s\n- openstack-tox-py35 http://logs.openstack.org/60/537660/1/check/openstack-tox-py35/9946200/ : SUCCESS in 6m 42s\n- build-openstack-sphinx-docs http://logs.openstack.org/60/537660/1/check/build-openstack-sphinx-docs/2e4a428/html/ : SUCCESS in 5m 56s\n- openstack-tox-cover http://logs.openstack.org/60/537660/1/check/openstack-tox-cover/faf115f/cover/ : SUCCESS in 5m 57s\n- legacy-tempest-dsvm-networking-bagpipe http://logs.openstack.org/60/537660/1/check/legacy-tempest-dsvm-networking-bagpipe/210bb62/ : SUCCESS in 1h 00m 48s\n- legacy-tempest-dsvm-networking-bgpvpn-bagpipe http://logs.openstack.org/60/537660/1/check/legacy-tempest-dsvm-networking-bgpvpn-bagpipe/19e5285/ : FAILURE in 47m 23s\n- legacy-networking-bagpipe-dsvm-fullstack http://logs.openstack.org/60/537660/1/check/legacy-networking-bagpipe-dsvm-fullstack/7031761/ : FAILURE in 30m 18s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0c82fe55f54dc6b5e8bfa07e8ad1d16e507df5cd","author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"date":"2018-01-31 06:59:43.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"0f0754e84aac56efb4175b42ef09b351fac78d9e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-31 08:21:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/60/537660/1/check/openstack-tox-pep8/8edc7eb/ : SUCCESS in 8m 03s\n- openstack-tox-py27 http://logs.openstack.org/60/537660/1/check/openstack-tox-py27/62c54da/ : SUCCESS in 7m 57s\n- openstack-tox-py35 http://logs.openstack.org/60/537660/1/check/openstack-tox-py35/88f58a7/ : SUCCESS in 6m 06s\n- build-openstack-sphinx-docs http://logs.openstack.org/60/537660/1/check/build-openstack-sphinx-docs/e732c1c/html/ : SUCCESS in 5m 19s\n- openstack-tox-cover http://logs.openstack.org/60/537660/1/check/openstack-tox-cover/eae7456/cover/ : SUCCESS in 5m 55s\n- legacy-tempest-dsvm-networking-bagpipe http://logs.openstack.org/60/537660/1/check/legacy-tempest-dsvm-networking-bagpipe/d4a3a73/ : SUCCESS in 1h 10m 06s\n- legacy-tempest-dsvm-networking-bgpvpn-bagpipe http://logs.openstack.org/60/537660/1/check/legacy-tempest-dsvm-networking-bgpvpn-bagpipe/86b20a1/ : SUCCESS in 24m 21s\n- legacy-networking-bagpipe-dsvm-fullstack http://logs.openstack.org/60/537660/1/check/legacy-networking-bagpipe-dsvm-fullstack/6632f37/ : SUCCESS in 25m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"77a911169493290cb27bd06ea74825e710063ec0","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2018-02-02 21:18:36.000000000","message":"Patch Set 1:\n\nyou can\u0027t honestly expect me to +2 this can you? :)","accounts_in_message":[],"_revision_number":1},{"id":"ed9f33bc5f58fce5baffa63998a49ccdddbd821b","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2018-02-02 21:21:26.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6e3f4feca37c1082ae4832fcc8d9f75b9ff0347e","author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"date":"2018-02-04 10:19:37.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ee66b287cc29043777a417645d168cfbd049eef0","author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"date":"2018-02-04 10:20:58.000000000","message":"Patch Set 1:\n\n\u003e you can\u0027t honestly expect me to +2 this can you? :)\n\nI\u0027m not proud of this bug, believe me.\nDon\u0027t make it worse.\n\nDunno why I\u0027m asking that though... I\u0027m sure you will anyways ! ;)\n\nThis will haunt be forever...","accounts_in_message":[],"_revision_number":1},{"id":"75d5aed38848da05d77a8f0c35d017e61687d79a","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2018-02-04 15:57:09.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"45b62634bf1342a1aa12c3604508308f3473ae0f","author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"date":"2018-02-05 09:24:51.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"65a819a8fcc44347fc32bca138257ba723c59758","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2018-02-05 16:20:47.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f7ce14fb301584a83f9a8b919e83b710eafc8c42","author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"date":"2018-03-15 20:19:58.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"2ca5449d1150a95acad54c0e7470eb25e7e38d16","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-15 20:20:32.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"479024d9e101e83fbedfc5b40b4a62e0935f2e76","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-15 21:33:20.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"59ef979fd920cbb0a8c86a7c93efe1b84f28e42f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-15 21:33:20.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/60/537660/1/gate/openstack-tox-pep8/554484b/ : SUCCESS in 5m 24s\n- openstack-tox-py27 http://logs.openstack.org/60/537660/1/gate/openstack-tox-py27/183f781/ : SUCCESS in 5m 26s\n- openstack-tox-py35 http://logs.openstack.org/60/537660/1/gate/openstack-tox-py35/8c3fe30/ : SUCCESS in 6m 32s\n- build-openstack-sphinx-docs http://logs.openstack.org/60/537660/1/gate/build-openstack-sphinx-docs/ec93b2d/html/ : SUCCESS in 5m 09s\n- openstack-tox-cover http://logs.openstack.org/60/537660/1/gate/openstack-tox-cover/81e48b4/cover/ : SUCCESS in 5m 50s\n- legacy-tempest-dsvm-networking-bagpipe http://logs.openstack.org/60/537660/1/gate/legacy-tempest-dsvm-networking-bagpipe/fc49355/ : SUCCESS in 1h 06m 57s\n- legacy-tempest-dsvm-networking-bgpvpn-bagpipe http://logs.openstack.org/60/537660/1/gate/legacy-tempest-dsvm-networking-bgpvpn-bagpipe/b1ffaf9/ : SUCCESS in 22m 28s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7d3678889fb21a9b31a911e1d8247f5ebe3707e3","revisions":{"7d3678889fb21a9b31a911e1d8247f5ebe3707e3":{"kind":"REWORK","_number":1,"created":"2018-01-24 21:26:04.000000000","uploader":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"ref":"refs/changes/60/537660/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/networking-bagpipe","ref":"refs/changes/60/537660/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/networking-bagpipe refs/changes/60/537660/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/networking-bagpipe refs/changes/60/537660/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/networking-bagpipe refs/changes/60/537660/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/networking-bagpipe refs/changes/60/537660/1"}}},"commit":{"parents":[{"commit":"ab71587c38981a439fa79ee0f9c95c4dd9e20a3e","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-bagpipe/commit/ab71587c38981a439fa79ee0f9c95c4dd9e20a3e"}]}],"author":{"name":"Thomas Morin","email":"thomas.morin@orange.com","date":"2018-01-24 13:09:46.000000000","tz":60},"committer":{"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","date":"2018-01-24 21:26:04.000000000","tz":0},"subject":"bagpipe-bgp: ensure instance id uniqueness","message":"bagpipe-bgp: ensure instance id uniqueness\n\nFix a how instance ids are allocated, to ensure that\ntwo VPN instance do not end up using the same id.\n\nYes, this is appalling.\n\nChange-Id: I474834340751d05ae33b6eb8404511e23f110598\nCloses-Bug: 1745145\n(cherry picked from commit 3af0e228eaf0fcac4a8c741a4ad14c4d336b4d2b)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-bagpipe/commit/7d3678889fb21a9b31a911e1d8247f5ebe3707e3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-bagpipe/commit/7d3678889fb21a9b31a911e1d8247f5ebe3707e3"}]},"branch":"refs/heads/stable/pike"}},"requirements":[],"submit_records":[],"submit_requirements":[]}