)]}'
{"networking_bagpipe/tests/unit/objects/test_bgpvpn.py":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"5ba9f57bab0ee1303a7029a0a7531f1832abcc85","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            {\u0027router_id\u0027: self.router_id,"},{"line_number":192,"context_line":"             \u0027bgpvpn_id\u0027: self._create_test_bgpvpn_id,"},{"line_number":193,"context_line":"             })"},{"line_number":194,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":197,"context_line":"        self.skipTest(\"test not passing yet, remains to be investigated why\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_8f15959e","line":194,"updated":"2019-05-13 19:57:01.000000000","message":"The routes field is indeed not present in this object.","commit_id":"b8ff73861efd7e6d1809b84e1ba6dc8c4b1bbcba"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"5ba9f57bab0ee1303a7029a0a7531f1832abcc85","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        self.update_obj_fields("},{"line_number":288,"context_line":"            {\u0027port_id\u0027: self.port_id,"},{"line_number":289,"context_line":"             \u0027bgpvpn_id\u0027: self._create_test_bgpvpn_id,"},{"line_number":290,"context_line":"             \u0027routes\u0027: {"},{"line_number":291,"context_line":"                 \u0027bgpvpn_id\u0027: self._create_test_bgpvpn_id,"},{"line_number":292,"context_line":"                 }})"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_af0c19a5","line":290,"range":{"start_line":290,"start_character":14,"end_line":290,"end_character":22},"updated":"2019-05-13 19:57:01.000000000","message":"To be honest, I lack background on the underlying bugfix that wakes this issue up.\n\nSurprisingly the test in error seems to be about this field, but this field is legitimately present in the object (see [1]).\n\nPerhaps removing the field may let the test pass, but would we still exercise everything in the object?\n\n\n[1] https://github.com/openstack/networking-bagpipe/blob/782370e6839c82f8cfaf31d7b4c8c107e37efac0/networking_bagpipe/objects/bgpvpn.py#L310","commit_id":"b8ff73861efd7e6d1809b84e1ba6dc8c4b1bbcba"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8a90038fcf60dff1d54fb31ab155639aff490097","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            [s[\u0027id\u0027] for s in get_assocs[0].all_subnets(network_.id)])"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"class BGPVPNPortAssociationTest(test_base.BaseDbObjectTestCase,"},{"line_number":278,"context_line":"                                testlib_api.SqlTestCase,"},{"line_number":279,"context_line":"                                _BPGVPNObjectsTestCommon):"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    _test_class \u003d bgpvpn_obj.BGPVPNPortAssociation"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def setUp(self):"},{"line_number":284,"context_line":"        test_base.BaseDbObjectTestCase.setUp(self)"},{"line_number":285,"context_line":"        self.project \u003d uuidutils.generate_uuid()"},{"line_number":286,"context_line":"        self.port_id \u003d self._create_test_port_id()"},{"line_number":287,"context_line":"        self.update_obj_fields("},{"line_number":288,"context_line":"            {\u0027port_id\u0027: self.port_id,"},{"line_number":289,"context_line":"             \u0027bgpvpn_id\u0027: self._create_test_bgpvpn_id,"},{"line_number":290,"context_line":"             \u0027routes\u0027: {"},{"line_number":291,"context_line":"                 \u0027bgpvpn_id\u0027: self._create_test_bgpvpn_id,"},{"line_number":292,"context_line":"                 }})"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":295,"context_line":"        self.skipTest(\"test not passing yet, remains to be investigated why\")"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"class BGPVPNPortAssociationRouteTest(test_base.BaseDbObjectTestCase,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_33d81d7f","side":"PARENT","line":295,"range":{"start_line":277,"start_character":0,"end_line":295,"end_character":77},"updated":"2019-11-27 15:53:53.000000000","message":"I would suggest to skip only test_db_obj, like\n    def test_db_obj(self):\n        self.skipTest(\"test not passing since https://review.opendev.org/650525, remains to be investigated why\")","commit_id":"0d1a5be04c7809c906a89057683f7f8498aa568e"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"9782b9a560b767a01a45e0c0e2a57e00e2557394","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            [s[\u0027id\u0027] for s in get_assocs[0].all_subnets(network_.id)])"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"class BGPVPNPortAssociationTest(test_base.BaseDbObjectTestCase,"},{"line_number":278,"context_line":"                                testlib_api.SqlTestCase,"},{"line_number":279,"context_line":"                                _BPGVPNObjectsTestCommon):"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    _test_class \u003d bgpvpn_obj.BGPVPNPortAssociation"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def setUp(self):"},{"line_number":284,"context_line":"        test_base.BaseDbObjectTestCase.setUp(self)"},{"line_number":285,"context_line":"        self.project \u003d uuidutils.generate_uuid()"},{"line_number":286,"context_line":"        self.port_id \u003d self._create_test_port_id()"},{"line_number":287,"context_line":"        self.update_obj_fields("},{"line_number":288,"context_line":"            {\u0027port_id\u0027: self.port_id,"},{"line_number":289,"context_line":"             \u0027bgpvpn_id\u0027: self._create_test_bgpvpn_id,"},{"line_number":290,"context_line":"             \u0027routes\u0027: {"},{"line_number":291,"context_line":"                 \u0027bgpvpn_id\u0027: self._create_test_bgpvpn_id,"},{"line_number":292,"context_line":"                 }})"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":295,"context_line":"        self.skipTest(\"test not passing yet, remains to be investigated why\")"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"class BGPVPNPortAssociationRouteTest(test_base.BaseDbObjectTestCase,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_e20f06de","side":"PARENT","line":295,"range":{"start_line":277,"start_character":0,"end_line":295,"end_character":77},"in_reply_to":"3fa7e38b_33d81d7f","updated":"2019-11-28 09:49:38.000000000","message":"You are right, that\u0027s a bit better. Done.","commit_id":"0d1a5be04c7809c906a89057683f7f8498aa568e"}]}