)]}'
{"id":"openstack%2Fnetworking-bagpipe~686489","triplet_id":"openstack%2Fnetworking-bagpipe~master~I39233176ab9a3fd221fdd3f1871d5b1fe0ca601d","project":"openstack/networking-bagpipe","branch":"master","topic":"bug/1846601","hashtags":[],"change_id":"I39233176ab9a3fd221fdd3f1871d5b1fe0ca601d","subject":"Fix TypeError when calling join on bytes sequence","status":"MERGED","created":"2019-10-03 20:24:44.000000000","updated":"2019-10-15 20:17:40.000000000","submitted":"2019-10-07 16:45:19.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"686489-1570466719419-33a7a8e1","meta_rev_id":"943570d23c7deefea6c18805d54d44e5b7dbc493","_number":686489,"virtual_id_number":686489,"owner":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},{"value":0,"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-07 16:45:19.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"all":[{"value":2,"date":"2019-10-07 07:14:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},{"value":2,"date":"2019-10-07 15:02:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"all":[{"value":0,"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},{"value":1,"date":"2019-10-07 15:02:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},{"value":0,"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-07 07:14:31.000000000","updated_by":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"reviewer":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"state":"REVIEWER"},{"updated":"2019-10-07 15:02:49.000000000","updated_by":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"reviewer":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"state":"REVIEWER"},{"updated":"2019-10-07 16:45:19.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e6496f15959c3f4f7b6f3de6c94ab53794792c70","author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"date":"2019-10-03 20:24:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1765d328d1d6996f5263d07a7291dd2ee0ae294e","author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"date":"2019-10-03 20:39:50.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"8feb7b31a4158f20c7508527cdb747970ff8cb83","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-03 22:12:19.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f1a2ba468f5d44cdb8802fe90e8a9ca8 : SUCCESS in 6m 33s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/b60d420dec594458aeff67d73db58c51 : FAILURE in 6m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c92fd0ffaafe48489ee88166e3b03bcc : SUCCESS in 6m 46s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/c892ef60b5424d859e9ec54267518702 : SUCCESS in 8m 15s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6661289a00d64d3da860fab232df7da5 : SUCCESS in 5m 24s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5940306d560940d08182b553e2421af4 : SUCCESS in 5m 59s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9fdb2b4dc5cb44349ee35de16ae175df : SUCCESS in 6m 32s\n- neutron-tempest-plugin-bgpvpn-bagpipe https://zuul.opendev.org/t/openstack/build/d24d7c0c52b448e09a5b71a4a1f162e8 : SUCCESS in 1h 41m 29s\n- legacy-networking-bagpipe-dsvm-fullstack https://zuul.opendev.org/t/openstack/build/79a14d8907c44184a157ea5c20fdb64e : FAILURE in 18m 55s (non-voting)\n- networking-bagpipe-tempest https://zuul.opendev.org/t/openstack/build/abe1fadfd6164998842666a470d0a0e9 : SUCCESS in 1h 18m 14s","accounts_in_message":[],"_revision_number":1},{"id":"a2db4837752cc9a52875571df63690d27b17bed6","author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"date":"2019-10-04 07:39:48.000000000","message":"Patch Set 1: Workflow-1\n\nIt\u0027s not working as expected yet. I need to investigate more","accounts_in_message":[],"_revision_number":1},{"id":"462e053a04ed20148ac7a996aafd51672858d542","author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"date":"2019-10-04 07:39:51.000000000","message":"Removed Workflow+1 by Thomas Morin \u003ctmmorin.orange@gmail.com\u003e\n","accounts_in_message":[],"_revision_number":1},{"id":"7d7191058bb251486800e008edb110159c853f0d","author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"date":"2019-10-04 08:22:02.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"dac8219f1c195e55d1a4d6de587eb2d81cf63ca2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-04 09:49:05.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fe62fad388594290a5134abecbbb00e4 : SUCCESS in 7m 13s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/4093b46e236945d88d8af4be5cf66299 : SUCCESS in 11m 39s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6f7595efc7644bc68b7f28bc96968608 : SUCCESS in 7m 39s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/395cd24df49749b68ebca1ba81d020d9 : SUCCESS in 7m 06s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8bed8ca7417347ccb3b4de8340da8b7c : SUCCESS in 6m 10s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4c05ffaca504404d9f3ca6cf4d887eba : SUCCESS in 8m 08s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e4a5f3415d7d439e94351365f2939740 : SUCCESS in 7m 40s\n- neutron-tempest-plugin-bgpvpn-bagpipe https://zuul.opendev.org/t/openstack/build/442020344f4d43199eab4f752a73bf4b : SUCCESS in 1h 24m 08s\n- legacy-networking-bagpipe-dsvm-fullstack https://zuul.opendev.org/t/openstack/build/50536d0ae9d34b6597ca973847aee14c : FAILURE in 19m 05s (non-voting)\n- networking-bagpipe-tempest https://zuul.opendev.org/t/openstack/build/7745c829a99d47caaea7acea505035bf : SUCCESS in 1h 20m 27s","accounts_in_message":[],"_revision_number":2},{"id":"800c5e29c9ec028b43089196a4fcb21581f3466b","author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"date":"2019-10-07 07:14:31.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"7c9c9d4a143b52b6ba71b4f1206571588170a01a","author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"date":"2019-10-07 15:02:49.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"f1fef3b5ccd1f3e196cbe377a59a04362d3b6f3b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-07 15:03:00.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"f4c7f217a0c310f9a63dedab09d9ac2ddb86899b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-07 16:45:19.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"39b04f6c8ebf5541b301f4bda51a3c9e0a24b1d7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-07 16:45:19.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ddc6215e18a94d6fa68d655365608ee8 : SUCCESS in 11m 59s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/d7b813088bb2410e9a174b7fa9762e8b : SUCCESS in 6m 29s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6a29b026e7ba45f8b07051e7c4cc7e49 : SUCCESS in 5m 59s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/e7c31774e80a4e898f3260b66689d06b : SUCCESS in 6m 53s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8c82d0b051934a6a99ec5d3115a3f037 : SUCCESS in 6m 58s\n- neutron-tempest-plugin-bgpvpn-bagpipe https://zuul.opendev.org/t/openstack/build/68664679553843a5909d74c5f69e5e8d : SUCCESS in 1h 34m 37s\n- networking-bagpipe-tempest https://zuul.opendev.org/t/openstack/build/4adfc4c849aa4fa1aeef137b467fa648 : SUCCESS in 1h 40m 19s","accounts_in_message":[],"_revision_number":2},{"id":"019acef0f89e9c04001d6160b7371721366ab7cf","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-07 16:46:46.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/11123fee82504a388ff6a4633c00a70e : SUCCESS in 1m 06s","accounts_in_message":[],"_revision_number":2},{"id":"ac62e6b564131466156bb84398ca9b76011cc1aa","author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"date":"2019-10-15 20:17:40.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/train as commit 4f5a2617f07c8ca083b69c9c5b21f697c37aa4de","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"996ea4530433039ef41a3dcd82c48bba905480ad","revisions":{"63d1f338d43edd5f9bf5bc28e1cd3081785f61bd":{"kind":"REWORK","_number":1,"created":"2019-10-03 20:24:44.000000000","uploader":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"ref":"refs/changes/89/686489/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/networking-bagpipe","ref":"refs/changes/89/686489/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/networking-bagpipe refs/changes/89/686489/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/networking-bagpipe refs/changes/89/686489/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/networking-bagpipe refs/changes/89/686489/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/networking-bagpipe refs/changes/89/686489/1"}}},"commit":{"parents":[{"commit":"f9a31f5c01f93f9675c99917f39e7a72956de69c","subject":"Merge \"Ensure to python3 as basepython in all tox envs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-bagpipe/commit/f9a31f5c01f93f9675c99917f39e7a72956de69c"}]}],"author":{"name":"Slawek Kaplonski","email":"skaplons@redhat.com","date":"2019-10-03 20:21:47.000000000","tz":120},"committer":{"name":"Slawek Kaplonski","email":"skaplons@redhat.com","date":"2019-10-03 20:21:47.000000000","tz":120},"subject":"Fix TypeError when calling join on bytes sequence","message":"Fix TypeError when calling join on bytes sequence\n\nIn bagpipe_bgp.common.run_command module output of command\nis used to be called as argument of join() method.\nBut this output variable has type \"byte\" instead of string\nand that cause failures when it\u0027s running on Python 3.\n\nSo this patch fixes it by converting output variable always to\nstring.\n\nChange-Id: I39233176ab9a3fd221fdd3f1871d5b1fe0ca601d\nCloses-Bug: #1846601\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-bagpipe/commit/63d1f338d43edd5f9bf5bc28e1cd3081785f61bd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-bagpipe/commit/63d1f338d43edd5f9bf5bc28e1cd3081785f61bd"}]},"branch":"refs/heads/master"},"996ea4530433039ef41a3dcd82c48bba905480ad":{"kind":"REWORK","_number":2,"created":"2019-10-04 08:22:02.000000000","uploader":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"ref":"refs/changes/89/686489/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/networking-bagpipe","ref":"refs/changes/89/686489/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/networking-bagpipe refs/changes/89/686489/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/networking-bagpipe refs/changes/89/686489/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/networking-bagpipe refs/changes/89/686489/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/networking-bagpipe refs/changes/89/686489/2"}}},"commit":{"parents":[{"commit":"f9a31f5c01f93f9675c99917f39e7a72956de69c","subject":"Merge \"Ensure to python3 as basepython in all tox envs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-bagpipe/commit/f9a31f5c01f93f9675c99917f39e7a72956de69c"}]}],"author":{"name":"Slawek Kaplonski","email":"skaplons@redhat.com","date":"2019-10-03 20:21:47.000000000","tz":120},"committer":{"name":"Slawek Kaplonski","email":"skaplons@redhat.com","date":"2019-10-04 08:21:55.000000000","tz":120},"subject":"Fix TypeError when calling join on bytes sequence","message":"Fix TypeError when calling join on bytes sequence\n\nIn bagpipe_bgp.common.run_command module output and error\nof command are of type \"bytes\" instead of \"string\".\nThat causes some issues when it\u0027s running on Python 3.\n\nSo this patch fixes it by converting those variables always to\nthe string type.\n\nChange-Id: I39233176ab9a3fd221fdd3f1871d5b1fe0ca601d\nCloses-Bug: #1846601\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-bagpipe/commit/996ea4530433039ef41a3dcd82c48bba905480ad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-bagpipe/commit/996ea4530433039ef41a3dcd82c48bba905480ad"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}