)]}'
{"networking_bagpipe/bagpipe_bgp/vpn/evpn/linux_vxlan.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"724a153d21c230a8f93d8404f85bfc2ffaaf1564","unresolved":false,"context_lines":[{"line_number":354,"context_line":"    @log_decorator.log_info"},{"line_number":355,"context_line":"    def reset_state(self):"},{"line_number":356,"context_line":"        # delete all EVPN bridges"},{"line_number":357,"context_line":"        res \u003d privileged_utils.brctl(\u0027show\u0027, check_exit\u003d[0, 1])[0]"},{"line_number":358,"context_line":"        bridge_lines \u003d [line for line in res.split(\u0027\\n\u0027)[1:-1]"},{"line_number":359,"context_line":"                        if BRIDGE_NAME_PREFIX in line]"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_206bf9b8","line":357,"range":{"start_line":357,"start_character":63,"end_line":357,"end_character":66},"updated":"2020-10-13 09:36:34.000000000","message":"Shouldn\u0027t you check first if you have something in the list?","commit_id":"b8af628bb1d7809b3ab9ecfbf0d62fb3115296f5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fac40f6babf031aaa4545f8a604406fa5cbd97cd","unresolved":false,"context_lines":[{"line_number":354,"context_line":"    @log_decorator.log_info"},{"line_number":355,"context_line":"    def reset_state(self):"},{"line_number":356,"context_line":"        # delete all EVPN bridges"},{"line_number":357,"context_line":"        res \u003d privileged_utils.brctl(\u0027show\u0027, check_exit\u003d[0, 1])[0]"},{"line_number":358,"context_line":"        bridge_lines \u003d [line for line in res.split(\u0027\\n\u0027)[1:-1]"},{"line_number":359,"context_line":"                        if BRIDGE_NAME_PREFIX in line]"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"a447401a_4ca098c3","line":357,"range":{"start_line":357,"start_character":63,"end_line":357,"end_character":66},"in_reply_to":"9f560f44_206bf9b8","updated":"2021-03-10 07:41:13.000000000","message":"valid comment ,thanks","commit_id":"b8af628bb1d7809b3ab9ecfbf0d62fb3115296f5"}],"networking_bagpipe/privileged/privileged_utils.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"724a153d21c230a8f93d8404f85bfc2ffaaf1564","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"@privileged.default_cmd.entrypoint"},{"line_number":44,"context_line":"def brctl(params, check_exit\u003dTrue):"},{"line_number":45,"context_line":"    \"\"\"run brctl command"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    :param params: parameters for brctl"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_003fd585","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":9},"updated":"2020-10-13 09:36:34.000000000","message":"You can use pyroute2 to execute the commands you need in this plugin: add br, set fd, set stp, del br, add if.\n\nYou can see them in neutron.agent.linux.bridge_lib.Bridge","commit_id":"b8af628bb1d7809b3ab9ecfbf0d62fb3115296f5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fac40f6babf031aaa4545f8a604406fa5cbd97cd","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"@privileged.default_cmd.entrypoint"},{"line_number":44,"context_line":"def brctl(params, check_exit\u003dTrue):"},{"line_number":45,"context_line":"    \"\"\"run brctl command"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    :param params: parameters for brctl"}],"source_content_type":"text/x-python","patch_set":3,"id":"61c629ff_5170bea7","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":9},"in_reply_to":"9f560f44_003fd585","updated":"2021-03-10 07:41:13.000000000","message":"you are right, I added only todo now, but a good next step","commit_id":"b8af628bb1d7809b3ab9ecfbf0d62fb3115296f5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"724a153d21c230a8f93d8404f85bfc2ffaaf1564","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                       branch/master/oslo_concurrency/processutils.py#L207"},{"line_number":51,"context_line":"    :return: tupple of stdout, stderr"},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    cmd \u003d [\u0027brctl\u0027] + params.split()"},{"line_number":54,"context_line":"    res \u003d processutils.execute(*cmd, check_exit_code\u003dcheck_exit,"},{"line_number":55,"context_line":"                               run_as_root\u003dTrue)"},{"line_number":56,"context_line":"    return res"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_00207599","line":53,"range":{"start_line":53,"start_character":22,"end_line":53,"end_character":36},"updated":"2020-10-13 09:36:34.000000000","message":"an easy way to preserve the current code, not bad","commit_id":"b8af628bb1d7809b3ab9ecfbf0d62fb3115296f5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"724a153d21c230a8f93d8404f85bfc2ffaaf1564","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    :return: tupple of stdout, stderr"},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    cmd \u003d [\u0027brctl\u0027] + params.split()"},{"line_number":54,"context_line":"    res \u003d processutils.execute(*cmd, check_exit_code\u003dcheck_exit,"},{"line_number":55,"context_line":"                               run_as_root\u003dTrue)"},{"line_number":56,"context_line":"    return res"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_20049913","line":54,"updated":"2020-10-13 09:36:34.000000000","message":"nit:\n\nreturn processutils.execute(...)","commit_id":"b8af628bb1d7809b3ab9ecfbf0d62fb3115296f5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fac40f6babf031aaa4545f8a604406fa5cbd97cd","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    :return: tupple of stdout, stderr"},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    cmd \u003d [\u0027brctl\u0027] + params.split()"},{"line_number":54,"context_line":"    res \u003d processutils.execute(*cmd, check_exit_code\u003dcheck_exit,"},{"line_number":55,"context_line":"                               run_as_root\u003dTrue)"},{"line_number":56,"context_line":"    return res"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac41caf_c689e4f6","line":54,"in_reply_to":"9f560f44_20049913","updated":"2021-03-10 07:41:13.000000000","message":"Done","commit_id":"b8af628bb1d7809b3ab9ecfbf0d62fb3115296f5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"724a153d21c230a8f93d8404f85bfc2ffaaf1564","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    :param params: parameters for bridge"},{"line_number":64,"context_line":"    \"\"\""},{"line_number":65,"context_line":"    cmd \u003d [\u0027bridge\u0027] + params.split()"},{"line_number":66,"context_line":"    processutils.execute(*cmd, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_60117153","line":66,"updated":"2020-10-13 09:36:34.000000000","message":"nit: You can also return the value here","commit_id":"b8af628bb1d7809b3ab9ecfbf0d62fb3115296f5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fac40f6babf031aaa4545f8a604406fa5cbd97cd","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    :param params: parameters for bridge"},{"line_number":64,"context_line":"    \"\"\""},{"line_number":65,"context_line":"    cmd \u003d [\u0027bridge\u0027] + params.split()"},{"line_number":66,"context_line":"    processutils.execute(*cmd, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0cab08ec_df115c09","line":66,"in_reply_to":"9f560f44_60117153","updated":"2021-03-10 07:41:13.000000000","message":"Done","commit_id":"b8af628bb1d7809b3ab9ecfbf0d62fb3115296f5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0881c554a2591322601ac3d175b49d053cccf84b","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    cmd \u003d [\u0027modprobe\u0027, module_name]"},{"line_number":40,"context_line":"    processutils.execute(*cmd, check_exit_code\u003dTrue)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# TODO(lajoskatona): use pyroute2.IPDB()"},{"line_number":43,"context_line":"@privileged.default_cmd.entrypoint"},{"line_number":44,"context_line":"def brctl(params, check_exit\u003dTrue):"},{"line_number":45,"context_line":"    \"\"\"run brctl command"}],"source_content_type":"text/x-python","patch_set":6,"id":"b6a9ba6d_69f73f63","line":42,"range":{"start_line":42,"start_character":34,"end_line":42,"end_character":38},"updated":"2021-03-11 12:04:27.000000000","message":"+1 you\u0027ll speed up the code for sure, but for a follow-up patch","commit_id":"88235621757157e38cf7a2bad654e6ecfdf2ef01"}]}