)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"72442e1c5584e0c4540fed71f287b6769da88972","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Flood broadcast to dhcp tunnels"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The patch makes sure broadcast traffic is sent not only to EVPN"},{"line_number":10,"context_line":"tunnels, but for original neutron tunnels with DHCP). Mirror"},{"line_number":11,"context_line":"rule for ARP responder with higher priority than flooding."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1915522"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9e3a0966_c54db10c","line":10,"range":{"start_line":10,"start_character":51,"end_line":10,"end_character":52},"updated":"2021-02-24 13:19:39.000000000","message":"Missing something or redundant?","commit_id":"899f7c2abf5256a48bb9acb247f12990db03df64"}],"networking_bagpipe/agent/bgpvpn/agent_extension.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"983419c22dbd8f0e4ff4e761a5cfd5b0f0227e52","unresolved":true,"context_lines":[{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        # we need to copy the existing br-tun rules to dispatch to UCAST_TO_TUN"},{"line_number":545,"context_line":"        # and FLOOD_TO_TUN, but only for except_from_src_mac MAC,"},{"line_number":546,"context_line":"        # and with a priority of 5"},{"line_number":547,"context_line":"        self.tun_br.add_flow(table\u003dovs_agt_consts.PATCH_LV_TO_TUN,"},{"line_number":548,"context_line":"                             priority\u003d5,"},{"line_number":549,"context_line":"                             dl_src\u003dbgpvpn_const.FALLBACK_SRC_MAC,"}],"source_content_type":"text/x-python","patch_set":5,"id":"4a401c80_04ab669a","line":546,"updated":"2021-02-26 11:08:35.000000000","message":"nit: add please here as well that the important is to be higher priority than flooding","commit_id":"899f7c2abf5256a48bb9acb247f12990db03df64"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"983419c22dbd8f0e4ff4e761a5cfd5b0f0227e52","unresolved":true,"context_lines":[{"line_number":562,"context_line":"        # FLOOD_TO_TUN_BROADCAS table where we have ability to:"},{"line_number":563,"context_line":"        #  1. send traffic into the group table, and pass it to EVPN"},{"line_number":564,"context_line":"        #  2. broadcast to original DHCP"},{"line_number":565,"context_line":"        #  3. return back to FLOOD_TO_TUN table when no mutch found,"},{"line_number":566,"context_line":"        #     network is not associated with any bgpvpn"},{"line_number":567,"context_line":"        # We assume arp responder is mandatory for bgpvpn. So mirror"},{"line_number":568,"context_line":"        # default arp responder rule here with higher precedence to let"}],"source_content_type":"text/x-python","patch_set":5,"id":"16e028b4_258d1294","line":565,"range":{"start_line":565,"start_character":56,"end_line":565,"end_character":61},"updated":"2021-02-26 11:08:35.000000000","message":"nit: match?","commit_id":"899f7c2abf5256a48bb9acb247f12990db03df64"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"efc365cb137bb96227b9d5e90e31afb78a117611","unresolved":true,"context_lines":[{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        # NOTE(vsaienko) send broadcast traffic to dedicated"},{"line_number":563,"context_line":"        # FLOOD_TO_TUN_BROADCAS table where we have ability to:"},{"line_number":564,"context_line":"        #  1. send traffic into the group table, and pass it to EVPN"},{"line_number":565,"context_line":"        #  2. broadcast to original DHCP"},{"line_number":566,"context_line":"        #  3. return back to FLOOD_TO_TUN table when no match found,"},{"line_number":567,"context_line":"        #     network is not associated with any bgpvpn"},{"line_number":568,"context_line":"        # We assume arp responder is mandatory for bgpvpn. So mirror"},{"line_number":569,"context_line":"        # default arp responder rule here with higher precedence to let"},{"line_number":570,"context_line":"        # arp responder still respond to arps."}],"source_content_type":"text/x-python","patch_set":9,"id":"71c7def4_8aad9320","line":567,"range":{"start_line":564,"start_character":0,"end_line":567,"end_character":55},"updated":"2021-03-12 05:11:09.000000000","message":"These should be:\n1. DHCP to traditional table\n2. ARP to arp responder table\n3. unicast to specific tunnel\nAm I right?","commit_id":"2ce59564df3adcc5359d8fca81003c73850c1572"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"efc365cb137bb96227b9d5e90e31afb78a117611","unresolved":true,"context_lines":[{"line_number":570,"context_line":"        # arp responder still respond to arps."},{"line_number":571,"context_line":"        self.tun_br.add_flow(table\u003dovs_agt_consts.PATCH_LV_TO_TUN,"},{"line_number":572,"context_line":"                             priority\u003d3,"},{"line_number":573,"context_line":"                             dl_dst\u003d\"ff:ff:ff:ff:ff:ff\","},{"line_number":574,"context_line":"                             actions\u003d(\"resubmit(,%d)\" %"},{"line_number":575,"context_line":"                                      ovs_agt_consts.ARP_RESPONDER))"},{"line_number":576,"context_line":"        self.tun_br.add_flow(table\u003dovs_agt_consts.PATCH_LV_TO_TUN,"}],"source_content_type":"text/x-python","patch_set":9,"id":"67966469_9d421dd6","line":573,"range":{"start_line":573,"start_character":29,"end_line":573,"end_character":56},"updated":"2021-03-12 05:11:09.000000000","message":"DHCP request with unkown destination will also have mac \"ff:ff:ff:ff:ff:ff\", a tcpdump packet looks like this:\n\n13:05:19.057454 fa:16:3e:72:05:73 \u003e ff:ff:ff:ff:ff:ff, ethertype IPv4 (0x0800), length 354: 0.0.0.0.68 \u003e 255.255.255.255.67: BOOTP/DHCP, Request from fa:16:3e:72:05:73, length 312\n\nSo this match and action is what you intend to?\nIf this fix is for DHCP only, why do not add some DHCP match rule here?","commit_id":"2ce59564df3adcc5359d8fca81003c73850c1572"}],"networking_bagpipe/bagpipe_bgp/constants.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9aa84c5fee0887644d83ea42ac5bffe60a7f1130","unresolved":true,"context_lines":[{"line_number":41,"context_line":"# (minus 1 for trailing null)"},{"line_number":42,"context_line":"LINUX_DEV_LEN \u003d 15"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"FLOOD_TO_TUN_BROADCAST \u003d 222"}],"source_content_type":"text/x-python","patch_set":8,"id":"b6300ae1_7ad14c8e","line":44,"updated":"2021-03-04 04:02:56.000000000","message":"This is an OVS table ID, but it is not clear from the variable name.\nI know this follows the naming convention in OVS agnet constants.py, so the variable name is okay, but we need some comment here.\n\nIn addition, how can we ensure to avoid table ID conflicts.\nIs there any guideline on which drivers can use which range of table IDs?\nDo we need some notes in neutron/plugins/ml2/drivers/openvswitch/agent/common/constants.py too?","commit_id":"ab1584b29b43c51a7c880126dbe3d8f7c471b086"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ee609470cbc365fe1a215c9b725fd8268e6be59a","unresolved":true,"context_lines":[{"line_number":41,"context_line":"# (minus 1 for trailing null)"},{"line_number":42,"context_line":"LINUX_DEV_LEN \u003d 15"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"FLOOD_TO_TUN_BROADCAST \u003d 222"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a939663_06915402","line":44,"in_reply_to":"b6300ae1_7ad14c8e","updated":"2021-03-05 07:45:00.000000000","message":"I think there\u0027s no such rule now but the idea is good. The easiest seems to be add this 222 table as constant to neutron and use that here, thanks Akihiro.\nVasyl could you add a coment here with \"TODO: use neutron constant\" or similar?","commit_id":"ab1584b29b43c51a7c880126dbe3d8f7c471b086"}],"networking_bagpipe/bagpipe_bgp/vpn/evpn/ovs.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d6d12b496c3782ac6784cb650f096596aef90a35","unresolved":true,"context_lines":[{"line_number":180,"context_line":"                             priority\u003dFLOW_PRIORITY,"},{"line_number":181,"context_line":"                             dl_vlan\u003dself.vlan,"},{"line_number":182,"context_line":"                             actions\u003d\"group:%d,resubmit(,%d)\" % ("},{"line_number":183,"context_line":"                                 self.vlan, ovs_const.FLOOD_TO_TUN))"},{"line_number":184,"context_line":"        self.log.debug(\"buckets: %s\", buckets)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def set_gateway_port(self, linuxif, gateway_ip):"}],"source_content_type":"text/x-python","patch_set":1,"id":"04bcee43_c2a015d2","line":183,"updated":"2021-02-12 21:20:32.000000000","message":"we need default rule at the end that will send all non matched packets back to the 22 table","commit_id":"399e43c1939fc92d7d6c7db67ca804299ecb0d72"}]}