)]}'
{"networking_baremetal/agent/ironic_neutron_agent.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"bdf648d173ecf9d584af5e2667715230d1c98657","unresolved":true,"context_lines":[{"line_number":224,"context_line":"            LOG.info(\u0027L2VNI trunk manager initialized\u0027)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"            # Register OVN event handlers for L2VNI reconciliation"},{"line_number":227,"context_line":"            if (CONF.l2vni.enable_l2vni_trunk_reconciliation_events"},{"line_number":228,"context_line":"                    and self.trunk_manager.ovn_nb_idl):"},{"line_number":229,"context_line":"                from networking_baremetal.agent import ovn_events"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3918c068_f12c501f","side":"PARENT","line":227,"updated":"2026-09-22 17:14:55.000000000","message":"GR-OSS team review:\n\nWe are confused. This change claims to make reconciliation_events turn off atomically with reconciliation, but it appears to disable events unconditionally. Where did this code block go?","commit_id":"8fc25fe4292ff136cf77b50cff82300c560fea24"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"aab6bed9ff9a324f4bf232836887618c51d2c36f","unresolved":true,"context_lines":[{"line_number":224,"context_line":"            LOG.info(\u0027L2VNI trunk manager initialized\u0027)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"            # Register OVN event handlers for L2VNI reconciliation"},{"line_number":227,"context_line":"            if (CONF.l2vni.enable_l2vni_trunk_reconciliation_events"},{"line_number":228,"context_line":"                    and self.trunk_manager.ovn_nb_idl):"},{"line_number":229,"context_line":"                from networking_baremetal.agent import ovn_events"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d5045481_8b0af0a0","side":"PARENT","line":227,"in_reply_to":"3918c068_f12c501f","updated":"2026-09-22 17:50:55.000000000","message":"So I originally had this as two separate patches which made this more clear but then I squashed it together as one that makes it a bit confusing. This is part of the dedup removal. We setup one in the __init__ and then forgot about it and setup another one in _register_ovn_event_handlers() which resulted in the event handler firing twice. By removing this one we avoid the duplication.","commit_id":"8fc25fe4292ff136cf77b50cff82300c560fea24"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"d6c5839382870f37fbb2568d42919d0e0ec1658c","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            LOG.info(\u0027L2VNI trunk manager initialized\u0027)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"            # Register OVN event handlers for L2VNI reconciliation"},{"line_number":227,"context_line":"            if (CONF.l2vni.enable_l2vni_trunk_reconciliation_events"},{"line_number":228,"context_line":"                    and self.trunk_manager.ovn_nb_idl):"},{"line_number":229,"context_line":"                from networking_baremetal.agent import ovn_events"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"798c68ee_11038142","side":"PARENT","line":227,"in_reply_to":"d5045481_8b0af0a0","updated":"2026-09-23 05:20:43.000000000","message":"Done","commit_id":"8fc25fe4292ff136cf77b50cff82300c560fea24"}]}
