)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1483ccfdc4aa3bd1195d9169b799ea3c89352868","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-01-08 15:06:18 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch from MechanismDriver to SimpleAgentMechanismDriverBase"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related-Bug: #1658964"},{"line_number":10,"context_line":"Change-Id: I952c7afbef5e80e3fd2a7f32f11bdc522e1ea397"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f91af0f_8e2e0790","line":8,"updated":"2018-01-08 19:55:24.000000000","message":"I don\u0027t understand why your making this change from the commit message.\n\nOkay, revising that statement after digging into neutron and neutron-lib ml2 driver interfaces. Please add a statement indicating that it is being changed to facilitate better integration, or... whatever makes sense.","commit_id":"b7c9fe5bb599806c353d91471904c75910510f68"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"32425c1a8e877e3445d95b81438213c2b4d10847","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-01-08 15:06:18 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch from MechanismDriver to SimpleAgentMechanismDriverBase"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related-Bug: #1658964"},{"line_number":10,"context_line":"Change-Id: I952c7afbef5e80e3fd2a7f32f11bdc522e1ea397"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f91af0f_b0a0e691","line":8,"in_reply_to":"9f91af0f_8e2e0790","updated":"2018-01-09 22:43:44.000000000","message":"Done","commit_id":"b7c9fe5bb599806c353d91471904c75910510f68"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"244bea4c9977c082c9631c030bffe8213cbc2311","unresolved":false,"context_lines":[{"line_number":13,"context_line":"detrmine if the segment specified can be bound."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":" * Use constants instead of strings in unit tests."},{"line_number":16,"context_line":" * Suppress pyroute2 warning to pass the doc build."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-Bug: #1658964"},{"line_number":19,"context_line":"Change-Id: I952c7afbef5e80e3fd2a7f32f11bdc522e1ea397"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f91af0f_bb3c472f","line":16,"updated":"2018-01-10 02:32:00.000000000","message":"For any other reviewers: This is what neutron does in-tree. :(","commit_id":"cc7709173bd779ea2b20d0278ca13e133705c8d5"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1b0f04037d3a2329a6ddbe8ecf8ef17d7597e8dc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch from MechanismDriver to SimpleAgentMechanismDriverBase"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To integrate with the baremetal neutron L2 agent switch to agent"},{"line_number":10,"context_line":"mechanism driver. The barametal neutron L2 agent populates"},{"line_number":11,"context_line":"bridge_mapping configuration, the agent mechanism driver will"},{"line_number":12,"context_line":"get the bridge mappings from agent_db data and use this to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"5f93b717_af847d5f","line":9,"range":{"start_line":9,"start_character":49,"end_line":9,"end_character":55},"updated":"2018-01-26 15:32:36.000000000","message":"s/switch//","commit_id":"dde5669373546d560b45df5920e6ecf4c43fdbeb"}],"networking_baremetal/plugins/ml2/baremetal_mech.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1483ccfdc4aa3bd1195d9169b799ea3c89352868","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        \"\"\"Try to bind with segment for agent."},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        :param context: PortContext instance describing the port"},{"line_number":324,"context_line":"        :param segment: segment dictionary describing segment to bind"},{"line_number":325,"context_line":"        :param agent: agents_db entry describing agent to bind"},{"line_number":326,"context_line":"        :returns: True iff segment has been bound for agent"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_2b81edfb","line":324,"updated":"2018-01-08 19:55:24.000000000","message":"nit: It might be helpful to include an example, or reference to where it can be looked up.\n\nAlso, It might be a good idea to end each line with a period.","commit_id":"b7c9fe5bb599806c353d91471904c75910510f68"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"32425c1a8e877e3445d95b81438213c2b4d10847","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        \"\"\"Try to bind with segment for agent."},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        :param context: PortContext instance describing the port"},{"line_number":324,"context_line":"        :param segment: segment dictionary describing segment to bind"},{"line_number":325,"context_line":"        :param agent: agents_db entry describing agent to bind"},{"line_number":326,"context_line":"        :returns: True iff segment has been bound for agent"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_90a5a2a4","line":324,"in_reply_to":"9f91af0f_2b81edfb","updated":"2018-01-09 22:43:44.000000000","message":"I\u0027m not sure about the periods, the doc text is a copy from here:\nhttps://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/mech_agent.py#L115:L133\n\nI have added an example and reference.","commit_id":"b7c9fe5bb599806c353d91471904c75910510f68"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1483ccfdc4aa3bd1195d9169b799ea3c89352868","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        :param context: PortContext instance describing the port"},{"line_number":324,"context_line":"        :param segment: segment dictionary describing segment to bind"},{"line_number":325,"context_line":"        :param agent: agents_db entry describing agent to bind"},{"line_number":326,"context_line":"        :returns: True iff segment has been bound for agent"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        Called outside any transaction during bind_port() so that"},{"line_number":329,"context_line":"        derived MechanismDrivers can use agent_db data along with"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_4ba7910c","line":326,"range":{"start_line":326,"start_character":23,"end_line":326,"end_character":25},"updated":"2018-01-08 19:55:24.000000000","message":"s/iff/if/","commit_id":"b7c9fe5bb599806c353d91471904c75910510f68"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"32425c1a8e877e3445d95b81438213c2b4d10847","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        :param context: PortContext instance describing the port"},{"line_number":324,"context_line":"        :param segment: segment dictionary describing segment to bind"},{"line_number":325,"context_line":"        :param agent: agents_db entry describing agent to bind"},{"line_number":326,"context_line":"        :returns: True iff segment has been bound for agent"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        Called outside any transaction during bind_port() so that"},{"line_number":329,"context_line":"        derived MechanismDrivers can use agent_db data along with"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_2a054711","line":326,"range":{"start_line":326,"start_character":23,"end_line":326,"end_character":25},"in_reply_to":"9f91af0f_4ba7910c","updated":"2018-01-09 22:43:44.000000000","message":":) I was close submit a typo review for the neutron reference code where this was copied from. I belive it is intentintional. Ref: https://en.wikipedia.org/wiki/If_and_only_if","commit_id":"b7c9fe5bb599806c353d91471904c75910510f68"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"244bea4c9977c082c9631c030bffe8213cbc2311","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        :param context: PortContext instance describing the port"},{"line_number":324,"context_line":"        :param segment: segment dictionary describing segment to bind"},{"line_number":325,"context_line":"        :param agent: agents_db entry describing agent to bind"},{"line_number":326,"context_line":"        :returns: True iff segment has been bound for agent"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        Neutron segments api-ref:"},{"line_number":329,"context_line":"          https://developer.openstack.org/api-ref/network/v2/#segments"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f91af0f_3c0b4dd6","line":326,"range":{"start_line":326,"start_character":23,"end_line":326,"end_character":26},"updated":"2018-01-10 02:32:00.000000000","message":"nit: s/iff/if/","commit_id":"cc7709173bd779ea2b20d0278ca13e133705c8d5"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"c0808778c31a314eb951f303151dd0f8f4690a7a","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        :param context: PortContext instance describing the port"},{"line_number":324,"context_line":"        :param segment: segment dictionary describing segment to bind"},{"line_number":325,"context_line":"        :param agent: agents_db entry describing agent to bind"},{"line_number":326,"context_line":"        :returns: True iff segment has been bound for agent"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        Neutron segments api-ref:"},{"line_number":329,"context_line":"          https://developer.openstack.org/api-ref/network/v2/#segments"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_8a5421cc","line":326,"range":{"start_line":326,"start_character":23,"end_line":326,"end_character":26},"in_reply_to":"9f91af0f_3c0b4dd6","updated":"2018-01-12 08:53:16.000000000","message":"This is from the original neutron code.\niff is short for \"if and only if\".\nIt is in dictionaries: http://www.dictionary.com/browse/iff","commit_id":"cc7709173bd779ea2b20d0278ca13e133705c8d5"}],"test-requirements.txt":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"244bea4c9977c082c9631c030bffe8213cbc2311","unresolved":false,"context_lines":[{"line_number":5,"context_line":"bashate\u003e\u003d0.5.1 # Apache-2.0"},{"line_number":6,"context_line":"hacking!\u003d0.13.0,\u003c0.14,\u003e\u003d0.12.0 # Apache-2.0"},{"line_number":7,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":8,"context_line":"neutron-lib\u003e\u003d1.11.0 # Apache-2.0"},{"line_number":9,"context_line":"oslotest\u003e\u003d1.10.0 # Apache-2.0"},{"line_number":10,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"},{"line_number":11,"context_line":"testtools\u003e\u003d2.2.0 # MIT"}],"source_content_type":"text/plain","patch_set":6,"id":"9f91af0f_9c97f948","line":8,"updated":"2018-01-10 02:32:00.000000000","message":"This should be in requirements.txt.","commit_id":"cc7709173bd779ea2b20d0278ca13e133705c8d5"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"c0808778c31a314eb951f303151dd0f8f4690a7a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"bashate\u003e\u003d0.5.1 # Apache-2.0"},{"line_number":6,"context_line":"hacking!\u003d0.13.0,\u003c0.14,\u003e\u003d0.12.0 # Apache-2.0"},{"line_number":7,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":8,"context_line":"neutron-lib\u003e\u003d1.11.0 # Apache-2.0"},{"line_number":9,"context_line":"oslotest\u003e\u003d1.10.0 # Apache-2.0"},{"line_number":10,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"},{"line_number":11,"context_line":"testtools\u003e\u003d2.2.0 # MIT"}],"source_content_type":"text/plain","patch_set":6,"id":"7f96bb07_aa60fdcf","line":8,"in_reply_to":"9f91af0f_9c97f948","updated":"2018-01-12 08:53:16.000000000","message":"Done","commit_id":"cc7709173bd779ea2b20d0278ca13e133705c8d5"}]}