)]}'
{"networking_baremetal/agent/ironic_neutron_agent.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"00ee5deebec0460afaf2478fa71c3a7c8098a458","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        ironic_ports \u003d []"},{"line_number":208,"context_line":"        try:"},{"line_number":209,"context_line":"            ironic_ports \u003d self.ironic_client.ports(details\u003dTrue)"},{"line_number":210,"context_line":"        except Exception:"},{"line_number":211,"context_line":"            LOG.exception(\"Failed to get ironic ports data!\")"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        return ironic_ports"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff570b3c_e5b2cb93","line":210,"updated":"2020-05-19 13:16:15.000000000","message":"nit: we could use exceptions from openstacksdk here","commit_id":"51ad04767baf27cc4c78e950ae8ccaa484e9e222"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"3400cec85d70cc15a8db89bb64eb24cceb3a64da","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        ironic_ports \u003d []"},{"line_number":208,"context_line":"        try:"},{"line_number":209,"context_line":"            ironic_ports \u003d self.ironic_client.ports(details\u003dTrue)"},{"line_number":210,"context_line":"        except Exception:"},{"line_number":211,"context_line":"            LOG.exception(\"Failed to get ironic ports data!\")"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        return ironic_ports"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff570b3c_55924658","line":210,"in_reply_to":"ff570b3c_e5b2cb93","updated":"2020-05-19 14:42:14.000000000","message":"Done","commit_id":"51ad04767baf27cc4c78e950ae8ccaa484e9e222"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"00ee5deebec0460afaf2478fa71c3a7c8098a458","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                {state[\u0027host\u0027]: state[\u0027configurations\u0027]})"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"def _unregiser_deprectated_opts():"},{"line_number":259,"context_line":"    CONF.reset()"},{"line_number":260,"context_line":"    CONF.unregister_opts("},{"line_number":261,"context_line":"        [CONF._groups[ironic_client.IRONIC_GROUP]._opts[opt][\u0027opt\u0027]"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff570b3c_05dfffd5","line":258,"range":{"start_line":258,"start_character":15,"end_line":258,"end_character":26},"updated":"2020-05-19 13:16:15.000000000","message":"nit: deprecated","commit_id":"51ad04767baf27cc4c78e950ae8ccaa484e9e222"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"3400cec85d70cc15a8db89bb64eb24cceb3a64da","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                {state[\u0027host\u0027]: state[\u0027configurations\u0027]})"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"def _unregiser_deprectated_opts():"},{"line_number":259,"context_line":"    CONF.reset()"},{"line_number":260,"context_line":"    CONF.unregister_opts("},{"line_number":261,"context_line":"        [CONF._groups[ironic_client.IRONIC_GROUP]._opts[opt][\u0027opt\u0027]"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff570b3c_d21f8c69","line":258,"range":{"start_line":258,"start_character":15,"end_line":258,"end_character":26},"in_reply_to":"ff570b3c_05dfffd5","updated":"2020-05-19 14:42:14.000000000","message":"Done","commit_id":"51ad04767baf27cc4c78e950ae8ccaa484e9e222"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"00ee5deebec0460afaf2478fa71c3a7c8098a458","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    # TODO(hjensas): Imports from neutron in ironic_neutron_agent registers the"},{"line_number":268,"context_line":"    # client options. We need to unregister the options we are deprecating"},{"line_number":269,"context_line":"    # first to avoid DuplicateOptError. Remove this when dropping deprecations."},{"line_number":270,"context_line":"    _unregiser_deprectated_opts()"},{"line_number":271,"context_line":"    common_config.init(sys.argv[1:])"},{"line_number":272,"context_line":"    common_config.setup_logging()"},{"line_number":273,"context_line":"    agent \u003d BaremetalNeutronAgent()"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff570b3c_65f19b6b","line":270,"range":{"start_line":270,"start_character":15,"end_line":270,"end_character":26},"updated":"2020-05-19 13:16:15.000000000","message":"ditto","commit_id":"51ad04767baf27cc4c78e950ae8ccaa484e9e222"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"3400cec85d70cc15a8db89bb64eb24cceb3a64da","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    # TODO(hjensas): Imports from neutron in ironic_neutron_agent registers the"},{"line_number":268,"context_line":"    # client options. We need to unregister the options we are deprecating"},{"line_number":269,"context_line":"    # first to avoid DuplicateOptError. Remove this when dropping deprecations."},{"line_number":270,"context_line":"    _unregiser_deprectated_opts()"},{"line_number":271,"context_line":"    common_config.init(sys.argv[1:])"},{"line_number":272,"context_line":"    common_config.setup_logging()"},{"line_number":273,"context_line":"    agent \u003d BaremetalNeutronAgent()"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff570b3c_32136868","line":270,"range":{"start_line":270,"start_character":15,"end_line":270,"end_character":26},"in_reply_to":"ff570b3c_65f19b6b","updated":"2020-05-19 14:42:14.000000000","message":"Done","commit_id":"51ad04767baf27cc4c78e950ae8ccaa484e9e222"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"655ec5e434c4113097f5116463044046e16cbd66","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    def _get_ironic_ports(self):"},{"line_number":208,"context_line":"        ironic_ports \u003d []"},{"line_number":209,"context_line":"        try:"},{"line_number":210,"context_line":"            ironic_ports \u003d self.ironic_client.ports(details\u003dTrue)"},{"line_number":211,"context_line":"        except sdk_exc.OpenStackCloudException:"},{"line_number":212,"context_line":"            LOG.exception(\"Failed to get ironic ports data!\")"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ff570b3c_76451b43","line":210,"updated":"2020-05-29 09:13:39.000000000","message":"This an iterator, used to be a list. I\u0027d prefer we stick to one data format.","commit_id":"e9bb19236b749276809772670034066b7b8007ac"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a5f072d18d267ca3de2b27e11ad9e05f6719443a","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    def _get_ironic_ports(self):"},{"line_number":208,"context_line":"        ironic_ports \u003d []"},{"line_number":209,"context_line":"        try:"},{"line_number":210,"context_line":"            ironic_ports \u003d self.ironic_client.ports(details\u003dTrue)"},{"line_number":211,"context_line":"        except sdk_exc.OpenStackCloudException:"},{"line_number":212,"context_line":"            LOG.exception(\"Failed to get ironic ports data!\")"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ff570b3c_29c0647c","line":210,"in_reply_to":"ff570b3c_76451b43","updated":"2020-05-29 11:40:57.000000000","message":"I don\u0027t see a reason to convert it to a list?\nI updated the unit tests so client mock return an iterator.","commit_id":"e9bb19236b749276809772670034066b7b8007ac"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"655ec5e434c4113097f5116463044046e16cbd66","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    def _report_state(self):"},{"line_number":217,"context_line":"        node_states \u003d {}"},{"line_number":218,"context_line":"        ironic_ports \u003d self._get_ironic_ports()"},{"line_number":219,"context_line":"        if not ironic_ports:"},{"line_number":220,"context_line":"            return"},{"line_number":221,"context_line":"        for port in ironic_ports:"},{"line_number":222,"context_line":"            node \u003d port.node_id"}],"source_content_type":"text/x-python","patch_set":28,"id":"ff570b3c_d675079a","line":219,"updated":"2020-05-29 09:13:39.000000000","message":"Will not work with an iterator.","commit_id":"e9bb19236b749276809772670034066b7b8007ac"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a5f072d18d267ca3de2b27e11ad9e05f6719443a","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    def _report_state(self):"},{"line_number":217,"context_line":"        node_states \u003d {}"},{"line_number":218,"context_line":"        ironic_ports \u003d self._get_ironic_ports()"},{"line_number":219,"context_line":"        if not ironic_ports:"},{"line_number":220,"context_line":"            return"},{"line_number":221,"context_line":"        for port in ironic_ports:"},{"line_number":222,"context_line":"            node \u003d port.node_id"}],"source_content_type":"text/x-python","patch_set":28,"id":"ff570b3c_c9e8c817","line":219,"in_reply_to":"ff570b3c_d675079a","updated":"2020-05-29 11:40:57.000000000","message":"I dropped this. The following for loops will do nothing if the iterator is empty.","commit_id":"e9bb19236b749276809772670034066b7b8007ac"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"655ec5e434c4113097f5116463044046e16cbd66","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    CONF.reset()"},{"line_number":261,"context_line":"    CONF.unregister_opts("},{"line_number":262,"context_line":"        [CONF._groups[ironic_client.IRONIC_GROUP]._opts[opt][\u0027opt\u0027]"},{"line_number":263,"context_line":"         for opt in ironic_client._deprecated_opts.keys()],"},{"line_number":264,"context_line":"        group\u003dironic_client.IRONIC_GROUP)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ff570b3c_b678538f","line":263,"updated":"2020-05-29 09:13:39.000000000","message":"nit: .keys() is redundant","commit_id":"e9bb19236b749276809772670034066b7b8007ac"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a5f072d18d267ca3de2b27e11ad9e05f6719443a","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    CONF.reset()"},{"line_number":261,"context_line":"    CONF.unregister_opts("},{"line_number":262,"context_line":"        [CONF._groups[ironic_client.IRONIC_GROUP]._opts[opt][\u0027opt\u0027]"},{"line_number":263,"context_line":"         for opt in ironic_client._deprecated_opts.keys()],"},{"line_number":264,"context_line":"        group\u003dironic_client.IRONIC_GROUP)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ff570b3c_a9ebd40f","line":263,"in_reply_to":"ff570b3c_b678538f","updated":"2020-05-29 11:40:57.000000000","message":"Done","commit_id":"e9bb19236b749276809772670034066b7b8007ac"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"269b29383cdf38f9dc2a726a4c1ca366c1787f30","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        try:"},{"line_number":210,"context_line":"            ironic_ports \u003d self.ironic_client.ports(details\u003dTrue)"},{"line_number":211,"context_line":"        except sdk_exc.OpenStackCloudException:"},{"line_number":212,"context_line":"            LOG.exception(\"Failed to get ironic ports data!\")"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        return ironic_ports"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"ff570b3c_57be78d4","line":212,"updated":"2020-06-09 00:30:15.000000000","message":"Seems that this would previously kill the plugin, where as now it doesn\u0027t appear to be the case.  I gueuss it doesn\u0027t matter too much?","commit_id":"a4e75f839605f6e2aba6b5f658004e9ffabc7156"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"cfad0443b89059c04c71100dc4126b1587a26e93","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        try:"},{"line_number":210,"context_line":"            ironic_ports \u003d self.ironic_client.ports(details\u003dTrue)"},{"line_number":211,"context_line":"        except sdk_exc.OpenStackCloudException:"},{"line_number":212,"context_line":"            LOG.exception(\"Failed to get ironic ports data!\")"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        return ironic_ports"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"ff570b3c_49b22a4b","line":212,"in_reply_to":"ff570b3c_57be78d4","updated":"2020-06-11 08:01:43.000000000","message":"Yes, we killed the plugin in case of UnsupportedVersion and AuthPluginOptionsMissing, but for other exceptions it continues. openstacksdk does\u0027nt have the specific exceptions, so it makes sense to not kill the plug-in.","commit_id":"a4e75f839605f6e2aba6b5f658004e9ffabc7156"}],"networking_baremetal/ironic_client.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"25bbd8dd4811c22c0e57c5756d41a01176632072","unresolved":false,"context_lines":[{"line_number":46,"context_line":"@retrying.retry("},{"line_number":47,"context_line":"    retry_on_exception\u003dlambda e: isinstance("},{"line_number":48,"context_line":"        e, openstack.exceptions.NotSupported),"},{"line_number":49,"context_line":"    wait_exponential_multiplier\u003d1000, wait_exponential_max\u003d30000,)"},{"line_number":50,"context_line":"def get_client():"},{"line_number":51,"context_line":"    \"\"\"Get an ironic client connection.\"\"\""},{"line_number":52,"context_line":"    session \u003d _get_ironic_session()"}],"source_content_type":"text/x-python","patch_set":17,"id":"ff570b3c_6de261a2","line":49,"range":{"start_line":49,"start_character":64,"end_line":49,"end_character":65},"updated":"2020-05-15 13:22:52.000000000","message":"oops, will update once I see CI result.","commit_id":"4b2df37ebdece61d25a9a4696746b8b220651a83"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"549f89c6a6a976364568dd1915cd36ad57f6c344","unresolved":false,"context_lines":[{"line_number":46,"context_line":"@retrying.retry("},{"line_number":47,"context_line":"    retry_on_exception\u003dlambda e: isinstance("},{"line_number":48,"context_line":"        e, openstack.exceptions.NotSupported),"},{"line_number":49,"context_line":"    wait_exponential_multiplier\u003d1000, wait_exponential_max\u003d30000,)"},{"line_number":50,"context_line":"def get_client():"},{"line_number":51,"context_line":"    \"\"\"Get an ironic client connection.\"\"\""},{"line_number":52,"context_line":"    session \u003d _get_ironic_session()"}],"source_content_type":"text/x-python","patch_set":17,"id":"ff570b3c_f3b5b27f","line":49,"range":{"start_line":49,"start_character":64,"end_line":49,"end_character":65},"in_reply_to":"ff570b3c_6de261a2","updated":"2020-05-15 14:50:10.000000000","message":"Done","commit_id":"4b2df37ebdece61d25a9a4696746b8b220651a83"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"896859072f13d0dce20a3e7feba0872e3bf6600f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                      \u0027(HTTP 409).\u0027)),"},{"line_number":45,"context_line":"]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"CONF.register_opts(IRONIC_OPTS, group\u003dIRONIC_GROUP)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":18,"id":"ff570b3c_61a1ba94","side":"PARENT","line":47,"updated":"2020-05-16 10:21:38.000000000","message":"we need to handle backward compatibility for the removed options or at least create a release note explaining the removal (auth_strategy -\u003e auth_type, ironic_url -\u003e endpoint_override, etc)","commit_id":"87cf218c5c3375773084e64919125565acec48d4"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ab0b0859914babd9b3f686ef987b19fd5f51ec5d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                      \u0027(HTTP 409).\u0027)),"},{"line_number":45,"context_line":"]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"CONF.register_opts(IRONIC_OPTS, group\u003dIRONIC_GROUP)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":18,"id":"ff570b3c_20616ad4","side":"PARENT","line":47,"in_reply_to":"ff570b3c_61a1ba94","updated":"2020-05-18 13:27:49.000000000","message":"yes this makes sense.\nauth_strategy and auth_type does map nicely. I went for ignoring auth_strategy and adding an upgrade node. The alternative might be to set the default auth_strategy to \u0027None\u0027 and try to handle it by setting auth_type overrides if auth_strategy is set?","commit_id":"87cf218c5c3375773084e64919125565acec48d4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"896859072f13d0dce20a3e7feba0872e3bf6600f","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def get_session(group):"},{"line_number":57,"context_line":"    loading.register_session_conf_options(CONF, group)"},{"line_number":58,"context_line":"    loading.register_auth_conf_options(CONF, group)"},{"line_number":59,"context_line":"    auth \u003d loading.load_auth_from_conf_options(CONF, group)"},{"line_number":60,"context_line":"    session \u003d loading.load_session_from_conf_options("},{"line_number":61,"context_line":"        CONF, group, auth\u003dauth)"}],"source_content_type":"text/x-python","patch_set":18,"id":"ff570b3c_c1aa466f","side":"PARENT","line":58,"updated":"2020-05-16 10:21:38.000000000","message":"Are you sure we don\u0027t need to register the options any more?","commit_id":"87cf218c5c3375773084e64919125565acec48d4"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ab0b0859914babd9b3f686ef987b19fd5f51ec5d","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def get_session(group):"},{"line_number":57,"context_line":"    loading.register_session_conf_options(CONF, group)"},{"line_number":58,"context_line":"    loading.register_auth_conf_options(CONF, group)"},{"line_number":59,"context_line":"    auth \u003d loading.load_auth_from_conf_options(CONF, group)"},{"line_number":60,"context_line":"    session \u003d loading.load_session_from_conf_options("},{"line_number":61,"context_line":"        CONF, group, auth\u003dauth)"}],"source_content_type":"text/x-python","patch_set":18,"id":"ff570b3c_8414d145","side":"PARENT","line":58,"in_reply_to":"ff570b3c_c1aa466f","updated":"2020-05-18 13:27:49.000000000","message":"afaict we should register the options first:\nhttps://opendev.org/openstack/keystoneauth/src/branch/master/keystoneauth1/loading/conf.py#L103-L104","commit_id":"87cf218c5c3375773084e64919125565acec48d4"}],"requirements.txt":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"7922fa8d5dd6c16a3bfc0390cb37c8ee495aaf49","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"retrying!\u003d1.3.0 # Apache-2.0"},{"line_number":6,"context_line":"neutron-lib\u003e\u003d1.28.0 # Apache-2.0"},{"line_number":7,"context_line":"oslo.config\u003e\u003d5.2.0 # Apache-2.0"},{"line_number":8,"context_line":"oslo.i18n\u003e\u003d3.15.3 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":17,"id":"ff570b3c_105e5c43","line":5,"updated":"2020-05-15 14:08:23.000000000","message":"this should include \u003e\u003d1.2.3","commit_id":"4b2df37ebdece61d25a9a4696746b8b220651a83"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"549f89c6a6a976364568dd1915cd36ad57f6c344","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"retrying!\u003d1.3.0 # Apache-2.0"},{"line_number":6,"context_line":"neutron-lib\u003e\u003d1.28.0 # Apache-2.0"},{"line_number":7,"context_line":"oslo.config\u003e\u003d5.2.0 # Apache-2.0"},{"line_number":8,"context_line":"oslo.i18n\u003e\u003d3.15.3 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":17,"id":"ff570b3c_338a8abe","line":5,"in_reply_to":"ff570b3c_105e5c43","updated":"2020-05-15 14:50:10.000000000","message":"Done","commit_id":"4b2df37ebdece61d25a9a4696746b8b220651a83"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"896859072f13d0dce20a3e7feba0872e3bf6600f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"retrying!\u003d1.3.0,\u003e\u003d1.2.3 # Apache-2.0"},{"line_number":6,"context_line":"neutron-lib\u003e\u003d1.28.0 # Apache-2.0"},{"line_number":7,"context_line":"oslo.config\u003e\u003d5.2.0 # Apache-2.0"},{"line_number":8,"context_line":"oslo.i18n\u003e\u003d3.15.3 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":18,"id":"ff570b3c_81a4cea7","line":5,"updated":"2020-05-16 10:21:38.000000000","message":"nit: retrying is not maintained, we should use tenacity probably","commit_id":"bbac84236b8e7f2a1642932472310e8a8105e625"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ab0b0859914babd9b3f686ef987b19fd5f51ec5d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"retrying!\u003d1.3.0,\u003e\u003d1.2.3 # Apache-2.0"},{"line_number":6,"context_line":"neutron-lib\u003e\u003d1.28.0 # Apache-2.0"},{"line_number":7,"context_line":"oslo.config\u003e\u003d5.2.0 # Apache-2.0"},{"line_number":8,"context_line":"oslo.i18n\u003e\u003d3.15.3 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":18,"id":"ff570b3c_00b3864e","line":5,"in_reply_to":"ff570b3c_81a4cea7","updated":"2020-05-18 13:27:49.000000000","message":"Done","commit_id":"bbac84236b8e7f2a1642932472310e8a8105e625"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"00ee5deebec0460afaf2478fa71c3a7c8098a458","unresolved":false,"context_lines":[{"line_number":13,"context_line":"tooz\u003e\u003d1.58.0 # Apache-2.0"},{"line_number":14,"context_line":"neutron\u003e\u003d14.0.0.0b1  # Apache-2.0"},{"line_number":15,"context_line":"tenacity\u003e\u003d4.9.0  # Apache-2.0"},{"line_number":16,"context_line":""}],"source_content_type":"text/plain","patch_set":26,"id":"ff570b3c_459bb716","line":16,"updated":"2020-05-19 13:16:15.000000000","message":"nit: remove blank line","commit_id":"51ad04767baf27cc4c78e950ae8ccaa484e9e222"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"3400cec85d70cc15a8db89bb64eb24cceb3a64da","unresolved":false,"context_lines":[{"line_number":13,"context_line":"tooz\u003e\u003d1.58.0 # Apache-2.0"},{"line_number":14,"context_line":"neutron\u003e\u003d14.0.0.0b1  # Apache-2.0"},{"line_number":15,"context_line":"tenacity\u003e\u003d4.9.0  # Apache-2.0"},{"line_number":16,"context_line":""}],"source_content_type":"text/plain","patch_set":26,"id":"ff570b3c_b2581856","line":16,"in_reply_to":"ff570b3c_459bb716","updated":"2020-05-19 14:42:14.000000000","message":"Done","commit_id":"51ad04767baf27cc4c78e950ae8ccaa484e9e222"}]}