)]}'
{"networking_baremetal/agent/ironic_neutron_agent.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"96c9e2ab5436d14621dc1c27a29b04cb997184de","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import eventlet"},{"line_number":17,"context_line":"from urllib import parse as urlparse"},{"line_number":18,"context_line":"# oslo_messaging/notify/listener.py documents that monkeypatching is required"},{"line_number":19,"context_line":"eventlet.monkey_patch()"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8df5e2ce","line":17,"updated":"2019-12-04 07:00:41.000000000","message":"I wonder why not just import parse so we only need to change this line.","commit_id":"7ea0e6f76edfb2a7bb0e1d946ed2a08595104744"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f59ebce3208141b3655e382df5cf95684a945bd8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import eventlet"},{"line_number":17,"context_line":"from urllib import parse as urlparse"},{"line_number":18,"context_line":"# oslo_messaging/notify/listener.py documents that monkeypatching is required"},{"line_number":19,"context_line":"eventlet.monkey_patch()"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_6b516ed9","line":17,"in_reply_to":"3fa7e38b_8df5e2ce","updated":"2019-12-04 09:14:31.000000000","message":"3 reasons:\n- this was an automated change, visually double-checked\n- it keeps consistency with the other projects, we normally do the same import statement in other places\n- (more personal opinion) parse is very generic, urlparse gives immediately the context and the origin library","commit_id":"7ea0e6f76edfb2a7bb0e1d946ed2a08595104744"}]}