)]}'
{"networking_baremetal/agent/ironic_neutron_agent.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0b972a52d88d8530d09c385e150f8f4eba7f323d","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import eventlet"},{"line_number":21,"context_line":"# oslo_messaging/notify/listener.py documents that monkeypatching is required"},{"line_number":22,"context_line":"# NOTE(rpittau) using noqa here to prevent E402 flake8 rule to complain"},{"line_number":23,"context_line":"eventlet.monkey_patch()"},{"line_number":24,"context_line":"import ironicclient.common.apiclient.exceptions as ironic_exc  # noqa: E402"},{"line_number":25,"context_line":"from neutron.agent import rpc as agent_rpc  # noqa: E402"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_e7e1c100","line":22,"updated":"2020-05-12 10:45:12.000000000","message":"can we use file-based ignores instead?","commit_id":"adcec884b079061e92ac9393f3c7472869f4e74c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"478e75183fad9720653013ec48875eee9e158be2","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import eventlet"},{"line_number":21,"context_line":"# oslo_messaging/notify/listener.py documents that monkeypatching is required"},{"line_number":22,"context_line":"# NOTE(rpittau) using noqa here to prevent E402 flake8 rule to complain"},{"line_number":23,"context_line":"eventlet.monkey_patch()"},{"line_number":24,"context_line":"import ironicclient.common.apiclient.exceptions as ironic_exc  # noqa: E402"},{"line_number":25,"context_line":"from neutron.agent import rpc as agent_rpc  # noqa: E402"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_c4f0f893","line":22,"in_reply_to":"ff570b3c_e7e1c100","updated":"2020-05-12 12:28:01.000000000","message":"yeah, will do that","commit_id":"adcec884b079061e92ac9393f3c7472869f4e74c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0b972a52d88d8530d09c385e150f8f4eba7f323d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                self.members.append(payload)"},{"line_number":97,"context_line":"            except Exception:"},{"line_number":98,"context_line":"                msg \u003d \u0027Failed to add member %s to hash ring!\u0027 % payload[\u0027id\u0027]"},{"line_number":99,"context_line":"                LOG.exception(msg)"},{"line_number":100,"context_line":"        else:"},{"line_number":101,"context_line":"            for member in self.members:"},{"line_number":102,"context_line":"                if payload[\u0027id\u0027] \u003d\u003d member[\u0027id\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_07b2f5e6","line":99,"updated":"2020-05-12 10:45:12.000000000","message":"not sure what exactly it complained about, but maybe it needed changing % to , ?","commit_id":"adcec884b079061e92ac9393f3c7472869f4e74c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"478e75183fad9720653013ec48875eee9e158be2","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                self.members.append(payload)"},{"line_number":97,"context_line":"            except Exception:"},{"line_number":98,"context_line":"                msg \u003d \u0027Failed to add member %s to hash ring!\u0027 % payload[\u0027id\u0027]"},{"line_number":99,"context_line":"                LOG.exception(msg)"},{"line_number":100,"context_line":"        else:"},{"line_number":101,"context_line":"            for member in self.members:"},{"line_number":102,"context_line":"                if payload[\u0027id\u0027] \u003d\u003d member[\u0027id\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_8424400f","line":99,"in_reply_to":"ff570b3c_07b2f5e6","updated":"2020-05-12 12:28:01.000000000","message":"\"String interpolation should be delayed to be handled by the logging code, rather than being done at the point of the logging call.\"\nThe other solution would be using \u0027,\u0027 instead of \u0027%\u0027","commit_id":"adcec884b079061e92ac9393f3c7472869f4e74c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dcbc2b670b8504279466ddfa6cb963b923ee587a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                self.members.append(payload)"},{"line_number":97,"context_line":"            except Exception:"},{"line_number":98,"context_line":"                msg \u003d \u0027Failed to add member %s to hash ring!\u0027 % payload[\u0027id\u0027]"},{"line_number":99,"context_line":"                LOG.exception(msg)"},{"line_number":100,"context_line":"        else:"},{"line_number":101,"context_line":"            for member in self.members:"},{"line_number":102,"context_line":"                if payload[\u0027id\u0027] \u003d\u003d member[\u0027id\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_474b4a83","line":99,"in_reply_to":"ff570b3c_8424400f","updated":"2020-05-12 13:03:50.000000000","message":"Using , is the right thing to do, let\u0027s not hack around this rule","commit_id":"adcec884b079061e92ac9393f3c7472869f4e74c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0b972a52d88d8530d09c385e150f8f4eba7f323d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                except Exception:"},{"line_number":115,"context_line":"                    msg \u003d (\u0027Failed to remove member %s from hash ring!\u0027"},{"line_number":116,"context_line":"                           % member[\u0027id\u0027])"},{"line_number":117,"context_line":"                    LOG.exception(msg)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        return oslo_messaging.NotificationResult.HANDLED"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_47cb4d52","line":117,"updated":"2020-05-12 10:45:12.000000000","message":"ditto?","commit_id":"adcec884b079061e92ac9393f3c7472869f4e74c"}],"test-requirements.txt":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0b972a52d88d8530d09c385e150f8f4eba7f323d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":13,"context_line":"testscenarios\u003e\u003d0.4 # Apache-2.0/BSD"},{"line_number":14,"context_line":"flake8-import-order\u003e\u003d0.17.1 # LGPLv3"},{"line_number":15,"context_line":"pyflakes\u003e\u003d1.6.0 # MIT"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Doc requirements"},{"line_number":18,"context_line":"sphinx!\u003d1.6.6,!\u003d1.6.7,!\u003d2.1.0,\u003e\u003d1.6.2 # BSD"}],"source_content_type":"text/plain","patch_set":3,"id":"ff570b3c_47d06df8","line":15,"updated":"2020-05-12 10:45:12.000000000","message":"I don\u0027t think we should add it explicitly. Or do we need it for something?","commit_id":"adcec884b079061e92ac9393f3c7472869f4e74c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"478e75183fad9720653013ec48875eee9e158be2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":13,"context_line":"testscenarios\u003e\u003d0.4 # Apache-2.0/BSD"},{"line_number":14,"context_line":"flake8-import-order\u003e\u003d0.17.1 # LGPLv3"},{"line_number":15,"context_line":"pyflakes\u003e\u003d1.6.0 # MIT"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Doc requirements"},{"line_number":18,"context_line":"sphinx!\u003d1.6.6,!\u003d1.6.7,!\u003d2.1.0,\u003e\u003d1.6.2 # BSD"}],"source_content_type":"text/plain","patch_set":3,"id":"ff570b3c_a4f98481","line":15,"in_reply_to":"ff570b3c_47d06df8","updated":"2020-05-12 12:28:01.000000000","message":"not really, it\u0027s a dependency of flake8 so I guess it\u0027s ok to remove it from here as far as we have it in lower-constraints","commit_id":"adcec884b079061e92ac9393f3c7472869f4e74c"}]}