)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b334ebd26ca4536798e4d367834b669cd0fe19be","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[0] https://opendev.org/openstack/networking-generic-switch/src/branch/master/networking_generic_switch/generic_switch_mech.py#L446"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Related-Prod: PRODX-36721"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I3af25f7d230dd3576286ae63a5c70837d3c810a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"d547295f_d2dabd6a","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":25},"updated":"2023-12-11 13:39:29.000000000","message":"this does not look like an appropriate bug tracker for upstream changes. Please consider filing a bug in https://bugs.launchpad.net/networking-baremetal with details and link it.","commit_id":"a212ea7a57c8a880ff916871f1d287cb30212ae3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"fe268a16aaaa498a2e0cbb064ce02edc3a120582","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[0] https://opendev.org/openstack/networking-generic-switch/src/branch/master/networking_generic_switch/generic_switch_mech.py#L446"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Related-Prod: PRODX-36721"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I3af25f7d230dd3576286ae63a5c70837d3c810a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3c96111d_86dd59a3","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":25},"in_reply_to":"d547295f_d2dabd6a","updated":"2023-12-12 14:44:06.000000000","message":"Done","commit_id":"a212ea7a57c8a880ff916871f1d287cb30212ae3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"fe268a16aaaa498a2e0cbb064ce02edc3a120582","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7569b149_77db53b7","updated":"2023-12-12 14:44:06.000000000","message":"thanks for review","commit_id":"e5f8502de5ac0ff92f0d2a9e57740a2422ad97ef"}],"networking_baremetal/plugins/ml2/baremetal_mech.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b334ebd26ca4536798e4d367834b669cd0fe19be","unresolved":true,"context_lines":[{"line_number":486,"context_line":"                    return False"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"            by_device[device][\u0027links\u0027].append(link)"},{"line_number":489,"context_line":"          "},{"line_number":490,"context_line":"        if not by_device:"},{"line_number":491,"context_line":"            # NOTE(vsaienko): we can call set_binding ONLY when we complete"},{"line_number":492,"context_line":"            # binding for the port in the segment. We do not handle the port"}],"source_content_type":"text/x-python","patch_set":4,"id":"20fe01f7_e3c07716","line":489,"range":{"start_line":489,"start_character":0,"end_line":489,"end_character":10},"updated":"2023-12-11 13:39:29.000000000","message":"pep8 fails because of this.","commit_id":"a212ea7a57c8a880ff916871f1d287cb30212ae3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"fe268a16aaaa498a2e0cbb064ce02edc3a120582","unresolved":false,"context_lines":[{"line_number":486,"context_line":"                    return False"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"            by_device[device][\u0027links\u0027].append(link)"},{"line_number":489,"context_line":"          "},{"line_number":490,"context_line":"        if not by_device:"},{"line_number":491,"context_line":"            # NOTE(vsaienko): we can call set_binding ONLY when we complete"},{"line_number":492,"context_line":"            # binding for the port in the segment. We do not handle the port"}],"source_content_type":"text/x-python","patch_set":4,"id":"91d164b2_e0594db7","line":489,"range":{"start_line":489,"start_character":0,"end_line":489,"end_character":10},"in_reply_to":"20fe01f7_e3c07716","updated":"2023-12-12 14:44:06.000000000","message":"Done","commit_id":"a212ea7a57c8a880ff916871f1d287cb30212ae3"}],"networking_baremetal/tests/unit/plugins/ml2/test_baremetal_mech.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b334ebd26ca4536798e4d367834b669cd0fe19be","unresolved":true,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    @mock.patch.object(provisioning_blocks, \u0027add_provisioning_component\u0027,"},{"line_number":429,"context_line":"                       autospec\u003dTrue)"},{"line_number":430,"context_line":"    def test_no_device_does_bind_port(self, mock_p_blocks):"},{"line_number":431,"context_line":"        binding_profile \u003d {}"},{"line_number":432,"context_line":"        lli \u003d binding_profile[\u0027local_link_information\u0027] \u003d []"},{"line_number":433,"context_line":"        lli.append({\u0027port_id\u0027: \u0027test1/1\u0027, \u0027switch_id\u0027: \u002711:11:11:11:11:11\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fbb8ce93_31cfe805","line":430,"range":{"start_line":430,"start_character":8,"end_line":430,"end_character":37},"updated":"2023-12-11 13:39:29.000000000","message":"should this be updated ? IIUC binding will be skipped when no device is found with this change.","commit_id":"a212ea7a57c8a880ff916871f1d287cb30212ae3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8564948326b6654d61bf46a8efdcbdc1d2ed66c6","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    @mock.patch.object(provisioning_blocks, \u0027add_provisioning_component\u0027,"},{"line_number":429,"context_line":"                       autospec\u003dTrue)"},{"line_number":430,"context_line":"    def test_no_device_does_bind_port(self, mock_p_blocks):"},{"line_number":431,"context_line":"        binding_profile \u003d {}"},{"line_number":432,"context_line":"        lli \u003d binding_profile[\u0027local_link_information\u0027] \u003d []"},{"line_number":433,"context_line":"        lli.append({\u0027port_id\u0027: \u0027test1/1\u0027, \u0027switch_id\u0027: \u002711:11:11:11:11:11\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"38b341d1_26cf14b5","line":430,"range":{"start_line":430,"start_character":8,"end_line":430,"end_character":37},"in_reply_to":"23ab6da0_b028bfc1","updated":"2023-12-12 17:05:17.000000000","message":"Done","commit_id":"a212ea7a57c8a880ff916871f1d287cb30212ae3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"fe268a16aaaa498a2e0cbb064ce02edc3a120582","unresolved":true,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    @mock.patch.object(provisioning_blocks, \u0027add_provisioning_component\u0027,"},{"line_number":429,"context_line":"                       autospec\u003dTrue)"},{"line_number":430,"context_line":"    def test_no_device_does_bind_port(self, mock_p_blocks):"},{"line_number":431,"context_line":"        binding_profile \u003d {}"},{"line_number":432,"context_line":"        lli \u003d binding_profile[\u0027local_link_information\u0027] \u003d []"},{"line_number":433,"context_line":"        lli.append({\u0027port_id\u0027: \u0027test1/1\u0027, \u0027switch_id\u0027: \u002711:11:11:11:11:11\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"23ab6da0_b028bfc1","line":430,"range":{"start_line":430,"start_character":8,"end_line":430,"end_character":37},"in_reply_to":"fbb8ce93_31cfe805","updated":"2023-12-12 14:44:06.000000000","message":"this is updated, please check L441","commit_id":"a212ea7a57c8a880ff916871f1d287cb30212ae3"}],"releasenotes/notes/fix-conflict-with-ngs-41a862c292718c3b.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5ae0726f0bf46799bba8ffe1806a46163267c3fa","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    An issue when networking-baremetal try to bind port that"},{"line_number":5,"context_line":"    should be handled by other ml2 driver like"},{"line_number":6,"context_line":"    networking-generic-switch."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0e43c4a0_9e528bd3","line":4,"updated":"2023-12-15 09:32:01.000000000","message":"nit: \"Fixes an issue\" (otherwise it will be out of context)","commit_id":"e5f8502de5ac0ff92f0d2a9e57740a2422ad97ef"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"3e418f9fe7b46f5e3a96586294b58837d9e69c15","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    An issue when networking-baremetal try to bind port that"},{"line_number":5,"context_line":"    should be handled by other ml2 driver like"},{"line_number":6,"context_line":"    networking-generic-switch."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6d225071_507c1649","line":4,"in_reply_to":"0e43c4a0_9e528bd3","updated":"2023-12-17 19:29:38.000000000","message":"thanks for review Dmitry, done.","commit_id":"e5f8502de5ac0ff92f0d2a9e57740a2422ad97ef"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e2bfc4505041a2bdb496975a80a96ff013246b47","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    An issue when networking-baremetal try to bind port that"},{"line_number":5,"context_line":"    should be handled by other ml2 driver like"},{"line_number":6,"context_line":"    networking-generic-switch."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5e5f5420_71961cd2","line":4,"in_reply_to":"6d225071_507c1649","updated":"2023-12-17 19:29:48.000000000","message":"Done","commit_id":"e5f8502de5ac0ff92f0d2a9e57740a2422ad97ef"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"add4dbace286224f45a95cac8d34d3b82a9b854d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue an issue when networking-baremetal try"},{"line_number":5,"context_line":"    to bind port that should be handled by other ml2"},{"line_number":6,"context_line":"    driver like networking-generic-switch."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7386f3fb_9d0cafea","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":27},"updated":"2023-12-18 14:55:23.000000000","message":"nit: remove duplicate words","commit_id":"6ba1de8250e3f5e572f74fbd297bd160dffa20df"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"cd39c8508c374da4b6bff51f5caaecaea8a983ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue an issue when networking-baremetal try"},{"line_number":5,"context_line":"    to bind port that should be handled by other ml2"},{"line_number":6,"context_line":"    driver like networking-generic-switch."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5fc612ec_b39e02e2","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":27},"in_reply_to":"7386f3fb_9d0cafea","updated":"2023-12-18 17:59:56.000000000","message":"Done","commit_id":"6ba1de8250e3f5e572f74fbd297bd160dffa20df"}]}
