)]}'
{"networking_baremetal/agent/l2vni_trunk_manager.py":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"267dbbed3139bb2bfb5258d1a62436f3b3fd358b","unresolved":true,"context_lines":[{"line_number":439,"context_line":"        for row in table.rows.values():"},{"line_number":440,"context_line":"            ha_groups.append(row)"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        return ha_groups"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    def _discover_trunks(self):"},{"line_number":445,"context_line":"        \"\"\"Discover existing trunk ports for network nodes."}],"source_content_type":"text/x-python","patch_set":1,"id":"d83199f6_b871a9a4","line":442,"updated":"2026-03-27 04:54:37.000000000","message":"return list(tables.rows.values())\n\nIf you really don’t want the iterator. Otherwise just return the iterator","commit_id":"ee9f0a89718f793f365a280ee731cc7fcf4c8184"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"33c01c74be8e196dd30c6ef7dda03c1583d2fc2f","unresolved":true,"context_lines":[{"line_number":439,"context_line":"        for row in table.rows.values():"},{"line_number":440,"context_line":"            ha_groups.append(row)"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        return ha_groups"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    def _discover_trunks(self):"},{"line_number":445,"context_line":"        \"\"\"Discover existing trunk ports for network nodes."}],"source_content_type":"text/x-python","patch_set":1,"id":"14da15d6_a687eb55","line":442,"in_reply_to":"9a638f48_a85965da","updated":"2026-03-27 12:05:10.000000000","message":"Yeah I agree. The helper makes a clear what data we are getting.","commit_id":"ee9f0a89718f793f365a280ee731cc7fcf4c8184"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"8f64838453bda8c95140eb6fe5f8c2387e768292","unresolved":true,"context_lines":[{"line_number":439,"context_line":"        for row in table.rows.values():"},{"line_number":440,"context_line":"            ha_groups.append(row)"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        return ha_groups"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    def _discover_trunks(self):"},{"line_number":445,"context_line":"        \"\"\"Discover existing trunk ports for network nodes."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a638f48_a85965da","line":442,"in_reply_to":"d83199f6_b871a9a4","updated":"2026-03-27 11:41:43.000000000","message":"indeed ... so the I ended up with returning:\n  `self.ovn_nb_idl.tables[\u0027HA_Chassis_Group\u0027].rows.values()`\n\nAnd updated the docstring to say it return `Iterator of ...`\n\nThis is used in like 6 places so I think the function still has some value for code readability.","commit_id":"ee9f0a89718f793f365a280ee731cc7fcf4c8184"}]}