)]}'
{"bgpvpn_dashboard/test/project/test_forms.py":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"32f1d8f7046de39ce2c292e365a8ce42a884213b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        mock_bgpvpn_api.bgpvpns_list.return_value \u003d list_bgpvpns"},{"line_number":50,"context_line":"        self.bgpvpn_form.cleaned_data \u003d bgpvpn_data"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        expected_error_msg \u003d \u0027The name \"foo\" is already used by another \u0027 \\"},{"line_number":53,"context_line":"                             \u0027BGPVPN.\u0027"},{"line_number":54,"context_line":"        with self.assertRaisesRegexp(django_forms.ValidationError,"},{"line_number":55,"context_line":"                                     expected_error_msg):"},{"line_number":56,"context_line":"            self.bgpvpn_form.clean()"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_35b110e3","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":38},"updated":"2017-06-20 13:43:15.000000000","message":"I may have already asked the question on the initial dashboard change: should we really prevent that ? if the backend allows having two BGPVPNs witht the same name, then the dashboard should allow this as well shouldn\u0027t it ?","commit_id":"8e8e04a3b5ef06eaeb8292f7416c7f3371a64ab6"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"ef74860fe239b0e6856309529a9872f2105b2039","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        mock_bgpvpn_api.bgpvpns_list.return_value \u003d list_bgpvpns"},{"line_number":50,"context_line":"        self.bgpvpn_form.cleaned_data \u003d bgpvpn_data"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        expected_error_msg \u003d \u0027The name \"foo\" is already used by another \u0027 \\"},{"line_number":53,"context_line":"                             \u0027BGPVPN.\u0027"},{"line_number":54,"context_line":"        with self.assertRaisesRegexp(django_forms.ValidationError,"},{"line_number":55,"context_line":"                                     expected_error_msg):"},{"line_number":56,"context_line":"            self.bgpvpn_form.clean()"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_c8bc5b6b","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":38},"in_reply_to":"5f201791_35b110e3","updated":"2017-06-21 13:37:42.000000000","message":"Ok, to remove the test, seems logical.\n\nSince the (wrong) test was passing, can a LP bug be filled so that we solve the issue in the dashboard (allow changing the name to an already existing name) ?","commit_id":"8e8e04a3b5ef06eaeb8292f7416c7f3371a64ab6"}],"bgpvpn_dashboard/test/project/test_tables.py":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"32f1d8f7046de39ce2c292e365a8ce42a884213b","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        self.update_net_assocs \u003d bgpvpn_tables.UpdateNetworkAssociations()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        self.assertEqual(\u0027update_network_associations\u0027,"},{"line_number":32,"context_line":"                         self.update_net_assocs.name)"},{"line_number":33,"context_line":"        self.assertEqual(\u0027Update Network Associations\u0027,"},{"line_number":34,"context_line":"                         self.update_net_assocs.verbose_name)"},{"line_number":35,"context_line":"        self.assertEqual(\u0027horizon:project:bgpvpn:update-associations\u0027,"},{"line_number":36,"context_line":"                         self.update_net_assocs.url)"},{"line_number":37,"context_line":"        self.assertEqual((\"ajax-modal\",), self.update_net_assocs.classes)"},{"line_number":38,"context_line":"        self.assertEqual(\u0027pencil\u0027, self.update_net_assocs.icon)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @mock.patch.object(bgpvpn_tables, \u0027reverse\u0027)"},{"line_number":41,"context_line":"    def test_get_link_url(self, mock_reverse):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_b54760bd","line":38,"range":{"start_line":31,"start_character":0,"end_line":38,"end_character":63},"updated":"2017-06-20 13:43:15.000000000","message":"We need to think twice before adding unit tests that are direct copy paste from the code under test: when they are, the unit test is most likely useless.\n\nFor instance, is the test above on \"verbose name\" really useful, since nothing breaks if verbose_name is set to something else.\n\nPerhaps some other test are needed, but I would like to understand first.","commit_id":"8e8e04a3b5ef06eaeb8292f7416c7f3371a64ab6"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"ef74860fe239b0e6856309529a9872f2105b2039","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        self.update_net_assocs \u003d bgpvpn_tables.UpdateNetworkAssociations()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        self.assertEqual(\u0027update_network_associations\u0027,"},{"line_number":32,"context_line":"                         self.update_net_assocs.name)"},{"line_number":33,"context_line":"        self.assertEqual(\u0027Update Network Associations\u0027,"},{"line_number":34,"context_line":"                         self.update_net_assocs.verbose_name)"},{"line_number":35,"context_line":"        self.assertEqual(\u0027horizon:project:bgpvpn:update-associations\u0027,"},{"line_number":36,"context_line":"                         self.update_net_assocs.url)"},{"line_number":37,"context_line":"        self.assertEqual((\"ajax-modal\",), self.update_net_assocs.classes)"},{"line_number":38,"context_line":"        self.assertEqual(\u0027pencil\u0027, self.update_net_assocs.icon)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @mock.patch.object(bgpvpn_tables, \u0027reverse\u0027)"},{"line_number":41,"context_line":"    def test_get_link_url(self, mock_reverse):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_a85fdf3f","line":38,"range":{"start_line":31,"start_character":0,"end_line":38,"end_character":63},"in_reply_to":"5f201791_b54760bd","updated":"2017-06-21 13:37:42.000000000","message":"I saw you removed everything in the last PS.\nIs this because none of the above was needed ?\n(e.g. would changing update_net_assoc_url to something else break things or not ?)","commit_id":"8e8e04a3b5ef06eaeb8292f7416c7f3371a64ab6"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"32f1d8f7046de39ce2c292e365a8ce42a884213b","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.update_net_assocs \u003d bgpvpn_tables.UpdateRouterAssociations()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        self.assertEqual(\u0027update_router_associations\u0027,"},{"line_number":60,"context_line":"                         self.update_net_assocs.name)"},{"line_number":61,"context_line":"        self.assertEqual(\u0027Update Router Associations\u0027,"},{"line_number":62,"context_line":"                         self.update_net_assocs.verbose_name)"},{"line_number":63,"context_line":"        self.assertEqual(\u0027horizon:project:bgpvpn:update-associations\u0027,"},{"line_number":64,"context_line":"                         self.update_net_assocs.url)"},{"line_number":65,"context_line":"        self.assertEqual((\"ajax-modal\",), self.update_net_assocs.classes)"},{"line_number":66,"context_line":"        self.assertEqual(\u0027pencil\u0027, self.update_net_assocs.icon)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @mock.patch.object(bgpvpn_tables, \u0027reverse\u0027)"},{"line_number":69,"context_line":"    def test_get_link_url(self, mock_reverse):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_55180cd2","line":66,"range":{"start_line":59,"start_character":0,"end_line":66,"end_character":63},"updated":"2017-06-20 13:43:15.000000000","message":"ditto","commit_id":"8e8e04a3b5ef06eaeb8292f7416c7f3371a64ab6"}],"bgpvpn_dashboard/test/project/test_views.py":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"32f1d8f7046de39ce2c292e365a8ce42a884213b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                         self.bgpvpn_view.table_class)"},{"line_number":40,"context_line":"        self.assertEqual(\u0027project/bgpvpn/index.html\u0027,"},{"line_number":41,"context_line":"                         self.bgpvpn_view.template_name)"},{"line_number":42,"context_line":"        self.assertEqual(\u0027BGP VPNs\u0027, self.bgpvpn_view.page_title)"},{"line_number":43,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _get_mock_bgpvpn(self, prefix):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_18af6995","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":65},"updated":"2017-06-20 13:43:15.000000000","message":"similar comment: is it usefull to test that ?","commit_id":"8e8e04a3b5ef06eaeb8292f7416c7f3371a64ab6"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"32f1d8f7046de39ce2c292e365a8ce42a884213b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.assertEqual(\u0027project/bgpvpn/index.html\u0027,"},{"line_number":41,"context_line":"                         self.bgpvpn_view.template_name)"},{"line_number":42,"context_line":"        self.assertEqual(\u0027BGP VPNs\u0027, self.bgpvpn_view.page_title)"},{"line_number":43,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _get_mock_bgpvpn(self, prefix):"},{"line_number":46,"context_line":"        bgpvpn_info \u003d {}"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_588e012f","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":43},"updated":"2017-06-20 13:43:15.000000000","message":"is this needed ?\n\nit seems like stopping all the patches of the mock framework would be overkill and may prevent the test from running properly in parallel with others... isn\u0027t there such an issue here ?","commit_id":"8e8e04a3b5ef06eaeb8292f7416c7f3371a64ab6"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"32f1d8f7046de39ce2c292e365a8ce42a884213b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.bgpvpn_view.kwargs \u003d {\u0027bgpvpn_id\u0027: \u0027foo-id\u0027}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        self.assertEqual(bgpvpn_form.EditDataBgpVpn,"},{"line_number":89,"context_line":"                         self.bgpvpn_view.form_class)"},{"line_number":90,"context_line":"        self.assertEqual(\u0027Edit BGPVPN\u0027, self.bgpvpn_view.modal_header)"},{"line_number":91,"context_line":"        self.assertEqual(\u0027Update Change\u0027, self.bgpvpn_view.submit_label)"},{"line_number":92,"context_line":"        self.assertEqual(\u0027horizon:project:bgpvpn:edit\u0027,"},{"line_number":93,"context_line":"                         self.bgpvpn_view.submit_url)"},{"line_number":94,"context_line":"        self.assertEqual(reverse_lazy(\u0027horizon:project:bgpvpn:index\u0027),"},{"line_number":95,"context_line":"                         self.bgpvpn_view.success_url)"},{"line_number":96,"context_line":"        self.assertEqual(\u0027project/bgpvpn/modify.html\u0027,"},{"line_number":97,"context_line":"                         self.bgpvpn_view.template_name)"},{"line_number":98,"context_line":"        self.assertEqual(\u0027Edit BGPVPN\u0027, self.bgpvpn_view.page_title)"},{"line_number":99,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @mock.patch.object(bgpvpn_views, \u0027bgpvpn_api\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_d89e9153","line":98,"range":{"start_line":89,"start_character":0,"end_line":98,"end_character":68},"updated":"2017-06-20 13:43:15.000000000","message":"(same as previously commented)","commit_id":"8e8e04a3b5ef06eaeb8292f7416c7f3371a64ab6"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"32f1d8f7046de39ce2c292e365a8ce42a884213b","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        self.assertEqual(bgpvpn_workflows.UpdateBgpVpnAssociations,"},{"line_number":152,"context_line":"                         self.bgpvpn_view.workflow_class)"},{"line_number":153,"context_line":"        self.assertEqual(\u0027Edit BGPVPN associations\u0027,"},{"line_number":154,"context_line":"                         self.bgpvpn_view.page_title)"},{"line_number":155,"context_line":"        self.assertEqual(reverse_lazy(\"horizon:project:bgpvpn:index\"),"},{"line_number":156,"context_line":"                         self.bgpvpn_view.failure_url)"},{"line_number":157,"context_line":"        self.addCleanup(mock.patch.stopall)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_b8abd573","line":154,"range":{"start_line":153,"start_character":0,"end_line":154,"end_character":53},"updated":"2017-06-20 13:43:15.000000000","message":"(same as previously commented)","commit_id":"8e8e04a3b5ef06eaeb8292f7416c7f3371a64ab6"}]}
