)]}'
{"networking_bgpvpn/neutron/services/service_drivers/driver_api.py":[{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"30352792a4270544885659db99e893681810e3cd","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        pass"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @abc.abstractmethod"},{"line_number":210,"context_line":"    def delete_net_assoc_precommit(self, context, net_assoc):"},{"line_number":211,"context_line":"        pass"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_130e63e4","line":210,"range":{"start_line":210,"start_character":25,"end_line":210,"end_character":29},"updated":"2017-07-06 07:15:33.000000000","message":"is this method in use anywhere?","commit_id":"2a1f584d1dd315ed5075502ed5613cb5ab4e51f5"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"69eb9830200704eb6f2652ae516198658234d8d2","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        pass"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @abc.abstractmethod"},{"line_number":210,"context_line":"    def delete_net_assoc_precommit(self, context, net_assoc):"},{"line_number":211,"context_line":"        pass"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_33695ff8","line":210,"range":{"start_line":210,"start_character":25,"end_line":210,"end_character":29},"in_reply_to":"3f1d235d_130e63e4","updated":"2017-07-06 07:32:31.000000000","message":"Yes, L154","commit_id":"2a1f584d1dd315ed5075502ed5613cb5ab4e51f5"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"30352792a4270544885659db99e893681810e3cd","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        pass"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @abc.abstractmethod"},{"line_number":226,"context_line":"    def delete_router_assoc_precommit(self, context, router_assoc):"},{"line_number":227,"context_line":"        pass"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_d3fb4bbe","line":226,"range":{"start_line":226,"start_character":29,"end_line":226,"end_character":31},"updated":"2017-07-06 07:15:33.000000000","message":"ditto","commit_id":"2a1f584d1dd315ed5075502ed5613cb5ab4e51f5"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"69eb9830200704eb6f2652ae516198658234d8d2","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        pass"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @abc.abstractmethod"},{"line_number":226,"context_line":"    def delete_router_assoc_precommit(self, context, router_assoc):"},{"line_number":227,"context_line":"        pass"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_937f13aa","line":226,"range":{"start_line":226,"start_character":29,"end_line":226,"end_character":31},"in_reply_to":"3f1d235d_d3fb4bbe","updated":"2017-07-06 07:32:31.000000000","message":"Yes, L178","commit_id":"2a1f584d1dd315ed5075502ed5613cb5ab4e51f5"}],"networking_bgpvpn/tests/unit/services/test_plugin.py":[{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"30352792a4270544885659db99e893681810e3cd","unresolved":false,"context_lines":[{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    def test_create_bgpvpn_net_assoc_precommit_fails(self):"},{"line_number":667,"context_line":"        with self.bgpvpn() as bgpvpn, \\"},{"line_number":668,"context_line":"                self.network() as net, \\"},{"line_number":669,"context_line":"                mock.patch.object(driver_api.BGPVPNDriver,"},{"line_number":670,"context_line":"                                  \u0027create_net_assoc_precommit\u0027,"},{"line_number":671,"context_line":"                                  new\u003dself._raise_bgpvpn_driver_precommit_exc):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_b3920f56","line":668,"range":{"start_line":668,"start_character":12,"end_line":668,"end_character":16},"updated":"2017-07-06 07:15:33.000000000","message":"is putting another tab during the with statement a new convention?","commit_id":"2a1f584d1dd315ed5075502ed5613cb5ab4e51f5"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"69eb9830200704eb6f2652ae516198658234d8d2","unresolved":false,"context_lines":[{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    def test_create_bgpvpn_net_assoc_precommit_fails(self):"},{"line_number":667,"context_line":"        with self.bgpvpn() as bgpvpn, \\"},{"line_number":668,"context_line":"                self.network() as net, \\"},{"line_number":669,"context_line":"                mock.patch.object(driver_api.BGPVPNDriver,"},{"line_number":670,"context_line":"                                  \u0027create_net_assoc_precommit\u0027,"},{"line_number":671,"context_line":"                                  new\u003dself._raise_bgpvpn_driver_precommit_exc):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_1621b19f","line":668,"range":{"start_line":668,"start_character":12,"end_line":668,"end_character":16},"in_reply_to":"3f1d235d_b3920f56","updated":"2017-07-06 07:32:31.000000000","message":"it\u0027s just to avoid aligning the various arguments or \u0027with\u0027 with the content of the \u0027with\u0027 statement . When reading this class, I found that the indentation made it pretty hard to read in some places and tried to fix that along with other nits\n\nthere is a pep8 or pylint check to enforce that (for \u0027if\u0027, \u0027for\u0027, \u0027while\u0027, etc.), but I can\u0027t find it","commit_id":"2a1f584d1dd315ed5075502ed5613cb5ab4e51f5"}]}
