)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"dc6a3f6d399eb22739ea8f87bb36f17ef30cc0d6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"dashboard: clean code in forms.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change remove few lines and fix behavior of validation."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1 - The change 476532 has removed some lines but everything"},{"line_number":12,"context_line":"was not removed. It\u0027s useless now to get the bgpvpn_id and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_39b107e3","line":9,"range":{"start_line":9,"start_character":33,"end_line":9,"end_character":36},"updated":"2017-07-12 09:05:11.000000000","message":"fixes","commit_id":"c51b96ea704691e7979500df86d697df68136d36"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"dc6a3f6d399eb22739ea8f87bb36f17ef30cc0d6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"dashboard: clean code in forms.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change remove few lines and fix behavior of validation."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1 - The change 476532 has removed some lines but everything"},{"line_number":12,"context_line":"was not removed. It\u0027s useless now to get the bgpvpn_id and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_79b77fda","line":9,"range":{"start_line":9,"start_character":12,"end_line":9,"end_character":18},"updated":"2017-07-12 09:05:11.000000000","message":"removes","commit_id":"c51b96ea704691e7979500df86d697df68136d36"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"ec25ccacfe04138225c79c6a7bf64bb2d1760606","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"dashboard: clean code in forms.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change remove few lines and fix behavior of validation."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1 - The change 476532 has removed some lines but everything"},{"line_number":12,"context_line":"was not removed. It\u0027s useless now to get the bgpvpn_id and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_7c83ed57","line":9,"range":{"start_line":9,"start_character":33,"end_line":9,"end_character":36},"in_reply_to":"1f1a1f67_39b107e3","updated":"2017-07-12 09:24:44.000000000","message":"Done","commit_id":"c51b96ea704691e7979500df86d697df68136d36"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"ec25ccacfe04138225c79c6a7bf64bb2d1760606","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"dashboard: clean code in forms.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change remove few lines and fix behavior of validation."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1 - The change 476532 has removed some lines but everything"},{"line_number":12,"context_line":"was not removed. It\u0027s useless now to get the bgpvpn_id and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_dcaa01d1","line":9,"range":{"start_line":9,"start_character":12,"end_line":9,"end_character":18},"in_reply_to":"1f1a1f67_79b77fda","updated":"2017-07-12 09:24:44.000000000","message":"Done","commit_id":"c51b96ea704691e7979500df86d697df68136d36"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"dc6a3f6d399eb22739ea8f87bb36f17ef30cc0d6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change remove few lines and fix behavior of validation."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1 - The change 476532 has removed some lines but everything"},{"line_number":12,"context_line":"was not removed. It\u0027s useless now to get the bgpvpn_id and"},{"line_number":13,"context_line":"the tenant_id. These datas was useful to check if the name of"},{"line_number":14,"context_line":"BGPVPN was already used by an other BGPBPN."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_590a838a","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":7},"updated":"2017-07-12 09:05:11.000000000","message":"you don\u0027t need \"the\" here","commit_id":"c51b96ea704691e7979500df86d697df68136d36"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"ec25ccacfe04138225c79c6a7bf64bb2d1760606","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change remove few lines and fix behavior of validation."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1 - The change 476532 has removed some lines but everything"},{"line_number":12,"context_line":"was not removed. It\u0027s useless now to get the bgpvpn_id and"},{"line_number":13,"context_line":"the tenant_id. These datas was useful to check if the name of"},{"line_number":14,"context_line":"BGPVPN was already used by an other BGPBPN."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_5c883170","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":7},"in_reply_to":"1f1a1f67_590a838a","updated":"2017-07-12 09:24:44.000000000","message":"Done","commit_id":"c51b96ea704691e7979500df86d697df68136d36"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"dc6a3f6d399eb22739ea8f87bb36f17ef30cc0d6","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1 - The change 476532 has removed some lines but everything"},{"line_number":12,"context_line":"was not removed. It\u0027s useless now to get the bgpvpn_id and"},{"line_number":13,"context_line":"the tenant_id. These datas was useful to check if the name of"},{"line_number":14,"context_line":"BGPVPN was already used by an other BGPBPN."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"2 - When a route target is incorrect in the create or update"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_b9c4f741","line":13,"range":{"start_line":13,"start_character":21,"end_line":13,"end_character":26},"updated":"2017-07-12 09:05:11.000000000","message":"\"data\"","commit_id":"c51b96ea704691e7979500df86d697df68136d36"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"dc6a3f6d399eb22739ea8f87bb36f17ef30cc0d6","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1 - The change 476532 has removed some lines but everything"},{"line_number":12,"context_line":"was not removed. It\u0027s useless now to get the bgpvpn_id and"},{"line_number":13,"context_line":"the tenant_id. These datas was useful to check if the name of"},{"line_number":14,"context_line":"BGPVPN was already used by an other BGPBPN."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"2 - When a route target is incorrect in the create or update"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_d9233305","line":13,"range":{"start_line":13,"start_character":38,"end_line":13,"end_character":46},"updated":"2017-07-12 09:05:11.000000000","message":"\"only when we were (uselessly) checking if\"","commit_id":"c51b96ea704691e7979500df86d697df68136d36"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"ec25ccacfe04138225c79c6a7bf64bb2d1760606","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1 - The change 476532 has removed some lines but everything"},{"line_number":12,"context_line":"was not removed. It\u0027s useless now to get the bgpvpn_id and"},{"line_number":13,"context_line":"the tenant_id. These datas was useful to check if the name of"},{"line_number":14,"context_line":"BGPVPN was already used by an other BGPBPN."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"2 - When a route target is incorrect in the create or update"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_3c7d756e","line":13,"range":{"start_line":13,"start_character":21,"end_line":13,"end_character":26},"in_reply_to":"1f1a1f67_b9c4f741","updated":"2017-07-12 09:24:44.000000000","message":"Done","commit_id":"c51b96ea704691e7979500df86d697df68136d36"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"ec25ccacfe04138225c79c6a7bf64bb2d1760606","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1 - The change 476532 has removed some lines but everything"},{"line_number":12,"context_line":"was not removed. It\u0027s useless now to get the bgpvpn_id and"},{"line_number":13,"context_line":"the tenant_id. These datas was useful to check if the name of"},{"line_number":14,"context_line":"BGPVPN was already used by an other BGPBPN."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"2 - When a route target is incorrect in the create or update"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_1c82b950","line":13,"range":{"start_line":13,"start_character":38,"end_line":13,"end_character":46},"in_reply_to":"1f1a1f67_d9233305","updated":"2017-07-12 09:24:44.000000000","message":"Done","commit_id":"c51b96ea704691e7979500df86d697df68136d36"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8b82a6ed02da69783c6ecfc4dcd818748fb1cd60","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2017-07-11 17:06:20 +0200"},{"line_number":4,"context_line":"Commit:     Cédric Savignan \u003ccedric.savignan@orange.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-18 10:03:31 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"dashboard: clean code in forms.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change removes few lines and fixes behavior of validation."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1f1a1f67_9bcdf832","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":33},"updated":"2017-07-18 13:04:55.000000000","message":"The summary line might be no longer correct. I wonder it may be better to introduce the usage of the policy file in a separate patch.","commit_id":"3c5a4874c8c4d8163869a17d4929d3f6fa388cc5"}],"bgpvpn_dashboard/dashboards/project/bgpvpn/forms.py":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"dc6a3f6d399eb22739ea8f87bb36f17ef30cc0d6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        params \u003d {}"},{"line_number":56,"context_line":"        is_admin \u003d policy.check(((\"network\", \"context_is_admin\"),), self.request)"},{"line_number":57,"context_line":"        if is_admin:"},{"line_number":58,"context_line":"            if data.get(\u0027tenant_id\u0027):"},{"line_number":59,"context_line":"                for key in bgpvpn_common.RT_FORMAT_ATTRIBUTES:"},{"line_number":60,"context_line":"                    if data.get(key):"},{"line_number":61,"context_line":"                        params[key] \u003d bgpvpn_common.format_rt(data[key])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_19e1abff","line":58,"range":{"start_line":58,"start_character":12,"end_line":58,"end_character":37},"updated":"2017-07-12 09:05:11.000000000","message":"If tenant_id is not provided, does this mean that RT will not be formatted ?","commit_id":"c51b96ea704691e7979500df86d697df68136d36"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"ec25ccacfe04138225c79c6a7bf64bb2d1760606","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        params \u003d {}"},{"line_number":56,"context_line":"        is_admin \u003d policy.check(((\"network\", \"context_is_admin\"),), self.request)"},{"line_number":57,"context_line":"        if is_admin:"},{"line_number":58,"context_line":"            if data.get(\u0027tenant_id\u0027):"},{"line_number":59,"context_line":"                for key in bgpvpn_common.RT_FORMAT_ATTRIBUTES:"},{"line_number":60,"context_line":"                    if data.get(key):"},{"line_number":61,"context_line":"                        params[key] \u003d bgpvpn_common.format_rt(data[key])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_f95eef43","line":58,"range":{"start_line":58,"start_character":12,"end_line":58,"end_character":37},"in_reply_to":"1f1a1f67_19e1abff","updated":"2017-07-12 09:24:44.000000000","message":"If tenant_id is not provided it means that we are in the case that an admin user use the bgpvpn panel from project. So RTs fields doesn\u0027t exist in the form.","commit_id":"c51b96ea704691e7979500df86d697df68136d36"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"2dc25fa0fbaae1374233d3297a8f26b19614632a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        params \u003d {}"},{"line_number":56,"context_line":"        is_admin \u003d policy.check(((\"network\", \"context_is_admin\"),), self.request)"},{"line_number":57,"context_line":"        if is_admin:"},{"line_number":58,"context_line":"            if data.get(\u0027tenant_id\u0027):"},{"line_number":59,"context_line":"                for key in bgpvpn_common.RT_FORMAT_ATTRIBUTES:"},{"line_number":60,"context_line":"                    if data.get(key):"},{"line_number":61,"context_line":"                        params[key] \u003d bgpvpn_common.format_rt(data[key])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_bcbbc00c","line":58,"range":{"start_line":58,"start_character":12,"end_line":58,"end_character":37},"in_reply_to":"1f1a1f67_f95eef43","updated":"2017-09-25 15:43:57.000000000","message":"Ok.","commit_id":"c51b96ea704691e7979500df86d697df68136d36"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"dc6a3f6d399eb22739ea8f87bb36f17ef30cc0d6","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        params.update(data)"},{"line_number":64,"context_line":"        try:"},{"line_number":65,"context_line":"            if self.action \u003d\u003d \u0027update\u0027:"},{"line_number":66,"context_line":"                # if an admin user use the bgpvpn panel project"},{"line_number":67,"context_line":"                # tenant_id field doesn\u0027t exist"},{"line_number":68,"context_line":"                if is_admin and data.get(\u0027tenant_id\u0027):"},{"line_number":69,"context_line":"                    attributes \u003d (\u0027bgpvpn_id\u0027, \u0027type\u0027, \u0027tenant_id\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_199d2b59","line":66,"range":{"start_line":66,"start_character":35,"end_line":66,"end_character":38},"updated":"2017-07-12 09:05:11.000000000","message":"uses","commit_id":"c51b96ea704691e7979500df86d697df68136d36"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"ec25ccacfe04138225c79c6a7bf64bb2d1760606","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        params.update(data)"},{"line_number":64,"context_line":"        try:"},{"line_number":65,"context_line":"            if self.action \u003d\u003d \u0027update\u0027:"},{"line_number":66,"context_line":"                # if an admin user use the bgpvpn panel project"},{"line_number":67,"context_line":"                # tenant_id field doesn\u0027t exist"},{"line_number":68,"context_line":"                if is_admin and data.get(\u0027tenant_id\u0027):"},{"line_number":69,"context_line":"                    attributes \u003d (\u0027bgpvpn_id\u0027, \u0027type\u0027, \u0027tenant_id\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_7c364db7","line":66,"range":{"start_line":66,"start_character":35,"end_line":66,"end_character":38},"in_reply_to":"1f1a1f67_199d2b59","updated":"2017-07-12 09:24:44.000000000","message":"Done","commit_id":"c51b96ea704691e7979500df86d697df68136d36"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d03ab4538662f0ec46be69eee1eec3d99c561cbb","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def handle(self, request, data):"},{"line_number":55,"context_line":"        params \u003d {}"},{"line_number":56,"context_line":"        is_admin \u003d policy.check(((\"network\", \"context_is_admin\"),),"},{"line_number":57,"context_line":"                                self.request)"},{"line_number":58,"context_line":"        if is_admin:"},{"line_number":59,"context_line":"            if data.get(\u0027tenant_id\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_e22078b3","line":56,"range":{"start_line":56,"start_character":33,"end_line":56,"end_character":64},"updated":"2017-07-12 10:25:54.000000000","message":"I think it is better to check \"update_bgpvpn:tenant_id\".\nTo do this you need to register BGPVPN policy.json into POLICY_FILES.\n\nSome example is FWaaS dashboard (under review):https://review.openstack.org/#/c/481867/\nHope it helps you.\n\nhttps://github.com/openstack/networking-bgpvpn/blob/master/etc/neutron/policy.d/bgpvpn.conf#L15","commit_id":"89b6ad3b203a6b2f0f3c1942a380be54ba613dc2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a841c2912c4da62330f125d7e673496195bab99b","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def handle(self, request, data):"},{"line_number":55,"context_line":"        params \u003d {}"},{"line_number":56,"context_line":"        is_admin \u003d policy.check(((\"network\", \"context_is_admin\"),),"},{"line_number":57,"context_line":"                                self.request)"},{"line_number":58,"context_line":"        if is_admin:"},{"line_number":59,"context_line":"            if data.get(\u0027tenant_id\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_d0441dba","line":56,"range":{"start_line":56,"start_character":33,"end_line":56,"end_character":64},"in_reply_to":"1f1a1f67_3021114f","updated":"2017-07-12 13:28:38.000000000","message":"Hmm... in a usual horizon deployment, POLICY_FILES dict is defined at L.237 [1] and local_settings.py (and local_settings.d) are loaded at L.321 (and L.340). I wonder what actually happens.\n\nAs a filepath, I think the absolute path is required as the cwd depends on a program and horizon does not do chdir().\n\n[1] https://github.com/openstack/horizon/blob/master/openstack_dashboard/settings.py#L237-L244","commit_id":"89b6ad3b203a6b2f0f3c1942a380be54ba613dc2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"41bceccbb7f41acde0d44e58d2c2886368495139","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def handle(self, request, data):"},{"line_number":55,"context_line":"        params \u003d {}"},{"line_number":56,"context_line":"        is_admin \u003d policy.check(((\"network\", \"context_is_admin\"),),"},{"line_number":57,"context_line":"                                self.request)"},{"line_number":58,"context_line":"        if is_admin:"},{"line_number":59,"context_line":"            if data.get(\u0027tenant_id\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_7df50bcb","line":56,"range":{"start_line":56,"start_character":33,"end_line":56,"end_character":64},"in_reply_to":"1f1a1f67_8598a46a","updated":"2017-07-13 01:54:21.000000000","message":"FYI: I updated the fwaas-dashboard devstack plugin to handle POLICY_FILES. At now, there is no convenient way, but at least I believe it works.\n\nhttps://review.openstack.org/#/c/481867/3/devstack/plugin.sh","commit_id":"89b6ad3b203a6b2f0f3c1942a380be54ba613dc2"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"777252a5e2329fc400d7bd9f8af19ae8f3db451d","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def handle(self, request, data):"},{"line_number":55,"context_line":"        params \u003d {}"},{"line_number":56,"context_line":"        is_admin \u003d policy.check(((\"network\", \"context_is_admin\"),),"},{"line_number":57,"context_line":"                                self.request)"},{"line_number":58,"context_line":"        if is_admin:"},{"line_number":59,"context_line":"            if data.get(\u0027tenant_id\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_3021114f","line":56,"range":{"start_line":56,"start_character":33,"end_line":56,"end_character":64},"in_reply_to":"1f1a1f67_92610d3d","updated":"2017-07-12 13:22:16.000000000","message":"Note that this will be:\n\n  POLICY_FILES[\u0027networking-bgpvpn\u0027]\n\ninstead of \n\nPOLICY_FILES[\u0027neutron-bgpvpn\u0027]\n\n(unrelated to the issue you are having)","commit_id":"89b6ad3b203a6b2f0f3c1942a380be54ba613dc2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"98ca643f65df3b4e5839edd478afed671da5010f","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def handle(self, request, data):"},{"line_number":55,"context_line":"        params \u003d {}"},{"line_number":56,"context_line":"        is_admin \u003d policy.check(((\"network\", \"context_is_admin\"),),"},{"line_number":57,"context_line":"                                self.request)"},{"line_number":58,"context_line":"        if is_admin:"},{"line_number":59,"context_line":"            if data.get(\u0027tenant_id\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_8598a46a","line":56,"range":{"start_line":56,"start_character":33,"end_line":56,"end_character":64},"in_reply_to":"1f1a1f67_d0441dba","updated":"2017-07-12 15:11:39.000000000","message":"My comment was wrong. I didn\u0027t tested well. Sorry.\nI think, at now, the only way is to copy POLICY_FILES from settings.py and add an entry for the service. This is the limitation of the current horizon. I will check what we can do better.","commit_id":"89b6ad3b203a6b2f0f3c1942a380be54ba613dc2"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"777252a5e2329fc400d7bd9f8af19ae8f3db451d","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def handle(self, request, data):"},{"line_number":55,"context_line":"        params \u003d {}"},{"line_number":56,"context_line":"        is_admin \u003d policy.check(((\"network\", \"context_is_admin\"),),"},{"line_number":57,"context_line":"                                self.request)"},{"line_number":58,"context_line":"        if is_admin:"},{"line_number":59,"context_line":"            if data.get(\u0027tenant_id\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_1c73d482","line":56,"range":{"start_line":56,"start_character":33,"end_line":56,"end_character":64},"in_reply_to":"1f1a1f67_e22078b3","updated":"2017-07-12 13:22:16.000000000","message":"I wasn\u0027t aware we could do that.\nThat makes a lot of sense.\nThanks for the suggestion!","commit_id":"89b6ad3b203a6b2f0f3c1942a380be54ba613dc2"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"67cd6beedb6808ade5d5b75007f12fa434fb9071","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def handle(self, request, data):"},{"line_number":55,"context_line":"        params \u003d {}"},{"line_number":56,"context_line":"        is_admin \u003d policy.check(((\"network\", \"context_is_admin\"),),"},{"line_number":57,"context_line":"                                self.request)"},{"line_number":58,"context_line":"        if is_admin:"},{"line_number":59,"context_line":"            if data.get(\u0027tenant_id\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_92610d3d","line":56,"range":{"start_line":56,"start_character":33,"end_line":56,"end_character":64},"in_reply_to":"1f1a1f67_e22078b3","updated":"2017-07-12 12:44:24.000000000","message":"Thanks for yout advise. I\u0027m working on it. Just one question. I just need to add something like this in local_setting right? POLICY_FILES[\u0027neutron-bgpvpn\u0027] \u003d \u0027../networking-bgpvpn/etc/neutron/policy.d/bgpvpn.conf\u0027\n\nBecause this error is returned : \nhorizon/openstack_dashboard/local/local_settings.py\", line 891, in \u003cmodule\u003e\n    POLICY_FILES[\u0027neutron-bgpvpn\u0027] \u003d \u0027../networking-bgpvpn/etc/neutron/policy.d/bgpvpn.conf\u0027\nNameError: name \u0027POLICY_FILES\u0027 is not defined\n\nI didn\u0027t touch to settings.py","commit_id":"89b6ad3b203a6b2f0f3c1942a380be54ba613dc2"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"ed010ab8b6468e8663f268be3be63d353d93bb98","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    def handle(self, request, data):"},{"line_number":55,"context_line":"        params \u003d {}"},{"line_number":56,"context_line":"        is_admin \u003d policy.check("},{"line_number":57,"context_line":"            ((\"networking-bgpvpn\", \"get_bgpvpn:tenant_id\"),), self.request)"},{"line_number":58,"context_line":"        if is_admin:"},{"line_number":59,"context_line":"            if data.get(\u0027tenant_id\u0027):"},{"line_number":60,"context_line":"                for key in bgpvpn_common.RT_FORMAT_ATTRIBUTES:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f1a1f67_956d499a","line":57,"range":{"start_line":57,"start_character":36,"end_line":57,"end_character":56},"updated":"2017-07-13 14:04:36.000000000","message":"The goal is not to determine the tenant id via the policy file (which does not tell you this), but do know whether the user has such or such policy right.\n\nThe actions related to write route target is not \"get_bgpvpn:tenant_id\", but \"update_bgpvpn:route_targets\",\n\"update_bgpvpn:import_targets\" and \"update_bgpvpn:export_targets\".\n\nYou can do the policy.check call inside the for loop for each type of RT attribute.","commit_id":"7a49d916fa067acfc22f4cb09198c71e0c2c29e3"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"4a2c4cf1cc163a0910735b9403d80f1f5f7ec1fc","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    def handle(self, request, data):"},{"line_number":55,"context_line":"        params \u003d {}"},{"line_number":56,"context_line":"        is_admin \u003d policy.check("},{"line_number":57,"context_line":"            ((\"networking-bgpvpn\", \"get_bgpvpn:tenant_id\"),), self.request)"},{"line_number":58,"context_line":"        if is_admin:"},{"line_number":59,"context_line":"            if data.get(\u0027tenant_id\u0027):"},{"line_number":60,"context_line":"                for key in bgpvpn_common.RT_FORMAT_ATTRIBUTES:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f1a1f67_61ed4fee","line":57,"range":{"start_line":57,"start_character":36,"end_line":57,"end_character":56},"in_reply_to":"1f1a1f67_28ee1c22","updated":"2017-07-13 15:32:13.000000000","message":"I miss something because policy.check(((\"networking-bgpvpn\", \"update_bgpvpn:route_targets\"),),self.request\nor with admin_only is always False even logged in admin.","commit_id":"7a49d916fa067acfc22f4cb09198c71e0c2c29e3"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"933914b81432398a2c192d424200c41524cda2a9","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    def handle(self, request, data):"},{"line_number":55,"context_line":"        params \u003d {}"},{"line_number":56,"context_line":"        is_admin \u003d policy.check("},{"line_number":57,"context_line":"            ((\"networking-bgpvpn\", \"get_bgpvpn:tenant_id\"),), self.request)"},{"line_number":58,"context_line":"        if is_admin:"},{"line_number":59,"context_line":"            if data.get(\u0027tenant_id\u0027):"},{"line_number":60,"context_line":"                for key in bgpvpn_common.RT_FORMAT_ATTRIBUTES:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f1a1f67_28ee1c22","line":57,"range":{"start_line":57,"start_character":36,"end_line":57,"end_character":56},"in_reply_to":"1f1a1f67_956d499a","updated":"2017-07-13 14:23:23.000000000","message":"It\u0027s not better to write policy.check(((\"bgpvpn\",\"admin_only\"),), self.request) to avoid to enter in the loop when the user isn\u0027t an admin?","commit_id":"7a49d916fa067acfc22f4cb09198c71e0c2c29e3"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"e14630cb7c957b86d765d749134c1200a7441686","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            if self.action \u003d\u003d \u0027update\u0027:"},{"line_number":63,"context_line":"                # if tenant user, tenant_id field doesn\u0027t exist"},{"line_number":64,"context_line":"                if self.request.user.is_superuser and data.get(\u0027tenant_id\u0027):"},{"line_number":65,"context_line":"                    attributes \u003d (\u0027bgpvpn_id\u0027, \u0027type\u0027, \u0027tenant_id\u0027)"},{"line_number":66,"context_line":"                else:"},{"line_number":67,"context_line":"                    attributes \u003d (\u0027bgpvpn_id\u0027, \u0027type\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f2577a7_5eedaaed","line":64,"range":{"start_line":64,"start_character":19,"end_line":64,"end_character":31},"updated":"2017-09-12 09:14:59.000000000","message":"Can an explanation be provided somewhere (in code or commit msg) on why the need to use self.request and not request ?","commit_id":"de9ee1773c66507c2241aa59418006fa77d73c40"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"16065c313bacc72f5b252bdf0411b02e117389bc","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            if self.action \u003d\u003d \u0027update\u0027:"},{"line_number":63,"context_line":"                # if tenant user, tenant_id field doesn\u0027t exist"},{"line_number":64,"context_line":"                if self.request.user.is_superuser and data.get(\u0027tenant_id\u0027):"},{"line_number":65,"context_line":"                    attributes \u003d (\u0027bgpvpn_id\u0027, \u0027type\u0027, \u0027tenant_id\u0027)"},{"line_number":66,"context_line":"                else:"},{"line_number":67,"context_line":"                    attributes \u003d (\u0027bgpvpn_id\u0027, \u0027type\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f2577a7_ab5e6a0f","line":64,"range":{"start_line":64,"start_character":19,"end_line":64,"end_character":31},"in_reply_to":"5f2577a7_5eedaaed","updated":"2017-09-13 07:38:08.000000000","message":"Only request work as well.","commit_id":"de9ee1773c66507c2241aa59418006fa77d73c40"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"93338fcc87c3a2cd254dcb5641ac6ea50ef379d6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            if self.action \u003d\u003d \u0027update\u0027:"},{"line_number":63,"context_line":"                # if tenant user, tenant_id field doesn\u0027t exist"},{"line_number":64,"context_line":"                if self.request.user.is_superuser and data.get(\u0027tenant_id\u0027):"},{"line_number":65,"context_line":"                    attributes \u003d (\u0027bgpvpn_id\u0027, \u0027type\u0027, \u0027tenant_id\u0027)"},{"line_number":66,"context_line":"                else:"},{"line_number":67,"context_line":"                    attributes \u003d (\u0027bgpvpn_id\u0027, \u0027type\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f2577a7_bd934ba3","line":64,"range":{"start_line":64,"start_character":19,"end_line":64,"end_character":31},"in_reply_to":"5f2577a7_ab5e6a0f","updated":"2017-09-13 14:17:23.000000000","message":"If using request does not work, we need to treat this as a bug in LP, address it in a separate change and then backport it to stable/* branches.","commit_id":"de9ee1773c66507c2241aa59418006fa77d73c40"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"2dc25fa0fbaae1374233d3297a8f26b19614632a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        params.update(data)"},{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            if self.action \u003d\u003d \u0027update\u0027:"},{"line_number":61,"context_line":"                # if tenant user, tenant_id field doesn\u0027t exist"},{"line_number":62,"context_line":"                if request.user.is_superuser and data.get(\u0027tenant_id\u0027):"},{"line_number":63,"context_line":"                    attributes \u003d (\u0027bgpvpn_id\u0027, \u0027type\u0027, \u0027tenant_id\u0027)"},{"line_number":64,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f515b1d_a31d9074","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":63},"updated":"2017-09-25 15:43:57.000000000","message":"The comment is inconsistent with the code that follows, maybe complete the sentence with \"does not exist if/when....\" ?","commit_id":"02ee59ade714429174a489410a70887cc9643d61"}],"devstack/plugin.sh":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"e14630cb7c957b86d765d749134c1200a7441686","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"5f2577a7_feb576ef","line":66,"updated":"2017-09-12 09:14:59.000000000","message":"(better to avoid making useless changes in unrelated files)","commit_id":"de9ee1773c66507c2241aa59418006fa77d73c40"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"16065c313bacc72f5b252bdf0411b02e117389bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"5f2577a7_eb6472e7","line":66,"in_reply_to":"5f2577a7_feb576ef","updated":"2017-09-13 07:38:08.000000000","message":"Done","commit_id":"de9ee1773c66507c2241aa59418006fa77d73c40"}]}
