)]}'
{"networking_bgpvpn/tests/unit/services/bagpipe/test_bagpipe.py":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"0c39ce579f66f6ff331d1b76f87b413297f806ac","unresolved":false,"context_lines":[{"line_number":739,"context_line":"            self.assertFalse(self.mock_detach_rpc.called)"},{"line_number":740,"context_line":"            self.assertTrue(log_exc.called)"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"    def test_format_bgpvpn_network_route_targets(self):"},{"line_number":743,"context_line":"        driver \u003d self.bgpvpn_plugin.driver"},{"line_number":744,"context_line":"        bgpvpns \u003d [{"},{"line_number":745,"context_line":"            \u0027type\u0027: \u0027l3\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_73cdbc64","line":742,"updated":"2017-10-25 09:45:40.000000000","message":"In this test there is no duplicate RT to filter, is it ?","commit_id":"3172db7047976d6b7d085ae2531b1c7351443fef"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"81a33db65a64e78347cdc07d9aea3c95526a2997","unresolved":false,"context_lines":[{"line_number":739,"context_line":"            self.assertFalse(self.mock_detach_rpc.called)"},{"line_number":740,"context_line":"            self.assertTrue(log_exc.called)"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"    def test_format_bgpvpn_network_route_targets(self):"},{"line_number":743,"context_line":"        driver \u003d self.bgpvpn_plugin.driver"},{"line_number":744,"context_line":"        bgpvpns \u003d [{"},{"line_number":745,"context_line":"            \u0027type\u0027: \u0027l3\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_516e352f","line":742,"in_reply_to":"3f4b6375_73cdbc64","updated":"2017-10-25 12:14:01.000000000","message":"My mistake","commit_id":"3172db7047976d6b7d085ae2531b1c7351443fef"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"0c39ce579f66f6ff331d1b76f87b413297f806ac","unresolved":false,"context_lines":[{"line_number":766,"context_line":"                \u0027export_rt\u0027: [\u002712347:1\u0027]"},{"line_number":767,"context_line":"            }"},{"line_number":768,"context_line":"        }"},{"line_number":769,"context_line":"        self.assertItemsEqual(result[\u0027l3vpn\u0027][\u0027import_rt\u0027],"},{"line_number":770,"context_line":"                              expected[\u0027l3vpn\u0027][\u0027import_rt\u0027])"},{"line_number":771,"context_line":"        self.assertItemsEqual(result[\u0027l3vpn\u0027][\u0027export_rt\u0027],"},{"line_number":772,"context_line":"                              expected[\u0027l3vpn\u0027][\u0027export_rt\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_193349f8","line":769,"updated":"2017-10-25 09:45:40.000000000","message":"Why not use assertDictEqual ?","commit_id":"3172db7047976d6b7d085ae2531b1c7351443fef"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"81a33db65a64e78347cdc07d9aea3c95526a2997","unresolved":false,"context_lines":[{"line_number":766,"context_line":"                \u0027export_rt\u0027: [\u002712347:1\u0027]"},{"line_number":767,"context_line":"            }"},{"line_number":768,"context_line":"        }"},{"line_number":769,"context_line":"        self.assertItemsEqual(result[\u0027l3vpn\u0027][\u0027import_rt\u0027],"},{"line_number":770,"context_line":"                              expected[\u0027l3vpn\u0027][\u0027import_rt\u0027])"},{"line_number":771,"context_line":"        self.assertItemsEqual(result[\u0027l3vpn\u0027][\u0027export_rt\u0027],"},{"line_number":772,"context_line":"                              expected[\u0027l3vpn\u0027][\u0027export_rt\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_b1f68962","line":769,"in_reply_to":"3f4b6375_193349f8","updated":"2017-10-25 12:14:01.000000000","message":"If I use assertDictEqual the test failed because elements in list expected (e.g l3vpn import_rt) are not in the same order than list in result.","commit_id":"3172db7047976d6b7d085ae2531b1c7351443fef"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"32ca67bd629fc58cac68d33ca207bbeb3d6744a9","unresolved":false,"context_lines":[{"line_number":766,"context_line":"                \u0027export_rt\u0027: [\u002712347:1\u0027]"},{"line_number":767,"context_line":"            }"},{"line_number":768,"context_line":"        }"},{"line_number":769,"context_line":"        self.assertItemsEqual(result[\u0027l3vpn\u0027][\u0027import_rt\u0027],"},{"line_number":770,"context_line":"                              expected[\u0027l3vpn\u0027][\u0027import_rt\u0027])"},{"line_number":771,"context_line":"        self.assertItemsEqual(result[\u0027l3vpn\u0027][\u0027export_rt\u0027],"},{"line_number":772,"context_line":"                              expected[\u0027l3vpn\u0027][\u0027export_rt\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_b42e778f","line":769,"in_reply_to":"3f4b6375_b1f68962","updated":"2017-10-25 12:23:26.000000000","message":"For instance with assertDict:\nAssertionError: {\u0027l2v[83 chars]\u002712345:1\u0027, \u002712345:2\u0027, \u002712345:4\u0027, \u002712346:1\u0027], \u0027[53 chars]1\u0027]}} !\u003d {\u0027l2v[83 chars]\u002712346:1\u0027, \u002712345:4\u0027, \u002712345:2\u0027, \u002712345:1\u0027], \u0027[53 chars]1\u0027]}}\nIt depend how the elements are sorted. Sometimes the test pass, sometimes it failed.","commit_id":"3172db7047976d6b7d085ae2531b1c7351443fef"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"6db51ea936def7c595626d20c1c78da537fe9a21","unresolved":false,"context_lines":[{"line_number":766,"context_line":"                \u0027export_rt\u0027: [\u002712347:1\u0027]"},{"line_number":767,"context_line":"            }"},{"line_number":768,"context_line":"        }"},{"line_number":769,"context_line":"        self.assertItemsEqual(result[\u0027l3vpn\u0027][\u0027import_rt\u0027],"},{"line_number":770,"context_line":"                              expected[\u0027l3vpn\u0027][\u0027import_rt\u0027])"},{"line_number":771,"context_line":"        self.assertItemsEqual(result[\u0027l3vpn\u0027][\u0027export_rt\u0027],"},{"line_number":772,"context_line":"                              expected[\u0027l3vpn\u0027][\u0027export_rt\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_f6a98f7b","line":769,"in_reply_to":"3f4b6375_b42e778f","updated":"2017-10-25 15:30:15.000000000","message":"Ok.","commit_id":"3172db7047976d6b7d085ae2531b1c7351443fef"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"6db51ea936def7c595626d20c1c78da537fe9a21","unresolved":false,"context_lines":[{"line_number":739,"context_line":"            self.assertFalse(self.mock_detach_rpc.called)"},{"line_number":740,"context_line":"            self.assertTrue(log_exc.called)"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"    def test_format_bgpvpn_network_route_targets(self):"},{"line_number":743,"context_line":"        driver \u003d self.bgpvpn_plugin.driver"},{"line_number":744,"context_line":"        bgpvpns \u003d [{"},{"line_number":745,"context_line":"            \u0027type\u0027: \u0027l3\u0027,"},{"line_number":746,"context_line":"            \u0027route_targets\u0027: [\u002712345:1\u0027, \u002712345:2\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_1620ab47","line":743,"range":{"start_line":742,"start_character":24,"end_line":743,"end_character":27},"updated":"2017-10-25 15:30:15.000000000","message":"This still does not take into account the case where an RT is both in route_targets and import_targets, or both in route_targets and export_targets.\n\nI know I\u0027m nitpicking a bit, but if we do it, then let\u0027s do it fully right ! :)","commit_id":"7dee8e0b9eeddb45f0eabeda87f223f1951c6011"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"985bc2e0d1f6c55018c1a24d8c297ed970957f56","unresolved":false,"context_lines":[{"line_number":739,"context_line":"            self.assertFalse(self.mock_detach_rpc.called)"},{"line_number":740,"context_line":"            self.assertTrue(log_exc.called)"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"    def test_format_bgpvpn_network_route_targets(self):"},{"line_number":743,"context_line":"        driver \u003d self.bgpvpn_plugin.driver"},{"line_number":744,"context_line":"        bgpvpns \u003d [{"},{"line_number":745,"context_line":"            \u0027type\u0027: \u0027l3\u0027,"},{"line_number":746,"context_line":"            \u0027route_targets\u0027: [\u002712345:1\u0027, \u002712345:2\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_d601f307","line":743,"range":{"start_line":742,"start_character":24,"end_line":743,"end_character":27},"in_reply_to":"3f4b6375_1620ab47","updated":"2017-10-25 15:45:35.000000000","message":"no problem\nit should be good now","commit_id":"7dee8e0b9eeddb45f0eabeda87f223f1951c6011"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"6db51ea936def7c595626d20c1c78da537fe9a21","unresolved":false,"context_lines":[{"line_number":772,"context_line":"                              expected[\u0027l3vpn\u0027][\u0027import_rt\u0027])"},{"line_number":773,"context_line":"        self.assertItemsEqual(result[\u0027l3vpn\u0027][\u0027export_rt\u0027],"},{"line_number":774,"context_line":"                              expected[\u0027l3vpn\u0027][\u0027export_rt\u0027])"},{"line_number":775,"context_line":"        self.assertListEqual(result[\u0027l2vpn\u0027][\u0027import_rt\u0027],"},{"line_number":776,"context_line":"                             expected[\u0027l2vpn\u0027][\u0027import_rt\u0027])"},{"line_number":777,"context_line":"        self.assertListEqual(result[\u0027l2vpn\u0027][\u0027export_rt\u0027],"},{"line_number":778,"context_line":"                             expected[\u0027l2vpn\u0027][\u0027export_rt\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_f6c2af33","line":778,"range":{"start_line":775,"start_character":0,"end_line":778,"end_character":60},"updated":"2017-10-25 15:30:15.000000000","message":"For the sake of consistency, use assertItemsequal here as well ?","commit_id":"7dee8e0b9eeddb45f0eabeda87f223f1951c6011"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"985bc2e0d1f6c55018c1a24d8c297ed970957f56","unresolved":false,"context_lines":[{"line_number":772,"context_line":"                              expected[\u0027l3vpn\u0027][\u0027import_rt\u0027])"},{"line_number":773,"context_line":"        self.assertItemsEqual(result[\u0027l3vpn\u0027][\u0027export_rt\u0027],"},{"line_number":774,"context_line":"                              expected[\u0027l3vpn\u0027][\u0027export_rt\u0027])"},{"line_number":775,"context_line":"        self.assertListEqual(result[\u0027l2vpn\u0027][\u0027import_rt\u0027],"},{"line_number":776,"context_line":"                             expected[\u0027l2vpn\u0027][\u0027import_rt\u0027])"},{"line_number":777,"context_line":"        self.assertListEqual(result[\u0027l2vpn\u0027][\u0027export_rt\u0027],"},{"line_number":778,"context_line":"                             expected[\u0027l2vpn\u0027][\u0027export_rt\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_fc073117","line":778,"range":{"start_line":775,"start_character":0,"end_line":778,"end_character":60},"in_reply_to":"3f4b6375_f6c2af33","updated":"2017-10-25 15:45:35.000000000","message":"Done","commit_id":"7dee8e0b9eeddb45f0eabeda87f223f1951c6011"}]}