)]}'
{"networking_bgpvpn_tempest/tests/scenario/test_bgpvpn_basic.py":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"93d1d7dc732a19c1b63bdab1b96ec8eeaf95a9c3","unresolved":false,"context_lines":[{"line_number":814,"context_line":"    def _setup_ip_forwarding(self, server_index):"},{"line_number":815,"context_line":"        server \u003d self.servers[server_index]"},{"line_number":816,"context_line":"        ssh_client \u003d self._setup_ssh_client(server)"},{"line_number":817,"context_line":"        ssh_client.exec_command(\"sudo sysctl -w net.ipv4.ip_forward\u003d1\")"},{"line_number":818,"context_line":"        ssh_client.exec_command(\"echo 1 \u0026#62 /proc/sys/net/ipv4/ip_forward\")"},{"line_number":819,"context_line":""},{"line_number":820,"context_line":"    def _setup_ip_address(self, server_index, cidr, device\u003dNone):"},{"line_number":821,"context_line":"        if device is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_4bdfaad5","line":818,"range":{"start_line":817,"start_character":0,"end_line":818,"end_character":76},"updated":"2018-01-16 08:57:07.000000000","message":"You don\u0027t need to do both, and the \u0027\u0026#62\u0027 is weird (does the second line even work ?).","commit_id":"fcdb2da3a1efbfb9b61ffd7e3a4c08df25fd49e1"},{"author":{"_account_id":26038,"name":"Łukasz Rajewski","email":"lukasz.rajewski@orange.com","username":"rajewluk"},"change_message_id":"29d5ea8b9202f70caf055c4465b75c4930dc3188","unresolved":false,"context_lines":[{"line_number":814,"context_line":"    def _setup_ip_forwarding(self, server_index):"},{"line_number":815,"context_line":"        server \u003d self.servers[server_index]"},{"line_number":816,"context_line":"        ssh_client \u003d self._setup_ssh_client(server)"},{"line_number":817,"context_line":"        ssh_client.exec_command(\"sudo sysctl -w net.ipv4.ip_forward\u003d1\")"},{"line_number":818,"context_line":"        ssh_client.exec_command(\"echo 1 \u0026#62 /proc/sys/net/ipv4/ip_forward\")"},{"line_number":819,"context_line":""},{"line_number":820,"context_line":"    def _setup_ip_address(self, server_index, cidr, device\u003dNone):"},{"line_number":821,"context_line":"        if device is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_1ac56af1","line":818,"range":{"start_line":817,"start_character":0,"end_line":818,"end_character":76},"in_reply_to":"7f96bb07_3a74e6fd","updated":"2018-01-16 11:27:49.000000000","message":"Done","commit_id":"fcdb2da3a1efbfb9b61ffd7e3a4c08df25fd49e1"},{"author":{"_account_id":26038,"name":"Łukasz Rajewski","email":"lukasz.rajewski@orange.com","username":"rajewluk"},"change_message_id":"7f151b3d0009474e37997f91f58d71d8b4bcd65c","unresolved":false,"context_lines":[{"line_number":814,"context_line":"    def _setup_ip_forwarding(self, server_index):"},{"line_number":815,"context_line":"        server \u003d self.servers[server_index]"},{"line_number":816,"context_line":"        ssh_client \u003d self._setup_ssh_client(server)"},{"line_number":817,"context_line":"        ssh_client.exec_command(\"sudo sysctl -w net.ipv4.ip_forward\u003d1\")"},{"line_number":818,"context_line":"        ssh_client.exec_command(\"echo 1 \u0026#62 /proc/sys/net/ipv4/ip_forward\")"},{"line_number":819,"context_line":""},{"line_number":820,"context_line":"    def _setup_ip_address(self, server_index, cidr, device\u003dNone):"},{"line_number":821,"context_line":"        if device is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_5aba120a","line":818,"range":{"start_line":817,"start_character":0,"end_line":818,"end_character":76},"in_reply_to":"7f96bb07_4bdfaad5","updated":"2018-01-16 11:11:15.000000000","message":"It was a consequence of stupid copy paste. Changed to \u003e","commit_id":"fcdb2da3a1efbfb9b61ffd7e3a4c08df25fd49e1"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"c31813e7fd63198c69060477f0da382519ffcc0f","unresolved":false,"context_lines":[{"line_number":814,"context_line":"    def _setup_ip_forwarding(self, server_index):"},{"line_number":815,"context_line":"        server \u003d self.servers[server_index]"},{"line_number":816,"context_line":"        ssh_client \u003d self._setup_ssh_client(server)"},{"line_number":817,"context_line":"        ssh_client.exec_command(\"sudo sysctl -w net.ipv4.ip_forward\u003d1\")"},{"line_number":818,"context_line":"        ssh_client.exec_command(\"echo 1 \u0026#62 /proc/sys/net/ipv4/ip_forward\")"},{"line_number":819,"context_line":""},{"line_number":820,"context_line":"    def _setup_ip_address(self, server_index, cidr, device\u003dNone):"},{"line_number":821,"context_line":"        if device is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_3a74e6fd","line":818,"range":{"start_line":817,"start_character":0,"end_line":818,"end_character":76},"in_reply_to":"7f96bb07_5aba120a","updated":"2018-01-16 11:23:08.000000000","message":"Sorry if I wasn\u0027t clear: you don\u0027t need both commands (L817 and L818). The first one is sufficient, and actually better, since it does not require to be root.","commit_id":"fcdb2da3a1efbfb9b61ffd7e3a4c08df25fd49e1"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"93d1d7dc732a19c1b63bdab1b96ec8eeaf95a9c3","unresolved":false,"context_lines":[{"line_number":834,"context_line":"                         should_succeed\u003dTrue, validate_server\u003dFalse,"},{"line_number":835,"context_line":"                         dest_ip\u003dNone):"},{"line_number":836,"context_line":"        from_server \u003d from_server or self.servers[0]"},{"line_number":837,"context_line":"        to_server \u003d to_server or self.servers[1]"},{"line_number":838,"context_line":"        server_1_ip \u003d self.server_fips[from_server[\u0027id\u0027]]["},{"line_number":839,"context_line":"            \u0027floating_ip_address\u0027]"},{"line_number":840,"context_line":"        server_2_ip \u003d dest_ip"},{"line_number":841,"context_line":"        if server_2_ip is None:"},{"line_number":842,"context_line":"            server_2_ip \u003d self.server_fixed_ips[to_server[\u0027id\u0027]]"},{"line_number":843,"context_line":"        ssh_client \u003d self._setup_ssh_client(from_server)"},{"line_number":844,"context_line":"        try:"},{"line_number":845,"context_line":"            should_be_reachable \u003d should_succeed or validate_server"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_8e114055","line":842,"range":{"start_line":837,"start_character":0,"end_line":842,"end_character":64},"updated":"2018-01-16 08:57:07.000000000","message":"The code would be simpler and more readable if check_l3_bgpvpn was taking a destination_ip parameter and if the caller was putting whichever IP it wants there.","commit_id":"fcdb2da3a1efbfb9b61ffd7e3a4c08df25fd49e1"},{"author":{"_account_id":26038,"name":"Łukasz Rajewski","email":"lukasz.rajewski@orange.com","username":"rajewluk"},"change_message_id":"7f151b3d0009474e37997f91f58d71d8b4bcd65c","unresolved":false,"context_lines":[{"line_number":834,"context_line":"                         should_succeed\u003dTrue, validate_server\u003dFalse,"},{"line_number":835,"context_line":"                         dest_ip\u003dNone):"},{"line_number":836,"context_line":"        from_server \u003d from_server or self.servers[0]"},{"line_number":837,"context_line":"        to_server \u003d to_server or self.servers[1]"},{"line_number":838,"context_line":"        server_1_ip \u003d self.server_fips[from_server[\u0027id\u0027]]["},{"line_number":839,"context_line":"            \u0027floating_ip_address\u0027]"},{"line_number":840,"context_line":"        server_2_ip \u003d dest_ip"},{"line_number":841,"context_line":"        if server_2_ip is None:"},{"line_number":842,"context_line":"            server_2_ip \u003d self.server_fixed_ips[to_server[\u0027id\u0027]]"},{"line_number":843,"context_line":"        ssh_client \u003d self._setup_ssh_client(from_server)"},{"line_number":844,"context_line":"        try:"},{"line_number":845,"context_line":"            should_be_reachable \u003d should_succeed or validate_server"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_7a758e63","line":842,"range":{"start_line":837,"start_character":0,"end_line":842,"end_character":64},"in_reply_to":"7f96bb07_8e114055","updated":"2018-01-16 11:11:15.000000000","message":"As discussed, two function for check are introduced. One with to_server and boolean for validate_name and second with to_server_ip and validate_name being a name of server - if is not None then hostname if verified.","commit_id":"fcdb2da3a1efbfb9b61ffd7e3a4c08df25fd49e1"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"2df3f8dd6df8f3f654eea5ade0d5c1e64ffb871e","unresolved":false,"context_lines":[{"line_number":882,"context_line":"                                                         to_server_ip,"},{"line_number":883,"context_line":"                                                         check_reachable)"},{"line_number":884,"context_line":"            self.assertTrue(result, msg)"},{"line_number":885,"context_line":"            if validate_server is not None and result:"},{"line_number":886,"context_line":"                to_name \u003d ssh_client.exec_command("},{"line_number":887,"context_line":"                    \"nc %s 80\" % to_server_ip).strip()"},{"line_number":888,"context_line":"                result \u003d to_name \u003d\u003d validate_server"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_a28a08bc","line":885,"range":{"start_line":885,"start_character":31,"end_line":885,"end_character":42},"updated":"2018-01-16 12:51:26.000000000","message":"not needed, I would think","commit_id":"1538aa1f273cb5d1f465a5b9c463682c11387d35"}]}