)]}'
{"networking_bgpvpn/neutron/services/service_drivers/bagpipe/bagpipe.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"37bd2c61324941a654c56c50ca635f55542839c8","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                          models_v2.Subnet.gateway_ip)."},{"line_number":54,"context_line":"                    join(models_v2.IPAllocation,"},{"line_number":55,"context_line":"                         models_v2.IPAllocation.port_id \u003d\u003d"},{"line_number":56,"context_line":"                         models_v2.Port.id)."},{"line_number":57,"context_line":"                    join(models_v2.Subnet,"},{"line_number":58,"context_line":"                         models_v2.IPAllocation.subnet_id \u003d\u003d"},{"line_number":59,"context_line":"                         models_v2.Subnet.id)."}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_9331dfa5","line":56,"range":{"start_line":56,"start_character":25,"end_line":56,"end_character":42},"updated":"2019-06-17 12:38:34.000000000","message":"\"Port.id\" is not in the main query. This left join should not work because the condition \"models_v2.Port.id\" is not in the select statement.","commit_id":"15c3f144e34aef62d35877bf2cc3425bcb5e4708"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"97fd584b8e291ace0ca6c8166e72fedcf7a1da29","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                          models_v2.Subnet.gateway_ip)."},{"line_number":54,"context_line":"                    join(models_v2.IPAllocation,"},{"line_number":55,"context_line":"                         models_v2.IPAllocation.port_id \u003d\u003d"},{"line_number":56,"context_line":"                         models_v2.Port.id)."},{"line_number":57,"context_line":"                    join(models_v2.Subnet,"},{"line_number":58,"context_line":"                         models_v2.IPAllocation.subnet_id \u003d\u003d"},{"line_number":59,"context_line":"                         models_v2.Subnet.id)."}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_67f1f301","line":56,"range":{"start_line":56,"start_character":25,"end_line":56,"end_character":42},"in_reply_to":"9fb8cfa7_8c73ecb1","updated":"2019-06-18 11:34:21.000000000","message":"thx","commit_id":"15c3f144e34aef62d35877bf2cc3425bcb5e4708"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4696f8d67d09e84f85e677925fb1881eed4a109d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                          models_v2.Subnet.gateway_ip)."},{"line_number":54,"context_line":"                    join(models_v2.IPAllocation,"},{"line_number":55,"context_line":"                         models_v2.IPAllocation.port_id \u003d\u003d"},{"line_number":56,"context_line":"                         models_v2.Port.id)."},{"line_number":57,"context_line":"                    join(models_v2.Subnet,"},{"line_number":58,"context_line":"                         models_v2.IPAllocation.subnet_id \u003d\u003d"},{"line_number":59,"context_line":"                         models_v2.Subnet.id)."}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_8c73ecb1","line":56,"range":{"start_line":56,"start_character":25,"end_line":56,"end_character":42},"in_reply_to":"9fb8cfa7_9331dfa5","updated":"2019-06-18 10:34:05.000000000","message":"I\u0027ve tested this manually\n\nThere is no need to have the field to be compared to in the main query.\n\nSELECT neutron.ports.mac_address, neutron.ipallocations.ip_address, neutron.subnets.cidr, neutron.subnets.gateway_ip FROM (neutron.ports, neutron.subnets, neutron.ipallocations)\njoin neutron.ipallocations as ipa\non neutron.ipallocations.port_id \u003d neutron.ports.id\njoin neutron.subnets as subn\non neutron.subnets.id \u003d neutron.ipallocations.subnet_id\nwhere neutron.subnets.ip_version \u003d 4\n\n(last filter is missing, I don\u0027t have a \"port_id\")","commit_id":"15c3f144e34aef62d35877bf2cc3425bcb5e4708"}]}