)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"600314598545eacebd8147c6905d45f5d288ffe3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"176c84ee_f0e55c1b","updated":"2023-05-16 07:35:33.000000000","message":"I know it is work in progress, but this looks good, just a couple of comments (adding -1 to not miss them due to the patch being in WIP)","commit_id":"6d58064d00ed67cae84814582eb65393007de47b"},{"author":{"_account_id":35638,"deleted":true},"change_message_id":"54bb0c03c5f1b071e61521d65ada5b175de4fceb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f4a93200_ee4d0080","in_reply_to":"176c84ee_f0e55c1b","updated":"2023-05-16 07:54:46.000000000","message":"Thanks! \nI\u0027m still struggling with Gerrit and the Zuul CI, at the moment it seems that it fails because of some errors in the bagpipe driver and also some RBAC issues in neutron, which will likely be fixed when #883057 is merged.\nNothing really related to this change.","commit_id":"6d58064d00ed67cae84814582eb65393007de47b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"51e3dd71c91d4a7d2f7e1fd99c3f93eefd1f4d1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"b446fbe2_a246d8c0","updated":"2023-07-28 13:12:58.000000000","message":"Could you please add\n* some hints how to test this in devstack\n* job proposal to test it in zuul\n* Some doc about design, configs necessary and similar","commit_id":"8a6a5bb76438f9387f118cef98e315f42ef34c69"},{"author":{"_account_id":35638,"deleted":true},"change_message_id":"af95d2000a951d8909520e4b95e28341fbed89fa","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"03289262_57b2f8f4","in_reply_to":"b446fbe2_a246d8c0","updated":"2023-08-25 12:11:01.000000000","message":"Agree. I am working on that.","commit_id":"8a6a5bb76438f9387f118cef98e315f42ef34c69"}],"networking_bgpvpn/neutron/services/service_drivers/ovn/helper.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"600314598545eacebd8147c6905d45f5d288ffe3","unresolved":true,"context_lines":[{"line_number":122,"context_line":"        net_association \u003d info[\u0027net_association\u0027]"},{"line_number":123,"context_line":"        bgpvpn \u003d info[\u0027bgpvpn\u0027]"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        filters \u003d {\u0027network_id\u0027: [net_association[\u0027network_id\u0027]]}"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        with db_api.CONTEXT_READER.using(context):"},{"line_number":128,"context_line":"            network_ports \u003d directory.get_plugin().get_ports(context, filters)"}],"source_content_type":"text/x-python","patch_set":11,"id":"776594bb_5e1554e8","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":65},"updated":"2023-05-16 07:35:33.000000000","message":"now we need to associate it to all the ports in the network due to being provider networks instead, right?","commit_id":"6d58064d00ed67cae84814582eb65393007de47b"},{"author":{"_account_id":35638,"deleted":true},"change_message_id":"54bb0c03c5f1b071e61521d65ada5b175de4fceb","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        net_association \u003d info[\u0027net_association\u0027]"},{"line_number":123,"context_line":"        bgpvpn \u003d info[\u0027bgpvpn\u0027]"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        filters \u003d {\u0027network_id\u0027: [net_association[\u0027network_id\u0027]]}"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        with db_api.CONTEXT_READER.using(context):"},{"line_number":128,"context_line":"            network_ports \u003d directory.get_plugin().get_ports(context, filters)"}],"source_content_type":"text/x-python","patch_set":11,"id":"2b1deb84_e17dd7b2","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":65},"in_reply_to":"776594bb_5e1554e8","updated":"2023-05-16 07:54:46.000000000","message":"Exactly.","commit_id":"6d58064d00ed67cae84814582eb65393007de47b"}],"networking_bgpvpn/neutron/services/service_drivers/ovn/ovn.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"600314598545eacebd8147c6905d45f5d288ffe3","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        bgp_type \u003d bgpvpn.get(\u0027type\u0027, None)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        if not network_is_external(context, net_assoc[\u0027network_id\u0027]):"},{"line_number":120,"context_line":"            raise BGPVPNExternalNetAssociation("},{"line_number":121,"context_line":"                driver\u003dOVN_DRIVER_NAME, type\u003dbgp_type)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def create_net_assoc_postcommit(self, context, net_assoc):"}],"source_content_type":"text/x-python","patch_set":11,"id":"61c3efbe_77c14a82","line":120,"range":{"start_line":120,"start_character":18,"end_line":120,"end_character":47},"updated":"2023-05-16 07:35:33.000000000","message":"this exception should now be different, right? BGPVPNNotExternalNetAssociation","commit_id":"6d58064d00ed67cae84814582eb65393007de47b"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"e0dd845052e6382312fd04a4fe7ba01e1208df2c","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        bgp_type \u003d bgpvpn.get(\u0027type\u0027, None)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        if not network_is_external(context, net_assoc[\u0027network_id\u0027]):"},{"line_number":120,"context_line":"            raise BGPVPNExternalNetAssociation("},{"line_number":121,"context_line":"                driver\u003dOVN_DRIVER_NAME, type\u003dbgp_type)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def create_net_assoc_postcommit(self, context, net_assoc):"}],"source_content_type":"text/x-python","patch_set":11,"id":"d860d6ba_05c10c01","line":120,"range":{"start_line":120,"start_character":18,"end_line":120,"end_character":47},"in_reply_to":"23a822ea_cc444523","updated":"2023-05-18 06:20:07.000000000","message":"perhaps I\u0027m missing something here. But from the code I understand you are checking if the network is not external, and in that case you raise the exception \"BGPVPNExternalNetAssociation\", which feels wrong. I suggest to create a new exception (or replace the existing one if not being used anymore) so that when the network is not external you raise a NoExternalNetAssociation exception","commit_id":"6d58064d00ed67cae84814582eb65393007de47b"},{"author":{"_account_id":35638,"deleted":true},"change_message_id":"54bb0c03c5f1b071e61521d65ada5b175de4fceb","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        bgp_type \u003d bgpvpn.get(\u0027type\u0027, None)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        if not network_is_external(context, net_assoc[\u0027network_id\u0027]):"},{"line_number":120,"context_line":"            raise BGPVPNExternalNetAssociation("},{"line_number":121,"context_line":"                driver\u003dOVN_DRIVER_NAME, type\u003dbgp_type)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def create_net_assoc_postcommit(self, context, net_assoc):"}],"source_content_type":"text/x-python","patch_set":11,"id":"23a822ea_cc444523","line":120,"range":{"start_line":120,"start_character":18,"end_line":120,"end_character":47},"in_reply_to":"61c3efbe_77c14a82","updated":"2023-05-16 07:54:46.000000000","message":"What would be your suggestion? We only use this here, and as we check weather the network is external I think its still the right exception. However, I modified the message in the exception to better reflect whats the problem here.","commit_id":"6d58064d00ed67cae84814582eb65393007de47b"},{"author":{"_account_id":35638,"deleted":true},"change_message_id":"4c5011314be6af398ed10f3b59a215b7e8d18f21","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        bgp_type \u003d bgpvpn.get(\u0027type\u0027, None)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        if not network_is_external(context, net_assoc[\u0027network_id\u0027]):"},{"line_number":120,"context_line":"            raise BGPVPNExternalNetAssociation("},{"line_number":121,"context_line":"                driver\u003dOVN_DRIVER_NAME, type\u003dbgp_type)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def create_net_assoc_postcommit(self, context, net_assoc):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ec1bd50a_8fbd6f42","line":120,"range":{"start_line":120,"start_character":18,"end_line":120,"end_character":47},"in_reply_to":"d860d6ba_05c10c01","updated":"2023-05-19 23:05:10.000000000","message":"Indeed. I will change that in the next patchset.","commit_id":"6d58064d00ed67cae84814582eb65393007de47b"},{"author":{"_account_id":35638,"deleted":true},"change_message_id":"873aab1458a3ba9e96e9703c54731d764344abf7","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        bgp_type \u003d bgpvpn.get(\u0027type\u0027, None)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        if not network_is_external(context, net_assoc[\u0027network_id\u0027]):"},{"line_number":120,"context_line":"            raise BGPVPNExternalNetAssociation("},{"line_number":121,"context_line":"                driver\u003dOVN_DRIVER_NAME, type\u003dbgp_type)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def create_net_assoc_postcommit(self, context, net_assoc):"}],"source_content_type":"text/x-python","patch_set":11,"id":"fe9bb66e_7216b4d3","line":120,"range":{"start_line":120,"start_character":18,"end_line":120,"end_character":47},"in_reply_to":"ec1bd50a_8fbd6f42","updated":"2023-05-22 09:51:50.000000000","message":"Done","commit_id":"6d58064d00ed67cae84814582eb65393007de47b"}]}