)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0011ad0c2160336e58e704b41e5098ca2456657b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6b81401e_7c954175","updated":"2024-02-08 20:56:35.000000000","message":"-1 for .keys() use","commit_id":"99611c387a9fa7ba1dc6718396cb130f81aca57a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a43d741767d32f2d547ecd87fd4577f3fc022ec4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a7842d21_47e21bd6","updated":"2024-02-13 15:01:28.000000000","message":"Thank you.","commit_id":"aa1863272425b7499229cae7494f897c641aae22"}],"networking_bgpvpn/neutron/extensions/bgpvpn.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0011ad0c2160336e58e704b41e5098ca2456657b","unresolved":true,"context_lines":[{"line_number":112,"context_line":"            translate_name\u003dTrue)"},{"line_number":113,"context_line":"        plugin \u003d directory.get_plugin(bgpvpn_api_def.ALIAS)"},{"line_number":114,"context_line":"        sub_res_attrs \u003d bgpvpn_api_def.SUB_RESOURCE_ATTRIBUTE_MAP"},{"line_number":115,"context_line":"        for collection_name, __ in sub_res_attrs.items():"},{"line_number":116,"context_line":"            # Special handling needed for sub-resources with \u0027y\u0027 ending"},{"line_number":117,"context_line":"            # (e.g. proxies -\u003e proxy)"},{"line_number":118,"context_line":"            resource_name \u003d collection_name[:-1]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ea5e7703_b00d0f1c","line":115,"updated":"2024-02-08 20:56:35.000000000","message":"for collection_name in ...keys()","commit_id":"99611c387a9fa7ba1dc6718396cb130f81aca57a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9658d5cb5db0f919a38608264abeda9431a40880","unresolved":true,"context_lines":[{"line_number":112,"context_line":"            translate_name\u003dTrue)"},{"line_number":113,"context_line":"        plugin \u003d directory.get_plugin(bgpvpn_api_def.ALIAS)"},{"line_number":114,"context_line":"        sub_res_attrs \u003d bgpvpn_api_def.SUB_RESOURCE_ATTRIBUTE_MAP"},{"line_number":115,"context_line":"        for collection_name, __ in sub_res_attrs.items():"},{"line_number":116,"context_line":"            # Special handling needed for sub-resources with \u0027y\u0027 ending"},{"line_number":117,"context_line":"            # (e.g. proxies -\u003e proxy)"},{"line_number":118,"context_line":"            resource_name \u003d collection_name[:-1]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9cf5d560_c05f0057","line":115,"in_reply_to":"41dcfeda_1d9e466b","updated":"2024-02-12 13:30:39.000000000","message":"thanks, I remembered that is also forbidden by pylint but perhaps I mess it up with some other pylint rule...","commit_id":"99611c387a9fa7ba1dc6718396cb130f81aca57a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1ea1935f5e90493b9cf1b509ce26ffafd1e66dc7","unresolved":true,"context_lines":[{"line_number":112,"context_line":"            translate_name\u003dTrue)"},{"line_number":113,"context_line":"        plugin \u003d directory.get_plugin(bgpvpn_api_def.ALIAS)"},{"line_number":114,"context_line":"        sub_res_attrs \u003d bgpvpn_api_def.SUB_RESOURCE_ATTRIBUTE_MAP"},{"line_number":115,"context_line":"        for collection_name, __ in sub_res_attrs.items():"},{"line_number":116,"context_line":"            # Special handling needed for sub-resources with \u0027y\u0027 ending"},{"line_number":117,"context_line":"            # (e.g. proxies -\u003e proxy)"},{"line_number":118,"context_line":"            resource_name \u003d collection_name[:-1]"}],"source_content_type":"text/x-python","patch_set":2,"id":"41dcfeda_1d9e466b","line":115,"in_reply_to":"bf0a86d8_a4ebb198","updated":"2024-02-09 14:57:11.000000000","message":"ok then why not just iterate with\n\n```\nfor collection_name in sub_res_attrs:\n```\n\nWhat I have a problem with is that you pull the VALUES of the dict only to scratch them (__) since you don\u0027t need them.\n\n(That said, I think you could as well use .items() but capture the values, then you would not need to re-fetch them in lines 119-122.)","commit_id":"99611c387a9fa7ba1dc6718396cb130f81aca57a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9c3083a1ff0b861573ce4fc7a678a4436f32e1a4","unresolved":true,"context_lines":[{"line_number":112,"context_line":"            translate_name\u003dTrue)"},{"line_number":113,"context_line":"        plugin \u003d directory.get_plugin(bgpvpn_api_def.ALIAS)"},{"line_number":114,"context_line":"        sub_res_attrs \u003d bgpvpn_api_def.SUB_RESOURCE_ATTRIBUTE_MAP"},{"line_number":115,"context_line":"        for collection_name, __ in sub_res_attrs.items():"},{"line_number":116,"context_line":"            # Special handling needed for sub-resources with \u0027y\u0027 ending"},{"line_number":117,"context_line":"            # (e.g. proxies -\u003e proxy)"},{"line_number":118,"context_line":"            resource_name \u003d collection_name[:-1]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf0a86d8_a4ebb198","line":115,"in_reply_to":"ea5e7703_b00d0f1c","updated":"2024-02-09 13:44:39.000000000","message":"pylint hates keys():\n\nnetworking_bgpvpn/neutron/extensions/bgpvpn.py:115:31: C0201: Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary)","commit_id":"99611c387a9fa7ba1dc6718396cb130f81aca57a"}],"requirements.txt":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0011ad0c2160336e58e704b41e5098ca2456657b","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# date but we do not test them so no guarantee of having them all correct. If"},{"line_number":3,"context_line":"# you find any incorrect lower bounds, let us know or propose a fix."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# The order of packages is significant, because pip processes them in the order"},{"line_number":6,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":7,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":8,"context_line":""}],"source_content_type":"text/plain","patch_set":2,"id":"afa1e48c_aa293c1c","side":"PARENT","line":5,"updated":"2024-02-08 20:56:35.000000000","message":"again, no idea why this is relevant, but can\u0027t judge (except to ask commit message to explain it).","commit_id":"2244a10a9c0947053f98f2728754a920c54f9a55"}]}