)]}'
{"networking_generic_switch/yang_models/juniper/constants.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"88c310ca46df67267fc22ef6153f7dc6c61a2c9e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Juniper VLAN constants"},{"line_number":14,"context_line":"# Juniper allows VLAN IDs from 1 to 4094"},{"line_number":15,"context_line":"VLAN_RANGE \u003d range(1, 4095)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# VLAN interface mode constants"}],"source_content_type":"text/x-python","patch_set":1,"id":"4f8cc613_daf39690","line":14,"updated":"2026-09-28 10:59:19.000000000","message":"Isn\u0027t it pretty common?","commit_id":"fd1c19644cfe0cf11f35cc2d6716ddb4cf61aed9"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"8e78882da3df40319c55c18746aef1894232cb26","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Juniper VLAN constants"},{"line_number":14,"context_line":"# Juniper allows VLAN IDs from 1 to 4094"},{"line_number":15,"context_line":"VLAN_RANGE \u003d range(1, 4095)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# VLAN interface mode constants"}],"source_content_type":"text/x-python","patch_set":1,"id":"79875ba3_d9e50e0f","line":14,"in_reply_to":"4f8cc613_daf39690","updated":"2026-09-28 22:17:07.000000000","message":"It is, I updated this change to also refactor so that both juniper and openconfig share these common constants.","commit_id":"fd1c19644cfe0cf11f35cc2d6716ddb4cf61aed9"}],"networking_generic_switch/yang_models/juniper/vlan/types.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"88c310ca46df67267fc22ef6153f7dc6c61a2c9e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"from networking_generic_switch.yang_models.juniper import constants"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"class VlanId:"},{"line_number":16,"context_line":"    \"\"\"Type definition representing a VLAN ID for Juniper devices."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    Juniper allows VLAN IDs from 1 to 4094."}],"source_content_type":"text/x-python","patch_set":1,"id":"37956cf9_a139b16c","line":15,"updated":"2026-09-28 10:59:19.000000000","message":"Why is it Juniper-specific?","commit_id":"fd1c19644cfe0cf11f35cc2d6716ddb4cf61aed9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"90dceb8ed69105e828bbadf1875ecf5c1b221055","unresolved":true,"context_lines":[{"line_number":22,"context_line":"        if not isinstance(vlan_id, int):"},{"line_number":23,"context_line":"            raise TypeError(\u0027vlan_id must be integer, got {}\u0027"},{"line_number":24,"context_line":"                            .format(type(vlan_id)))"},{"line_number":25,"context_line":"        if vlan_id not in constants.VLAN_RANGE:"},{"line_number":26,"context_line":"            raise ValueError(\u0027Invalid vlan id: {vlan_id} not in {range}\u0027"},{"line_number":27,"context_line":"                             .format(vlan_id\u003dvlan_id,"},{"line_number":28,"context_line":"                                     range\u003dconstants.VLAN_RANGE))"}],"source_content_type":"text/x-python","patch_set":1,"id":"a8e19a1c_b065ada5","line":25,"updated":"2026-09-25 20:02:43.000000000","message":"Just thinking outloud, but I can\u0027t help but wonder if this should instead be a comparison. But that is also likely over thinking it.","commit_id":"fd1c19644cfe0cf11f35cc2d6716ddb4cf61aed9"}]}