)]}'
{"networking_generic_switch/generic_switch_mech.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dac6975650bf6bce230e204f325716fd59250f8a","unresolved":false,"context_lines":[{"line_number":514,"context_line":"            return"},{"line_number":515,"context_line":"        port_id \u003d local_link_information[0].get(\u0027port_id\u0027)"},{"line_number":516,"context_line":"        # If segmentation ID is None, set vlan 1"},{"line_number":517,"context_line":"        segmentation_id \u003d network.get(\u0027provider:segmentation_id\u0027) or \u00271\u0027"},{"line_number":518,"context_line":"        LOG.debug(\"Unplugging port {port} on {switch_info} from vlan: \""},{"line_number":519,"context_line":"                  \"{segmentation_id}\".format("},{"line_number":520,"context_line":"                      port\u003dport_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_640f4037","line":517,"updated":"2018-01-07 12:06:44.000000000","message":"Could you add a unit test to cover this case if it was previously broken?","commit_id":"92c543d117fa405e405ec1c9bd183583831d32c4"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0882de697b429471be3585227300158700028a9d","unresolved":false,"context_lines":[{"line_number":514,"context_line":"            return"},{"line_number":515,"context_line":"        port_id \u003d local_link_information[0].get(\u0027port_id\u0027)"},{"line_number":516,"context_line":"        # If segmentation ID is None, set vlan 1"},{"line_number":517,"context_line":"        segmentation_id \u003d network.get(\u0027provider:segmentation_id\u0027) or \u00271\u0027"},{"line_number":518,"context_line":"        LOG.debug(\"Unplugging port {port} on {switch_info} from vlan: \""},{"line_number":519,"context_line":"                  \"{segmentation_id}\".format("},{"line_number":520,"context_line":"                      port\u003dport_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_188b346e","line":517,"in_reply_to":"9f91af0f_640f4037","updated":"2018-01-07 13:00:14.000000000","message":"Done. \n\nWithout this change the test fail with:\n    AssertionError: Expected call: delete_port(\u00272222\u0027, \u00271\u0027)\n    Actual call: delete_port(\u00272222\u0027, None)","commit_id":"92c543d117fa405e405ec1c9bd183583831d32c4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9363da193d302e76bd5ba7c6bd5ea05c57caeec5","unresolved":false,"context_lines":[{"line_number":446,"context_line":"            port_id \u003d local_link_information[0].get(\u0027port_id\u0027)"},{"line_number":447,"context_line":"            segments \u003d context.segments_to_bind"},{"line_number":448,"context_line":"            # If segmentation ID is None, set vlan 1"},{"line_number":449,"context_line":"            segmentation_id \u003d segments[0].get(\u0027segmentation_id\u0027) or \u00271\u0027"},{"line_number":450,"context_line":"            provisioning_blocks.add_provisioning_component("},{"line_number":451,"context_line":"                context._plugin_context, port[\u0027id\u0027], resources.PORT,"},{"line_number":452,"context_line":"                GENERIC_SWITCH_ENTITY)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_5b71b60b","line":449,"updated":"2018-01-07 19:15:29.000000000","message":"nit: the new code is equivalent to the old code","commit_id":"708e7808f2def53aab4c5b9d4063273570e4c795"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"cbd37fc65644d1167c5ebca5bf2ee679dcf53b53","unresolved":false,"context_lines":[{"line_number":446,"context_line":"            port_id \u003d local_link_information[0].get(\u0027port_id\u0027)"},{"line_number":447,"context_line":"            segments \u003d context.segments_to_bind"},{"line_number":448,"context_line":"            # If segmentation ID is None, set vlan 1"},{"line_number":449,"context_line":"            segmentation_id \u003d segments[0].get(\u0027segmentation_id\u0027) or \u00271\u0027"},{"line_number":450,"context_line":"            provisioning_blocks.add_provisioning_component("},{"line_number":451,"context_line":"                context._plugin_context, port[\u0027id\u0027], resources.PORT,"},{"line_number":452,"context_line":"                GENERIC_SWITCH_ENTITY)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_ae25225e","line":449,"in_reply_to":"9f91af0f_5b71b60b","updated":"2018-01-07 22:11:29.000000000","message":"Yes, I guess this is just code taste. And I thought it made sense to do it similarly here as is done in the new code below.","commit_id":"708e7808f2def53aab4c5b9d4063273570e4c795"}]}